[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

poelmanc created this revision. poelmanc added a reviewer: clang-tools-extra. poelmanc added a project: clang-tools-extra. Herald added a subscriber: jdoerfert. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Running `check-clang-t

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96896/new/ https://reviews.llvm.org/D96896

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 326957. poelmanc added a comment. Removed a function in modernize/LoopConvertCheck.cpp that's no longer needed due to this patch. Fixed clang-format and clang-tidy issues identified by HarborMaster in prior submission. Hopefully it's ready to go, but as al

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. In D87587#2592605 , @kuzkry wrote: >> Do you need someone to push it? > > Yes, I need someone to do that. I don't have write permissions. I'm new here. Please state the name and mail for the commit. I will push it for y

[PATCH] D93164: [AST] Add generator for source location introspection

njames93 added a comment. Another point, is there any use case of this outside of clang-query. If not would it not be wise to move this infrastructure to clang-tools-extra/clang-query? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ http

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds an option, `PreferResetCall`, currently default

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx added a comment. In D97577#2592093 , @lebedev.ri wrote: > It is best not to change existing tests, but add new ones. Could elaborate on this, Roman? In this case the tests use special auto convertible types with the intention to test that the check

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

njames93 updated this revision to Diff 326972. njames93 added a comment. Clean up some fix-it logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97630/new/ https://reviews.llvm.org/D97630 Files: clang-tools-extra/clang-tidy/readability/Uniquept

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-uniqueptr-delete-release.rst:24 + + If ``true``, refactor by calling the reset member function instead of + assigning to ``nullptr``. Default value is ``false``.

[PATCH] D97632: [clang-tidy] Simplify diagnostics for UniqueptrResetRelease check

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tweak the diagnostics to create small replacements r

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

njames93 added a comment. @Eugene.Zelenko I think there should be a herald rule for marking projects as clang-tools-extra automatically Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97630/new/ https://reviews.llvm.org/D97630 _

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

njames93 updated this revision to Diff 326977. njames93 marked an inline comment as done. njames93 added a comment. Use single back ticks for option values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97630/new/ https://reviews.llvm.org/D97630 F

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 326985. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 326986. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 326987. steveire marked 7 inline comments as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Toolin

[PATCH] D93164: [AST] Add generator for source location introspection

steveire marked 3 inline comments as done. steveire added inline comments. Comment at: clang/lib/Tooling/DumpTool/ASTSrcLocProcessor.cpp:22-25 +auto publicAccessor = [](auto... InnerMatcher) { + return cxxMethodDecl(isPublic(), parameterCountIs(0), isConst(), +

[PATCH] D93164: [AST] Add generator for source location introspection

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang/include/clang/Tooling/NodeIntrospection.h:54 +public: + static std::string format(LocationCall *Call) { +std::vector vec; njames93 wrote: > Should this (and potentia

[PATCH] D97639: [clang-tidy][NFC] Use equalsBoundNode matchers to simplify LoopConvertCheck

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, gribozavr2. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make use of the `equalsBoundNode` matcher to ensure

[PATCH] D97351: [clangd] Use flags from open files when opening headers they include

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, this looks great. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:187 +/// +/// This could also naturally live in the index, but there are advantages to +/// usi

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 326997. steveire marked an inline comment as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Toolin

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. In D87587#2592722 , @HazardyKnusperkeks wrote: > In D87587#2592605 , @kuzkry wrote: > >>> Do you need someone to push it? >> >> Yes, I need someone to do that. I don't have write permissions

[PATCH] D97639: [clang-tidy][NFC] Use equalsBoundNode matchers to simplify LoopConvertCheck

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Looks like a good simplification! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97639/new/ https://reviews.llvm.org/D97639

[clang-tools-extra] 40cee38 - Add tests which include brace initialization

Author: Stephen Kelly Date: 2021-03-01T00:34:58Z New Revision: 40cee381c1779256e039d66ea5d01ad7d344efb7 URL: https://github.com/llvm/llvm-project/commit/40cee381c1779256e039d66ea5d01ad7d344efb7 DIFF: https://github.com/llvm/llvm-project/commit/40cee381c1779256e039d66ea5d01ad7d344efb7.diff LOG:

[PATCH] D97142: [clang-tidy] Simplify unused RAII check

steveire updated this revision to Diff 327004. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97142/new/ https://reviews.llvm.org/D97142 Files: clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-too

[PATCH] D97121: [clang-tidy] Add a single fix mode to clang-tidy

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:516 + /// applied at a time. + bool isSingleFixMode() const { return Context->isSingleFixMode(); } }; I find the naming of this as "single fix" confusing. Something alon

[PATCH] D97142: [clang-tidy] Simplify unused RAII check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LG, with 1 nit. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unused-raii.cpp:81-82 + + int i = 0; + (void)i; +} Is this necessary?

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. FYI, we're seeing test failures caused by this patch in iOS/arm64 builds when arc is used (simulator is fine though): https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c11 We'll try to investigate a bit more on our side, but I wanted to give an early(ish) he

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

njames93 added a comment. Is it not nicer to name the class `PolymorphicMatcher` and do away with `WithParamN`, It may require partial specialization for the empty parameters case. But I think it would be worth it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. In D94500#2592448 , @HazardyKnusperkeks wrote: > Do you need someone to push this? Yes I do. I don't have committer access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, JonasToth, rsmith, MyDeveloperDay. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: shafik. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: c

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 added a comment. Where would be a good place for testing refersToDefaultCapture support? Comment at: clang/lib/Sema/SemaLambda.cpp:1619 + if (Cap.isVariableCapture() && ImplicitCaptureLoc.isValid()) +cast(InitExpr)->setRefersToDefaultCapture(true); InitializedE

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

steveire abandoned this revision. steveire added a comment. Clearing this out of my outgoing list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96114/new/ https://reviews.llvm.org/D96114 ___ cfe-commits

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 updated this revision to Diff 327019. njames93 added a comment. Add a test case using init capture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97653/new/ https://reviews.llvm.org/D97653 Files: clang-tools-extra/clang-tidy/utils/Renam

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. In D92808#2593204 , @thakis wrote: > FYI, we're seeing test failures caused by this patch in iOS/arm64 builds when > arc is used (simulator is fine though): > https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c11 > >

[PATCH] D93031: Enable fexec-charset option

tahonermann added a comment. Hi, Abhina. Sorry for the delay getting back to you. I added some more comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:191 +Preprocessor &PP, tok::TokenKind kind, +ConversionState Translation

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:99 + Loop *RowLoop = LI.AllocateLoop(); + Loop *ColLoop = LI.AllocateLoop(); + RowLoop->addChildLoop(ColLoop); pengfei wrote: > Not sure how about the arithmetic intrinsics

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 327029. myhsu marked 4 inline comments as done. myhsu added a comment. [NFC] Update FileCheck prefix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td clang/lib/D

[PATCH] D97659: BPF: fix enum value 0 issue for __builtin_preserve_enum_value()

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lorenz Bauer reported that the following code will have compilation error for bpf target: e