hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
thanks, this looks great. ================ Comment at: clang-tools-extra/clangd/TUScheduler.cpp:187 +/// +/// This could also naturally live in the index, but there are advantages to +/// using open files instead: ---------------- I'm a bit confused, I don't get the meaning of the "This could also naturally live in the index", what lives in the index? my best guess is the include structure captured in background index. ================ Comment at: clang-tools-extra/clangd/TUScheduler.cpp:202 +/// proxy file is invalidated *and* a new candidate proxy file is built. +/// Switching proxies likely invalidates the preamble, so it's expensive. +/// - We don't capture the actual compile command, but just the filename we ---------------- maybe it is just me, it took me a while to understand the meaning of "invalidates the preamble" -- switching proxies usually indicates the change of CMD of the header, thus the preamble of the header is invalidated, is that right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97351/new/ https://reviews.llvm.org/D97351 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
