[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 326882. tbaeder added a comment. You are right of course. I changed the diff to allow GNU-style attributes and reject everything else. This is a bit hairy because `[[]]` is an empty attribute list but the `SourceRange` is still valid. We don't know if the s

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:186 - // Emit a fix and a fix description of the check; - diag(Context.FoundUsingDecl->getLocation(), - /*Description=*/"remove the using", DiagnosticIDs::N

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 326888. DmitryPolukhin added a comment. Use -DAG checks to make test stable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files: clang-tools-extra/clang-tidy

[clang-tools-extra] a5e3d87 - [clang-tidy] Handle uninstantiated templates in redundant get check

Author: Stephen Kelly Date: 2021-02-27T12:08:41Z New Revision: a5e3d87f66a1b833594f121fbd8c7334df5a1eeb URL: https://github.com/llvm/llvm-project/commit/a5e3d87f66a1b833594f121fbd8c7334df5a1eeb DIFF: https://github.com/llvm/llvm-project/commit/a5e3d87f66a1b833594f121fbd8c7334df5a1eeb.diff LOG:

[PATCH] D96222: Handle uninstantiated templates in redundant get check

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5e3d87f66a1: [clang-tidy] Handle uninstantiated templates in redundant get check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang-tools-extra] 296c6e8 - [clang-tidy] Simplify shrink to fit check

Author: Stephen Kelly Date: 2021-02-27T12:11:42Z New Revision: 296c6e85c19b7fc224109fe43af2fd9ed1d3d510 URL: https://github.com/llvm/llvm-project/commit/296c6e85c19b7fc224109fe43af2fd9ed1d3d510 DIFF: https://github.com/llvm/llvm-project/commit/296c6e85c19b7fc224109fe43af2fd9ed1d3d510.diff LOG:

[clang-tools-extra] 9ba557c - [clang-tidy] Simplify default member init check

Author: Stephen Kelly Date: 2021-02-27T12:11:43Z New Revision: 9ba557cc0370ee5fa93dca04a20bd2b05bf19f45 URL: https://github.com/llvm/llvm-project/commit/9ba557cc0370ee5fa93dca04a20bd2b05bf19f45 DIFF: https://github.com/llvm/llvm-project/commit/9ba557cc0370ee5fa93dca04a20bd2b05bf19f45.diff LOG:

[clang-tools-extra] 35763ba - [clang-tidy] Simplify redundant member init check

Author: Stephen Kelly Date: 2021-02-27T12:11:44Z New Revision: 35763baf9aa927c2e8fc0a4af484c51391ecc30c URL: https://github.com/llvm/llvm-project/commit/35763baf9aa927c2e8fc0a4af484c51391ecc30c DIFF: https://github.com/llvm/llvm-project/commit/35763baf9aa927c2e8fc0a4af484c51391ecc30c.diff LOG:

[PATCH] D97144: [clang-tidy] Simplify shrink to fit check

This revision was automatically updated to reflect the committed changes. Closed by commit rG296c6e85c19b: [clang-tidy] Simplify shrink to fit check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97144/new/ https://reviews

[clang-tools-extra] df42f99 - [clang-tidy] Simplify suspicious enum usage check

Author: Stephen Kelly Date: 2021-02-27T12:11:45Z New Revision: df42f9950d5e4aaea2038581188ed9d786d09213 URL: https://github.com/llvm/llvm-project/commit/df42f9950d5e4aaea2038581188ed9d786d09213 DIFF: https://github.com/llvm/llvm-project/commit/df42f9950d5e4aaea2038581188ed9d786d09213.diff LOG:

[clang-tools-extra] a5feefa - [clang-tidy] Simplify redundant branch condition check

Author: Stephen Kelly Date: 2021-02-27T12:13:23Z New Revision: a5feefa3c72e67ea94b50addf8f0975dae9a9696 URL: https://github.com/llvm/llvm-project/commit/a5feefa3c72e67ea94b50addf8f0975dae9a9696 DIFF: https://github.com/llvm/llvm-project/commit/a5feefa3c72e67ea94b50addf8f0975dae9a9696.diff LOG:

[PATCH] D97145: [clang-tidy] Simplify default member init check

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ba557cc0370: [clang-tidy] Simplify default member init check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97145/new/ https://r

[clang-tools-extra] b672870 - [clang-tidy] Simplify special member functions check

Author: Stephen Kelly Date: 2021-02-27T12:13:24Z New Revision: b672870886643a99dd74f3114995f2a091eab813 URL: https://github.com/llvm/llvm-project/commit/b672870886643a99dd74f3114995f2a091eab813 DIFF: https://github.com/llvm/llvm-project/commit/b672870886643a99dd74f3114995f2a091eab813.diff LOG:

[clang-tools-extra] 302cc84 - [clang-tidy] Simplify boolean expr check

Author: Stephen Kelly Date: 2021-02-27T12:13:24Z New Revision: 302cc8421ee4ac1cf910dd6cd3306c6eae8d0d3e URL: https://github.com/llvm/llvm-project/commit/302cc8421ee4ac1cf910dd6cd3306c6eae8d0d3e DIFF: https://github.com/llvm/llvm-project/commit/302cc8421ee4ac1cf910dd6cd3306c6eae8d0d3e.diff LOG:

[PATCH] D97147: [clang-tidy] Simplify redundant member init check

This revision was automatically updated to reflect the committed changes. Closed by commit rG35763baf9aa9: [clang-tidy] Simplify redundant member init check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97147/new/ https:/

[PATCH] D97149: [clang-tidy] Simplify suspicious enum usage check

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf42f9950d5e: [clang-tidy] Simplify suspicious enum usage check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97149/new/ https:/

[PATCH] D97151: [clang-tidy] Simplify redundant branch condition check

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5feefa3c72e: [clang-tidy] Simplify redundant branch condition check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97151/new/ ht

[PATCH] D97152: [clang-tidy] Simplify special member functions check

This revision was automatically updated to reflect the committed changes. Closed by commit rGb67287088664: [clang-tidy] Simplify special member functions check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97152/new/ http

[PATCH] D97153: [clang-tidy] Simplify boolean expr check

This revision was automatically updated to reflect the committed changes. Closed by commit rG302cc8421ee4: [clang-tidy] Simplify boolean expr check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97153/new/ https://reviews.

[clang-tools-extra] 42ce00e - [clang-tidy] Simplify suspicious memset usage check

Author: Stephen Kelly Date: 2021-02-27T12:17:09Z New Revision: 42ce00ec3947de89c1cda0138fe6adfface3 URL: https://github.com/llvm/llvm-project/commit/42ce00ec3947de89c1cda0138fe6adfface3 DIFF: https://github.com/llvm/llvm-project/commit/42ce00ec3947de89c1cda0138fe6adfface3.diff LOG:

[PATCH] D97150: [clang-tidy] Simplify suspicious memset usage check

This revision was automatically updated to reflect the committed changes. Closed by commit rG42ce00ec3947: [clang-tidy] Simplify suspicious memset usage check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97150/new/ https

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:88 + +template Can we just use `template `? I think it also can reduce the > branch. Why do we need a template instead of passing a parameter `bool IsLoad`? Repository: rG LLVM Github

[PATCH] D97614: [clang-tidy] Remove OptionError

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The interface served a purpose, but since the ability to emit di

[PATCH] D97615: [clangd] Include macro expansions in documentSymbol hierarchy

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Browsing macro-generated symbols is confu

[PATCH] D97615: [clangd] Include macro expansions in documentSymbol hierarchy

sammccall added a comment. Before: F15668515: 2021-02-27-141552_903x356_scrot.png After: F15668516: 2021-02-27-141523_815x430_scrot.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:88 + +template pengfei wrote: > > Can we just use `template `? I think it also can reduce the > > branch. > Why do we need a template instead of passing a parameter `bool IsLoad`? Bing thou

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:88 + +template LuoYuanke wrote: > > pengfei wrote: > > > Can we just use `template `? I think it also can reduce the > > > branch. > > Why do we need a template instead of passing a param

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX updated this revision to Diff 326903. ArcsinX added a comment. - Do not insert the keys into the file list - Iterate through refs and symbols to create the file list after releasing the lock Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D975

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:279 SymbolSlabs.push_back(FileAndSymbols.second); + for (const auto &S : *FileAndSymbols.second) { +if (S.Definition)

[PATCH] D97246: [ASTMatchers] Fix matching failure in IgnoreUnlessSpelledInSource mode

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4358 internal::Matcher, InnerMatcher) { - auto MatchIt = matchesFirstInPointerRange(InnerMatcher, Node.init_begin(), -Node.init_en

[PATCH] D97246: [ASTMatchers] Fix matching failure in IgnoreUnlessSpelledInSource mode

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Thanks for this change! I don't feel strongly about whether a new method or a new parameter is appropriate, so it's a +1 from me already. Giving other AST nodes consistent API about whethe

[clang] dd6738d - [clang][Lifetimes] Fix false positive warning from BUG 49342

Author: Gabor Horvath Date: 2021-02-27T08:09:57-08:00 New Revision: dd6738d93de148f2239ef5be82a61cf8f5f71124 URL: https://github.com/llvm/llvm-project/commit/dd6738d93de148f2239ef5be82a61cf8f5f71124 DIFF: https://github.com/llvm/llvm-project/commit/dd6738d93de148f2239ef5be82a61cf8f5f71124.diff

[PATCH] D97605: [Lifetimes] Fix false positive warning from BUG 49342

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd6738d93de1: [clang][Lifetimes] Fix false positive warning from BUG 49342 (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANGES S

[clang-tools-extra] 415acb2 - Revert "[clang-itdy] Simplify virtual near-miss check"

Author: Stephen Kelly Date: 2021-02-27T19:30:38Z New Revision: 415acb2c5994a95be739b908785ea8260baa18fd URL: https://github.com/llvm/llvm-project/commit/415acb2c5994a95be739b908785ea8260baa18fd DIFF: https://github.com/llvm/llvm-project/commit/415acb2c5994a95be739b908785ea8260baa18fd.diff LOG:

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

steveire added a comment. Thanks for the heads-up. I've reverted it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96224/new/ https://reviews.llvm.org/D96224 ___ cfe-commits mailing list cfe-commits@

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

sammccall created this revision. sammccall added a reviewer: dgoldman. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - highlight references to proto

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop added a comment. In D96120#2591418 , @vitalybuka wrote: >>> This is intended as a step to porting scudo standalone. > > Why this is needed for scudo stadalone? It’s not strictly needed. It seemed like it was easier, as some of the work had

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

sammccall added a comment. (not really sure why this suddenly seemed important to me, but if you don't have semantic highlighting on, you're missing out!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97617/new/ https://reviews.llvm.org/D97617 __

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 326922. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: clang-tools-extra/clangd/FindSymbols.cpp:176 +std::string getSymbolName(ASTContext &Ctx, const NamedDecl &ND) { + if (const auto *Container

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 326923. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] e0b1df9 - [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

Author: Darwin Xu Date: 2021-02-27T22:56:36+01:00 New Revision: e0b1df924ae06d6d88582334087d2eacc6702e8f URL: https://github.com/llvm/llvm-project/commit/e0b1df924ae06d6d88582334087d2eacc6702e8f DIFF: https://github.com/llvm/llvm-project/commit/e0b1df924ae06d6d88582334087d2eacc6702e8f.diff LOG

[PATCH] D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b1df924ae0: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers (authored by darwin, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Do you need someone to push this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. Is this acceptable to the others? Do you need someone to push it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 ___ cfe-comm

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks updated this revision to Diff 326928. HazardyKnusperkeks added a comment. - Work with `::max` instead of many checks for `== 0`. - Additional Testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96896/new/ https://reviews.llvm.

[PATCH] D93164: [AST] Add generator for source location introspection

njames93 added a comment. Mostly mechanical changes requested here. In D93164#2456247 , @steveire wrote: > @thakis FYI - I think the GN build would need to be adapted to this. FWIW the GN build has a bot that can typically update its gn files. ===

[PATCH] D97620: Fix DecisionForestBenchmark.cpp compile errors

poelmanc created this revision. poelmanc added a reviewer: usaxena95. poelmanc added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. poelmanc requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. clang-to

[PATCH] D97620: Fix DecisionForestBenchmark.cpp compile errors

poelmanc updated this revision to Diff 326937. poelmanc added a comment. Shorten comment and add period. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97620/new/ https://reviews.llvm.org/D97620 Files: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry added a comment. > Do you need someone to push it? Yes, I need someone to do that. I don't have write permissions. I'm new here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 _