[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov, yaxunl. Herald added a subscriber: ebevhan. Anastasia requested review of this revision. Add documentation that explains how to extend clang with new extensions/features. The guidelines also detail clang's position ab

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1781 +// analysis. +if (VTable->isDeclarationForLinker()) + CGM.addCompilerUsedGlobal(VTable); ---

[PATCH] D97001: [Coverage] Normalize compilation dir as well

vsk added a comment. Would it be straightforward to test this, like we do other filename encodings in abspath.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97001/new/ https://reviews.llvm.org/D97001 __

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5355 + Expr *Cond, *Inc; + VarDecl *CounterDecl, *LVDecl; + if (auto *For = dyn_cast(AStmt)) { jdenny wrote: > `CounterDecl` is the declaration of the "loop iteration variable" based on >

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. Herald added a subscriber: frasercrmck. Looking back at this I'm not so sure if it was beneficial to divert from the generic behavior and print each function for each prefix. Having a function only in one run line but not the other should work perfectly fine as long as

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. This patch has no effect if the OpenMP IR builder is not enabled, and it's disabled by default. Is that right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973 _

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

tejohnson updated this revision to Diff 325065. tejohnson added a comment. Add assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96919/new/ https://reviews.llvm.org/D96919 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/CodeGenCXX/typ

[clang] 0923a60 - [clang] Emit type metadata on available_externally vtables for WPD

Author: Teresa Johnson Date: 2021-02-19T12:42:34-08:00 New Revision: 0923a60ea70f884d2f170f65d0faa494a25af231 URL: https://github.com/llvm/llvm-project/commit/0923a60ea70f884d2f170f65d0faa494a25af231 DIFF: https://github.com/llvm/llvm-project/commit/0923a60ea70f884d2f170f65d0faa494a25af231.diff

[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0923a60ea70f: [clang] Emit type metadata on available_externally vtables for WPD (authored by tejohnson). Repository: rG LLVM Github Monorepo CHA

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, tskeith, sscalpone, clementval, AMDChirag, SouraVX. Herald added subscribers: jansvoboda11, dang, jfb. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add su

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 325071. v.g.vassilev marked 8 inline comments as done. v.g.vassilev added a comment. Address comments from Raphael and Stefan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files: clang/include/clan

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:184 + SourceLocation NewLoc = SM.getLocForStartOfFile(SM.getMainFileID()) + .getLocWithOffset(InputCount + 2); + teemperor wrote: > The `+ 2`

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

gregmiller added a comment. Hello, We are seeing failures like below: -- Note: Google Test filter = ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0 [==] Running 1 test from 1 test case. [--] Global test environment set

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

ldionne added a comment. In D93003#2567088 , @steven_wu wrote: > In D93003#2566906 , @rprichard wrote: > >> Maybe this is blocked on someone from Apple reviewing the Mach-O parts? > > This is fine with me for how Ap

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

Quuxplusone accepted this revision. Quuxplusone added a comment. Suggested some ways to improve test coverage, and continued bikeshedding on the SFINAE ;) but there's no reason to hold this up AFAIC. Comment at: libcxx/include/tuple:58 tuple& operator=(const tuple&); -

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

Quuxplusone added inline comments. Comment at: libcxx/include/tuple:971 +_VSTD::get<0>(*this) = _VSTD::forward<_Up1>(__pair.first); +_VSTD::get<1>(*this) = _VSTD::forward<_Up2>(__pair.second); +return *this; Oh, late-breaking nit: I would

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

ctetreau accepted this revision. ctetreau added a comment. LGTM. I'll land it for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] 55448ab - [AArch64] Adding Neon Polynomial vadd Intrinsics

Author: Christopher Tetreault Date: 2021-02-19T14:48:12-08:00 New Revision: 55448ab540ded21bb2880e52efcf22e07603a096 URL: https://github.com/llvm/llvm-project/commit/55448ab540ded21bb2880e52efcf22e07603a096 DIFF: https://github.com/llvm/llvm-project/commit/55448ab540ded21bb2880e52efcf22e07603a0

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG55448ab540de: [AArch64] Adding Neon Polynomial vadd Intrinsics (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://revi

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka created this revision. vvereschaka added a reviewer: sepavloff. vvereschaka added a project: clang. vvereschaka requested review of this revision. Herald added a subscriber: cfe-commits. Added supporting CC_PRINT_PROC_STAT and CC_PRINT_PROC_STAT_FILE environment variables to trigger c

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka added a comment. @sepavloff would you add more persons in additional to the reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 ___ cfe-commits

[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

craig.topper added a comment. Is this change specific to fixed vectors declared with arm_sve_vector_bits or any of the subclasses of VectorType? If it allows the others, how do we know for sure that there are enough bits in the scalable type for the fixed vector. I ask because RISCV is also usi

[PATCH] D97001: [Coverage] Normalize compilation dir as well

phosek updated this revision to Diff 325099. phosek added a comment. Test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97001/new/ https://reviews.llvm.org/D97001 Files: clang/lib/CodeGen/CoverageMappingGen.cpp clang/test/Profile/profil

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik updated this revision to Diff 325100. shafik added a comment. Herald added subscribers: usaxena95, kadircet. Fixing tests that I missed before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm.org/D96807 Files: clang-tools-extra/clangd/unittests/Fi

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 325101. vvereschaka added a comment. Updated diff in according of the Lint/clang-format recommendations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 Files: cl

[PATCH] D97001: [Coverage] Normalize compilation dir as well

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97001/new/ https://reviews.llvm.org/D97001 ___ cfe-

[clang] 3275b18 - [Coverage] Normalize compilation dir as well

Author: Petr Hosek Date: 2021-02-19T15:29:03-08:00 New Revision: 3275b18f8979ab750e3674f28e7f82c7ef37d2a3 URL: https://github.com/llvm/llvm-project/commit/3275b18f8979ab750e3674f28e7f82c7ef37d2a3 DIFF: https://github.com/llvm/llvm-project/commit/3275b18f8979ab750e3674f28e7f82c7ef37d2a3.diff LO

[PATCH] D97001: [Coverage] Normalize compilation dir as well

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3275b18f8979: [Coverage] Normalize compilation dir as well (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:90 + } else if (T->isWideCharType()) +Out << "L'" << reinterpret_cast(Val.getLimitedValue(WCHAR_MAX)) +<< "'"; `getLimitedValue` doesn't return a pointer, and the host `WCHAR_MA

[PATCH] D97095: [ASTMatchers] Fix hasUnaryOperand matcher for postfix operators

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97095 Files: clang/include/clang/ASTMatch

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

danalbert added a comment. It sounds like everyone is happy here but the tools. Could we get a libunwind reviewer (preferably @compnerd, since his review is the red one) to LGTM this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https:

[PATCH] D97098: [Utils] Add an option to specify number of cores to use in creduce-clang-crash.py

zequanwu created this revision. zequanwu added reviewers: akhuang, thakis, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97098 Files: clang/utils/creduce-cl

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer updated this revision to Diff 325114. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/no-warn-missing-prototype-efi.c Index: clang/test/Sem

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer added a comment. Added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu created this revision. zequanwu added reviewers: vsk, efriedma, rnk, pirama. Herald added a subscriber: lxfind. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This solves the problems that D85036

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

steven_wu accepted this revision. steven_wu added a comment. My main concern is just that weak alias for libc++abi that never worked for Darwin :) LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https://reviews.llvm.org/D93003 ___

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

rprichard added a comment. For reference, I know of four ways that LLVM's libunwind is currently linked into programs: - Fuchsia/Windows (i.e. Clang's default behavior): it's part of libc++, e.g.: - Fuchsia: - `fuchsia/prebuilt/third_party/clang/linux-x64/lib/x86_64-unknown-fuchsia/c++/li

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

ikudrin added a comment. In D96865#2575486 , @gregmiller wrote: > Do you have any suggestions on why we would start seeing above failures after > you commit? Was passing before. From my understanding, the areas seem to be perfectly unrelated. Reposito

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 updated this revision to Diff 325133. tianshilei1992 added a comment. Update to CUDA 9.2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 Files: clang/include/clang/Basic/DiagnosticDriverKin

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target

tianshilei1992 updated this revision to Diff 325136. tianshilei1992 added a comment. Use CUDA 9.1 for failure test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 Files: clang/include/clang/Basic/Diagnost

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me - maybe the test could be rolled into whatever file is already testing -Wmissing-prototype and the existing special case for "main"? Do you need me to commit this, or can

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

phosek accepted this revision. phosek added a comment. LGTM I'd also suggest renaming `LIBCXXABI_HERMETIC_STATIC_LIBRARY` and `LIBCXX_HERMETIC_STATIC_LIBRARY` to `LIBCXXABI_HIDE_SYMBOLS` and `LIBCXX_HIDE_SYMBOLS` respectively in a follow up change to maintain consistency. Repository: rG LL

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT created this revision. oToToT added reviewers: jdoerfert, sammccall, ilya-biryukov. oToToT added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald a

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:211-212 +IRBuilderBase &B, DomTreeUpdater &DTU, +LoopInfo &LI, Value *Row, Value *Col, +

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 325152. yubing added a comment. Address the commments above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h llvm/lib/Targe

[clang] ee51c42 - Reduce the number of attributes attached to each function

Author: Dávid Bolvanský Date: 2021-02-20T06:57:47+01:00 New Revision: ee51c42e0060fc98b499312e51a96bc7cf4bcc18 URL: https://github.com/llvm/llvm-project/commit/ee51c42e0060fc98b499312e51a96bc7cf4bcc18 DIFF: https://github.com/llvm/llvm-project/commit/ee51c42e0060fc98b499312e51a96bc7cf4bcc18.dif

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 325155. yubing marked 5 inline comments as done. yubing added a comment. Small fix for some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/ll

[clang] 501b4fe - Fixed failing test

Author: Dávid Bolvanský Date: 2021-02-20T07:11:42+01:00 New Revision: 501b4fe4ed7f5de2ae00cbc9da87a5b1141ec47a URL: https://github.com/llvm/llvm-project/commit/501b4fe4ed7f5de2ae00cbc9da87a5b1141ec47a DIFF: https://github.com/llvm/llvm-project/commit/501b4fe4ed7f5de2ae00cbc9da87a5b1141ec47a.dif

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar updated this revision to Diff 325158. jlebar added a comment. Rename noteNumOverloadCandidatesShown -> overloadCandidatesShown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/ https://reviews.llvm.org/D95754 Files: clang/include/

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. > I guess I was confused by the function name Haha, two hardest problems in computer science. :) Changed it to `S.Diags.overloadCandidatesShown(ShownOverloads);` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95754/new/ ht

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

dexonsmith added a comment. In D96847#2574408 , @jansvoboda11 wrote: > That's a bit nicer. > > Not sure if `RemarkPattern` is a good name now, as it may represent an > optimization remark that doesn't have any pattern associated with it. > How about call

[PATCH] D97042: [clang][cli] Stop creating '-Wno-stdlibcxx-not-found' in cc1

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Agreed; LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97042/new/ https://reviews.llvm.org/D97042

[PATCH] D97042: [clang][cli] Stop creating '-Wno-stdlibcxx-not-found' in cc1

dexonsmith added a comment. In D97042#2576372 , @dexonsmith wrote: > Agreed; LGTM. To be more explicit, here's how I confirmed this is dead code: `warn_drv_libstdcxx_not_found` is the only warning in `DiagGroup<"stdlibcxx-not-found">` and it's only used

<    1   2