yubing added inline comments.
================
Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:211-212
+ IRBuilderBase &B, DomTreeUpdater &DTU,
+ LoopInfo &LI, Value *Row, Value *Col,
+ Value *K, Value *Acc, Value *LHS,
+ Value *RHS) {
----------------
xiangzhangllvm wrote:
> In fact, no need handle Row, Col, K here, just use fix size 16x16, the result
> of calculation is some in effective area. (just need tileload "keep" the
> "unused" area is 0).
> Then can use vector to handle all of the them, let type legalization to split
> the type.
We should keep the code here. In bf16, since +0.0(0x0000) * negative float is
equal to -0.0(0x8000), following your solution is not able to ensure outer edge
is allzero.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93594/new/
https://reviews.llvm.org/D93594
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
