[PATCH] D96838: CodeGen: Set !retain metadata on UsedAttr definitions for Linux/FreeBSD

phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2071 + const llvm::Triple &T = getTarget().getTriple(); + if (T.isOSFreeBSD() || T.isOSLinux()) +GO->setMetadata(llvm::LLVMContext::MD_retain, Would it be possible to also include

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a comment. CodePtr points into the bytecode emitted by the byte code compiler. In some instances, pointers to auxiliary data structures are embedded into the byte code, such as functions or AST nodes which contain information relevant to the execution of the instruction. Would it he

[PATCH] D96755: [clangd] Shutdown sequence for modules, and doc threading requirements

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:180 +for (auto &Mod : *Modules) + Mod.blockUntilIdle(Deadline::infinity()); + }

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

kadircet accepted this revision. kadircet added a comment. still LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ https://reviews.llvm.org/D96717 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson added a comment. @ASDenysPetrov, could you provide your link command-line for one of the tools that produces the failing message, please, e.g. llvm-ar? That may give us a hint about whether different libraries are being used. It's possible we need some additional cmake-time configura

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:184 + SourceLocation NewLoc = SM.getLocForStartOfFile(SM.getMainFileID()) + .getLocWithOffset(InputCount + 2); + The `+ 2` here is probably not

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After a revision of D96274 changed `DiagnosticOptions`

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324224. phosek marked an inline comment as done. phosek retitled this revision from "Store compilation dir separately in coverage mapping" to "[Coverage] Store compilation dir separately in coverage mapping". Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {#ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.def" Should

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 updated this revision to Diff 324225. jansvoboda11 added a comment. Rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 Files: clang/include/clang/Basic/CodeGenOptions.h clang/l

[clang] e1a64aa - [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

Author: Anton Zabaznov Date: 2021-02-17T12:18:46+03:00 New Revision: e1a64aa66c332d16b3f0dae0426ee29eeb6bbba6 URL: https://github.com/llvm/llvm-project/commit/e1a64aa66c332d16b3f0dae0426ee29eeb6bbba6 DIFF: https://github.com/llvm/llvm-project/commit/e1a64aa66c332d16b3f0dae0426ee29eeb6bbba6.diff

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1a64aa66c33: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

theraven requested changes to this revision. theraven added a comment. This revision now requires changes to proceed. I'm broadly in favour of this change, but with the GNUstep ABIs this is an ABI-breaking change and so should not be on by default. The type encoding leaks into the ABI in two wa

[PATCH] D96848: [clang][cli] Don't emit manufactured warnings

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The switch from per-member round-trip to whole-`CompilerInvocation` round-trip in D96280

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 updated this revision to Diff 324229. jansvoboda11 added a comment. Add fixme as suggested in code review. Rebase on top of the final version of D94472 , which added `-[no-]round-trip-args`. The arguments are now handled in `RoundTrip`. Repository:

[PATCH] D96751: [clangd] Populate detail field in document symbols

sammccall added a comment. This looks really good. Only thing i'd really think about changing in behavior is dropping the template params. Please go ahead and upload the unittests! (And thanks for including the diff context) Comment at: clang-tools-extra/clangd/FindSymbols.cp

[PATCH] D96850: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn created this revision. Herald added subscribers: jansvoboda11, dexonsmith, dang. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This cherry-picks the following patches on the release branch: 6280bb4cd80e

[clang-tools-extra] 7b83837 - [clangd] Bind outgoing calls through LSPBinder too. NFC

Author: Sam McCall Date: 2021-02-17T10:56:06+01:00 New Revision: 7b83837af6f472e9c0ed0b96b78717d4a3c4dbfe URL: https://github.com/llvm/llvm-project/commit/7b83837af6f472e9c0ed0b96b78717d4a3c4dbfe DIFF: https://github.com/llvm/llvm-project/commit/7b83837af6f472e9c0ed0b96b78717d4a3c4dbfe.diff LO

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b83837af6f4: [clangd] Bind outgoing calls through LSPBinder too. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ http

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added a comment. In D96419#2556411 , @xbolva00 wrote: > In D96419#2556349 , @fhahn wrote: > >> In D96419#213 , @xbolva00 wrote: >> >>> Maybe we want these options i

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Looks sensible to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 ___ cfe-commi

[clang] aa84289 - [DebugInfo] Keep the DWARF64 flag in the module metadata

Author: Igor Kudrin Date: 2021-02-17T17:03:34+07:00 New Revision: aa842896299b014dc1837f1a01dfccbd94242c84 URL: https://github.com/llvm/llvm-project/commit/aa842896299b014dc1837f1a01dfccbd94242c84 DIFF: https://github.com/llvm/llvm-project/commit/aa842896299b014dc1837f1a01dfccbd94242c84.diff L

[PATCH] D96597: [DebugInfo] Keep the DWARF64 flag in the module metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa842896299b: [DebugInfo] Keep the DWARF64 flag in the module metadata (authored by ikudrin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96597/new/ https

[clang] 72eee60 - [Driver] Support -gdwarf64 for assembly files

Author: Igor Kudrin Date: 2021-02-17T17:03:34+07:00 New Revision: 72eee60b2451e8627e492d42bf1d43247685bef9 URL: https://github.com/llvm/llvm-project/commit/72eee60b2451e8627e492d42bf1d43247685bef9 DIFF: https://github.com/llvm/llvm-project/commit/72eee60b2451e8627e492d42bf1d43247685bef9.diff L

[PATCH] D96783: [Driver] Support -gdwarf64 for assembly files

This revision was automatically updated to reflect the committed changes. ikudrin marked 2 inline comments as done. Closed by commit rG72eee60b2451: [Driver] Support -gdwarf64 for assembly files (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D96783?vs=323989&id=324239#

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

DavidSpickett added a comment. This LGTM unless @labrinea has any final comments. Could you add "Neon" in the commit title? "[AArch64] Adding Neon Polynomial vadd Intrinsics support", just to help when reading git history. Comment at: clang/test/CodeGen/aarch64-poly-add.c:4 +

[clang-tools-extra] d20961c - [clang-tidy] Simplify delete null ptr check

Author: Stephen Kelly Date: 2021-02-17T10:18:36Z New Revision: d20961c6575c00fc998d901ded78c1a41edd61b1 URL: https://github.com/llvm/llvm-project/commit/d20961c6575c00fc998d901ded78c1a41edd61b1 DIFF: https://github.com/llvm/llvm-project/commit/d20961c6575c00fc998d901ded78c1a41edd61b1.diff LOG:

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

This revision was automatically updated to reflect the committed changes. Closed by commit rGd20961c6575c: [clang-tidy] Simplify delete null ptr check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96138/new/ https://revie

[clang-tools-extra] 6c2eca9 - [clang-tidy] Simplify inefficient algorithm check

Author: Stephen Kelly Date: 2021-02-17T10:19:44Z New Revision: 6c2eca96a2a59f69889a9d4133a819ab2e4fa1ef URL: https://github.com/llvm/llvm-project/commit/6c2eca96a2a59f69889a9d4133a819ab2e4fa1ef DIFF: https://github.com/llvm/llvm-project/commit/6c2eca96a2a59f69889a9d4133a819ab2e4fa1ef.diff LOG:

[PATCH] D96140: [clang-tidy] Simplify inefficient algorithm check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c2eca96a2a5: [clang-tidy] Simplify inefficient algorithm check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang-tools-extra] ca4485d - [clang-tidy] Simplify const params check

Author: Stephen Kelly Date: 2021-02-17T10:20:12Z New Revision: ca4485d9fc3449f7bb9522ee16ccf63f2219732c URL: https://github.com/llvm/llvm-project/commit/ca4485d9fc3449f7bb9522ee16ccf63f2219732c DIFF: https://github.com/llvm/llvm-project/commit/ca4485d9fc3449f7bb9522ee16ccf63f2219732c.diff LOG:

[PATCH] D96141: [clang-tidy] Simplify const params check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca4485d9fc34: [clang-tidy] Simplify const params check (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

thopre added a comment. In D96568#2567145 , @jonpa wrote: > In D96568#2559476 , @thopre wrote: > >> In D96568#2559475 , @uweigand wrote: >> >>> In D96568#2559336

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

joechrisellis created this revision. joechrisellis added reviewers: DavidTruby, peterwaller-arm, paulwalker-arm, bsmith. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added a project: clang. Her

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. @jhenderson > @ASDenysPetrov, could you provide your link command-line for one of the tools > that produces the failing message, please, e.g. llvm-ar? Here is output of running tests in llvm-ar folder: F15562458: fail_output_llvm_ar.txt

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96853

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. This patch immitates avr-gcc behavior on `__flash` 1. `__flash` variables are put into `.section .progmem.data` 2. `__flash` non-const variables are rejected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ http

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson added a comment. In D95246#2568084 , @ASDenysPetrov wrote: > @jhenderson > >> @ASDenysPetrov, could you provide your link command-line for one of the >> tools that produces the failing message, please, e.g. llvm-ar? > > Here is output of runni

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

balazske accepted this revision. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:835 + CTU.getMacroExpansionContextForSourceLocation(MacroExpansionLoc)) { +return CTUMacroExpCtx->getExpandedText(MacroExpansionLoc); }

[PATCH] D96755: [clangd] Shutdown sequence for modules, and doc threading requirements

sammccall updated this revision to Diff 324262. sammccall added a comment. Fix racy test - forgot to blockUntilIdle in sync! Found a bug in blockUntilIdle, i'll send it separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96755/new/ https://r

[PATCH] D96856: [clangd] Narrow and document a loophole in blockUntilIdle

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. blockUntilIdle of a parent can't always b

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz added a comment. In D96803#2566322 , @aeubanks wrote: > why is this now a module pass? Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better wa

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 324197. khchen added a comment. remove float32_t and float64_t to avoid collisions with other project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files: clang/inc

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

aaron.ballman added a comment. In D96082#2566984 , @steveire wrote: > In D96082#2565339 , @aaron.ballman > wrote: > >> A somewhat similar check that would be interesting is a function that >> returns the same valu

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the remaining missing builtin function declarations that have enum or typede

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder added a comment. In D95536#2557197 , @aaron.ballman wrote: > Hmm... I feel like the diagnostic should already be sufficient to locate the > originating location of the class or namespace and the note is adding a bit > more (almost, but not quite

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

aaron.ballman added a comment. It was explicitly disallowed in the initial patch: https://reviews.llvm.org/D12922 and the original author said "I'm still trying to figure out the best way to handle c++ virtual functions: this attribute is not very useful for someone who is looking for a way to

[PATCH] D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation

jansvoboda11 updated this revision to Diff 324280. jansvoboda11 added a comment. Add example to "Adding new Command Line Option", polish the rest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95790/new/ https://reviews.llvm.org/D95790 Files: cl

[clang] 8ddfcec - [clang][cli] Documentation of CompilerInvocation parsing/generation

Author: Jan Svoboda Date: 2021-02-17T14:29:49+01:00 New Revision: 8ddfcec91b7801af058f43906073822d7f146bf5 URL: https://github.com/llvm/llvm-project/commit/8ddfcec91b7801af058f43906073822d7f146bf5 DIFF: https://github.com/llvm/llvm-project/commit/8ddfcec91b7801af058f43906073822d7f146bf5.diff L

[PATCH] D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ddfcec91b78: [clang][cli] Documentation of CompilerInvocation parsing/generation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

aaron.ballman added a comment. Can you add a bit more description to the review summary about what's being fixed? It helps the reviewers with context but it also helps when doing code archeology on changes. Comment at: clang/lib/AST/ParentMapContext.cpp:138 + // diff

[PATCH] D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4

bd1976llvm marked 2 inline comments as done. bd1976llvm added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90299/new/ https://reviews.llvm.org/D90299 ___ cfe-commits mailing list cfe-

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

joechrisellis planned changes to this revision. joechrisellis added a comment. Speaking to @DavidTruby about this, it appears that this fix is insufficient -- `inline` has important semantic meaning in C++ that means that we can't simply omit the keyword here. The `inline` keyword bypasses the

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

paulwalker-arm added a comment. In D96852#2568383 , @joechrisellis wrote: > Speaking to @DavidTruby about this, it appears that this fix is insufficient > -- `inline` has important semantic meaning in C++ that means that we can't > simply omit the keywo

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

This revision was automatically updated to reflect the committed changes. Closed by commit rG23d65aa44631: [OpenCL] Support enum and typedef args in TableGen BIFs (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https:/

[clang] 23d65aa - [OpenCL] Support enum and typedef args in TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-17T14:17:43Z New Revision: 23d65aa446312402a0b4615122f0a18d4467ed60 URL: https://github.com/llvm/llvm-project/commit/23d65aa446312402a0b4615122f0a18d4467ed60 DIFF: https://github.com/llvm/llvm-project/commit/23d65aa446312402a0b4615122f0a18d4467ed60.diff

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

tschuett added a comment. See __STDC_VERSION__ in https://gcc.gnu.org/onlinedocs/cpp/Standard-Predefined-Macros.html. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96852/new/ https://reviews.llvm.org/D96852 __

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

joechrisellis added a comment. > That makes sense and suggests we're missing some additional C++ testing? Agreed -- this passes all tests at the moment, so we can do better test-wise. The error to do with the one definition rule would crop up at link time, though, so we'd need at least two comp

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flang

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for `-Xflang` in `flang-new`. The semanti

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal added a comment. This patch preserves all previous reports as expected. You can check it by yourself at https://codechecker-demo.eastus.cloudapp.azure.com/Default/runs?run=D96090&items-per-page=50. However, I still have some minor concerns inline. Comment at: clang/

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

paulwalker-arm added a comment. One observation is that for arm_neon.h `__inline__` is used. So perhaps we can just do likewise and we'll also be consistent across the two ACLE headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96852/new/ htt

[PATCH] D95536: [clang][sema] Note decl location on missing member

aaron.ballman added a comment. In D95536#2568252 , @tbaeder wrote: > In D95536#2557197 , @aaron.ballman > wrote: > >> Hmm... I feel like the diagnostic should already be sufficient to locate the >> originating loc

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:835 + CTU.getMacroExpansionContextForSourceLocation(MacroExpansionLoc)) { +return CTUMacroExpCtx->getExpandedText(MacroExpansionLoc); } balazske wrote:

[clang-tools-extra] e030de7 - [clangd] Pass file when possible to resolve URI.

Author: Haojian Wu Date: 2021-02-17T15:33:50+01:00 New Revision: e030de7e5a28de1bcc337ede445600f8d282d252 URL: https://github.com/llvm/llvm-project/commit/e030de7e5a28de1bcc337ede445600f8d282d252 DIFF: https://github.com/llvm/llvm-project/commit/e030de7e5a28de1bcc337ede445600f8d282d252.diff LO

[PATCH] D96844: [clangd] Pass file when possible to resolve URI.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe030de7e5a28: [clangd] Pass file when possible to resolve URI. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96844/new/ https://review

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 7048cb5 - [clangd] IndexedFiles should include Fils from RefSlab and RelationSlab.

Author: Haojian Wu Date: 2021-02-17T15:41:09+01:00 New Revision: 7048cb5371f93788ee650c521995a85211f3ae46 URL: https://github.com/llvm/llvm-project/commit/7048cb5371f93788ee650c521995a85211f3ae46 DIFF: https://github.com/llvm/llvm-project/commit/7048cb5371f93788ee650c521995a85211f3ae46.diff LO

[PATCH] D96845: [clangd] IndexedFiles should include Fils from RefSlab and RelationSlab.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7048cb5371f9: [clangd] IndexedFiles should include Fils from RefSlab and RelationSlab. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

ikudrin created this revision. ikudrin added reviewers: dblaikie, probinson, aprantl, MaskRay, mehdi_amini. ikudrin added projects: LLVM, clang, debug-info. ikudrin requested review of this revision. This fixes an issue when `-gdwarf-N` switch was ignored if it was given before another debug opti

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324296. arnamoy10 added a comment. Addresses proper handling of sizes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D96852: [clang][SVE] Remove inline keyword from arm_sve.h

joechrisellis updated this revision to Diff 324311. joechrisellis added a comment. This revision is now accepted and ready to land. Use __inline__ instead of inline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96852/new/ https://reviews.llvm.org/

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

SouraVX added a comment. Thanks! for the patch @awarzynski . I support this enhancement. LGTM(Not accepting formally :) ), Let's wait and hear from others also, what's their take on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96864/new/ h

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

SouraVX added inline comments. Comment at: flang/test/Frontend/input-output-file.f90:6 !-- +! NOTE: We need `-E` below in order to instruct the compiler driver to create a job representing a fronted compiler invocation ! TEST 1: Print to stdout (implici

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski requested changes to this revision. awarzynski added a comment. This revision now requires changes to proceed. Thank you for updating this! I've left a couple of small suggestions inline. Once those are addressed I believe that this is ready to land. @tskeith, any thoughts ? ==

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:254 + if (args.hasArg(clang::driver::options::OPT_fdefault_real_8)) +res.defaultKinds().set_defaultRealKind(8); + if (args.hasArg(clang::driver::options::OPT_fdefault_integer_8)) { --

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

santagada added a comment. In D80833#2069411 , @aganea wrote: > In D80833#2069246 , @amccarth wrote: > >> Does the full path to the tool end up only in the object file, or does this >> make it all the way to the fi

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:254 + if (args.hasArg(clang::driver::options::OPT_fdefault_real_8)) +res.defaultKinds().set_defaultRealKind(8); + if (args.hasArg(clang::driver::options::OPT_fdefault_integer_8)) { -

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

rjmccall added a comment. Since this is just in pointee types, I suspect this is fine for dispatch outside of targets (like that one old Cray) where `sizeof(void*) != sizeof(some_struct*)`, which I don't believe we generally support. But yeah, if this affects GNU-runtime ivar mangling, we need

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324334. arnamoy10 added a comment. - Added option for setting DOUBLE PRECISION when `fdefault-real-8` is given - Also added link to relevant gfortran doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Fil

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

awarzynski added inline comments. Comment at: flang/test/Frontend/input-output-file.f90:6 !-- +! NOTE: We need `-E` below in order to instruct the compiler driver to create a job representing a fronted compiler invocation ! TEST 1: Print to stdout (impl

[PATCH] D96825: [AArch64] Adding Polynomial vadd Intrinsics support

rsanthir.quic marked an inline comment as done. rsanthir.quic added inline comments. Comment at: clang/test/CodeGen/aarch64-poly-add.c:4 +// RUN: %clang_cc1 -triple arm64-none-linux-gnu -target-feature +neon \ +// RUN: -disable-O0-optnone -ffp-contract=fast -emit-llvm -o - %s | o

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

rsanthir.quic updated this revision to Diff 324336. rsanthir.quic marked an inline comment as done. rsanthir.quic retitled this revision from "[AArch64] Adding Polynomial vadd Intrinsics support" to "[AArch64] Adding Neon Polynomial vadd Intrinsics". rsanthir.quic added a comment. removed unneces

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

DavidSpickett added a comment. One nit for now, I'll take a proper look tomorrow. Thanks for your work on these! Comment at: clang/test/CodeGen/aarch64-neon-sha3.c:26 +void test_vsha512su0(uint64x2_t w0_1, uint64x2_t w2_) { + + uint64x2_t result = vsha512su0q_u64(w0_1, w2_);

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, tskeith, sscalpone, clementval, AMDChirag, SouraVX. Herald added subscribers: jansvoboda11, dang. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96515/new/ https://reviews.llvm.org/D96515 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:234 + // -J/module-dir option + auto &moduleDir = res.moduleDir(); auto moduleDirList = In my opinion, using mutable references like this make the code hard to understand.

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, ye-luo, tianshilei1992, ABataev, grokos. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. [libomptarget] Try a fallback devicertl if

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield updated this revision to Diff 324342. JonChesterfield added a comment. - drop whitespace from .td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llvm.org/D96877 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D96789: [OpenCL] Move printf declaration to opencl-c-base.h

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96789/new/ https://reviews.llvm.org/D96789 __

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:254 + if (args.hasArg(clang::driver::options::OPT_fdefault_real_8)) +res.defaultKinds().set_defaultRealKind(8); + if (args.hasArg(clang::driver::options::OPT_fdefault_integer_8)) {

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1695 -std::string LibOmpTargetName = -"libomptarget-" + BitcodeSuffix.str() + ".bc"; - -for (StringRef LibraryPath : LibraryPaths) { - SmallString<128> LibOmpTarget

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. @jhenderson I'm using `cmake -GNinja ../llvm -DLLVM_LIT_ARGS=-sv -DLLVM_ENABLE_PROJECTS=clang -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON` for setup and `ninja` for build. Here is my CMakeCache.txt config file. F15567363: CM

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

SouraVX added inline comments. Comment at: flang/test/Frontend/input-output-file.f90:6 !-- +! NOTE: We need `-E` below in order to instruct the compiler driver to create a job representing a fronted compiler invocation ! TEST 1: Print to stdout (implici

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman updated this revision to Diff 324352. FarisRehman marked an inline comment as done. FarisRehman added a comment. Make semantics_ private Make semantics_ in PrescanAndSemaAction private, adding semantics() and setSemantics(). Summary of changes: - Add semantics() and setSemantics()

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:54 +public: + std::unique_ptr semantics_; }; FarisRehman wrote: > awarzynski wrote: > > Do we need to expose it? Shouldn't this be private? > It will not compile if th

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 _

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:265 "No library '%0' found in the default clang lib directory or in LIBRARY_PATH. Please use --libomptarget-%1-bc-path to specify %1 bitcode library.">; +def warn_drv_omp_off

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic updated this revision to Diff 324347. rsanthir.quic added a comment. Removed extra whitespace CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381 Files: clang/include/clang/Basic/arm_neon.td clang/include/clang/Basic/arm_neon_incl.

[PATCH] D96835: [HIP] Support device sanitizer

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:939 "__cyg_profile_func_enter and __cyg_profile_func_exit">; +def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">, + HelpText<"Enable sanitizer for AMDGPU target.">; We do have `BoolFOp

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debug-options-as.c:65 +// Check that -gdwarf-N can be placed before other options of the "-g" group. +// RUN: %clang -### -c -g -gdwarf-3

  1   2   >