FarisRehman added inline comments.
================ Comment at: flang/include/flang/Frontend/FrontendActions.h:54 +public: + std::unique_ptr<Fortran::semantics::Semantics> semantics_; }; ---------------- FarisRehman wrote: > awarzynski wrote: > > Do we need to expose it? Shouldn't this be private? > It will not compile if the variable is private as it needs to be referenced > in the implementation of ExecuteAction, e.g. > `DebugDumpParseTreeAction::ExecuteAction()` > It will compile if set to `protected` or `public` Updated to use a public getter and setter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96716/new/ https://reviews.llvm.org/D96716 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
