[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 322609. phosek retitled this revision from "[CoverageMapping] Don't absolutize source paths" to "Store compilation dir separately in coverage mapping". phosek edited the summary of this revision. Herald added subscribers: llvm-commits, dexonsmith, dang, sstefan

[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek added a comment. In D95753#2534895 , @vsk wrote: > Thanks for pointing DW_AT_comp_dir out. For coverage, gating the use of > relative paths on a flag sounds reasonable to me. It should also be possible > to extend the .covmapping format to include

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei updated this revision to Diff 322611. pengfei added a comment. Add nnan and nsz flags for fmin/fmax llvm.reduction intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 Files: clang/include/

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Have you rebased your change? It seems that your release notes are still for LLVM 12. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei updated this revision to Diff 322613. pengfei added a comment. Minor fixes in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 Files: clang/include/clang/Basic/BuiltinsX86.def clang/lib/Co

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei updated this revision to Diff 322615. pengfei added a comment. Minor fixes in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 Files: clang/include/clang/Basic/BuiltinsX86.def clang/lib/Co

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei updated this revision to Diff 322616. pengfei added a comment. Minor fixes in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 Files: clang/include/clang/Basic/BuiltinsX86.def clang/lib/Co

[clang] 9ae99a0 - [OpenCL] Add cl_khr_subgroup_non_uniform_arithmetic to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-10T09:44:39Z New Revision: 9ae99a0de8c79799df6fc0ff69ac3f73b7f4600f URL: https://github.com/llvm/llvm-project/commit/9ae99a0de8c79799df6fc0ff69ac3f73b7f4600f DIFF: https://github.com/llvm/llvm-project/commit/9ae99a0de8c79799df6fc0ff69ac3f73b7f4600f.diff

[clang] a7d0177 - [OpenCL] Add cl_khr_subgroup_clustered_reduce to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-10T09:44:52Z New Revision: a7d01772ac370bfc5ef1838c8d18b7be070edfbe URL: https://github.com/llvm/llvm-project/commit/a7d01772ac370bfc5ef1838c8d18b7be070edfbe DIFF: https://github.com/llvm/llvm-project/commit/a7d01772ac370bfc5ef1838c8d18b7be070edfbe.diff

[PATCH] D95951: [OpenCL] Add cl_khr_subgroup_non_uniform_arithmetic to TableGen BIFs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae99a0de8c7: [OpenCL] Add cl_khr_subgroup_non_uniform_arithmetic to TableGen BIFs (authored by svenvh). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D96402: [Driver] Recognize arm-none-linux-gnueabihf as valid ARMHF triple

dmantipov created this revision. dmantipov added a reviewer: clang. Herald added subscribers: pengfei, kristof.beyls. dmantipov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After installing official 10.2-2020.11 AARCH64 / ARM toolchains

[clang] 6d48a1a - [flang][driver] Add support for -fopenmp and -fopenacc

Author: Faris Rehman Date: 2021-02-10T09:59:35Z New Revision: 6d48a1a53fabae8715091a9aca128cc4a5d9b0a6 URL: https://github.com/llvm/llvm-project/commit/6d48a1a53fabae8715091a9aca128cc4a5d9b0a6 DIFF: https://github.com/llvm/llvm-project/commit/6d48a1a53fabae8715091a9aca128cc4a5d9b0a6.diff LOG:

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d48a1a53fab: [flang][driver] Add support for -fopenmp and -fopenacc (authored by FarisRehman). Changed prior to commit: https://reviews.llvm.org/

[clang] cb93363 - [clang][cli] Generate and round-trip PreprocessorOutput options

Author: Jan Svoboda Date: 2021-02-10T11:27:55+01:00 New Revision: cb933632bc5fb40387cf9bc69cadc26b743e0f4a URL: https://github.com/llvm/llvm-project/commit/cb933632bc5fb40387cf9bc69cadc26b743e0f4a DIFF: https://github.com/llvm/llvm-project/commit/cb933632bc5fb40387cf9bc69cadc26b743e0f4a.diff L

[PATCH] D96156: [clang][cli] Generate and round-trip PreprocessorOutput options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb933632bc5f: [clang][cli] Generate and round-trip PreprocessorOutput options (authored by jansvoboda11). Changed prior to commit: https://reviews

[clang] b89af18 - [clang][cli] Generate and round-trip Target options

Author: Jan Svoboda Date: 2021-02-10T11:45:32+01:00 New Revision: b89af18d9e20a6c51bc2efa7d92030e428b39a3f URL: https://github.com/llvm/llvm-project/commit/b89af18d9e20a6c51bc2efa7d92030e428b39a3f DIFF: https://github.com/llvm/llvm-project/commit/b89af18d9e20a6c51bc2efa7d92030e428b39a3f.diff L

[PATCH] D96158: [clang][cli] Generate and round-trip Target options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb89af18d9e20: [clang][cli] Generate and round-trip Target options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

steakhal marked 4 inline comments as done. steakhal added a comment. Thank you @Szelethus for taking the time to review this. This time I marked the inline comments done where it was applicable :) I'm gonna investigate some of your comments and if everything goes well I'm planning to commit this

[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

steakhal added a comment. In D93223#2553053 , @Szelethus wrote: > My no1. thought is that I wish the new functionality you're implementing was > in the interface of the `Preprocessor`. I found, and still find it so hard to > believe that you couldn't jus

[PATCH] D93224: [analyzer] Use the MacroExpansionContext for macro expansions in plists

steakhal marked an inline comment as done. steakhal added a comment. Yey, thanks @Szelethus. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93224/new/ https://reviews.llvm.org/D93224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

DavidSpickett added inline comments. Comment at: clang/test/Driver/arm-target-as-mimplicit-it.s:26 +/// assembler flag appearing last (latter wins). +// RUN: %clang -target arm-linux-gnueabi -### -mimplicit-it=never -Wa,-mimplicit-it=always %S/Inputs/wildcard1.c 2>&1 | FileCheck

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

rprichard created this revision. Herald added a subscriber: dberris. rprichard requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. On Android, the unwinder isn't part of the C++ STL and isn't (in older versions) exported from libc.so. I

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

rprichard created this revision. Herald added a subscriber: dberris. rprichard requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By default, the driver uses the compiler-rt builtins and links with -l:libunwind.a. Restore the previous behavio

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

rprichard added reviewers: danalbert, srhines, pcc. rprichard added subscribers: thakis, glandium. rprichard added a comment. Adding glandium and thakis for Firefox and Chrome. e.g. I suspect this change would cause the same sort of breakage seen in D95166 . Re

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 17e5c99 - [clang][cli] Generate and round-trip DependencyOutput options

Author: Jan Svoboda Date: 2021-02-10T12:20:51+01:00 New Revision: 17e5c99d5128f33158103c260714b6e02dbe35d5 URL: https://github.com/llvm/llvm-project/commit/17e5c99d5128f33158103c260714b6e02dbe35d5 DIFF: https://github.com/llvm/llvm-project/commit/17e5c99d5128f33158103c260714b6e02dbe35d5.diff L

[PATCH] D96273: [clang][cli] Generate and round-trip DependencyOutput options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17e5c99d5128: [clang][cli] Generate and round-trip DependencyOutput options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

pdhaliwal updated this revision to Diff 322638. pdhaliwal marked an inline comment as done. pdhaliwal added a comment. I haave removed libomptarget-device-bc-path and have added amdgcn one. For diagnostic, instead of having one per architecture, I have used the same and added second parameter to

[clang] eb581fc - [clang][cli] Generate and round-trip Diagnostic options

Author: Jan Svoboda Date: 2021-02-10T12:44:49+01:00 New Revision: eb581fc324688ee814170c92fb49c0c4cf61 URL: https://github.com/llvm/llvm-project/commit/eb581fc324688ee814170c92fb49c0c4cf61 DIFF: https://github.com/llvm/llvm-project/commit/eb581fc324688ee814170c92fb49c0c4cf61.diff L

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb581fc32411: [clang][cli] Generate and round-trip Diagnostic options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.or

[PATCH] D96328: [Clang, NewPM] Add KMSan support

vitalybuka updated this revision to Diff 322643. vitalybuka added a comment. simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96328/new/ https://reviews.llvm.org/D96328 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Driver/msan

[PATCH] D96406: [Msan, NewPM] Reduce size of msan binaries

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. EarlyCSEPass called after msan redices code size by about 10%. Similar optimization exists for legacy pass ma

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 322645. Budovi added a comment. Changes: - Fixed comments Thanks @curdeius for pointing out the issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94661/new/ https://reviews.llvm.org/D94661 Files: clang/docs/ClangFormatStyleOptions.rst clan

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commit

[clang] fa11496 - [clang][cli] Extract FileSystem and Migrator options parsing/generation

Author: Jan Svoboda Date: 2021-02-10T13:36:00+01:00 New Revision: fa11496b618e84ce1daa53108ef87c25efaf3813 URL: https://github.com/llvm/llvm-project/commit/fa11496b618e84ce1daa53108ef87c25efaf3813 DIFF: https://github.com/llvm/llvm-project/commit/fa11496b618e84ce1daa53108ef87c25efaf3813.diff L

[PATCH] D96278: [clang][cli] Extract FileSystem and Migrator options parsing/generation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa11496b618e: [clang][cli] Extract FileSystem and Migrator options parsing/generation (authored by jansvoboda11). Repository: rG LLVM Github Monor

[PATCH] D96278: [clang][cli] Extract FileSystem and Migrator options parsing/generation

dmajor added a comment. This broke the windows bot: http://lab.llvm.org:8011/#/builders/86/builds/7540/steps/6/logs/stdio FAILED: tools/clang/lib/Frontend/CMakeFiles/obj.clangFrontend.dir/CompilerInvocation.cpp.obj C:\PROGRA~2\MICROS~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x

[clang] a715041 - [clang][cli] Declare local variable for marshalling macros

Author: Jan Svoboda Date: 2021-02-10T13:54:08+01:00 New Revision: a7150415ddd8e520a4fa024f07575527d445a689 URL: https://github.com/llvm/llvm-project/commit/a7150415ddd8e520a4fa024f07575527d445a689 DIFF: https://github.com/llvm/llvm-project/commit/a7150415ddd8e520a4fa024f07575527d445a689.diff L

[PATCH] D96278: [clang][cli] Extract FileSystem and Migrator options parsing/generation

jansvoboda11 added a comment. In D96278#2553807 , @dmajor wrote: > This broke the windows bot: > http://lab.llvm.org:8011/#/builders/86/builds/7540/steps/6/logs/stdio Thanks, I'm pushing a fix. If it doesn't fix the build, I'll revert. Repository: rG

[PATCH] D96278: [clang][cli] Extract FileSystem and Migrator options parsing/generation

jansvoboda11 added a comment. @dmajor a7150415 turned the build green: http://lab.llvm.org:8011/#/builders/86/builds/7541 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96278/new

[PATCH] D96363: Mark output as text if it is really text

abhina.sreeskantharajan updated this revision to Diff 322658. abhina.sreeskantharajan added a comment. Rerun CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96363/new/ https://reviews.llvm.org/D96363 Files: clang/lib/Driver/Driver.cpp clang/l

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. But let other folks a few days to chime in. Especially @mydeveloperday's input would be valuable here as he already attempted to implement this. Do you have have commit rights or you

[PATCH] D96412: [ThinLTO, NewPM] Call OptimizerLastEPCallbacks after Prelink

vitalybuka created this revision. vitalybuka added reviewers: aeubanks, tejohnson, eugenis. Herald added subscribers: steven_wu, hiraditya, inglorion. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. -O0 ThinLTO

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added a comment. In D94661#2553843 , @curdeius wrote: > LGTM. But let other folks a few days to chime in. Especially > @mydeveloperday's input would be valuable here as he already attempted to > implement this. Sure, no problem. Thanks for your i

[PATCH] D96278: [clang][cli] Extract FileSystem and Migrator options parsing/generation

dmajor added a comment. Thank you for the quick followup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96278/new/ https://reviews.llvm.org/D96278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 6f9db45 - [clang][NFC] Fix undefined-libs tests

Author: Timm Bäder Date: 2021-02-10T15:01:09+01:00 New Revision: 6f9db455a50489d05e4aff761ee070dc90a1ece6 URL: https://github.com/llvm/llvm-project/commit/6f9db455a50489d05e4aff761ee070dc90a1ece6 DIFF: https://github.com/llvm/llvm-project/commit/6f9db455a50489d05e4aff761ee070dc90a1ece6.diff LO

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev added a comment. @sammccall this is the argument renaming diff I was talking about during the standup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96324/new/ https://reviews.llvm.org/D96324 _

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski added a comment. Hi @arnamoy10, thank you for working on this! Overall this looks good to me, but I'm wondering whether we could simplify it a bit? More comments inline. Comment at: clang/include/clang/Driver/Options.td:4163 defm d_lines_as_comments : BooleanFFlag<

[clang] c6a1b16 - clang: try to fix Driver/undefined-libs.cpp on non-linux

Author: Nico Weber Date: 2021-02-10T09:45:04-05:00 New Revision: c6a1b16db7dc7a0af8951b39f29ddbe639a98a3b URL: https://github.com/llvm/llvm-project/commit/c6a1b16db7dc7a0af8951b39f29ddbe639a98a3b DIFF: https://github.com/llvm/llvm-project/commit/c6a1b16db7dc7a0af8951b39f29ddbe639a98a3b.diff LO

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

JackKemp99 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1908 +uint64_t Offset = Stream.GetCurrentBitNo() - SLocEntryOffsetsBase; +assert((Offset >> 32) == 0 && "SLocEntry offset too large"); +SLocEntryOffsets.push_back(Offset);

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn created this revision. fhahn added reviewers: jdoerfert, rjmccall, xbolva00, atmnpatel, aaron.ballman, rsmith. fhahn requested review of this revision. Herald added a project: clang. Currently Clang does not add mustprogress to inifinite loops with a known constant condition, matching C11 b

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn created this revision. fhahn added reviewers: jdoerfert, rjmccall, xbolva00, atmnpatel, aaron.ballman, rsmith. Herald added subscribers: dexonsmith, dang. Herald added a reviewer: jansvoboda11. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322679. fhahn added a comment. Add description for options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 Files: clang/include/clang/Basic/CodeGenOptions.def clang/

[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs

sammccall updated this revision to Diff 322681. sammccall added a comment. Also handle parens and unresolved calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96376/new/ https://reviews.llvm.org/D96376 Files: clang-tools-extra/clangd/unittests

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

xbolva00 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1923 + if (Arg *A = Args.getLastArg(OPT_save_temps_EQ)) +Opts.SaveTempsFilePrefix = Not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322683. fhahn added a comment. Remove accidentally copied code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 Files: clang/include/clang/Basic/CodeGenOptions.def cl

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1923 + if (Arg *A = Args.getLastArg(OPT_save_temps_EQ)) +Opts.SaveTempsFilePrefix = xbolva00 wrote: > Not needed Removed, thanks! Repository: rG LLVM Github Monorepo CH

[clang] 5ea2d4f - Avoid conflicts between debug-info and pseudo-probe profiling

Author: Paul Robinson Date: 2021-02-10T07:09:18-08:00 New Revision: 5ea2d4fa481160c9843b8651df265ce1fbfd9316 URL: https://github.com/llvm/llvm-project/commit/5ea2d4fa481160c9843b8651df265ce1fbfd9316 DIFF: https://github.com/llvm/llvm-project/commit/5ea2d4fa481160c9843b8651df265ce1fbfd9316.diff

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea2d4fa4811: Avoid conflicts between debug-info and pseudo-probe profiling (authored by probinson). Changed prior to commit: https://reviews.llvm

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon updated this revision to Diff 322685. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 Files: clan

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230 + explicit FunctionASTVisitor(const bool IgnoreMacros) + : RecursiveASTVisitor(), IgnoreMacros(IgnoreMacros){}; + Is a default base

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string.h:12 -void abort(void); -void _Exit(int); -void quick_exit(int); +typedef int size_t; I think this is causing some test failures: https://revie

[PATCH] D96354: Avoid conflicts between debug-info and pseudo-probe profiling

probinson added a comment. > the driver had a redundant pass-through of the option I could've sworn it worked to remove that, but it didn't when I rebased, so that's gone from the final patch (i.e, the explicit pass-through in the driver is still there). It's a functionally separate topic anyw

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 322689. timwoj added a comment. Rebased on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/UnwrappedLineForm

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia added a comment. The change looks good, could we test the diagnostic that is added? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D96279: [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96279/new/ https://reviews.llvm.org/D96279 ___

[PATCH] D96215: [clang-tidy] Recognize captures as a form of aliasing.

aaron.ballman added a comment. In D96215#2550227 , @NoQ wrote: > In D96215#2548492 , @aaron.ballman > wrote: > >> Should structured bindings be treated similarly as well (not necessarily as >> part of this patch)?

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D93630#2506604 , @aaron.ballman wrote: > In D93630#2504758 , @vsavchenko > wrote: > >> I'll

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 322695. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 Files: clan

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2554186 , @aaron.ballman wrote: > In D93630#2506604 , @aaron.ballman > wrote: > >> In D93630#2504758 , @vsavchenko >> wrote: >> >>> I

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 322696. segoon added a comment. Herald added a subscriber: nullptr.cpp. - explicitly state in docs that the check must be used only for async code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files: clan

[PATCH] D96150: [OpenCL][Docs] Describe internals of TableGen BIFs

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Ok, this looks like a good start. Later we can add a bit more information/guidance on how to add new function specifically how to specify parameter or return types, overloads, and attri

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov added a comment. Thanks for review. Just to be clear: can I proceed with this? Or we should discuss it first? As I see possible this change can be abandoned after discussion. Moreover,  I see nothing about address space of void pointer in OpenCL C spec. For example (OpenCL C 2.2, Cla

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } Can you modify the documentation to talk about what loops must make progress, this is the code be

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a reviewer: alexfh_. segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 ___ cfe-commits mailing list cfe-commits@

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. alexfh, aaron.ballman, hi! Any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:147 +No = 2, // No loop is assumed to be finite. + }; + Can we have different names? `FiniteLoopsKind::None` sounds more like what ``FiniteLoopsKind::No` implies. May

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. Friendly ping, I think this is still worth merging in even without the QName changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 __

[clang] a743702 - Revert "[clang][driver] Only warn once about invalid library values"

Author: Tom Weaver Date: 2021-02-10T16:37:34Z New Revision: a743702a1f4880e4492196b1ce9a9a63e0b4c075 URL: https://github.com/llvm/llvm-project/commit/a743702a1f4880e4492196b1ce9a9a63e0b4c075 DIFF: https://github.com/llvm/llvm-project/commit/a743702a1f4880e4492196b1ce9a9a63e0b4c075.diff LOG: Re

[clang] b86a763 - Revert "Revert "[clang][driver] Only warn once about invalid library values""

Author: Tom Weaver Date: 2021-02-10T16:40:07Z New Revision: b86a763afb9a1f55f4b234ce97320917ead6ac7f URL: https://github.com/llvm/llvm-project/commit/b86a763afb9a1f55f4b234ce97320917ead6ac7f DIFF: https://github.com/llvm/llvm-project/commit/b86a763afb9a1f55f4b234ce97320917ead6ac7f.diff LOG: Re

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10314 + switch (kind) { + case clang::CK_IntegralToPointer: // [[fallthrough]]; + case clang::CK_FunctionToPointerDecay: { cjdb wrote: > aaron.ballman wrote: > > > Done, but why?

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

apazos added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:2118 Record *R = Def->getRecord(); -if (R->getValueAsBit("isVCVT_N")) { +if (R->getValueAsBit("isVXAR")) { + //VXAR takes an immediate in the range [0, 63] Consider a

[PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. Herald added a reviewer: JDevlieghere. Heral

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk added a comment. This looks great, that turned out to be a lot cleaner than I expected. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1717 + FilenameStrs[0] = getCurrentDirname(); + FilenameRefs[0] = FilenameStrs[0]; for (const auto &Entry : FileEntries) { -

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for losing this. > LMK if you think it makes sense to move some of this logic in AST.cpp > (clangd). objcContainerLocalScope seems like it would be useful to generalize > support

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic added a comment. @labrinea could you commit this when you have some time please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1908 +uint64_t Offset = Stream.GetCurrentBitNo() - SLocEntryOffsetsBase; +assert((Offset >> 32) == 0 && "SLocEntry offset too large"); +SLocEntryOffsets.push_back(Offset);

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic updated this revision to Diff 322713. rsanthir.quic added a comment. alphabetized check in NeonEmitter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96381 Files: clang/include/clang/Basic/arm_neon.td clang/include/clang/Basic/arm_n

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

svenvh added a comment. In D96178#2551449 , @Anastasia wrote: > @svenvh We haven't looked into address spaces in details when adding this. I > wonder what behavior would make sense for new/delete? Do we plan to allow > new/delete in named address spaces

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 322724. saiislam added a comment. Added support for optional TargetID during unbundling of archives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 Files: clang/doc

[PATCH] D96320: [ThinLTO, Sanitizers] Skip instrumentation by testing backend

aeubanks added a comment. This seems like the wrong fix to me. ThinLTO only runs the simplification pipeline pre-link, then runs it again plus the optimization pipeline. The optimization pipeline is the only place that OptimizerLastEPCallback should run (aside from the -O0 pipeline). Basically,

[clang] 1e8afba - [clang] Add support for attribute 'swift_async_error'

Author: Erik Pilkington Date: 2021-02-10T13:18:13-05:00 New Revision: 1e8afba6f176653abcbda4f0485d9419c8407afb URL: https://github.com/llvm/llvm-project/commit/1e8afba6f176653abcbda4f0485d9419c8407afb DIFF: https://github.com/llvm/llvm-project/commit/1e8afba6f176653abcbda4f0485d9419c8407afb.dif

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e8afba6f176: [clang] Add support for attribute 'swift_async_error' (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D96175?vs=322152&id=32

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sunfish added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89274/new/ https://reviews.llvm.org/D89274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

kadircet updated this revision to Diff 322743. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96245/new/ https://reviews.llvm.org/D96245 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

spatel added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9305 + * 1. The elements are reassociable when using fadd/fmul intrinsics; + * 2. There's no nan and signed zero in the elements when using fmin/max + intrinsics; If I understand correctl

[PATCH] D96244: [clangd][RFC] Introudce Plugins

kadircet updated this revision to Diff 322744. kadircet added a comment. - Rename Plugin to Module - Have a ModuleSet that enables type-safe traversal of existing modules (with questions about implementation options) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 322746. ldionne retitled this revision from "[libc++] Fix tuple assignment from type derived from a tuple-like" to "[libc++] Fix tuple assignment from types derived from a tuple-like". ldionne edited the summary of this revision. ldionne added a comment. Hera

[PATCH] D96439: [clangd] Introduce DiagnosticAugmentationModule

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. A module interface to enable custom contrib

  1   2   >