[PATCH] D95702: [AIX] Improve option processing for mabi=vec-extabi and mabi=vec=defaul

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3426a528d5: [AIX] Improve option processing for mabi=vec-extabi and mabi=vec=defaul (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-len2.cpp:10 + +void declaration(int Param, int Other); // NO-WARN: No chance to change this function. + aaron.ballman wrote: > whisperi

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

svenvh added a comment. In D95778#2536266 , @Anastasia wrote: >> LGTM, but perhaps you can add a test that has each keyword disabled? > > FYI we currently already test that `pipe` and `generic` are valid for OpenCL > 2.0 and invalid for OpenCL < 2.0. Or d

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-len2.cpp:10 + +void declaration(int Param, int Other); // NO-WARN: No chance to change this function. + whisperity wrote: > aaron.ba

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske added a comment. In D95860#2536609 , @steakhal wrote: > Please, also add a regression test for Haoxin Tu's reproducer. > > // RUN: %clang %s > > // expected warning > volatile long a ( a .~b What about already the added test? Repos

[clang] 844f01f - Fixed failing OpenCL test

Author: Anastasia Stulova Date: 2021-02-02T16:19:28Z New Revision: 844f01fc9589b25a3427a6cf4ca406e6787ae171 URL: https://github.com/llvm/llvm-project/commit/844f01fc9589b25a3427a6cf4ca406e6787ae171 DIFF: https://github.com/llvm/llvm-project/commit/844f01fc9589b25a3427a6cf4ca406e6787ae171.diff

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

MyDeveloperDay added a comment. I guess I'm not making myself clear, I was just hoping you could be super explicit about what you are changing so anyone coming into this review would understand why the behaviour had changed (this is just pseudo code it may not be correct for all cases, but you

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17904 +" call_function(arg, arg);"; + EXPECT_EQ(IfSourceShort, format(IfSourceShort, Style)); + can these all be verifyFormats

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17996 +format(ForSourceLong, Style)); +} + MyDeveloperDay wrote: > MyDeveloperDay wrote: > > are you testing do/while? > whilst people discuss the ethics of modif

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:135 void sanitize() { -assert(Flags != MIX_Invalid && "sanitize() called on invalid bitvec"); -// TODO: There will be statements here in further e

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. I'm just going to say this here, but LLVM doesn't like the use of braces on single lines (I don't actually like that myself, but I go with the convention when I remember), but this is followed only if the reviewer catches it, but by and large its super easy for

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity added a comment. (Typing this in here so it is not forgotten.) @aaron.ballman suggested in http://reviews.llvm.org/D69560#inline-893813 that a case of argument and parameter swaps could be discovered between forward declarations and the definitions, i.e. void fn(int x, int y);

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:141 +kernel void extended_subgroup(global uint4 *out) { + out[0] = get_sub_group_eq_mask(); +#if __OPENCL_C_VERSION__ < CL_VERSION_2_0 && !defined(__OPENCL_CPP_VERSION__)

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

thakis added a comment. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95739/new/ https://reviews.llvm.org/D95739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D95876: [clang-cl] Remove the /fallback option

hans created this revision. hans added reviewers: rnk, thakis. Herald added a subscriber: dang. Herald added a reviewer: jansvoboda11. hans requested review of this revision. Herald added a project: clang. As discussed in https://lists.llvm.org/pipermail/cfe-dev/2021-January/067524.html It doesn

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:135 void sanitize() { -assert(Flags != MIX_Invalid && "sanitize() called on invalid bitvec"); -// TODO: There will be statements here in further exte

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

arphaman added inline comments. Comment at: clang/include/clang/Driver/Options.td:2141 + Group, Flags<[CC1Option]>, + HelpText<"Ignore attribute objc_direct so that direct methods can be tested">; + Do you need to use the new options marshaling infrastructure?

[PATCH] D95877: [analyer] Fix static_cast on pointer-to-member handling

RedDocMD created this revision. RedDocMD added reviewers: vsavchenko, NoQ, xazax.hun, dcoughlin. Herald added subscribers: martong, Charusso, rnkovacs. RedDocMD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit fixes bug #48739. T

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. This patch focuses on clang work for enabling fp atomics. There is a middle end pass for lowering fp atomics to cmpxchg, however not all targets enable it or enable it properly. From clang point of view, those targets are not ready to say they support fp atomics, therefo

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

FarisRehman updated this revision to Diff 320811. FarisRehman marked an inline comment as done. FarisRehman added a comment. Address review comment This revision addresses a review comment by @tskeith Summary of changes: - Add a new option, ffixed_line_length_EQ, that defines `-ffixed-line-leng

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:141 +kernel void extended_subgroup(global uint4 *out) { + out[0] = get_sub_group_eq_mask(); +#if __OPENCL_C_VERSION__ < CL_VERSION_2_0 && !defined(__OPENCL_CPP_VERSION__) -

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets.cpp:743 + // Assume compiling for FULL profile + Builder.defineMacro("__opencl_c_int64"); } azabaznov wrote: > Anastasia wrote: > > Btw we could add the other feature macros for earlier versi

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi planned changes to this revision. Budovi added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17868 + FormatStyle Style = getLLVMStyle(); + Style.AccessModifierOffset = 4; + Style.AllowShortEnumsOnASingleLine = false; Budovi wrote: >

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

Anastasia added a comment. In D95778#2536598 , @azabaznov wrote: > In D95778#2536266 , @Anastasia wrote: > >>> LGTM, but perhaps you can add a test that has each keyword disabled? >> >> FYI we currently already test

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

wmi accepted this revision. wmi added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95271/new/ https://reviews.llvm.org/D95271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. If the concern is that diagnose fp atomics as unsupported hinders middle end and backend work for fixing fp atomic issues, how about adding a -fenable-fp-atomics to clang which can override target info about fp atomics support. CHANGES SINCE LAST ACTION https://revie

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 320818. Budovi added a comment. Updated the tests after checking the issues were not caused by the patch and they are reported / fixed. Rebased the changes to the newest version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94661/new/ https://revi

[PATCH] D95879: [clang][index] Mark file as C++ in parse-all-comments test

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `CompilerInvocation::CreateFromArgs` doesn't always r

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy updated this revision to Diff 320822. hoy added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93264/new/ https://reviews.llvm.org/D93264 Files: clang/test/CodeGen/pseudo-probe-emit.c llvm/include/llvm/IR/IntrinsicInst.

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

nickdesaulniers added a comment. Wow, thank you so much for the work that went into this patch! Very thorough tests. Just minor questions about yet more test cases. Patch LGTM. Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42 +/// We use the target CPU for both. +

[PATCH] D95793: [clang][cli] Generate and round-trip language options

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1196 const std::vector &Sanitizers, DiagnosticsEngine &Diags, SanitizerSet &S) { + bool Success = true; de

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. My concern is that this is treating a backend _bug_ as if it were just an optional feature. But it's not the case that it might be reasonable to either implement or not implement this in a backend -- it should be implemented, and those that don't are buggy. I'd be hap

[clang] d3e2e37 - [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

Author: Hongtao Yu Date: 2021-02-02T09:43:57-08:00 New Revision: d3e2e3740d0730cb6788c771bb01a8f3e935bf2e URL: https://github.com/llvm/llvm-project/commit/d3e2e3740d0730cb6788c771bb01a8f3e935bf2e DIFF: https://github.com/llvm/llvm-project/commit/d3e2e3740d0730cb6788c771bb01a8f3e935bf2e.diff LO

[PATCH] D95271: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the linker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hoy marked an inline comment as done. Closed by commit rGd3e2e3740d07: [CSSPGO] Passing the clang driver switch -fpseudo-probe-for-profiling to the… (authored by hoy).

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

MaskRay added a comment. In D95849#2536559 , @nikic wrote: > Just to be clear here: Only the small handful where a spelling mistake was > fixed were actually bugs. All other unused check prefixes were there for > convenience, and are now casualties of th

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop updated this revision to Diff 320806. russell.gallop added a comment. Remove -fsanitize=scudo support for Windows in LLVM cmake, using LLVM_INTEGRATED_CRT_ALLOC instead. Remove scudo_cxx from LLVM_INTEGRATED_CRT_ALLOC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86694/n

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. I managed to get this to fail in the debugger (for the cross-module-sm-pic-a.ll test): 01655e9d001e() Unknown 01655e9d0019() Unknown 017e5eb6b410() Unknown 017c5eb63810() Unknown 017e5

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

tra added a comment. In D71726#2536966 , @jyknight wrote: > My concern is that this is treating a backend _bug_ as if it were just an > optional feature. But it's not the case that it might be reasonable to either > implement or not implement this in a b

[clang] ca98c15 - [OpenMP] Fix iterations calculation for dependent counters.

Author: Mike Rice Date: 2021-02-02T10:09:37-08:00 New Revision: ca98c15f23354520bf689bd5feb333a716159d2c URL: https://github.com/llvm/llvm-project/commit/ca98c15f23354520bf689bd5feb333a716159d2c DIFF: https://github.com/llvm/llvm-project/commit/ca98c15f23354520bf689bd5feb333a716159d2c.diff LOG

[PATCH] D95834: [OpenMP] Fix iterations calculation for dependent counters

This revision was automatically updated to reflect the committed changes. Closed by commit rGca98c15f2335: [OpenMP] Fix iterations calculation for dependent counters. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. In D71726#2537054 , @tra wrote: > In D71726#2536966 , @jyknight wrote: > >> My concern is that this is treating a backend _bug_ as if it were just an >> optional feature. But it's not the ca

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy updated this revision to Diff 320844. hoy added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93264/new/ https://reviews.llvm.org/D93264 Files: clang/test/CodeGen/pseudo-probe-emit.c llvm/include/llvm/IR/IntrinsicInst.

[PATCH] D94533: [clang] Add AddClang.cmake to the list of the CMake modules that are installed

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. This seems reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94533/new/ https://reviews.llvm.org/D94533

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4270-4271 } else { - // Host-side shadows of external declarations of device-side - // global variables become internal definitions. These have to - // be internal in order to prevent n

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. https://reviews.llvm.org/D95886 Files: clang/docs/UsersManual.rst Index: clang/docs/UsersManual.rst

[PATCH] D95879: [clang][index] Mark file as C++ in parse-all-comments test

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95879/new/ https://reviews.llvm.org/D95879 _

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4270-4271 } else { - // Host-side shadows of external declarations of device-side - // global variables become internal definitions. These have to

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. fine with me, assuming this doesn't disturb anything outside the AMD pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ ht

[PATCH] D95793: [clang][cli] Generate and round-trip language options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, since I don't think the parallel error paths are too bad in this specific patch, but see my longer comment inline. Comment at: clang/lib/Frontend/CompilerInvoc

[PATCH] D95560: [CUDA][HIP] Fix function scope static variable

tra added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:7247-7250 + // CUDA/HIP: Function-scope static variables in device or global functions + // have implicit device or constant attribute. Function-scope static variables + // in host device functions have implic

[clang] 74c94b5 - [test] Default clang/test to FileCheck --allow-unused-prefixes=false

Author: Fangrui Song Date: 2021-02-02T11:22:46-08:00 New Revision: 74c94b5d9c2b19333b43684c9d60decd41543d50 URL: https://github.com/llvm/llvm-project/commit/74c94b5d9c2b19333b43684c9d60decd41543d50 DIFF: https://github.com/llvm/llvm-project/commit/74c94b5d9c2b19333b43684c9d60decd41543d50.diff

[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCUDA.cpp:538 AllowedInit = - ((VD->getType()->isDependentType() || Init->isValueDependent()) && - VD->isConstexpr()) ||

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

tra added a comment. LGTM. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4270-4271 } else { - // Host-side shadows of external declarations of device-side - // global variables become internal definitions. These have to - // be internal in order to prevent

[PATCH] D95822: [FE][AIX] Use i8 as guard variable type in both load and store operation

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGenCXX/aix-static-init-temp-spec-and-inline-var.cpp:193 // CHECK: %1 = call i32 @atexit(void ()* @__dtor__ZN5test12t1IiEE) -// CHECK: store i64 1, i64* @_ZGVN5test12t

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added a comment. In D71726#2537101 , @yaxunl wrote: > In D71726#2537054 , @tra wrote: > >> In D71726#2536966 , @jyknight wrote: >> >>> My concern is that this is tre

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. I think idiomatically we normally just use `(void)` instead of spelling it out with `static_cast`, since there's only one possible meaning for a cast to `void`. I don't car

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap updated this revision to Diff 320865. Conanap marked 10 inline comments as done. Conanap added a comment. Addressed comments, fixed an incorrect encoding. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h lld/EL

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap added a comment. Added a note on one of the functions Comment at: lld/ELF/Driver.cpp:765 +// instructions in stubs. +static bool getP10StubOpt(opt::InputArgList &args) { + For this function here, I realize we can inline all the ifs into a giant return

[PATCH] D95655: [AArch64] Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic added a comment. @t.p.northover Could you take a look before I ask for this to be merged? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

HazardyKnusperkeks added a comment. You need to supply a full diff (with context). Please also add it to the release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94661/new/ https://reviews.llvm.org/D94661 ___ cfe-commits mailing list

[clang] 3d89b3c - [CSSPGO] Introducing distribution factor for pseudo probe.

Author: Hongtao Yu Date: 2021-02-02T11:55:01-08:00 New Revision: 3d89b3cbec230633e8228787819b15116c1a1730 URL: https://github.com/llvm/llvm-project/commit/3d89b3cbec230633e8228787819b15116c1a1730 DIFF: https://github.com/llvm/llvm-project/commit/3d89b3cbec230633e8228787819b15116c1a1730.diff LO

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d89b3cbec23: [CSSPGO] Introducing distribution factor for pseudo probe. (authored by hoy). Changed prior to commit: https://reviews.llvm.org/D932

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. In D71726#2537101 , @yaxunl wrote: > For amdgpu target, we do need diagnose unsupported atomics (not limited to fp > atomics) since we do not support libcall due to ISA level linking not > supported. This is something we cannot

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

abhina.sreeskantharajan added inline comments. Comment at: clang/test/CodeGenCXX/global-init.cpp:84 // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE - // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE + // CHECK-NEXT: store i8 1, i8* bitcast (i64* @_ZGVN5test41xE to i8*)

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

hubert.reinterpretcast added inline comments. Comment at: guard.patch:1 +From 9c7d0afec1e634cdeaf3a2ca4273f5da07f6f946 Mon Sep 17 00:00:00 2001 +From: Xiangling Liao Looks like this file got added by accident. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi planned changes to this revision. Budovi added a comment. In D94661#2537356 , @HazardyKnusperkeks wrote: > You need to supply a full diff (with context). > Please also add it to the release notes. Oh sorry, forgot about the context lines. Will try

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGenCXX/global-init.cpp:84 // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE - // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE + // CHECK-NEXT: store i8 1, i8* bit

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/global-init.cpp:84 // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE - // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE + // CHECK-NEXT: store i8 1, i8* bitcast (i64* @_ZGVN5test41xE to i8*)

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

Xiangling_L updated this revision to Diff 320879. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Remove redundant file; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95822/new/ https://reviews.llvm.org/D95822 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp cl

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added a comment. Broadly LGTM Comment at: clang/include/clang/Basic/AttrDocs.td:4398 + let Content = [{ +TODO + }]; varungandhi-apple wrote: > I have left this as a TODO for now, so that it can be filled in later when > the exact details of the

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8106-8115 + case ParsedAttr::AT_SwiftAsyncCall: case ParsedAttr::AT_VectorCall: case ParsedAttr::AT_MSABI: case ParsedAttr::AT_SysVABI: case ParsedAttr::AT_Pcs: case ParsedAttr::A

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2711 + Out << 'T'; + break; case CC_PreserveMost: Out << 'U'; break; rjmccall wrote: > Please use consistent formatting with the other cases, here and elsewhere.

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

Xiangling_L updated this revision to Diff 320881. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Addressed the comments related to test formatting; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95822/new/ https://reviews.llvm.org/D95822 Files: clang/lib/Co

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

Xiangling_L added inline comments. Comment at: clang/test/CodeGenCXX/global-init.cpp:84 // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE - // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE + // CHECK-NEXT: store i8 1, i8* bitcast (i64* @_ZGVN5test41xE to i8*) __attrib

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. In D93844#2536354 , @njames93 wrote: > As a follow up it may be wise to pass a diag handler to parseConfiguration as > when we parse it a second time, we probably wan

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 320886. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Silence unused variable warnings in release and using `llvm::reverse` with range based for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95822/new/ https://reviews.llvm.org/D95822 _

[PATCH] D95876: [clang-cl] Remove the /fallback option

thakis added a comment. Probably get a short release notes entry too. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:669 const InputInfoList &Inputs, const ArgList &Args, const char *LinkingOutput) const { ArgStringList CmdArgs; Doesn't this whol

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8106-8115 + case ParsedAttr::AT_SwiftAsyncCall: case ParsedAttr::AT_VectorCall: case ParsedAttr::AT_MSABI: case ParsedAttr::AT_SysVABI: case ParsedAttr::AT_Pcs: case ParsedAttr::AT_IntelOc

[PATCH] D95733: [AMDGPU] Set s-memtime-inst feature from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e661d3d9c52: [AMDGPU] Set s-memtime-inst feature from clang (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:448 + /// Number of collapsed loops as specified by 'collapse' clause. + unsigned CollapsedNum = 0; + ABataev wrote: > Meinersbur wrote: > > Inaccurate for the tile directive. >

[PATCH] D95746: clang: Exclude efi_main from -Wmissing-prototypes

DaanDeMeyer updated this revision to Diff 320899. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95746/new/ https://reviews.llvm.org/D95746 Files: clang/lib/Sema/SemaDecl.cpp Index: clang/lib/Sema/SemaDecl.cpp

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM. I think there would be more concern if the load/store actions were previously symmetric, but this patch is actually needed for the symmetry. Nevertheless, please wait a bit before committing this (since

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added a comment. Thanks for taking your time and getting to the root cause of it! Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:209 +// thing about Clang AST. +std::list BaseList; +for (const auto &I : PathList) `std::li

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

fcloutier updated this revision to Diff 320904. fcloutier added a comment. Address Aaron's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95695/new/ https://reviews.llvm.org/D95695 Files: clang/test/AST/ast-print-attr.c clang/utils/Tab

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

fcloutier added inline comments. Comment at: clang/test/AST/ast-print-attr.c:31 +// CHECK: int fun_annotate() __attribute__((annotate("annotation"))) +int fun_annotate() __attribute__((annotate("annotation"))); aaron.ballman wrote: > Can you add a second test tha

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

nickdesaulniers added inline comments. Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42 +/// We use the target CPU for both. +// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8 -Wa,-march=armv8a %s 2>&1 | \ +// RUN: FileCheck -check-prefix=TRIPLE-ARMV8 -

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. For -fgpu-rdc, shadow variables should not be internalized, otherwise they cannot be accessed by other TUs. This is necessary because the shadow variable of external device variables are always em

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, grokos, ABataev, Fznamznon. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

int3 updated this revision to Diff 320940. int3 retitled this revision from "[lld-macho] switch default to new Darwin port" to "[lld-macho] Switch default to new Darwin port". int3 edited the summary of this revision. int3 edited reviewers, added: thakis; removed: gkm. int3 added a comment. updat

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

jdoerfert updated this revision to Diff 320944. jdoerfert added a comment. Add more examples and TODOs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95903/new/ https://reviews.llvm.org/D95903 Files: clang/test/OpenMP/nvptx_unsupported_type_messa

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

jdoerfert updated this revision to Diff 320945. jdoerfert added a comment. More TODOs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95903/new/ https://reviews.llvm.org/D95903 Files: clang/test/OpenMP/nvptx_unsupported_type_messages.cpp Index:

[PATCH] D95910: Fix the guaranteed alignment of memory returned by malloc/new on Darwin

ahatanak created this revision. ahatanak added reviewers: rjmccall, arphaman, ab. ahatanak added a project: clang. Herald added subscribers: ributzka, jkorous. ahatanak requested review of this revision. The guaranteed alignment is 16-bytes on 64-bit Darwin. rdar://73431623 Repository: rG LLV

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 320956. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files: clang/li

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, grokos, ABataev, Fznamznon. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Type

[PATCH] D95911: [Docs] Add some documentation for constructor homing, a debug info optimization (-fuse-ctor-homing)

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding this, since there's currently no documentation about this. Repository: rG LLVM Github Monorepo https:

[clang] ad50c86 - [clang-format] Fix MSVC "unsafe use of type 'bool' in operation" warning (NFC)

Author: Yang Fan Date: 2021-02-03T10:50:59+08:00 New Revision: ad50c8633321a2a76b6e49daf57c7eaea4494536 URL: https://github.com/llvm/llvm-project/commit/ad50c8633321a2a76b6e49daf57c7eaea4494536 DIFF: https://github.com/llvm/llvm-project/commit/ad50c8633321a2a76b6e49daf57c7eaea4494536.diff LOG:

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:223 + auto DelIt = find_first(BaseList.begin(), BaseList.end(), PathBase); + assert(DelIt != BaseList.end() && "PTM has insufficient base specifiers"); + BaseList.erase

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder created this revision. tbaeder added reviewers: Hahnfeld, phosek, yaxunl, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since ToolChain::GetCXXStdlibType() is a simple getter that might emit the "invalid library n

<    1   2   3   >