RedDocMD added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:223 + auto DelIt = find_first(BaseList.begin(), BaseList.end(), PathBase); + assert(DelIt != BaseList.end() && "PTM has insufficient base specifiers"); + BaseList.erase(DelIt); ---------------- vsavchenko wrote: > It's better to be more verbose in the assertions. > Additionally, I'm not sure that it is clear what it is all about because > pointer-to-members do not have base specifiers. Well, the `PointerToMember` contains a `PointerToMemberData`, which has a list of `CXXBaseSpecifier`. Should I put something like: "PointerToMemberData has insufficient number of base specifiers"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
