[PATCH] D95852: [clangd] Report xref for base methods.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. See: https://github.com/clangd/clangd/issues/668 struct A { virtual void foo(

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

jhenderson added a comment. I think you need to add the new values to the list of recognised substitutions in the documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95808/new/ https://reviews.llvm.org/D95808

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc updated this revision to Diff 320704. poelmanc marked an inline comment as done. poelmanc added a comment. Fix formatting, add suggested test case (which works.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95771/new/ https://reviews.llvm.org/D95771 Files: clang-tools-extra

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

nridge added a comment. In D77811#2533815 , @sammccall wrote: > Introducing nonstandard kinds is **backwards-incompatible**. If the client > doesn't understand primitiveType, then the token kind is now completely > unknown. This could be a regression fro

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. I assume this now runs cleanly. If so, LGTM. Probably worth mentioning on the mailing list thread too, so wrap up that conversation. By the way, did we ever figure out how many of the

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 320708. azabaznov added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Basic/T

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov updated this revision to Diff 320709. azabaznov added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 Files: clang/include/clang/Basic/LangOptions.def clang/lib/Frontend/Com

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 320710. azabaznov added a comment. Rebased one more time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clang/include/clang/Basic/OpenCLExtensions.def cla

[PATCH] D95852: [clangd] Report xref for base methods.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1902 +void test(BaseBase* BB, Base* B, Derived* D) { + BB->func(); // refs to base's base method are not reported. + B->[[func]](); // References to the base me

[clang] 0479c53 - [dllimport] Honor always_inline when deciding whether a dllimport function should be available for inlining (PR48925)

Author: Hans Wennborg Date: 2021-02-02T10:28:32+01:00 New Revision: 0479c53b6c5224c16bdc78cb014e76c0b0dbc6f9 URL: https://github.com/llvm/llvm-project/commit/0479c53b6c5224c16bdc78cb014e76c0b0dbc6f9 DIFF: https://github.com/llvm/llvm-project/commit/0479c53b6c5224c16bdc78cb014e76c0b0dbc6f9.diff

[PATCH] D95673: [dllimport] Honor always_inline when deciding whether a dllimport function should be available for inlining (PR48925)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0479c53b6c52: [dllimport] Honor always_inline when deciding whether a dllimport function… (authored by hans). Repository: rG LLVM Github Monorepo

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

svenvh added a comment. LGTM, but perhaps you can add a test that has each keyword disabled? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 ___ cfe-commits maili

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 320722. pdhaliwal added a comment. Addressed review comments. - Combined the toolchain creation logic for nvptx and amdgcn - Replaced -Xopenmp-target with -emit-llvm-bc inside AMDGPUOpenMP.cpp - Removed opt from pipeline Repository: rG LLVM Github Monor

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal marked 3 inline comments as done. pdhaliwal added a comment. After addressing the review comments, I have internally verified changes on few simple test programs. They seem to be working fine. Comment at: clang/lib/Driver/Driver.cpp:3004 +} + } + //

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

MyDeveloperDay added a comment. I'm never going to be the one to accept patches where people change tests without making it really clear why they are changing it. You have to prove you are not regressing behaviour, I work on the Beyonce rule, "if you liked it you should have put a test on it"

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

JonChesterfield added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain.c:2 +// REQUIRES: amdgpu-registered-target +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:35 +// Enable extensions that are enabled in opencl-c-base.h. +#if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200) +#define cl_khr_subgroup_ballot 1 Anast

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: Szelethus. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Displaying the problem range could crash if the be

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

JonChesterfield added a comment. Looks much simpler, thanks! Comment at: clang/lib/Driver/Driver.cpp:755 + *this, TT, *HostTC, C.getInputArgs(), Action::OFK_OpenMP); +else if (TT.isAMDGCN()) + DeviceTC = Mi

[clang] dc00c96 - [OpenCL] Change extension handling for -fdeclare-opencl-builtins

Author: Sven van Haastregt Date: 2021-02-02T11:15:29Z New Revision: dc00c96b2d1bcae56ef598b614ba65a1cc26c4de URL: https://github.com/llvm/llvm-project/commit/dc00c96b2d1bcae56ef598b614ba65a1cc26c4de DIFF: https://github.com/llvm/llvm-project/commit/dc00c96b2d1bcae56ef598b614ba65a1cc26c4de.diff

[PATCH] D95616: [OpenCL] Change extension handling for -fdeclare-opencl-builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc00c96b2d1b: [OpenCL] Change extension handling for -fdeclare-opencl-builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2534790 , @bader wrote: >> Regarding SYCLDevice and SYCLAddrSpaceMap I am still not very convinced >> about the flow. Have you had any design discussion regarding this already >> that you could point to? > > We discus

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320737. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tool

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 320740. pdhaliwal added a comment. - Use 0 for default -O option - Rename addOptLevelArgs to addLLCOptArg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: cla

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal added inline comments. Comment at: clang/lib/Driver/Driver.cpp:755 + *this, TT, *HostTC, C.getInputArgs(), Action::OFK_OpenMP); +else if (TT.isAMDGCN()) + DeviceTC = JonChesterfield wrote: > Minor s

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

JonChesterfield added inline comments. Comment at: clang/lib/Driver/Driver.cpp:755 + *this, TT, *HostTC, C.getInputArgs(), Action::OFK_OpenMP); +else if (TT.isAMDGCN()) + DeviceTC = pdhaliwal wrote: > JonChes

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 320741. bader added a comment. Applied code review suggestions from Anastasia. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang/AST/Type.h c

[clang-tools-extra] fbeff2e - [clangd] Report only decl of overridding method in xref.

Author: Utkarsh Saxena Date: 2021-02-02T13:06:20+01:00 New Revision: fbeff2ec2bc6e44b92931207b0063f83ff7a3b3a URL: https://github.com/llvm/llvm-project/commit/fbeff2ec2bc6e44b92931207b0063f83ff7a3b3a DIFF: https://github.com/llvm/llvm-project/commit/fbeff2ec2bc6e44b92931207b0063f83ff7a3b3a.diff

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbeff2ec2bc6: [clangd] Report only decl of overridding method in xref. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 320745. abhina.sreeskantharajan added a comment. Thank you for reminding me, I've updated the TestingGuide.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95808/new/ https://reviews.llvm.org/

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95808/new/ https://reviews.llvm.org/D95808

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added a subscriber: svenvh. Anastasia added inline comments. Comment at: clang/lib/Basic/Targets.cpp:743 + // Assume compiling for FULL profile + Builder.defineMacro("__opencl_c_int64"); } Btw we could add the other feature macros for earlier version

[clang] f2b4cc9 - Revert "[test] Default clang/test to FileCheck --allow-unused-prefixes=false"

Author: Nico Weber Date: 2021-02-02T07:38:44-05:00 New Revision: f2b4cc91e0830835c251e0525322effda8522b1c URL: https://github.com/llvm/llvm-project/commit/f2b4cc91e0830835c251e0525322effda8522b1c DIFF: https://github.com/llvm/llvm-project/commit/f2b4cc91e0830835c251e0525322effda8522b1c.diff LO

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

Anastasia added a comment. > LGTM, but perhaps you can add a test that has each keyword disabled? FYI we currently already test that `pipe` and `generic` are valid for OpenCL 2.0 and invalid for OpenCL < 2.0. Or do you mean different kind of tests? In OpenCL 3.0 we will have to set the new `Lan

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:141 +kernel void extended_subgroup(global uint4 *out) { + out[0] = get_sub_group_eq_mask();

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

Anastasia updated this revision to Diff 320751. Anastasia marked an inline comment as done. Anastasia added a comment. Fixed value kind. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95608/new/ https://reviews.llvm.org/D95608 Files: clang/lib/Sema/SemaInit.cpp clang/test/CodeGenOpe

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4308 + if (T1Quals.hasAddressSpace()) +Sequence.AddQualificationConversionStep(cv1T1, VK_XValue); +} else rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > > This s

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

svenvh added inline comments. Comment at: clang/lib/Headers/opencl-c.h:17161 +#if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ == 200) +#undef __opencl_c_pipes +#undef __opencl_c_generic_address_space Anastasia wrote: > Looping in @svenvh - I don't m

[PATCH] D95516: [clang][cli] Benchmark command line round-trip

jansvoboda11 updated this revision to Diff 320755. jansvoboda11 added a comment. Add license header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95516/new/ https://reviews.llvm.org/D95516 Files: clang/CMakeLists.txt clang/benchmarks/CMakeList

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked an inline comment as done. bader added a comment. In D89909#2536157 , @Anastasia wrote: > In D89909#2534790 , @bader wrote: > >>> Regarding SYCLDevice and SYCLAddrSpaceMap I am still not very convinced

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

TWeaver added a comment. Hiya, this patch (probably) broke the build bot at: http://lab.llvm.org:8011/#/builders/53/builds/1184 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802

[PATCH] D95735: [ASTMatchers] Fix matching after generic top-level matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D95735#2534715 , @steveire wrote: > In D95735#2534400 , @aaron.ballman > wrote: > >> I'm a bi

[PATCH] D95740: [ASTMatchers] Ignore parts of BindingDecls which are not spelled in source

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2607 +EXPECT_TRUE(matches(Code, traverse(TK_AsIs, M))); +EXPECT_FALSE(matches

[clang] d6a0636 - [ASTMatchers] Fix matching after generic top-level matcher

Author: Stephen Kelly Date: 2021-02-02T13:31:05Z New Revision: d6a06365cf12bebe20a7d65cf3894608efc089b4 URL: https://github.com/llvm/llvm-project/commit/d6a06365cf12bebe20a7d65cf3894608efc089b4 DIFF: https://github.com/llvm/llvm-project/commit/d6a06365cf12bebe20a7d65cf3894608efc089b4.diff LOG:

[PATCH] D95735: [ASTMatchers] Fix matching after generic top-level matcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6a06365cf12: [ASTMatchers] Fix matching after generic top-level matcher (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

njames93 added a comment. As a follow up it may be wise to pass a diag handler to parseConfiguration as when we parse it a second time, we probably want to disregard any warnings (like unknown key) detected as they will have been printed on the first pass. Comment at: clang/l

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95739/new/ https://reviews.llvm.org/D95739 __

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

GoBigorGoHome added a comment. @MyDeveloperDay I changed the `verifyFormat` to `EXPECT_NE` because I don't know the proper way "to show that the previous tests were wrong", and I agree with you that it is a dirty hack. However, I think it is already clear why the tests were changed, that was b

[PATCH] D95846: [analyzer] Updated comments to reflect D85817

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Thanks for doing that! I have a minor nit-picking comment, it is preferable to use present-tense imperative-style commit messages, i.e. "Update comment...". Repository: rG LLVM Gith

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 320761. bader added a comment. Fixed a couple of typos in the comments; NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang/AST/Type.h cla

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman added a comment. I think there should be some documentation change for the new `with` functionality. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:398-407 + bool isBuilderMatcher() const override { return false; } + + std::unique_ptr + buildMatcherCt

[PATCH] D95846: [analyzer] Updated comments to reflect D85817

RedDocMD added a comment. In D95846#2536380 , @vsavchenko wrote: > Thanks for doing that! > I have a minor nit-picking comment, it is preferable to use present-tense > imperative-style commit messages, i.e. "Update comment...". Noted. I will do that in f

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. In D76342#2535321 , @Meinersbur wrote: > Thank you for the update. > > From comparing the diffs, here is the list of main changes I found: > > 1. Create `OMPLoopBasedDirective` as a new base class for OMPLoopDirective > (and OMPTi

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG467a04560143: [ASTMatchers] Add matchers for decomposition decls (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 467a045 - [ASTMatchers] Add matchers for decomposition decls

Author: Stephen Kelly Date: 2021-02-02T14:11:02Z New Revision: 467a045601430c81e1a7f41f6a134e751f17df55 URL: https://github.com/llvm/llvm-project/commit/467a045601430c81e1a7f41f6a134e751f17df55 DIFF: https://github.com/llvm/llvm-project/commit/467a045601430c81e1a7f41f6a134e751f17df55.diff LOG:

[PATCH] D95017: [clang-format] Add case aware include sorting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8105b3766e4: [clang-format] Add case aware include sorting. (authored by kentsommer, committed by curdeius). Changed prior to commit: https://rev

[clang] a8105b3 - [clang-format] Add case aware include sorting.

Author: Kent Sommer Date: 2021-02-02T15:12:27+01:00 New Revision: a8105b3766e4195ca2390cd0714e07406bc8a4a5 URL: https://github.com/llvm/llvm-project/commit/a8105b3766e4195ca2390cd0714e07406bc8a4a5 DIFF: https://github.com/llvm/llvm-project/commit/a8105b3766e4195ca2390cd0714e07406bc8a4a5.diff L

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

awarzynski added a comment. LGTM! Thank you for addressing my comments, (`DELETEME` can be fixed when pushing upstream)! From what I can see you've also addressed all of Tim's comments, but could you wait a day or two before merging this? Just in case I missed something, or Tim or somebody els

[clang] 4f1320b - Revert "[InstrProfiling] Use !associated metadata for counters, data and values"

Author: Tom Weaver Date: 2021-02-02T14:19:31Z New Revision: 4f1320b77d1780dd7532f8ca8b123c13ab55bf1a URL: https://github.com/llvm/llvm-project/commit/4f1320b77d1780dd7532f8ca8b123c13ab55bf1a DIFF: https://github.com/llvm/llvm-project/commit/4f1320b77d1780dd7532f8ca8b123c13ab55bf1a.diff LOG: Re

[clang] 9e5fc57 - [ASTMatchers] Ignore parts of BindingDecls which are not spelled in source

Author: Stephen Kelly Date: 2021-02-02T14:23:13Z New Revision: 9e5fc578f99aaa3f01374d3f09fda75fa7d0239e URL: https://github.com/llvm/llvm-project/commit/9e5fc578f99aaa3f01374d3f09fda75fa7d0239e DIFF: https://github.com/llvm/llvm-project/commit/9e5fc578f99aaa3f01374d3f09fda75fa7d0239e.diff LOG:

[PATCH] D95740: [ASTMatchers] Ignore parts of BindingDecls which are not spelled in source

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e5fc578f99a: [ASTMatchers] Ignore parts of BindingDecls which are not spelled in source (authored by stephenkelly). Repository: rG LLVM Github Mo

[clang-tools-extra] 6ac3fd9 - [clangd] Fix race in Global CDB shutdown

Author: Sam McCall Date: 2021-02-02T15:24:14+01:00 New Revision: 6ac3fd9706047304c52a678884122a3a6bc55432 URL: https://github.com/llvm/llvm-project/commit/6ac3fd9706047304c52a678884122a3a6bc55432 DIFF: https://github.com/llvm/llvm-project/commit/6ac3fd9706047304c52a678884122a3a6bc55432.diff LO

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. Thanks for the updates! The LLVM side of things now looks good to me. Could you also add a description of the new bundle to LangRef https://llvm.org/docs/LangRef.html#operand-bundles? In D92808#2535593 , @ahatanak wrote: > We coul

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire updated this revision to Diff 320774. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 Files: clang/include/clang/ASTMatchers/Dynamic/Diagnostics.h clang/include

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. In D94880#2536399 , @aaron.ballman wrote: > I think there should be some documentation change for the new `with` > functionality. It's already documented in https://clang.llvm.org/docs/LibASTMatchersReference.html , just like

[PATCH] D95852: [clangd] Report xref for base methods.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1902 +void test(BaseBase* BB, Base* B, Derived* D) { + BB->func(); // refs to base's base method are not reported. + B->[[func]](); // References to the base

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:58 + +namespace { + whisperity wrote: > aaron.ballman wrote: > > Is there a need for the anonymous namespace? (We typically only use them >

[clang] 9b0b435 - [AVR][clang] Fix a bug in AVR toolchain search paths

Author: Ben Shi Date: 2021-02-02T22:45:52+08:00 New Revision: 9b0b435d7931bdb1fb128861cc9063a365a9e648 URL: https://github.com/llvm/llvm-project/commit/9b0b435d7931bdb1fb128861cc9063a365a9e648 DIFF: https://github.com/llvm/llvm-project/commit/9b0b435d7931bdb1fb128861cc9063a365a9e648.diff LOG:

[PATCH] D95529: [AVR][clang] Fix a bug in AVR toolchain search paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b0b435d7931: [AVR][clang] Fix a bug in AVR toolchain search paths (authored by benshi001). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

thakis added a comment. Looks like this doesn't link on windows: http://45.33.8.238/win/32481/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95739/new/ https://reviews.llvm.org/D95739 ___ cfe-c

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked 6 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:255 + std::string NodeTypeName = + Node->getType().getAsString(Node->getASTContext().getPrintingPolicy()); +

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2536331 , @bader wrote: > In D89909#2536157 , @Anastasia wrote: > >> In D89909#2534790 , @bader wrote: >> Regarding SYCLDevice and S

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 added a comment. Sounds good to me, thanks for the help. In the meantime I will work on the `fdefault-*` family of flags, which will be dependent on this patch I think. Comment at: clang/include/clang/Driver/Options.td:4124 def A_DASH : Joined<["-"], "A-">, Group;

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

mtrofin added a comment. In D95849#2535939 , @jhenderson wrote: > I assume this now runs cleanly. If so, LGTM. Probably worth mentioning on the > mailing list thread too, so wrap up that conversation. By the way, did we > ever figure out how many of the

[clang] 9a5dc01 - [clang][PATCH][NFC] Correct test case related to review D95482

Author: Melanie Blower Date: 2021-02-02T07:06:43-08:00 New Revision: 9a5dc01e4b65b15c73751f5b3d9273ea73533b5d URL: https://github.com/llvm/llvm-project/commit/9a5dc01e4b65b15c73751f5b3d9273ea73533b5d DIFF: https://github.com/llvm/llvm-project/commit/9a5dc01e4b65b15c73751f5b3d9273ea73533b5d.diff

[clang] 5bbf397 - [OpenCL] Add diagnostics for references to functions

Author: Anastasia Stulova Date: 2021-02-02T15:07:40Z New Revision: 5bbf39704c2b70581d78a463f3c9d20b0eb7dcd5 URL: https://github.com/llvm/llvm-project/commit/5bbf39704c2b70581d78a463f3c9d20b0eb7dcd5 DIFF: https://github.com/llvm/llvm-project/commit/5bbf39704c2b70581d78a463f3c9d20b0eb7dcd5.diff

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bbf39704c2b: [OpenCL] Add diagnostics for references to functions (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

nikic added a comment. Just to be clear here: Only the small handful where a spelling mistake was fixed were actually bugs. All other unused check prefixes were there for convenience, and are now casualties of this unnecessary crusade. I regret not speaking out against this at the time. Repos

[clang] 903a153 - Ensure that the matcher is instantiated

Author: Stephen Kelly Date: 2021-02-02T15:12:39Z New Revision: 903a153409b8640aac30fa0b46b9a99ad90fe786 URL: https://github.com/llvm/llvm-project/commit/903a153409b8640aac30fa0b46b9a99ad90fe786 DIFF: https://github.com/llvm/llvm-project/commit/903a153409b8640aac30fa0b46b9a99ad90fe786.diff LOG:

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

steveire added a comment. In D95739#2536515 , @thakis wrote: > Looks like this doesn't link on windows: > http://45.33.8.238/win/32481/step_4.txt Thanks, should be fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked 3 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:402-403 + +// Unfortunately, undersquiggly highlights are for some reason chewed up +// and not respected b

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

steveire added a comment. I haven't read through all the comments, but the word 'easily' implies 'desirable'. This check seems to be for finding params which are undesirably swappable, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added inline comments. Comment at: clang/lib/Basic/Targets.cpp:743 + // Assume compiling for FULL profile + Builder.defineMacro("__opencl_c_int64"); } Anastasia wrote: > Btw we could add the other feature macros for earlier versions too but I > gues

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. Herald added a reviewer: jansvoboda11. @arsenm I would like to see if we can finalize this patch soon. Do you think you will have a capacity for this in the next weeks? Otherwise I would be happy to help too. It looks in a good shape, we just need to decide if we go a

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:402-403 + +// Unfortunately, undersquiggly highlights are for some reason chewed up +// and not respected by diagnostics from Clang-Tidy. :( +dia

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added a comment. In D69560#2536570 , @steveire wrote: > I haven't read through all the comments, but the word 'easily' implies > 'desirable'. This check seems to be for finding params which are undesirably > swappable, right? The `easily` was

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov added a comment. In D95778#2536266 , @Anastasia wrote: >> LGTM, but perhaps you can add a test that has each keyword disabled? > > FYI we currently already test that `pipe` and `generic` are valid for OpenCL > 2.0 and invalid for OpenCL < 2.0. O

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked an inline comment as done. whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-len2.cpp:10 + +void declaration(int Param, int Other); // NO-WARN: No chance to change this function. + ---

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:402-403 + +// Unfortunately, undersquiggly highlights are for some reason chewed up +// and not respected by diagnostics from Clang-Tidy. :( +diag(F

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:218 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +LANGOPT(OpenCLGenericKeyword, 1, 0, "OpenCL generic keyword") +LANGOPT(OpenCLPipeKeyword , 1, 0, "OpenCL pipe keywo

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

steakhal added a comment. Please, also add a regression test for Haoxin Tu's reproducer. // RUN: %clang %s // expected warning volatile long a ( a .~b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95860/new/ https://reviews.llvm.org/D

[PATCH] D95871: [clang] Store the location for invalid type of a declarator.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: kristof.beyls. hokein requested review of this revision. Herald added a project: clang. Prior to the patch, for an invalid type of declarator, the TInfo's location was invalid. This patch would improve the

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes Bugzilla #48894 for Arm, where it was reported that -Wa,-march was not being

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

DavidSpickett added a comment. Bug link: https://bugs.llvm.org/show_bug.cgi?id=48894 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95872/new/ https://reviews.llvm.org/D95872 ___ cfe-commits mailing list

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

DavidSpickett added reviewers: ostannard, nickdesaulniers. DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:753 : tools::arm::getARMTargetCPU(MCPU, MArch, Triple); StringRef Suffix = tools::arm::getLLVMArchSuffixForARM(CPU,

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. In D78979#2536590 , @Anastasia wrote: > @arsenm I would like to see if we can finalize this patch soon. Do you think > you will have a capacity for this in the next weeks? Otherwise I would be > happy to help too. I don't think I

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-len2.cpp:10 + +void declaration(int Param, int Other); // NO-WARN: No chance to change this function. + whisperity wrote: > aaron.ba

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-len2.cpp:10 + +void declaration(int Param, int Other); // NO-WARN: No chance to change this function. + aaron.ballman wrote: > whisperi

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-easily-swappable-parameters-len2.cpp:10 + +void declaration(int Param, int Other); // NO-WARN: No chance to change this function. + whisperity wrote: > aaron.ba

[clang] eb3426a - [AIX] Improve option processing for mabi=vec-extabi and mabi=vec=defaul

Author: Zarko Todorovski Date: 2021-02-02T10:59:21-05:00 New Revision: eb3426a528d5b3cbbb54aee662a779f2067fc9db URL: https://github.com/llvm/llvm-project/commit/eb3426a528d5b3cbbb54aee662a779f2067fc9db DIFF: https://github.com/llvm/llvm-project/commit/eb3426a528d5b3cbbb54aee662a779f2067fc9db.di

  1   2   3   >