Anastasia added a comment. > LGTM, but perhaps you can add a test that has each keyword disabled?
FYI we currently already test that `pipe` and `generic` are valid for OpenCL 2.0 and invalid for OpenCL < 2.0. Or do you mean different kind of tests? In OpenCL 3.0 we will have to set the new `LangOpts` fields based on the values of `OpenCLOptions` but my guess is that is going to be added in the subsequent patches... ================ Comment at: clang/include/clang/Basic/LangOptions.def:218 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +LANGOPT(OpenCLGenericKeyword, 1, 0, "OpenCL generic keyword") +LANGOPT(OpenCLPipeKeyword , 1, 0, "OpenCL pipe keyword") ---------------- Normally we use just a name of the feature, so perhaps: OpenCLGenericKeyword -> OpenCLGenericAddressSpace OpenCLPipeKeyword -> OpenCLPipe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
