[PATCH] D94287: [clang-format] Fix include sorting bug

kentsommer abandoned this revision. kentsommer added a comment. In D94287#2486099 , @curdeius wrote: > Seems to be a duplicate of D94206 . Right you are! Thanks for catching that! I'll abandon this one in favor of the one

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

richard.barton.arm added a comment. Could we tweak the wording to clarify that it is Clang-specific? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94169/new/ https://reviews.llvm.org/D94169 ___ cfe-commi

[PATCH] D94289: [clangd] Add go-to-def metric.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. to track the number of different "special" go-to-def

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. That sounds good but it's different to what this patch is trying to accomplish, isn't it? -ansi already doesn't get passed to the linker. E.g. with clang 10.0.1 without this patch: ~ ❯ clang test.o -o test -ansi -### clang version 10.0.1 (Fedora 10.0.1-3.fc32) Targ

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94188/new/ https://reviews.llvm.org/D94188 ___ cfe-commits mailing list cfe-com

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

MyDeveloperDay added a comment. In D94206#2485397 , @rjelonek wrote: > I do not have commit access. we are going need to know your name and email address so we can commit on your behalf git commit --amend --author="John Doe " https://llvm.org/docs/P

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 315313. serge-sans-paille added a comment. Address some of the review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticG

[clang] 8e3230f - [clang][cli] Port DiagnosticOpts to new option parsing system

Author: Jan Svoboda Date: 2021-01-08T10:44:22+01:00 New Revision: 8e3230ffa3ad2994c3bbddffc3e53b3bccb2ee41 URL: https://github.com/llvm/llvm-project/commit/8e3230ffa3ad2994c3bbddffc3e53b3bccb2ee41 DIFF: https://github.com/llvm/llvm-project/commit/8e3230ffa3ad2994c3bbddffc3e53b3bccb2ee41.diff L

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e3230ffa3ad: [clang][cli] Port DiagnosticOpts to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. "Rafał Jelonek <71409580+rjelo...@users.noreply.github.com>" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] 8e3e148 - Revert "[clang][cli] Port DiagnosticOpts to new option parsing system"

Author: Jan Svoboda Date: 2021-01-08T10:53:12+01:00 New Revision: 8e3e148c888e1d9d2b11721112a54a62e33a635a URL: https://github.com/llvm/llvm-project/commit/8e3e148c888e1d9d2b11721112a54a62e33a635a DIFF: https://github.com/llvm/llvm-project/commit/8e3e148c888e1d9d2b11721112a54a62e33a635a.diff L

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/test/Sema/reserved-identifier.c:9 +int _foo() { return 0; }// expected-warning {{'_foo' is a reserved identifier}} + +// This one is explicitly skipped by -Wres

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92749/new/ https://reviews.llvm.org/D92749 __

[PATCH] D94290: [clang][AArch64][SVE] Avoid going through memory for coerced VLST return values

joechrisellis created this revision. joechrisellis added reviewers: c-rhodes, bsmith, peterwaller-arm. Herald added subscribers: NickHung, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Kind of bizarre that we missed these, thanks for adding them. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94162/new/ https://reviews

[PATCH] D94290: [clang][AArch64][SVE] Avoid going through memory for coerced VLST return values

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. I've left one minor nit but looks otherwise looks fine to me Comment at: clang/lib/CodeGen/CGCall.cpp:1273 +if (auto *FixedSrc = +dyn_cast(Src.getElementT

[PATCH] D94290: [clang][AArch64][SVE] Avoid going through memory for coerced VLST return values

joechrisellis updated this revision to Diff 315339. joechrisellis added a comment. Address @c-rhodes's comment. - Use `SrcTy` instead of `Src.getElementType()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94290/new/ https://reviews.llvm.org/D942

[PATCH] D94293: [clangd] automatically index STL

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94293 Fil

[clang] 38d18d9 - [SVE] Add support to vectorize_width loop pragma for scalable vectors

Author: David Sherwood Date: 2021-01-08T11:37:27Z New Revision: 38d18d93534d290d045bbbfa86337e70f1139dc2 URL: https://github.com/llvm/llvm-project/commit/38d18d93534d290d045bbbfa86337e70f1139dc2 DIFF: https://github.com/llvm/llvm-project/commit/38d18d93534d290d045bbbfa86337e70f1139dc2.diff LOG

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rG38d18d93534d: [SVE] Add support to vectorize_width loop pragma for scalable vectors (authored by david-arm). Changed prior to commit: https://reviews.llvm.org/D89031?vs=315121&id=315341#toc Repository:

[PATCH] D94293: [clangd] automatically index STL

kuhnel added a comment. @sammccall here the first implementation we talked about yesterday. This works well on my testing poject that has a compile_commands.json. It does not work without one. Also I'm not really happy with the design as I haven't really found a good place to store the generat

[PATCH] D94293: [clangd] automatically index STL

kadircet added a comment. (not sure if you were looking for comments yet, but i was just passing by and it was a small-ish patch, so couldn't resist :D) Comment at: clang-tools-extra/clangd/index/Background.cpp:449 + // TODO(kuhnel): is the a better place to store this file?

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

curdeius added a comment. I like what you did with tests. And thank you for the patch. Before accepting this formally, I'd like to see the premerge tests pass. How do you upload the diff? Do you use arcanist? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocation &Invocation, -const llvm::MemoryBuffer *M

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek added a comment. no, i upload diff file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D94293: [clangd] automatically index STL

kuhnel added a comment. Yes, I was looking for feedback on this one as I wasn't happy with my design. Comment at: clang-tools-extra/clangd/index/Background.cpp:449 + // TODO(kuhnel): is the a better place to store this file? + // TODO(kuhnel): do we need a file at all, can we

[clang-tools-extra] b83b7d0 - [clangd] NFC, avoid potential ODR violation.

Author: Haojian Wu Date: 2021-01-08T13:29:11+01:00 New Revision: b83b7d08730e2b67d911653f59091b1b311c0213 URL: https://github.com/llvm/llvm-project/commit/b83b7d08730e2b67d911653f59091b1b311c0213 DIFF: https://github.com/llvm/llvm-project/commit/b83b7d08730e2b67d911653f59091b1b311c0213.diff LO

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

erichkeane added a comment. In D92715#2446479 , @craig.topper wrote: > I think it would be possible to add a new attribute to define these types. > But only specific values for parameters would be allowed so that it could > only generate the exact types

[clang-tools-extra] c909512 - [clangd] Cleanup a remaining Optional usage, NFC.

Author: Haojian Wu Date: 2021-01-08T13:44:20+01:00 New Revision: c909512fdb9ed63081b0578410430117811b86e8 URL: https://github.com/llvm/llvm-project/commit/c909512fdb9ed63081b0578410430117811b86e8 DIFF: https://github.com/llvm/llvm-project/commit/c909512fdb9ed63081b0578410430117811b86e8.diff LO

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh added inline comments. Comment at: clang/docs/UsersManual.rst:2832 +Note that if compiled to bitcode for generic targets such as SPIR, +portable IR is produced that it can be used with various vendor +tools as well as open source tools such as `SPIRV-LLVM Translator --

[clang-tools-extra] ed3b1f9 - [clangd] go-to-implementation on a base class jumps to all subclasses.

Author: Haojian Wu Date: 2021-01-08T13:50:57+01:00 New Revision: ed3b1f906115a0dcd2542fa294d0382a42eb177d URL: https://github.com/llvm/llvm-project/commit/ed3b1f906115a0dcd2542fa294d0382a42eb177d DIFF: https://github.com/llvm/llvm-project/commit/ed3b1f906115a0dcd2542fa294d0382a42eb177d.diff LO

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed3b1f906115: [clangd] go-to-implementation on a base class jumps to all subclasses. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9274

[PATCH] D94293: [clangd] automatically index STL

njames93 added a comment. How does this approach work with differing language standards. For example with an old implementation designed for c++14, `string_view` header won't exist. If the implementation is designed to work with c++17, including that header in c++14 mode will probably be ifdef.

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

kadircet added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:49 + /// To do this, isNamespaceVisible should return true on "foo" NamespaceDecl. + virtual bool isNamespaceVisible(const NamespaceDecl *NS) const { +return false; oh wow,

[PATCH] D94293: [clangd] automatically index STL

kadircet added a comment. In D94293#2486468 , @njames93 wrote: > How does this approach work with differing language standards. For example > with an old implementation designed for c++14, `string_view` header won't > exist. If the implementation is desi

[clang] 9c4b222 - Revert "Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."""""

Author: Alexander Belyaev Date: 2021-01-08T14:17:18+01:00 New Revision: 9c4b2225b24de07a728715ce20238803370413ea URL: https://github.com/llvm/llvm-project/commit/9c4b2225b24de07a728715ce20238803370413ea DIFF: https://github.com/llvm/llvm-project/commit/9c4b2225b24de07a728715ce20238803370413ea.d

[clang] af7cce2 - [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

Author: Mark Murray Date: 2021-01-08T13:21:11Z New Revision: af7cce2fa4d19c3cd09607e1d6ea2e0847cc55b7 URL: https://github.com/llvm/llvm-project/commit/af7cce2fa4d19c3cd09607e1d6ea2e0847cc55b7 DIFF: https://github.com/llvm/llvm-project/commit/af7cce2fa4d19c3cd09607e1d6ea2e0847cc55b7.diff LOG: [

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. In D93375#2486165 , @tbaeder wrote: > That sounds good but it's different to what this patch is trying to > accomplish, isn't it? -ansi already doesn't get passed to the linker. > E.g. with clang 10.0.1 without this patch: >

[clang] 7d4a8bc - [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

Author: Mark Murray Date: 2021-01-08T13:21:12Z New Revision: 7d4a8bc417bf75b5e4034674a4255173d0089e68 URL: https://github.com/llvm/llvm-project/commit/7d4a8bc417bf75b5e4034674a4255173d0089e68 DIFF: https://github.com/llvm/llvm-project/commit/7d4a8bc417bf75b5e4034674a4255173d0089e68.diff LOG: [

[PATCH] D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4a8bc417bf: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification… (authored by MarkMurrayARM). Repository: rG LLVM Gi

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7cce2fa4d1: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer… (authored by MarkMurrayARM). Repository: rG LLVM Github Monor

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2480070 , @vsavchenko wrote: > In D93630#2479757 , @aaron.ballman > wrote: > >> There are attributes like `nomerge` which are both a declaration and a >> statement attribut

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz updated this revision to Diff 315363. adamcz marked an inline comment as done. adamcz added a comment. Addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94259/new/ https://reviews.llvm.org/D94259 Files: clang-tools-ex

[clang] 0ef2b68 - [OpenCL] Documentation for experimental C++ libs

Author: Anastasia Stulova Date: 2021-01-08T13:45:59Z New Revision: 0ef2b68ff063164a83a37a2a363196d51b76ed8d URL: https://github.com/llvm/llvm-project/commit/0ef2b68ff063164a83a37a2a363196d51b76ed8d DIFF: https://github.com/llvm/llvm-project/commit/0ef2b68ff063164a83a37a2a363196d51b76ed8d.diff

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

This revision was automatically updated to reflect the committed changes. Anastasia marked an inline comment as done. Closed by commit rG0ef2b68ff063: [OpenCL] Documentation for experimental C++ libs (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://review

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94259/new/ https://reviews.llvm.org/D94259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this effort! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11087 +// TCB warnings +def err_tcb_conflicting_attributes : Error

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

aheejin updated this revision to Diff 315366. aheejin added a comment. Remove an extra word Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94038/new/ https://reviews.llvm.org/D94038 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

curdeius added a comment. I've set the repository to rG LLVM. Could you please rebase and update the patch so that the CI gets triggered? I hope it is enough to just reupload a patch. I have heard that sometimes you might need to reupload the diff

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

curdeius added a comment. Please rebase this patch too to trigger CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:893 +def warn_pragma_pack_identifer_not_supported : Warning< + "specifying an identifier within pragma pack is not supported, identifier is ignored">, + InGroup;

[clang] e97071d - [NFC] Renaming PackStack to AlignPackStack

Author: Xiangling Liao Date: 2021-01-08T09:15:11-05:00 New Revision: e97071d7952068bbb5fee7bf9e46f304044d4aee URL: https://github.com/llvm/llvm-project/commit/e97071d7952068bbb5fee7bf9e46f304044d4aee DIFF: https://github.com/llvm/llvm-project/commit/e97071d7952068bbb5fee7bf9e46f304044d4aee.diff

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

This revision was automatically updated to reflect the committed changes. Closed by commit rGe97071d79520: [NFC] Renaming PackStack to AlignPackStack (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews

[PATCH] D94293: [clangd] automatically index STL

sammccall added a comment. In D94293#2486468 , @njames93 wrote: > How does this approach work with differing language standards. For example > with an old implementation designed for c++14, `string_view` header won't > exist. If the implementation is des

[PATCH] D94289: [clangd] Add go-to-def metric.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:375 VirtualMethods.insert(getSymbolID(CMD)); + LocateASTReferentMetric.record(1, "go-to-overrides

[PATCH] D94265: [clangd] Search compiler in PATH for system include extraction If the compiler is specified by its name, search it in the system PATH instead of the command directory: this is what th

sammccall added a comment. Yes, I was getting deja vu reading the description. Thanks though! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94265/new/ https://reviews.llvm.org/D94265 ___ cfe-commits mail

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 315373. serge-sans-paille added a comment. Update codebase and testbed to reflect recent discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/test/Sema/reserved-identifier.cpp:58 +// we skip this one because it's not at top-level. +int _barbatruc; // no-warning +} aaron.ballman wrote: > This i

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

sscalpone added a comment. @awarzynski, perhaps I am being too dramatic by wondering if we are compromising support for one or the other language in order to support a common definition. In the case of -I, there are language-specific semantics that are important and interesting, such as the re

[PATCH] D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'

whisperity updated this revision to Diff 315384. whisperity added a comment. Herald added a subscriber: shchenz. **Ignore one-way implicit conversions** One-way implicit conversions introduce too much noise, and except in very odd circumstances, do not provide a meaningful result. The stalwart

[clang] 7be2715 - [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

Author: Heejin Ahn Date: 2021-01-08T06:55:04-08:00 New Revision: 7be271537e97018c56a714a90106f1e25e32f4db URL: https://github.com/llvm/llvm-project/commit/7be271537e97018c56a714a90106f1e25e32f4db DIFF: https://github.com/llvm/llvm-project/commit/7be271537e97018c56a714a90106f1e25e32f4db.diff LO

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG7be271537e97: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94038/new/ h

[PATCH] D93095: Introduce -Wreserved-identifier

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/reserved-identifier.cpp:40 + return foo__bar(); // no-warning +} serge-sans-paille wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > You should also have some tests for: > > > `

[PATCH] D93095: Introduce -Wreserved-identifier

Quuxplusone added inline comments. Comment at: clang/test/Sema/reserved-identifier.cpp:77 + +long double operator"" _BarbeBleue(long double) // no-warning +{ This should get a warning, since it's using an identifier "reserved for any use." https://stackoverflow.

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

fhahn added a comment. FWIW I think it would be good to have a bit more details in the description for changes such as this, like a link to the public docs for the extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94083/new/ https://reviews

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

whisperity added a comment. I was just about to write an issue to the CoreGuidelines project, but I was @vingeldal has posted about "relatedness" before me: https://github.com/isocpp/CppCoreGuidelines/issues/1579. It was in the list of //closed// issues. Herb Sutter has changed the rule's titl

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 315390. serge-sans-paille marked 2 inline comments as done. serge-sans-paille added a comment. Ignore forward declaration of tagdecl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/i

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

fhahn added a comment. In D86841#2484705 , @atmnpatel wrote: > I'm happy to add a patch amending this, the reason it wasn't done that way > was because at the time and even now, out of icc/clang/msvc/gcc, gcc seems to > be the only one that happily remov

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/unittests/tweaks/ExpandAutoTypeTests.cpp:68 + EXPECT_EQ(apply("ns::Class * foo() { au^to c = foo(); }"), +

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin marked an inline comment as done. aheejin added a comment. In D94039#2480002 , @tlively wrote: > In the description I think "but LLVM does not have a way of that kind of > behavior" is missing the word "modeling" => "but LLVM does not have a way o

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin updated this revision to Diff 315392. aheejin marked an inline comment as done. aheejin added a comment. Delete `declare void @_ZSt9terminatev()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94039/new/ https://reviews.llvm.org/D94039 File

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

chill added a comment. In D94083#2486800 , @fhahn wrote: > FWIW I think it would be good to have a bit more details in the description > for changes such as this, like a link to the public docs for the extension. I'm sorry, I assumed this information was

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz updated this revision to Diff 315398. adamcz marked an inline comment as done. adamcz added a comment. final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94259/new/ https://reviews.llvm.org/D94259 Files: clang-tools-extra

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

kadircet added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:51 + /// be no calls with outer scopes. + virtual bool isScopeVisible(const DeclContext *NS) const { return false; } }; nit: s/NS/DC/ Repository: rG LLVM Github Monorepo C

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz updated this revision to Diff 315401. adamcz added a comment. s/NS/DC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94259/new/ https://reviews.llvm.org/D94259 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/unittests/tw

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402 ArrayRef InnerMatchers) { + if (InnerMatchers.empty()) +return true; Does it make sense to return `true` when there are no

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4af86581e80: [clangd] Fix type printing in the presence of qualifiers (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] d4af865 - [clangd] Fix type printing in the presence of qualifiers

Author: Adam Czachorowski Date: 2021-01-08T17:00:39+01:00 New Revision: d4af86581e80ef0f7a6f4a4fff1c97260a726e71 URL: https://github.com/llvm/llvm-project/commit/d4af86581e80ef0f7a6f4a4fff1c97260a726e71 DIFF: https://github.com/llvm/llvm-project/commit/d4af86581e80ef0f7a6f4a4fff1c97260a726e71.d

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/lib/AST/Decl.cpp:1099 +const DeclContext *CurrentContext = getDeclContext(); +while (true) { + if (isa(CurrentContext)) Rather than trying to manually decide whether the name will be exposed at t

[PATCH] D94314: [clangd] Add missing "override" to fix the build.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up to d4af86581e80ef0f7a6f4a4fff1c97260a726e71

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast added a comment. Ping, @aaron.ballman? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93999/new/ https://reviews.llvm.org/D93999 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang-tools-extra] 2e1bb79 - [clangd] Add missing "override" to fix the build.

Author: Adam Czachorowski Date: 2021-01-08T17:24:47+01:00 New Revision: 2e1bb7940a4ddc847cebd25092d10f40866a7fad URL: https://github.com/llvm/llvm-project/commit/2e1bb7940a4ddc847cebd25092d10f40866a7fad DIFF: https://github.com/llvm/llvm-project/commit/2e1bb7940a4ddc847cebd25092d10f40866a7fad.d

[PATCH] D94314: [clangd] Add missing "override" to fix the build.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e1bb7940a4d: [clangd] Add missing "override" to fix the build. (a

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

aaron.ballman added a comment. In D69560#2486806 , @whisperity wrote: > I was just about to write an issue to the CoreGuidelines project, but I was > @vingeldal has posted about "relatedness" before me: > https://github.com/isocpp/CppCoreGuidelines/issue

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a comment. In D86694#2463429 , @russell.gallop wrote: > - With scudo all lit tests (generally) pass, but there are some intermittent > failures (Access Violation) on the following tests: > >> ExecutionEngine/MCJIT/test-global-init-nonzero-sm

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ABataev, sstefan1. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added a project: clang. Whenever we enter a new OpenMP data environment we want to enter a function

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

whisperity added a comment. I have posted two questions to GitHub, mostly related to the guideline rule and how free the implementation could be: #1732 and #1733 , I think I tagged y

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7783-7784 "|%diff{casting $ to type $|casting between types}0,1}2" - " converts between pointers to integer types with different sign">, + " converts between pointers to integer

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski added a comment. Thank you all for your input. Let me summarize. **SUGGESTION 1** Tweak the wording to clarify that it is Clang-specific. That's a good compromise IMO. It highlights that the described semantics apply to Clang only. And I'm not aware of any other way to achieve this r

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

aaron.ballman added a comment. In D69560#2487093 , @whisperity wrote: > I have posted two questions to GitHub, mostly related to the guideline rule > and how free the implementation could be: #1732 >

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

whisperity added a comment. In D69560#2487117 , @aaron.ballman wrote: > In D69560#2487093 , @whisperity > wrote: > >> Not sure what CVR-modelling's default should be... it finds less when "off", >> but too easily

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

JonChesterfield added a comment. I'm guessing we're using the function boundary as a compiler barrier. That seems fragile in the face of improving cross-function optimisation. What is the invariant we want around entry to a data environment, which happens to be met by a function boundary? Rep

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

ABataev added a comment. In D94315#2487150 , @JonChesterfield wrote: > I'm guessing we're using the function boundary as a compiler barrier. That > seems fragile in the face of improving cross-function optimisation. Looks like applying inaccessiblemem_o

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

nickdesaulniers added a comment. Compiler crash reported in: https://bugs.llvm.org/show_bug.cgi?id=48695 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78105/new/ https://reviews.llvm.org/D78105 ___ cfe-c

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek updated this revision to Diff 315424. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek added a comment. @curdeius Can you commit this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek updated this revision to Diff 315428. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315431. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

jdoerfert added a comment. In D94315#2487164 , @ABataev wrote: > In D94315#2487150 , @JonChesterfield > wrote: > >> I'm guessing we're using the function boundary as a compiler barrier. That >> seems fragile in th

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

ABataev added a comment. In D94315#2487242 , @jdoerfert wrote: > In D94315#2487164 , @ABataev wrote: > >> In D94315#2487150 , >> @JonChesterfield wrote: >> >>> I'm guessing

  1   2   >