[clang] d2ddc69 - Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""

Author: Artem Dergachev Date: 2021-01-07T00:28:22-08:00 New Revision: d2ddc694ff94743d9735aaf07edcaf6db8aaca04 URL: https://github.com/llvm/llvm-project/commit/d2ddc694ff94743d9735aaf07edcaf6db8aaca04 DIFF: https://github.com/llvm/llvm-project/commit/d2ddc694ff94743d9735aaf07edcaf6db8aaca04.dif

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek created this revision. rjelonek added reviewers: rsmith, rnk. rjelonek created this object with visibility "All Users". rjelonek created this object with edit policy "Members of Project: clang". rjelonek added a project: clang-format. rjelonek requested review of this revision. Herald adde

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:751-753 + // they effectively want vectorization disabled. We leave the + // scalable flag unspecified in this case to avoid setting the + // vectorize.enable flag later on. -

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. In D89490#2482531 , @rjmccall wrote: > I'm not calling Wine a niche use-case, I'm calling this feature a niche > use-case. The lack of this feature has not blocked Wine from being a > successful project. The feature has to stan

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

HazardyKnusperkeks added a comment. I think your base for the diff is wrong, there are many "added" things which are already in clang-format. Could you update the diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846 ___

[clang] 77db83a - [clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo

Author: Jan Svoboda Date: 2021-01-07T10:01:49+01:00 New Revision: 77db83ae997767400ffcbe0101f8ee867ebaa111 URL: https://github.com/llvm/llvm-project/commit/77db83ae997767400ffcbe0101f8ee867ebaa111 DIFF: https://github.com/llvm/llvm-project/commit/77db83ae997767400ffcbe0101f8ee867ebaa111.diff L

[clang] c6ea4d5 - [clang][cli] Implement ContainsN Google Test matcher

Author: Jan Svoboda Date: 2021-01-07T10:01:49+01:00 New Revision: c6ea4d5b2c0054f3e2fa06b911ed3933fe59bc5b URL: https://github.com/llvm/llvm-project/commit/c6ea4d5b2c0054f3e2fa06b911ed3933fe59bc5b DIFF: https://github.com/llvm/llvm-project/commit/c6ea4d5b2c0054f3e2fa06b911ed3933fe59bc5b.diff L

[PATCH] D84674: [clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77db83ae9977: [clang][cli] Allow users to specify a conditional to prevent parsing options… (authored by jansvoboda11). Changed prior to commit: h

[PATCH] D93636: [clang][cli] Implement ContainsN Google Test matcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6ea4d5b2c00: [clang][cli] Implement ContainsN Google Test matcher (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

HazardyKnusperkeks added a comment. I don't know if I would create that many test functions, but put it all in one (maybe even one existing). Otherwise this looks ok. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.or

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

HazardyKnusperkeks added a comment. Should the BOM not be ignored in ANY case, not just while sorting includes? And thus a different code should be touched? How about aligned assignments at the beginning of the line with a BOM, does it count to the type name, or does clang-format handle that co

[clang] d0fa7a0 - Revert "[clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo"

Author: Jan Svoboda Date: 2021-01-07T10:12:53+01:00 New Revision: d0fa7a05be92617a0262ec8b622f158971a54c54 URL: https://github.com/llvm/llvm-project/commit/d0fa7a05be92617a0262ec8b622f158971a54c54 DIFF: https://github.com/llvm/llvm-project/commit/d0fa7a05be92617a0262ec8b622f158971a54c54.diff L

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

peterwaller-arm added a comment. Suggesting a few small tweaks. Otherwise LGTM when @rnk is happy. Comment at: clang/test/CodeGenCXX/homogeneous-aggregates.cpp:129 +struct Empty {}; +// A class with a base is returned using the sret calling convetion by MSVC. +struct HasEmptyBa

[PATCH] D93977: [clangd] Pass DraftStore to Tweak Apply and Prepare.

njames93 abandoned this revision. njames93 added a comment. Abandoning in favour of VFS approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93977/new/ https://reviews.llvm.org/D93977 ___ cfe-commits m

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(doub

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 updated this revision to Diff 315070. njames93 added a comment. Herald added a subscriber: javed.absar. Use VFS instead of DraftStore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93978/new/ https://reviews.llvm.org/D93978 Files: clang-

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201

[PATCH] D89490: Introduce __attribute__((darwin_abi))

rjmccall added a comment. In D89490#2483792 , @aguinet wrote: > In D89490#2482531 , @rjmccall wrote: > >> I'm not calling Wine a niche use-case, I'm calling this feature a niche >> use-case. The lack of this featu

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

MyDeveloperDay added a comment. In D94201#2483824 , @HazardyKnusperkeks wrote: > Should the BOM not be ignored in ANY case, not just while sorting includes? > And thus a different code should be touched? > > How about aligned assignments at the beginning

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

MyDeveloperDay added subscribers: krasimir, klimek. MyDeveloperDay added a comment. @rjelonek please don't set the editable to "clang" but leave it as all users F14974099: image.png otherwise only members of the clang project can actually edit it the review

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

MyDeveloperDay added a comment. Could you add user case where you see this issue to the description or add a link to the related bug in the bug tracker if there is one, I'm just struggling a little to see what the original problem was. Generally it looks fine, just for understanding I'd like to

[clang] 67a4c67 - Reapply "[clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo"

Author: Jan Svoboda Date: 2021-01-07T11:11:47+01:00 New Revision: 67a4c672b02359fa6f723249f633ffc76aff2174 URL: https://github.com/llvm/llvm-project/commit/67a4c672b02359fa6f723249f633ffc76aff2174 DIFF: https://github.com/llvm/llvm-project/commit/67a4c672b02359fa6f723249f633ffc76aff2174.diff L

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

MyDeveloperDay added a comment. I'm not seeing this // clang-format off #include "d.h" #include "b.h" // clang-format on #include "a.h" #include "c.h" #include "e.h" $ unix2dos test1.cpp unix2dos: converting file test1.cpp to DOS format... $ clang-format test1.cpp // clang-form

[clang] 0877b96 - [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

Author: Balázs Kéri Date: 2021-01-07T11:28:11+01:00 New Revision: 0877b963ef2d3c384b47f7a6161c9d9ab106a7f2 URL: https://github.com/llvm/llvm-project/commit/0877b963ef2d3c384b47f7a6161c9d9ab106a7f2 DIFF: https://github.com/llvm/llvm-project/commit/0877b963ef2d3c384b47f7a6161c9d9ab106a7f2.diff L

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0877b963ef2d: [clang][ASTImporter] Fix a possible assertion failure… (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https:

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

MyDeveloperDay added a comment. I've not used this before, but you seem to be suggesting that `#pragma hdrstop` should be used to determine when the files main header should now be placed? Could you explain a little more as to why you think that should be the case (i.e. is there a technical rea

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. In unit test "DetectClangFormatOn" is my real case. I have problems with D94201 and D94217 so i tried to turn off sorting for first block (with #pragma hdrstop at the end of this block). But sorting tu

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 315073. hliao added a comment. Forget that C function could be overloaded on Clang with overloadable extension. With that, we don't need to mark functions from `` as HD. Instead, we could provide their device-side implementation directly. Repository: rG LLVM

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek added a comment. Currently at work we use Embarcadero Builder C++ In builder all above #pragma hdrstop is a precompiled header. And we have this #pragma at almost all cpp files, so mainInclude is ignored because is in second include block. `#pragma hdrstop( "c:\\projects\\include\\myin

[PATCH] D94222: [clangd] Add server capability advertising hot-reloading of CDBs.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Currently some clients watch for CDB chan

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

NoQ added a comment. > My code seems to think that a variable print_count has the value INT_MAX for > some reason Typically in such cases bug visitors should be added/improved until it is clear from the user-facing report why does the analyzer think so. They'd highlight the important events, p

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek added a comment. I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] a828fb4 - [clang][cli] Port a CommaJoined option to the marshalling infrastructure

Author: Jan Svoboda Date: 2021-01-07T11:52:06+01:00 New Revision: a828fb463ed9f6085849bb3a4f225b3c84e7cf29 URL: https://github.com/llvm/llvm-project/commit/a828fb463ed9f6085849bb3a4f225b3c84e7cf29 DIFF: https://github.com/llvm/llvm-project/commit/a828fb463ed9f6085849bb3a4f225b3c84e7cf29.diff L

[PATCH] D93698: [clang][cli] Port a CommaJoined option to the marshalling infrastructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa828fb463ed9: [clang][cli] Port a CommaJoined option to the marshalling infrastructure (authored by jansvoboda11). Changed prior to commit: https:

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre updated this revision to Diff 315080. thopre added a comment. Change approach to remove continuation line instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 Files: clang/include/clang/AST/Decl

[clang] e5cdb6c - [flang][driver] Add support for `-c` and `-emit-obj`

Author: Andrzej Warzynski Date: 2021-01-07T10:52:38Z New Revision: e5cdb6c56edf656d03f57c5c285cfa8c6b7b6f57 URL: https://github.com/llvm/llvm-project/commit/e5cdb6c56edf656d03f57c5c285cfa8c6b7b6f57 DIFF: https://github.com/llvm/llvm-project/commit/e5cdb6c56edf656d03f57c5c285cfa8c6b7b6f57.diff

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5cdb6c56edf: [flang][driver] Add support for `-c` and `-emit-obj` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D93

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2481300 , @rjmccall wrote: > People can't actually just copy/paste from the comment anyway because of the > comment characters on the line, and I don't think anyone will misunderstand > the example if the backslash is mi

[clang] b6ba598 - [clang][cli] Port getAllArgumentValues to the marshalling infrastructure

Author: Jan Svoboda Date: 2021-01-07T12:02:07+01:00 New Revision: b6ba59830796b4efad69a3d3c1fae56c20029f30 URL: https://github.com/llvm/llvm-project/commit/b6ba59830796b4efad69a3d3c1fae56c20029f30 DIFF: https://github.com/llvm/llvm-project/commit/b6ba59830796b4efad69a3d3c1fae56c20029f30.diff L

[PATCH] D93679: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ba59830796: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure (authored by jansvoboda11). Changed prior to commit: https:

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. there is no related bug. About Line.endswith("\\") -> Trimmed.endswith("\\") When i debugging clang-format, i noticed that "Line.endswith("\\")" never result with true (even if i put \ at the end of line - in my case CRLF). But when i change line ending to LF condition

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek added a comment. In D94206#2483901 , @MyDeveloperDay wrote: > I'm not seeing this > > // clang-format off > #include "d.h" > #include "b.h" > // clang-format on > > #include "a.h" > #include "c.h" > #include "e.h" > > $ unix2

[clang] 33f90f3 - [clang][cli] Report the actual argument parsing result

Author: Jan Svoboda Date: 2021-01-07T12:37:04+01:00 New Revision: 33f90f38e11c7c23d6e2a23ca526f8b0d8f53771 URL: https://github.com/llvm/llvm-project/commit/33f90f38e11c7c23d6e2a23ca526f8b0d8f53771 DIFF: https://github.com/llvm/llvm-project/commit/33f90f38e11c7c23d6e2a23ca526f8b0d8f53771.diff L

[PATCH] D93700: [clang][cli] Report the actual argument parsing result

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33f90f38e11c: [clang][cli] Report the actual argument parsing result (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman updated this revision to Diff 315090. FarisRehman added a comment. Rename test files Rename test files to use dashes instead of underscores, as other test files do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93453/new/ https://revie

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch utilizes the `alignas` specifier and removes the workaround which used a union object for the same

[clang-tools-extra] 213329d - [clangd] Add server capability advertising hot-reloading of CDBs.

Author: Sam McCall Date: 2021-01-07T13:39:21+01:00 New Revision: 213329d7c64f9710f23a78596255509b147b37c6 URL: https://github.com/llvm/llvm-project/commit/213329d7c64f9710f23a78596255509b147b37c6 DIFF: https://github.com/llvm/llvm-project/commit/213329d7c64f9710f23a78596255509b147b37c6.diff LO

[PATCH] D94222: [clangd] Add server capability advertising hot-reloading of CDBs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG213329d7c64f: [clangd] Add server capability advertising hot-reloading of CDBs. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94222/

[clang] 236129f - [CompilationDatabase] Pass Twine by const reference instead of by value. NFCI.

Author: Simon Pilgrim Date: 2021-01-07T12:53:28Z New Revision: 236129fb4460a4030eee685abc2f02b32458e775 URL: https://github.com/llvm/llvm-project/commit/236129fb4460a4030eee685abc2f02b32458e775 DIFF: https://github.com/llvm/llvm-project/commit/236129fb4460a4030eee685abc2f02b32458e775.diff LOG:

[PATCH] D93701: [clang][cli] NFC: Ensure non-null DiagnosticsEngine in ParseDiagnosticArgs

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1400-1402 bool clang::ParseDiagnosticArgs(DiagnosticOptions &Opts, ArgList &Args, -DiagnosticsEngine *Diags, +DiagnosticsEngi

[clang] e72cdc5 - [clang][cli] NFC: Ensure non-null DiagnosticsEngine in ParseDiagnosticArgs

Author: Jan Svoboda Date: 2021-01-07T14:15:08+01:00 New Revision: e72cdc5ba1e65ecd8632663b6604eb9be8d1a162 URL: https://github.com/llvm/llvm-project/commit/e72cdc5ba1e65ecd8632663b6604eb9be8d1a162 DIFF: https://github.com/llvm/llvm-project/commit/e72cdc5ba1e65ecd8632663b6604eb9be8d1a162.diff L

[clang] 75d6363 - [clang][cli] NFC: Move parseSimpleArgs

Author: Jan Svoboda Date: 2021-01-07T14:15:08+01:00 New Revision: 75d63630ebb197c338801d6b100ae2e06800c4ce URL: https://github.com/llvm/llvm-project/commit/75d63630ebb197c338801d6b100ae2e06800c4ce DIFF: https://github.com/llvm/llvm-project/commit/75d63630ebb197c338801d6b100ae2e06800c4ce.diff L

[PATCH] D93701: [clang][cli] NFC: Ensure non-null DiagnosticsEngine in ParseDiagnosticArgs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe72cdc5ba1e6: [clang][cli] NFC: Ensure non-null DiagnosticsEngine in ParseDiagnosticArgs (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D93701?vs=314866&id=315108#toc Rep

[PATCH] D94172: [clang][cli] NFC: Move parseSimpleArgs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75d63630ebb1: [clang][cli] NFC: Move parseSimpleArgs (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D94172?vs=31487

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

gbencze added a comment. Ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89649/new/ https://reviews.llvm.org/D89649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fcd1e35 - [clang][cli] NFC: Make parsing macro reusable

Author: Jan Svoboda Date: 2021-01-07T14:25:48+01:00 New Revision: fcd1e35e4cc6887c3fb880126e60676458e60680 URL: https://github.com/llvm/llvm-project/commit/fcd1e35e4cc6887c3fb880126e60676458e60680 DIFF: https://github.com/llvm/llvm-project/commit/fcd1e35e4cc6887c3fb880126e60676458e60680.diff L

[PATCH] D93702: [clang][cli] NFC: Make parsing macro reusable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcd1e35e4cc6: [clang][cli] NFC: Make parsing macro reusable (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D93702?v

[PATCH] D94231: [clang][Sema] Compare SourceLocations directly [NFCI]

miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl, rsmith. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The ordered comparison operators are defined for the SourceLocation class, so SourceLocation objects c

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

miyuki updated this revision to Diff 315113. miyuki added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/ https://reviews.llvm.org/D94224 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cp

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315115. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files: clang/include/clang/Basic/DiagnosticOptions.h clang/include

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

sammccall added a comment. Thanks, this looks much better! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:434 +tweakSelection(const Range &Sel, const InputsAndAST &AST, + llvm::vfs::FileSystem *VFS = nullptr) { auto Begin = positionToOffset(AST.Inputs.Co

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315117. jansvoboda11 added a comment. Move the "DiagnosticOpts->" prefix from TableGen definitions to macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; shafik w

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm updated this revision to Diff 315121. david-arm added a comment. - Updated documentation as per review comments. - Fixed an issue with using value->prettyPrint on a null ptr. - Reworked the code that sets vectorize.enable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89031/new

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 315126. Xiangling_L marked 5 inline comments as done. Xiangling_L added a comment. Addressed the comments; Rebased the patch on latest master; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: cla

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315131. jansvoboda11 added a comment. Don't create diagnostics_fixit_info via BoolXxxOption to keep the distinstion of Group and Group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://revi

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1193-1195 +defm caret_diagnostics : BoolFOption<"caret-diagnostics", + "DiagnosticOpts->ShowCarets", DefaultsToTrue, + ChangedBy, ResetBy>, IsDiag; dexonsmith wrote: > There w

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch updated this revision to Diff 315119. kiausch marked an inline comment as done. kiausch added a comment. - enable -mspe if -mefpu2 is defined in clang interface - added clang feature test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92935/new/ https://reviews.llvm.org/D92935 F

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks for all the changes @david-arm! Comment at: clang/lib/AST/AttrImpl.cpp:46 + else if (state == FixedWidth || state == ScalableWidth) { +if (value) { +

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

mantognini added a comment. Looks good overall. Comment at: clang/docs/OpenCLSupport.rst:104 +Clang provides the following new WIP features for the developers to experiment +with and provide early feedback or contribute with further improvements. +Feel free to contact us on `cf

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

steakhal added a comment. Here is a link for our results on a few more projects. It might be useful for you. https://codechecker-demo.eastus.cloudapp.azure.com/Default/runs?run=D92634&items-per-page=50&sort-by=name&sort-desc=false Note: use the diff to filter only for the new reports. Repositor

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks for getting to the bottom of this. Agreed, and also LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93395/new/ https://re

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

HazardyKnusperkeks added a comment. In D94217#2483925 , @rjelonek wrote: > Currently at work we use Embarcadero Builder C++ I'm very sorry for you! (As someone who has (had?) also to use it.) > In builder all above #pragma hdrstop is a precompiled header

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

RatTac reopened this revision. RatTac added a comment. This revision is now accepted and ready to land. This is a great feature. However I found two issues: First issue is with combination of IndentPPDirectives // IndentPPDirectives: BeforeHash // IndentPragmas: true #if defined(WIN32)

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks Comment at: clang/include/clang/AST/TypeLoc.h:1756 + +class VectorTypeLoc : public ConcreteTypeLoc { erichkeane wrote: > fhahn wrote: > > Can we r

[PATCH] D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel.

qiucf added a comment. Can we add tests to `builtins-ppc-altivec.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94162/new/ https://reviews.llvm.org/D94162 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek added a comment. heh, maybe you seen unexpectedly closed IDE, errors while expanding list in source editor or blinking gui, etc ;D I made plugin to use clang-format in Builder. After reading the msvc documentation, I agree with you. `#pragma hdrstop( "c:\\projects\\include\\myinc.pch"

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn added a comment. In D86844#2481922 , @xbolva00 wrote: > int a, b; > > int f(void) { > while (1) { > if (a != b) return 1; > } > return 0; > } > > int g(int a, int b) { > while (1) { > if (a !=

[PATCH] D94237: [clang] Use SourceLocations in unions

miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl, rsmith. Herald added a subscriber: jfb. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, there are many instances where `SourceLocation` objects are

[PATCH] D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: Kai, fanbo-meng, muiez, zibi, hubert.reinterpretcast. Herald added subscribers: wenlei, rupprecht, steven_wu, gbedwell, hiraditya, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: espind

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 __

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added a comment. In D86844#2484568 , @fhahn wrote: > In D86844#2481922 , @xbolva00 wrote: > >> int a, b; >> >> int f(void) { >> while (1) { >> if (a != b) return 1; >> } >>

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

fhahn added subscribers: xbolva00, fhahn. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:799 EmitBoolCondBranch = false; + FnIsMustProgress = false; +} Shouldn't this only apply for C? http://eel.is/c++draft/intro.progress#1

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn added a comment. In D86844#2484639 , @atmnpatel wrote: > I might be misunderstanding the standard here but since 1 is a non-zero > constant expression, it can't be assumed to terminate by the implementation > right? The relevant section from C11 at

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

xbolva00 added a comment. In D86844#2484639 , @atmnpatel wrote: > In D86844#2484568 , @fhahn wrote: > >> In D86844#2481922 , @xbolva00 wrote: >> >>> int a, b; >>> >>>

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

richard.barton.arm accepted this revision. richard.barton.arm added a comment. This revision is now accepted and ready to land. The rationale for this revert looks good to me. I don't see the rationale behind the original change as it was committed without review. If @andrei99 gets back to us th

[clang] 59fce6b - [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

Author: Jeroen Dobbelaere Date: 2021-01-07T17:08:15Z New Revision: 59fce6b0661647062918a47bdb1874950d3938d5 URL: https://github.com/llvm/llvm-project/commit/59fce6b0661647062918a47bdb1874950d3938d5 DIFF: https://github.com/llvm/llvm-project/commit/59fce6b0661647062918a47bdb1874950d3938d5.diff

[PATCH] D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG59fce6b06616: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function… (authored by jeroen.dobbelaere, committed by pratlucas). Herald added a project: clang. Herald added a subscriber:

[PATCH] D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

pratlucas added a comment. No problem! I've pushed the commit on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94233/new/ https://reviews.llvm.org/D94233 ___ cfe-commits mailing list cfe-com

[clang] acbb365 - [AST][NFC] Silence GCC warning about multiline comments

Author: Thomas Preud'homme Date: 2021-01-07T17:11:49Z New Revision: acbb3652931a735a861b756075b1cc86fd041761 URL: https://github.com/llvm/llvm-project/commit/acbb3652931a735a861b756075b1cc86fd041761 DIFF: https://github.com/llvm/llvm-project/commit/acbb3652931a735a861b756075b1cc86fd041761.diff

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

This revision was automatically updated to reflect the committed changes. Closed by commit rGacbb3652931a: [AST][NFC] Silence GCC warning about multiline comments (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https:/

[clang] 43043ad - Add element-type to the Vector TypeLoc types.

Author: Erich Keane Date: 2021-01-07T09:14:36-08:00 New Revision: 43043adcfbc60945646b791d7162e5a1307a5318 URL: https://github.com/llvm/llvm-project/commit/43043adcfbc60945646b791d7162e5a1307a5318 DIFF: https://github.com/llvm/llvm-project/commit/43043adcfbc60945646b791d7162e5a1307a5318.diff L

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG43043adcfbc6: Add element-type to the Vector TypeLoc types. (authored by erichkeane). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D93483?vs=312582&id=315164#toc Rep

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel added a comment. I'm happy to add a patch amending this, the reason it wasn't done that way was because at the time and even now, out of icc/clang/msvc/gcc, gcc seems to be the only one that happily removed such loops in C++ (https://godbolt.org/z/W9vj99), and I didn't have a particul

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek updated this revision to Diff 315166. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clang/unittests/Format/SortIncludesTest.cpp

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315169. rjelonek added a comment. Add support to `#pragma hdrstop( "c:\\projects\\include\\myinc.pch" )' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittest

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

jtmott-intel added a comment. Seems I don't have commit access. I'll look into it. For now, could someone push this commit? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92892/new/ https://reviews.llvm.org/D92892 ___ cfe-commits mail

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

rnk added inline comments. Comment at: clang/lib/CodeGen/CGCXXABI.h:143 /// Returns how an argument of the given record type should be passed. virtual RecordArgABI getRecordArgABI(const CXXRecordDecl *RD) const = 0; nit: I would group the new virtual meth

[clang] d015445 - Silence warning: comparison of integers of different signs: 'const unsigned int' and 'const long' [-Wsign-compare]

Author: Alexandre Ganea Date: 2021-01-07T13:01:06-05:00 New Revision: d0154456e61c5ab79e25fc9b8bb684ebdca3a7c2 URL: https://github.com/llvm/llvm-project/commit/d0154456e61c5ab79e25fc9b8bb684ebdca3a7c2 DIFF: https://github.com/llvm/llvm-project/commit/d0154456e61c5ab79e25fc9b8bb684ebdca3a7c2.dif

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

Anastasia updated this revision to Diff 315173. Anastasia added a comment. Addressed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94188/new/ https://reviews.llvm.org/D94188 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst

  1   2   >