[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

MyDeveloperDay added a comment. Nit: Please just separate your test from old test Comment at: clang/unittests/Format/FormatTest.cpp:12158 "default:\n" + " break;\n" "}", HazardyKnusperkeks wrote: > MyDeveloperDay w

[clang] 95114f2 - [clang][cli] Do not marshall only CC1Option flags in BoolOption

Author: Jan Svoboda Date: 2020-12-16T09:29:40+01:00 New Revision: 95114f21f5bf1704672dadb45ca7c25efca72e03 URL: https://github.com/llvm/llvm-project/commit/95114f21f5bf1704672dadb45ca7c25efca72e03 DIFF: https://github.com/llvm/llvm-project/commit/95114f21f5bf1704672dadb45ca7c25efca72e03.diff L

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95114f21f5bf: [clang][cli] Do not marshall only CC1Option flags in BoolOption (authored by jansvoboda11). Changed prior to commit: https://reviews

[clang] f2661be - [clang][cli] Prevent double denormalization

Author: Jan Svoboda Date: 2020-12-16T09:44:54+01:00 New Revision: f2661bed185e14a8f5aa9a54565a8b938a7a10aa URL: https://github.com/llvm/llvm-project/commit/f2661bed185e14a8f5aa9a54565a8b938a7a10aa DIFF: https://github.com/llvm/llvm-project/commit/f2661bed185e14a8f5aa9a54565a8b938a7a10aa.diff L

[PATCH] D93094: [clang][cli] Prevent double denormalization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2661bed185e: [clang][cli] Prevent double denormalization (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D93094?vs=

[clang] 741978d - [clang][cli] Port CodeGen option flags to new option parsing system

Author: Jan Svoboda Date: 2020-12-16T10:00:33+01:00 New Revision: 741978d727a445fa279d5952a86ea634adb7dc52 URL: https://github.com/llvm/llvm-project/commit/741978d727a445fa279d5952a86ea634adb7dc52 DIFF: https://github.com/llvm/llvm-project/commit/741978d727a445fa279d5952a86ea634adb7dc52.diff L

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG741978d727a4: [clang][cli] Port CodeGen option flags to new option parsing system (authored by jansvoboda11). Changed prior to commit: https://rev

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 312149. vsavchenko added a comment. Turn off conventional check heuristic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files: clang/include/clang/Analysis/Analy

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

steven.zhang added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2668 // ::= g # __float128 + // ::= g # __ibm128 // UNSUPPORTED:::= Dd # IEEE 754r decimal floating point (64 bits) This is a bit confusin

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

joechrisellis updated this revision to Diff 312150. joechrisellis added a comment. Address @c-rhodes's comments. - Add a comment stating that we intend to eliminate going through memory when the element types of the vectors are not the same (for example, with predicates). - Doc comments for the

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG383778e2171b: [clang][cli] Port LangOpts option flags to new option parsing system (authored by jansvoboda11). Changed prior to commit: https://re

[clang] 383778e - [clang][cli] Port LangOpts option flags to new option parsing system

Author: Jan Svoboda Date: 2020-12-16T10:16:27+01:00 New Revision: 383778e2171b4993f555433745466e211e713548 URL: https://github.com/llvm/llvm-project/commit/383778e2171b4993f555433745466e211e713548 DIFF: https://github.com/llvm/llvm-project/commit/383778e2171b4993f555433745466e211e713548.diff L

[clang] f141d1a - [NFC] Pre-commit test for long-double builtins

Author: Qiu Chaofan Date: 2020-12-16T17:19:54+08:00 New Revision: f141d1afc5068d5c5e2c47e25a5d4b4914116b92 URL: https://github.com/llvm/llvm-project/commit/f141d1afc5068d5c5e2c47e25a5d4b4914116b92 DIFF: https://github.com/llvm/llvm-project/commit/f141d1afc5068d5c5e2c47e25a5d4b4914116b92.diff L

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf updated this revision to Diff 312153. qiucf edited the summary of this revision. qiucf added a comment. - Diff based on pre-commit - Restrict to PPC64 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2449236 , @craig.topper wrote: > D91675 has PowerPC only changes to make the > f128 calls get emitted. If you change the frontend in a target independent > way as proposed here, won't th

[clang] 0da240c - [clang][cli] Port DependencyOutput string based options to new option parsing system

Author: Jan Svoboda Date: 2020-12-16T10:28:37+01:00 New Revision: 0da240c2d050303c99564f1901b0d1548ffe2323 URL: https://github.com/llvm/llvm-project/commit/0da240c2d050303c99564f1901b0d1548ffe2323 DIFF: https://github.com/llvm/llvm-project/commit/0da240c2d050303c99564f1901b0d1548ffe2323.diff L

[PATCH] D84187: [clang][cli] Port DependencyOutput string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0da240c2d050: [clang][cli] Port DependencyOutput string based options to new option parsing… (authored by jansvoboda11). Repository: rG LLVM Githu

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 312155. vsavchenko added a comment. Add more info to the docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files: clang/include/clang/Analysis/Analyses/CalledOn

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

jansvoboda11 updated this revision to Diff 312157. jansvoboda11 added a comment. Reduce number of instantiations of denormalizeString template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84186/new/ https://reviews.llvm.org/D84186 Files: clang/

[PATCH] D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly

curdeius accepted this revision. curdeius added a comment. I'd like to see a test with braces inside the try (intoducing scope), just to verify it doesn't break. E.g.: verifyFormat("class A {\n" " int a;\n" " A() try : a(0), b{1}, c{2} {\n" "

[PATCH] D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly

MyDeveloperDay added a comment. In D93296#2457366 , @curdeius wrote: > I'd like to see a test with braces inside the try (intoducing scope), just to > verify it doesn't break. Sure let me add that. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:261-263 /// The inlining stack depth limit. - // Cap the stack depth at 4 calls (5 stack frames, base + 4 calls). - unsigned InlineMaxStackDepth = 5; + unsigned InlineM

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

yroux created this revision. yroux added reviewers: paquette, efriedma, samparker. Herald added a subscriber: inglorion. yroux requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch propagates the -moutline flag when LTO is enabled and

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

steakhal marked an inline comment as done. steakhal added a comment. I want to highlight, that the 4th part of the stack is not yet done. Partially because I'm not quite familiar with CTU. AFAIK, CTU creates compiler invocations, which are going to call Parse at some point. I'm not sure how to co

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org/D92852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

xazax.hun added inline comments. Comment at: clang/lib/Analysis/MacroExpansionContext.cpp:22 +: PP(PP), SM(PP.getSourceManager()), LangOpts(LangOpts) { + class MacroExpansionRangeRecorder : public PPCallbacks { +const Preprocessor &PP; steakhal wrote: >

[PATCH] D93314: [clangd] go-to-definition on auto unwraps array/pointer types

sammccall planned changes to this revision. sammccall added a comment. In D93314#2455884 , @qchateau wrote: > Ah good catch, I agree this is the behavior we want. > > Concerning cases like `unique_ptr`, the only generic behavior I can think > of would be

[PATCH] D93223: [RFC][analyzer] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers

steakhal added a comment. Thanks for the review. Comment at: clang/include/clang/Analysis/PathDiagnostic.h:911 +void createHTMLSingleFileDiagnosticConsumer( +PathDiagnosticConsumerOptions DiagOpts, martong wrote: > Why do we need this prototype here? Than

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:826-833 +static MacroExpansionContext::MacroExpansionText +getExpandedMacro(SourceLocation MacroExpansionLoc, + const cross_tu::CrossTranslationUnitContext &CTU, +

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:685 + } +} + dfukalov wrote: > RKSimon wrote: > > This should probably be pulled out too > It uses `d

[PATCH] D87030: Adapt CastExpr::getSubExprAsWritten to ConstantExpr

sberg added a comment. Ping; OK to submit? (I meanwhile also get this when compiling some code with plain Clang, not just with the LibreOffice Clang plugin where I saw it originally.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87030/new/ https://reviews.llvm.org/D87030 __

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:248 +template ::value, bool> = true> static void denormalizeSimpleEnum(SmallVectorImpl &Args, dexonsmith wrote: > I don't think this needs to be templated; it can just use

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 312171. jansvoboda11 added a comment. Remove template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84668/new/ https://reviews.llvm.org/D84668 Files: clang/include/clang/Driver/Options.td clang/lib/Fr

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

seanyoung updated this revision to Diff 312172. seanyoung added a comment. Add tests cases for _ExtInt on BPF. This makes the _ExtInt testing equivalent to the testing on every platform except x86-64. The use-case is to use _ExtInt on BPF when targeting Solana BPF smart contracts. I am writing

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

whisperity added inline comments. Comment at: clang/lib/Analysis/MacroExpansionContext.cpp:22 +: PP(PP), SM(PP.getSourceManager()), LangOpts(LangOpts) { + class MacroExpansionRangeRecorder : public PPCallbacks { +const Preprocessor &PP; xazax.hun wrote:

[PATCH] D84670: Port HeaderSearch simple string options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

xazax.hun added inline comments. Comment at: clang/lib/Analysis/MacroExpansionContext.cpp:22 +: PP(PP), SM(PP.getSourceManager()), LangOpts(LangOpts) { + class MacroExpansionRangeRecorder : public PPCallbacks { +const Preprocessor &PP; whisperity wrote:

[clang] dad07ba - [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

Author: Joe Ellis Date: 2020-12-16T12:24:32Z New Revision: dad07baf123e672b1d5d5e7c21e73b92399d5a0c URL: https://github.com/llvm/llvm-project/commit/dad07baf123e672b1d5d5e7c21e73b92399d5a0c DIFF: https://github.com/llvm/llvm-project/commit/dad07baf123e672b1d5d5e7c21e73b92399d5a0c.diff LOG: [cl

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdad07baf123e: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts (authored by joechrisellis). Repository: rG LLVM Github Mon

[PATCH] D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system

jansvoboda11 updated this revision to Diff 312176. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84670/new/ https://reviews.llvm.org/D84670 Files: clang/include/clang/Driver/

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG! Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400 +DiagCallback Handler) { + llvm::yaml::Input Input(Config, nu

[PATCH] D93314: [clangd] go-to-definition on auto unwraps array/pointer types

qchateau added a comment. > So I'm leaning towards defining these behaviors for **pointers and > containers** rather than **templates** per se. There's a nice symmetry with > the raw pointer and array types that this patch. > (We have some precedent and code for detecting smart pointers, see >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

thakis added a comment. In D91980#2456637 , @jdoerfert wrote: > In D91980#2456600 , @thakis wrote: > >> In addition to the build error, it also broke check-clang everywhere as far >> as I can tell. >> mac: http://4

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This patch fixes the following problem: - open a file with references to

[PATCH] D91944: OpenMP 5.0 metadirective

dreachem added a comment. In D91944#2414364 , @jdoerfert wrote: > This looks close to an OpenMP 5.0 implementation. I left comments inlined. > > We need tests that show how non-selected alternatives *do not* impact the > program. As an example, a template

[PATCH] D84671: Port LangOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D84671: Port LangOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 312192. jansvoboda11 added a comment. Rebase, move options to their original lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84671/new/ https://reviews.llvm.org/D84671 Files: clang/include/clang/Bas

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1321 let Documentation = [NoMergeDocs]; + let Subjects = SubjectList<[Function], ErrorDiag>; + let SimpleHandler = 1; Related to my comments in ClangAttrEmitter.cpp, I think y

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall updated this revision to Diff 312193. sammccall marked 7 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92663/new/ https://reviews.llvm.org/D92663 Files: clang-tools-e

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:206 + auto Stat = FS.status(Path); + if (!Stat || !Stat->isRegularFile()) { +Size = NoFileCached; adamcz wrote: > Here's a fun thought: what if this is a net

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield updated this revision to Diff 312196. JonChesterfield added a comment. - Remove hard coded version numbers in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 Files: clang/include/cla

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2907 +// start with it. +llvm::SmallVector Stack{DynTypedNode::create(*BugStmt)}; + jkorous wrote: > Since IIUC a node can have multiple parents - does that mean w

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity added a reviewer: aaron.ballman. whisperity added a comment. Right, let's bump. I've checked the output of the checker on a set of test projects (our usual testbed, I should say) which contains around 15 projects, half of which was C and the other half C++. All projects were analysed

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes the `-f[no-]trapping-math` flags from

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3080 } Opts.setFPExceptionMode(FPEB); The parsing of `OPT_ftrapping_math` and `OPT_fno_trapping_math` is immediately overwritten here. Repository: rG LLVM Githu

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity added a comment. But of course, after having written all of that, I forgot to upload the results themselves... 😲 F14738535: SuspiciousCall.sqlite Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20689/n

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval added a comment. Ping since there was a phab email delivery problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://reviews.llvm.org/D92955 ___ cfe-commits mailing list cfe-c

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield added a comment. @yaxunl Please see Gerrit 456139 for a close approximation to the test changes here. I don't think hip should be hard coding a version number in tests that don't care about it, so would like to move trunk and internal to a regex. Repository: rG LLVM Github Mo

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

jansvoboda11 added a reviewer: SjoerdMeijer. jansvoboda11 added a subscriber: SjoerdMeijer. jansvoboda11 added a comment. Tagging @SjoerdMeijer, as these flags were pulled into the `-cc1` command-line in his patch: D23840 . Repository: rG LLVM Github Monorepo

[clang] 95b2dab - [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

Author: Erik Pilkington Date: 2020-12-16T10:01:24-05:00 New Revision: 95b2dab199100f5a86d3f73a995afea879886d65 URL: https://github.com/llvm/llvm-project/commit/95b2dab199100f5a86d3f73a995afea879886d65 DIFF: https://github.com/llvm/llvm-project/commit/95b2dab199100f5a86d3f73a995afea879886d65.dif

[clang] 92d6e80 - NFC: balance a quote in AttrDocs.td

Author: Erik Pilkington Date: 2020-12-16T10:01:24-05:00 New Revision: 92d6e8001e20d6d0f457ac7cab8b64f3b1a131bf URL: https://github.com/llvm/llvm-project/commit/92d6e8001e20d6d0f457ac7cab8b64f3b1a131bf DIFF: https://github.com/llvm/llvm-project/commit/92d6e8001e20d6d0f457ac7cab8b64f3b1a131bf.dif

[PATCH] D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG95b2dab19910: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to… (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

aaron.ballman added a comment. Is the attribute considered to be a property of the parameter or a property of the function the parameter is declared in? e.g., void someOtherFunc(void (^cb)(void)) { if (something()) cb(); } void barWithCallback(void (^callback)(void) __attribut

[PATCH] D84672: Port PreprocessorOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D84672: [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 312205. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84672/new/ https://reviews.llvm.org/D84672 Files: clang/include/clang/Driver/

[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

adamcz updated this revision to Diff 312206. adamcz marked an inline comment as done. adamcz added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93220/new/ https://reviews.llvm.org/D93220 Files: clang-tools-extra/clan

[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:193 +} else { + elog("Code completion header path manipulation failed {0}", + HeaderFile.takeError()); sammccall wrote: > I think this is too noisy.

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2897 + ASTContext &AC) { + PathDiagnosticLocation Location = BR.getLocation(); + What will this location return?

[PATCH] D93258: [amdgpu] Default to code object v3

yaxunl added a comment. Thanks for fixing the lit tests. Using regex is the right choice. Do we have a plan about how to merge this to amd-stg-open? Will it cause ePSDB to fail? Do you have a follow up patch to make amd-stg-open happy? Thanks. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

kito-cheng added a comment. Do you have implement register pair for rv32ifd_zfinx? I didn't saw the related implementation, but I could be wrong since I am not LLVM expert, in case you have implemented, you need a test case for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D93068: [clang-offload-bundler] Add option -allow-missing-bundles

yaxunl marked 2 inline comments as done. yaxunl added a comment. @ABataev Is this patch OK for OpenMP? It is NFC for OpenMP toolchain but affects using clang-offload-bundler as a standalone tool. Thanks. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:112

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

whisperity added a comment. Herald added a subscriber: shchenz. In D69560#2319340 , @aaron.ballman wrote: > Congrats on the SCAM acceptance, I hope the presentation goes well! The entire event was amazing, even if short. There was another paper which se

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

JonChesterfield created this revision. JonChesterfield added a reviewer: yaxunl. JonChesterfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] Use regex for code object version in hip tests Extracted from D93258

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield added a comment. In D93258#2457905 , @yaxunl wrote: > Thanks for fixing the lit tests. Using regex is the right choice. > > Do we have a plan about how to merge this to amd-stg-open? Will it cause > ePSDB to fail? Do you have a follow up p

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

t-tye added inline comments. Comment at: clang/test/Driver/hip-code-object-version.hip:56 -// V4: "-mllvm" "--amdhsa-code-object-version=4" -// V4: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906" +// VD: "-mllvm" "--amdhsa-code-object-version=4" +// VD: "-tar

[PATCH] D91444: [InstCombine] Preserve !annotation metadata for memory combines.

fhahn updated this revision to Diff 312216. fhahn added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D91444#2394512 , @lebedev.ri wrote: > What about teaching IRBuilder to deal with it like it deals with debugloc? D

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

t-tye added inline comments. Comment at: clang/test/Driver/hip-code-object-version.hip:56 -// V4: "-mllvm" "--amdhsa-code-object-version=4" -// V4: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906" +// VD: "-mllvm" "--amdhsa-code-object-version=4" +// VD: "-tar

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added a comment. In D92039#2457867 , @aaron.ballman wrote: > Is the attribute considered to be a property of the parameter or a property > of the function the parameter is declared in? e.g., > > void someOtherFunc(void (^cb)(void)) { > i

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

probinson added a comment. One thing this patch does, is make decisions about default behavior static. Meaning, the option behavior cannot depend on other options; specifically, it can't be based on the triple, which allows target-specific customization. PS4 certainly has cases where our defa

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

JonChesterfield added inline comments. Comment at: clang/test/Driver/hip-code-object-version.hip:56 -// V4: "-mllvm" "--amdhsa-code-object-version=4" -// V4: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906" +// VD: "-mllvm" "--amdhsa-code-object-version=4" +//

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for options -D and -U in the Flang driver along with a regressio

[PATCH] D93031: Enable fexec-charset option

tahonermann added inline comments. Comment at: clang/include/clang/Driver/Options.td:3583-3584 +def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">, + HelpText<"Set the execution for string and character literals">; def target_cpu : Separate<["-"], "target

[PATCH] D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines

0x1eaf created this revision. 0x1eaf added reviewers: alexfh, njames93, aaron.ballman. 0x1eaf added projects: clang, clang-tools-extra. Herald added subscribers: lxfind, modocache, xazax.hun. 0x1eaf requested review of this revision. Herald added a subscriber: cfe-commits. We have an internal bug

[PATCH] D93356: [libomptarget][amdgpu] Call into deviceRTL instead of ockl

JonChesterfield planned changes to this revision. JonChesterfield added a comment. There's a codegen test that checks for __ockl_get_local_size. Testing a change to that test out of tree now, probably need to update said test before landing this. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert accepted this revision. jdoerfert added a comment. LGTM still Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://reviews.llvm.org/D92955 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. In D91944#2457744 , @dreachem wrote: > In D91944#2414364 , @jdoerfert wrote: > >> This looks close to an OpenMP 5.0 implementation. I left comments inlined. >> >> We need tests that show h

[PATCH] D93031: Enable fexec-charset option

tahonermann added inline comments. Comment at: clang/test/CodeGen/systemz-charset.c:4 + +char *UpperCaseLetters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; +// CHECK: c"\C1\C2\C3\C4\C5\C6\C7\C8\C9\D1\D2\D3\D4\D5\D6\D7\D8\D9\E2\E3\E4\E5\E6\E7\E8\E9\00" `const char *` please

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93398/new/ https://reviews.llvm.org/D93398 ___ cfe

[clang] c0619d3 - [NFC] Use regex for code object version in hip tests

Author: Jon Chesterfield Date: 2020-12-16T17:00:19Z New Revision: c0619d3b21cd420b9faf15f14db0816787c44ded URL: https://github.com/llvm/llvm-project/commit/c0619d3b21cd420b9faf15f14db0816787c44ded DIFF: https://github.com/llvm/llvm-project/commit/c0619d3b21cd420b9faf15f14db0816787c44ded.diff L

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

sammccall added a comment. TL;DR: Cool! I think we should complicate the signature of `hasFile()` a bit to avoid calling SwapIndex::snapshot() for each file. There's also some quadratic behavior due to calling index ops from MergeIndex when children are MergeIndexes, but N is small and I think

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0619d3b21cd: [NFC] Use regex for code object version in hip tests (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:193 +} else { + elog("Code completion header path manipulation failed {0}", + H

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

tmatheson updated this revision to Diff 312232. tmatheson added a comment. Herald added a subscriber: jdoerfert. Extended to Objective-C methods and properties. Added suggested C tests, C++ template function test and Objective-C tests. I had to removed PSF_Implicit flag so that cases where the fun

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield updated this revision to Diff 312236. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

bsaleil updated this revision to Diff 312238. bsaleil added a comment. Rebase and fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91974/new/ https://reviews.llvm.org/D91974 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/C

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added a comment. In D90159#2454905 , @bmahjour wrote: > In D90159#2453805 , @Meinersbur > wrote: > >> Can I help fixing the Windows build problem? > > I think I have a fix (please see the updated patch), b

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

tmatheson marked 3 inline comments as done. tmatheson added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3048 D->addAttr(NewAttr); +if (auto FD = dyn_cast(D)) + if (auto SA = dyn_cast(NewAttr)) aaron.ballman wrote: > Does this need t

[clang] 6eff127 - [DDG] Data Dependence Graph - DOT printer - recommit

Author: Bardia Mahjour Date: 2020-12-16T12:37:36-05:00 New Revision: 6eff12788ee8d3f85f6e57809e757ca3250813d8 URL: https://github.com/llvm/llvm-project/commit/6eff12788ee8d3f85f6e57809e757ca3250813d8 DIFF: https://github.com/llvm/llvm-project/commit/6eff12788ee8d3f85f6e57809e757ca3250813d8.diff

[PATCH] D87146: [analyzer] Implement shared semantics checks for XNU functions in PthreadLockChecker

ASDenysPetrov added a comment. Hey, folk. Please, look at this revision. This is the **2nd** revision from the //stack of 3//. Its aim is preparing the field for the **3rd** revision (also welcome to review). The **1st** one has been closed. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D93068: [clang-offload-bundler] Add option -allow-missing-bundles

ABataev added a comment. In D93068#2457946 , @yaxunl wrote: > @ABataev Is this patch OK for OpenMP? It is NFC for OpenMP toolchain but > affects using clang-offload-bundler as a standalone tool. Thanks. Yes, I think it is ok. CHANGES SINCE LAST ACTION

  1   2   >