tahonermann added inline comments.
================ Comment at: clang/test/CodeGen/systemz-charset.c:4 + +char *UpperCaseLetters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; +// CHECK: c"\C1\C2\C3\C4\C5\C6\C7\C8\C9\D1\D2\D3\D4\D5\D6\D7\D8\D9\E2\E3\E4\E5\E6\E7\E8\E9\00" ---------------- `const char *` please :) ================ Comment at: clang/test/CodeGen/systemz-charset.c:24 +//CHECK: c"abc\00" + +char singleChar = 'a'; ---------------- Add validation of UCNs. Something like: const char *UcnCharacters = "\u00E2\u00AC\U000000DF"; // CHECK: c"\42\B0\59\00" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D93031 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
