[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:53 namespace clang { +namespace tidy { +/// Returns if a clang tidy \p Check has been registered. nit: if this is in the clangd code, it should be in the clangd namespace (i

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 311930. vsavchenko added a comment. Introduce a suppression for double call warning by nullifying the parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 File

[clang] 5a2a836 - [AArch64][NEON] Remove undocumented vceqz{, q}_p16, vml{a,s}q_n_f64 intrinsics

Author: Joe Ellis Date: 2020-12-15T17:19:16Z New Revision: 5a2a8369e82cea9689b0ff60f3e9baa7fc79fbcf URL: https://github.com/llvm/llvm-project/commit/5a2a8369e82cea9689b0ff60f3e9baa7fc79fbcf DIFF: https://github.com/llvm/llvm-project/commit/5a2a8369e82cea9689b0ff60f3e9baa7fc79fbcf.diff LOG: [AA

[PATCH] D93206: [AArch64][NEON] Remove undocumented vceqz{,q}_p16, vml{a,s}q_n_f64 intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2a8369e82c: [AArch64][NEON] Remove undocumented vceqz{,q}_p16, vml{a,s}q_n_f64 intrinsics (authored by joechrisellis). Repository: rG LLVM Githu

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 updated this revision to Diff 311934. njames93 marked 3 inline comments as done. njames93 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92990/new/ https://reviews.llvm.org/D92990 Files: clang-tools-ext

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311937. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove the race between ConnectionStatus access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 311938. DavidTruby added a comment. Add additional callee-side tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 Files: clang/lib/CodeGen/CGCXXABI.cpp clang/

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311939. kbobyrev added a comment. Cleanup includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp Index: c

[PATCH] D93314: [clangd] go-to-definition on auto unwraps array/pointer types

sammccall created this revision. sammccall added a reviewer: qchateau. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Mo

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311942. kbobyrev added a comment. Cleanup rebase artifact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp I

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added inline comments. Comment at: llvm/utils/update_analyze_test_checks.py:129 + +common.warn_on_failed_prefixes(func_dict) is_in_function = False pengfei wrote: > Can we move these warn to common.py? Come to think of it, maybe moving it to

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311943. kbobyrev added a comment. Actually clean up rebase artifacts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Cl

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

sammccall added a comment. I sent you D93314 to extend the getNonReferenceType() a bit... curious what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92977/new/ https://reviews.llvm.org/D92977 __

[clang-tools-extra] dcdef5b - [clangd] Log remote index connectivity status

Author: Kirill Bobyrev Date: 2020-12-15T18:29:48+01:00 New Revision: dcdef5b5b3df457566e7faf61e1e5789c42528d1 URL: https://github.com/llvm/llvm-project/commit/dcdef5b5b3df457566e7faf61e1e5789c42528d1 DIFF: https://github.com/llvm/llvm-project/commit/dcdef5b5b3df457566e7faf61e1e5789c42528d1.diff

[PATCH] D92198: [clangd] Log remote index connectivity status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcdef5b5b3df: [clangd] Log remote index connectivity status (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

adamcz added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:206 + auto Stat = FS.status(Path); + if (!Stat || !Stat->isRegularFile()) { +Size = NoFileCached; Here's a fun thought: what if this is a network or otherwise m

[PATCH] D93314: [clangd] go-to-definition on auto unwraps array/pointer types

sammccall added a comment. We don't do this kind of unwrapping in targetDecl() because it seems a bit sloppy/approximate, but in this case the full type isn't written, so you can't choose to target the `Foo` rather than the `*` in `Foo *`. Do you think we should try to handle unique_ptr/shared_

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:27 +static llvm::Optional +bestGuess(llvm::StringRef Search, (nit: no need for static

[clang] 67a1ffd - [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.

Author: Kevin P. Neal Date: 2020-12-15T12:38:10-05:00 New Revision: 67a1ffd88ac08526bb6cfc7b3f607e6668ba1c70 URL: https://github.com/llvm/llvm-project/commit/67a1ffd88ac08526bb6cfc7b3f607e6668ba1c70 DIFF: https://github.com/llvm/llvm-project/commit/67a1ffd88ac08526bb6cfc7b3f607e6668ba1c70.diff

[PATCH] D93134: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67a1ffd88ac0: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp… (authored by kpn). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:58 + assert(!Check.contains('*') && "isRegisteredCheck doesn't support globs"); + assert(Check.trim().size() == Check.size() && + "Check has

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 updated this revision to Diff 311948. njames93 marked 2 inline comments as done. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92874/new/ https://reviews.llvm.org/D92874 Files: clang-tools-extr

[clang-tools-extra] 32e7a9c - Revert "[clangd] Log remote index connectivity status"

Author: Kirill Bobyrev Date: 2020-12-15T18:42:42+01:00 New Revision: 32e7a9cab6412cb4bb5add5cb2d48be82e7d9f11 URL: https://github.com/llvm/llvm-project/commit/32e7a9cab6412cb4bb5add5cb2d48be82e7d9f11 DIFF: https://github.com/llvm/llvm-project/commit/32e7a9cab6412cb4bb5add5cb2d48be82e7d9f11.diff

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 updated this revision to Diff 311949. njames93 marked 2 inline comments as done. njames93 added a comment. Last nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92990/new/ https://reviews.llvm.org/D92990 Files: clang-tools-extra/clan

[PATCH] D93134: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.

thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/35362/step_7.txt PTAL, and if it takes a while to fix please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93134/new/ https://reviews.llvm.org/

[clang] 2ec5973 - Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute."

Author: Kevin P. Neal Date: 2020-12-15T12:58:47-05:00 New Revision: 2ec5973fddb07e66ae0df7d0aac2cda55387b0bd URL: https://github.com/llvm/llvm-project/commit/2ec5973fddb07e66ae0df7d0aac2cda55387b0bd DIFF: https://github.com/llvm/llvm-project/commit/2ec5973fddb07e66ae0df7d0aac2cda55387b0bd.diff

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 ___ c

[clang-tools-extra] cfa1010 - [clangd] Provide suggestions with invalid config keys

Author: Nathan James Date: 2020-12-15T18:16:17Z New Revision: cfa1010c42429f689186125270dfbad7d6a1c01d URL: https://github.com/llvm/llvm-project/commit/cfa1010c42429f689186125270dfbad7d6a1c01d DIFF: https://github.com/llvm/llvm-project/commit/cfa1010c42429f689186125270dfbad7d6a1c01d.diff LOG:

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfa1010c4242: [clangd] Provide suggestions with invalid config keys (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311961. tmroeder added a comment. Explicitly instantiate the templates in the structural-equivalence test. This seems to work correctly on Windows, and it avoids the need for the extra hooks in the test framework. So, this diff removes those hooks as well a

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

bsaleil added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1427 + if (Target.getTriple().isPPC64() && + Target.hasFeature("paired-vector-memops")) { +if (Target.hasFeature("mma")) { amyk wrote: > Is it better to do `hasFeature()` over `Pair

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. Left a couple of nits but mostly LGTM, cheers Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2025-2051 // Perform VLAT <-> VLST bitcast through memory. if ((isa

[PATCH] D93324: Avoid isImplicit call on object which could be nullptr

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A callExpr whose argument is dependent has a null getCalleeDecl(). Repository: rG LLVM Github Monorepo h

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

clementval added inline comments. Comment at: clang/include/clang/Driver/Options.td:4629 -} // let Flags = [CC1Option] +} // let Flags = [CC1Option, NoDriverOption] + Is it intended to modify the SYCL options? Comment at: flang/lib/Frontend/

[PATCH] D93325: Add srcloc output to clang-query

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93325 Files: clang-tools-extra/clang-quer

[PATCH] D93324: Avoid isImplicit call on object which could be nullptr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93324/new/ https://reviews.llvm.org/D93324 __

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/ https://reviews.llvm.org/D92756 __

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400 +DiagCallback Handler) { + llvm::yaml::Input Input(Config, nullptr, Handler ? diagHandlerImpl : nullptr, + &Handler); -

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:40 : TargetInfo(Triple), HasM(false), HasA(false), HasF(false), HasD(false), -HasC(false), HasB(false), HasV(false), HasZfh(false) { LongDoubleWidth = 128; We real

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

rnk added a comment. Thanks for the fix. At first, misunderstood, I expected that an aggregate containing non-aggregates should be returned indirectly, and that the fix would be in the C++ ABI codepath. However, I see that is not the case. An aggregate may contain non-aggregates, and MSVC will

[clang-tools-extra] 0545680 - Reland dcdef5b5b3df457566e7faf61e1e5789c42528d1

Author: Kirill Bobyrev Date: 2020-12-15T20:54:55+01:00 New Revision: 0545680cb870f1ca81198cd8324814543eb79e64 URL: https://github.com/llvm/llvm-project/commit/0545680cb870f1ca81198cd8324814543eb79e64 DIFF: https://github.com/llvm/llvm-project/commit/0545680cb870f1ca81198cd8324814543eb79e64.diff

[clang] ef40d52 - Adding a test case that I accidentally dropped from 27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6

Author: Aaron Ballman Date: 2020-12-15T14:56:44-05:00 New Revision: ef40d5233b8b6f82927128c5b255cdc3aed9021d URL: https://github.com/llvm/llvm-project/commit/ef40d5233b8b6f82927128c5b255cdc3aed9021d DIFF: https://github.com/llvm/llvm-project/commit/ef40d5233b8b6f82927128c5b255cdc3aed9021d.diff

[clang] 76edf98 - Set decl on DeclRefExpr directly during deserialization rather than

Author: Richard Smith Date: 2020-12-15T12:00:57-08:00 New Revision: 76edf98b27c45f1aa26c1972927ce1638cda50fd URL: https://github.com/llvm/llvm-project/commit/76edf98b27c45f1aa26c1972927ce1638cda50fd DIFF: https://github.com/llvm/llvm-project/commit/76edf98b27c45f1aa26c1972927ce1638cda50fd.diff

[clang] 6c365cd - Consider reference, pointer, and pointer-to-member TemplateArguments to be different if they have different types.

Author: Richard Smith Date: 2020-12-15T12:00:57-08:00 New Revision: 6c365cd31e323d2d075573edd927e4f7fb5ec01c URL: https://github.com/llvm/llvm-project/commit/6c365cd31e323d2d075573edd927e4f7fb5ec01c DIFF: https://github.com/llvm/llvm-project/commit/6c365cd31e323d2d075573edd927e4f7fb5ec01c.diff

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman added a comment. In D72241#2449426 , @ffrankies wrote: > @aaron.ballman Thank you! If there are no further comments, could you please > commit this on my behalf? My GitHub username is ffrankies > . I'd be happ

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

wchilders requested changes to this revision. wchilders added a comment. This revision now requires changes to proceed. I'm still "chewing on this", I'm not sure I fully understand the problem well enough to give great "big picture" feedback. In any case, I've left a few comments where I had a p

[PATCH] D93314: [clangd] go-to-definition on auto unwraps array/pointer types

qchateau added a comment. Ah good catch, I agree this is the behavior we want. Concerning cases like `unique_ptr`, the only generic behavior I can think of would be to suggest multiple `LocatedSymbol` when `auto` is deduced to a template class: the template class itself, and all its template ty

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. In D93240#2454268 , @MyDeveloperDay wrote: > I generally don't have the same aversion to new options than others have, but > can you point out a style guide that mig

[PATCH] D93333: tidy: supress warning for default member funcs

cwarner-8702 created this revision. cwarner-8702 added reviewers: clang-tools-extra, alexfh_, malcolm.parsons. cwarner-8702 added a project: clang-tools-extra. Herald added subscribers: kbarton, nemanjai. cwarner-8702 requested review of this revision. Herald added a project: clang. Herald added a

[clang] c103f9e - [RISCV] Use default member initializers for the feature flags in RISCVTargetInfo. NFC

Author: Craig Topper Date: 2020-12-15T12:37:47-08:00 New Revision: c103f9ef5a0e3180db8c9e94f9cd0b0e2a65375f URL: https://github.com/llvm/llvm-project/commit/c103f9ef5a0e3180db8c9e94f9cd0b0e2a65375f DIFF: https://github.com/llvm/llvm-project/commit/c103f9ef5a0e3180db8c9e94f9cd0b0e2a65375f.diff

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3048 D->addAttr(NewAttr); +if (auto FD = dyn_cast(D)) + if (auto SA = dyn_cast(NewAttr)) Does this need to be limited to function declarations? It seems to me that this

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one minor comment. Do you have commit access? If not, I can merge for you; please specify your preferred git "Author" line. Comment at: clang/test/CodeGenCXX

[clang-tools-extra] dfac97d - [clangd] Validate clang-tidy Checks in clangd config.

Author: Nathan James Date: 2020-12-15T21:10:57Z New Revision: dfac97d557690dd4b1f2fab798680234b238d11f URL: https://github.com/llvm/llvm-project/commit/dfac97d557690dd4b1f2fab798680234b238d11f DIFF: https://github.com/llvm/llvm-project/commit/dfac97d557690dd4b1f2fab798680234b238d11f.diff LOG:

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfac97d55769: [clangd] Validate clang-tidy Checks in clangd config. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 57d83c3 - [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

Author: Baptiste Saleil Date: 2020-12-15T15:14:11-06:00 New Revision: 57d83c3a90c427ad0975803feb5b348d1ad34e29 URL: https://github.com/llvm/llvm-project/commit/57d83c3a90c427ad0975803feb5b348d1ad34e29 DIFF: https://github.com/llvm/llvm-project/commit/57d83c3a90c427ad0975803feb5b348d1ad34e29.dif

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. bsaleil marked an inline comment as done. Closed by commit rG57d83c3a90c4: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled (authored by bsaleil)

[clang-tools-extra] 68e642c - [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

Author: Nathan James Date: 2020-12-15T21:15:16Z New Revision: 68e642cad02468ce3efb18e7648cf82f2611e7a3 URL: https://github.com/llvm/llvm-project/commit/68e642cad02468ce3efb18e7648cf82f2611e7a3 DIFF: https://github.com/llvm/llvm-project/commit/68e642cad02468ce3efb18e7648cf82f2611e7a3.diff LOG:

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68e642cad024: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions. (authored by njames93). Repository: rG LLVM Github Mono

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5095 +Clang implements a check for ``called_once`` parameters, +``-Wcalled-once-parameter``. It is on by default and finds the following +violations: Comme

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. One last point, is there a way to validate that these options are only set where it makes sense. If someone tries to use say `MacroDefinitionHungarianPrefix` That could be warning worthy? Comment at: clang-tools-extra/clang-tidy/readability/Identifi

[clang] 59decf8 - [clang] Migrate deprecated DebugInfo::get to DILocation::get

Author: Fangrui Song Date: 2020-12-15T13:59:31-08:00 New Revision: 59decf8e9c3d86472073266ad8ee1cc699d94525 URL: https://github.com/llvm/llvm-project/commit/59decf8e9c3d86472073266ad8ee1cc699d94525 DIFF: https://github.com/llvm/llvm-project/commit/59decf8e9c3d86472073266ad8ee1cc699d94525.diff

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 312023. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/lib/Tooling/CMakeLists.txt clang/lib/Tooling/DumpTool/APIData

[PATCH] D93164: [AST] Add generator for source location introspection

steveire added a comment. > Do I understand correctly that the workflow is to use the new dumping tool to > generate the needed JSON file that then gets used as input to > generate_cxx_src_locs.py which creates NodeLocationIntrospection.cpp/.h that > then gets used by clang-query (eventually)?

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 312024. steveire marked 19 inline comments as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/lib/Tooling/CMakeLi

[PATCH] D93164: [AST] Add generator for source location introspection

steveire marked 3 inline comments as done. steveire added inline comments. Comment at: clang/lib/Tooling/DumpTool/ASTSrcLocProcessor.cpp:40 + // TODO: Extend this with other clades + namedDecl(hasName("clang::Stmt")).bind("nodeClade")), + option

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91129/new/ https://reviews.llvm.org/D91129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

shivanshu3 added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91659/new/ https://reviews.llvm.org/D91659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 0eb4378 - Frontend: Fix confusing comment at call to clearOutputFiles, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-15T14:21:37-08:00 New Revision: 0eb4378290ffcd5da650217df3ac3b8c473d5ed6 URL: https://github.com/llvm/llvm-project/commit/0eb4378290ffcd5da650217df3ac3b8c473d5ed6 DIFF: https://github.com/llvm/llvm-project/commit/0eb4378290ffcd5da650217df3ac3b8c473d

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 312026. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/lib/Tooling/CMakeLists.txt clang/lib/Tooling/DumpTool/APIData

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 312027. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/lib/Tooling/CMakeLists.txt clang/lib/Tooling/DumpTool/APIData

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for your work, I am glad that finally the Window bug is fixed with a simple solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D926

[PATCH] D93094: [clang][cli] Prevent double denormalization

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too, once the test is fixed. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267 - ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager"))); + ASSERT_EQ(count(GeneratedArgs, "-fde

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

rsmith added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2267-2280 +SourceLocation OpTokLoc = OpTok.getLocation(); +if (OpTokLoc.isMacroID()) { + SourceLocation OpTokExpansionLoc = + PP.getSourceManager().getFileLoc(OpTokLoc);

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 312033. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/lib/Tooling/CMakeLists.txt clang/lib/Tooling/DumpTool/APIData

[clang] c4736b9 - Don't memcpy from an empty ArrayRef; the base pointer could be null, and

Author: Richard Smith Date: 2020-12-15T14:37:52-08:00 New Revision: c4736b91f87e9163edcdef78891398f32390ffc2 URL: https://github.com/llvm/llvm-project/commit/c4736b91f87e9163edcdef78891398f32390ffc2 DIFF: https://github.com/llvm/llvm-project/commit/c4736b91f87e9163edcdef78891398f32390ffc2.diff

[PATCH] D93164: [AST] Add generator for source location introspection

steveire added a subscriber: thakis. steveire added a comment. @thakis FYI - I think the GN build would need to be adapted to this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 __

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:248 +template ::value, bool> = true> static void denormalizeSimpleEnum(SmallVectorImpl &Args, I don't think this needs to be templated; it can just use the same prototype it

[PATCH] D84190: [clang][cli] Port FrontendOpts simple string based options to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84190/new/ https://reviews.llvm.org/D84190

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 312039. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/lib/Tooling/CMakeLists.txt clang/lib/Tooling/DumpTool/APIData

[PATCH] D84187: [clang][cli] Port DependencyOutput string based options to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84187/new/ https://reviews.llvm.org/D84187

[clang] b9c7754 - [Clang][Attr] Introduce the `assume` function attribute

Author: Johannes Doerfert Date: 2020-12-15T16:51:34-06:00 New Revision: b9c77542e23756967e77dc42412effc41257a850 URL: https://github.com/llvm/llvm-project/commit/b9c77542e23756967e77dc42412effc41257a850 DIFF: https://github.com/llvm/llvm-project/commit/b9c77542e23756967e77dc42412effc41257a850.d

[clang] a5a14cb - [OpenMP] Add initial support for `omp [begin/end] assumes`

Author: Johannes Doerfert Date: 2020-12-15T16:51:34-06:00 New Revision: a5a14cbe7f87e01882ecaa14df5d596cbf38823a URL: https://github.com/llvm/llvm-project/commit/a5a14cbe7f87e01882ecaa14df5d596cbf38823a DIFF: https://github.com/llvm/llvm-project/commit/a5a14cbe7f87e01882ecaa14df5d596cbf38823a.d

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9c77542e237: [Clang][Attr] Introduce the `assume` function attribute (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5a14cbe7f87: [OpenMP] Add initial support for `omp [begin/end] assumes` (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 6b760a5 - DR2100: &expr is value-dependent if expr constant-evaluates to a

Author: Richard Smith Date: 2020-12-15T14:53:26-08:00 New Revision: 6b760a50f52142e401a6380ff71f933cda22a909 URL: https://github.com/llvm/llvm-project/commit/6b760a50f52142e401a6380ff71f933cda22a909 DIFF: https://github.com/llvm/llvm-project/commit/6b760a50f52142e401a6380ff71f933cda22a909.diff

[clang] 7e7f38f - DR1413 and part of P1815R2: Minor improvements to Clang's determination

Author: Richard Smith Date: 2020-12-15T14:53:26-08:00 New Revision: 7e7f38f853fbf96c6ab2a0e5f9d7747ef8a76ffe URL: https://github.com/llvm/llvm-project/commit/7e7f38f853fbf96c6ab2a0e5f9d7747ef8a76ffe DIFF: https://github.com/llvm/llvm-project/commit/7e7f38f853fbf96c6ab2a0e5f9d7747ef8a76ffe.diff

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

dexonsmith added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:261-263 /// The inlining stack depth limit. - // Cap the stack depth at 4 calls (5 stack frames, base + 4 calls). - unsigned InlineMaxStackDepth = 5; + unsigned InlineMax

Re: [PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

Thanks for reverting; sorry I missed your email. > On 2020 Dec 14, at 19:27, Nico Weber via Phabricator > wrote: > > thakis added a comment. > > The revert helped, check-clang is no longer failing on Windows. > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > htt

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre created this revision. thopre added reviewers: zbrid, chandlerc, EricWF. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix use of undefined variable in CHECK-NOT directive in clang test CodeGen/attr-speculative-load-hardenin

[PATCH] D78938: Make LLVM build in C++20 mode

MaskRay added a comment. @BRevzin Please share your name and email if you want someone to commit it for you https://llvm.org/docs/DeveloperPolicy.html#commit-messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.or

[PATCH] D93350: [Test] Fix undef var in catch-undef-behavior.c

thopre created this revision. thopre added reviewers: rsmith, rnk, BillyONeal, spatel. thopre requested review of this revision. Herald added a project: clang. Commit 9e52c43090f8cd980167bbd2719878ae36bcf6b5 removed the directive defining LINE_1600 but left a string substitution to that variable i

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 updated this revision to Diff 312055. shivanshu3 added a comment. Don't assume that `getLocForEndOfToken` will fail if and only if the token is a macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91129/new/ https://reviews.llvm.org/D9

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 marked an inline comment as done. shivanshu3 added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2267-2280 +SourceLocation OpTokLoc = OpTok.getLocation(); +if (OpTokLoc.isMacroID()) { + SourceLocation OpTokExpansionLoc = +

[clang] bc7126b - [FIX] Add the comma missing in D91979

Author: Johannes Doerfert Date: 2020-12-15T17:24:53-06:00 New Revision: bc7126b2bc542fdb28347c73a9cb193f5790d93b URL: https://github.com/llvm/llvm-project/commit/bc7126b2bc542fdb28347c73a9cb193f5790d93b DIFF: https://github.com/llvm/llvm-project/commit/bc7126b2bc542fdb28347c73a9cb193f5790d93b.d

[clang] 702f822 - [ASTMatcher] Avoid isImplicit call on object which could be nullptr

Author: Stephen Kelly Date: 2020-12-15T23:27:38Z New Revision: 702f822ca5bbff96401e9ede39f4ae5c7cbc6b05 URL: https://github.com/llvm/llvm-project/commit/702f822ca5bbff96401e9ede39f4ae5c7cbc6b05 DIFF: https://github.com/llvm/llvm-project/commit/702f822ca5bbff96401e9ede39f4ae5c7cbc6b05.diff LOG:

[clang-tools-extra] 0dd8f6f - [ClangTidy] NFC: Add more tests for container-size-empty

Author: Stephen Kelly Date: 2020-12-15T23:27:38Z New Revision: 0dd8f6f9035408fc18b4351ae4096a2852aa8fb5 URL: https://github.com/llvm/llvm-project/commit/0dd8f6f9035408fc18b4351ae4096a2852aa8fb5 DIFF: https://github.com/llvm/llvm-project/commit/0dd8f6f9035408fc18b4351ae4096a2852aa8fb5.diff LOG:

[PATCH] D93324: Avoid isImplicit call on object which could be nullptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG702f822ca5bb: [ASTMatcher] Avoid isImplicit call on object which could be nullptr (authored by stephenkelly). Repository: rG LLVM Github Monorepo

[PATCH] D93354: [clang-tidy] Make clang-format and include-order-check coherent again

njames93 created this revision. njames93 added reviewers: hokein, kadircet. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After D91602 gmock support was adde

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire updated this revision to Diff 312062. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80623/new/ https://reviews.llvm.org/D80623 Files: clang/include/clang/ASTMatchers/ASTMatchFinder.h clang/lib/ASTMatch

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 312063. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

<    1   2   3   >