[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7759-7761 + // The default setting for PointerAlignment is PAS_Right. + // But if we set PointerAlignment as PAS_Left, the formatter + // would mis-format the pointer alignment. ---

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

sammccall added a comment. In D92155#2453597 , @psionic12 wrote: > In D92155#2450474 , @nridge wrote: > >> Something just occurred to me: can't clangd arguments also be controlled by >> the untrusted repository by

[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:193 +} else { + elog("Code completion header path manipulation failed {0}", + HeaderFile.takeError()); I think this is too noisy. We can hit thi

[PATCH] D92041: [clangd] Add hover info for `this` expr

sammccall accepted this revision. sammccall added a comment. Very nice, thanks! I'll land this for you now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

nridge added a comment. In D92155#2454175 , @sammccall wrote: > I thought `getConfiguration('clangd')` with no scope specified was supposed > to be global (i.e. not a workspace-specific setting). There's a scope you can > pass in, and we're not providing

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7759-7761 + // The default setting for PointerAlignment is PAS_Right. + // But if we set PointerAlignment as PAS_Left, the formatter + // would mis-format the pointer alignment. ---

[clang-tools-extra] 9c328e7 - [clangd] Add hover info for `this` expr

Author: xndcn Date: 2020-12-15T09:47:29+01:00 New Revision: 9c328e7afafd15795fed54e3b0c1c5bd4fa97dfa URL: https://github.com/llvm/llvm-project/commit/9c328e7afafd15795fed54e3b0c1c5bd4fa97dfa DIFF: https://github.com/llvm/llvm-project/commit/9c328e7afafd15795fed54e3b0c1c5bd4fa97dfa.diff LOG: [c

[PATCH] D92041: [clangd] Add hover info for `this` expr

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9c328e7afafd: [clangd] Add hover info for `this` expr (authored by xndcn, committed by sammccall). Repository: rG LLVM

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

MyDeveloperDay added a comment. I generally don't have the same aversion to new options than others have, but can you point out a style guide that might want this option. (that is kind of the process) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:12115 + " break;\n" "}", InheritanceStyle); maybe add a `default` example with {} try not to change existing tests just add you

[clang] f24e58d - [clang][cli] Create accessors for exception models in LangOptions

Author: Jan Svoboda Date: 2020-12-15T10:15:58+01:00 New Revision: f24e58df7ddf2dc9f13c8f8fc259f0374f04aca3 URL: https://github.com/llvm/llvm-project/commit/f24e58df7ddf2dc9f13c8f8fc259f0374f04aca3 DIFF: https://github.com/llvm/llvm-project/commit/f24e58df7ddf2dc9f13c8f8fc259f0374f04aca3.diff L

[clang] 573255b - [clang][cli] Squash exception model in LangOptions into one member

Author: Jan Svoboda Date: 2020-12-15T10:15:58+01:00 New Revision: 573255b47eb9b210e74a1c620fee363dfaa52794 URL: https://github.com/llvm/llvm-project/commit/573255b47eb9b210e74a1c620fee363dfaa52794 DIFF: https://github.com/llvm/llvm-project/commit/573255b47eb9b210e74a1c620fee363dfaa52794.diff L

[PATCH] D93214: [clang][cli] Create accessors for exception models in LangOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf24e58df7ddf: [clang][cli] Create accessors for exception models in LangOptions (authored by jansvoboda11). Changed prior to commit: https://revie

[clang] 56c5548 - [clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception-model=xxx option

Author: Jan Svoboda Date: 2020-12-15T10:15:58+01:00 New Revision: 56c5548d7f07f5853a2e40562db08dc2e56ece03 URL: https://github.com/llvm/llvm-project/commit/56c5548d7f07f5853a2e40562db08dc2e56ece03 DIFF: https://github.com/llvm/llvm-project/commit/56c5548d7f07f5853a2e40562db08dc2e56ece03.diff L

[PATCH] D93215: [clang][cli] Squash exception model in LangOptions into one member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG573255b47eb9: [clang][cli] Squash exception model in LangOptions into one member (authored by jansvoboda11). Changed prior to commit: https://revi

[PATCH] D93216: [clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception-model=xxx option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56c5548d7f07: [clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

ktkachov added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:673-686 +def ProcA78C : SubtargetFeature<"cortex-a78c", "ARMProcFamily", +"CortexA78C", +"Cortex-A78C ARM processors", [ +

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:287 +static void +denormalizeString(SmallVectorImpl &Args, const char *Spelling, + CompilerInvocation::StringAllocator SA, unsigned, T &&Value) { dexonsmit

[PATCH] D93094: [clang][cli] Prevent double denormalization

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267 - ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager"))); + ASSERT_EQ(count(GeneratedArgs, "-fdebug-pass-manager"), 1); ASSERT_THAT(GeneratedArgs, Not(Conta

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

martong added a comment. In D92634#2451646 , @danielmarjamaki wrote: > No reviews => I will not contribute. Hi, thanks for the patch! I am terribly sorry that we could not pick this up earlier. You can always ping the community with a simple 'Ping' mess

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

martong added a comment. In D92634#2453822 , @OikawaKirie wrote: > I think it could be better to implement this check with a checker on > `PreStmt` and so on. And IMO, checkers have enough > functionalities to report these problems. > > Besides, the retu

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

ChuanqiXu updated this revision to Diff 311849. ChuanqiXu added a comment. Edit the comment to avoid misleading. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91245/new/ https://reviews.llvm.org/D91245 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

martong added a comment. In D92797#2452497 , @compnerd wrote: > Ping I am terribly sorry for keeping you waiting always. Thanks for your patience. Comment at: clang/include/clang/APINotes/APINotesWriter.h:1 +//===-- APINotesWriter.h -

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

ChuanqiXu added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7759-7761 + // The default setting for PointerAlignment is PAS_Right. + // But if we set PointerAlignment as PAS_Left, the formatter + // would mis-format the pointer alignment.

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield added a comment. In D93258#2453828 , @yaxunl wrote: > Can they use rocm release branches of llvm/clang with the corresponding rocm > release? As llvm/clang trunk is like the development branch, it is > understandable that they may contain

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong requested changes to this revision. martong added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1656-1662 + R"( + template + void f() { +T x; +(void)_Generic(x,

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

MyDeveloperDay added a comment. Aside: Would you be prepared to take a look at D34225: [clang-format] Teach clang-format how to handle C++ coroutines which is pretty much been abandoned, and see if there is anything there that might help the co_routinues suppor

[PATCH] D93206: [AArch64][NEON] Remove undocumented vceqz{,q}_p16, vml{a,s}q_n_f64 intrinsics

bsmith accepted this revision. bsmith added a comment. This revision is now accepted and ready to land. Changes look good to me, also can confirm these are in fact not part of the ACLE specification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM updated this revision to Diff 311856. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 Files: clang/test/Driver/aarch64-cpus.c llvm/i

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

martong added a comment. Nice and precise work! And special thanks for the unit tests. I've found some minor nits. Comment at: clang/include/clang/Analysis/MacroExpansionContext.h:77 + /// \param MacroExpansionLoc Must be the expansion location of a macro. + /// \return The

[PATCH] D84187: Port DependencyOutput string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84187/new/ https://reviews.llvm.org/D

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM marked 4 inline comments as done. MarkMurrayARM added a comment. Marked addressed comments as "done". Some debug code has been abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 __

[PATCH] D93223: [RFC][analyzer] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers

martong added a comment. Looks quite straight-forward other than that new prototype. Comment at: clang/include/clang/Analysis/PathDiagnostic.h:911 +void createHTMLSingleFileDiagnosticConsumer( +PathDiagnosticConsumerOptions DiagOpts, Why do we need this p

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

martong added inline comments. Comment at: clang/include/clang/Analysis/MacroExpansionContext.h:82 + MacroExpansionText + getExpandedMacroForLocation(SourceLocation MacroExpansionLoc) const; + `getExpandedText` ? Since what you get back is not a macro anymore.

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

martong added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:148 nameSET_PTR_VAR_TO_NULL - expansionptr = 0 + expansionptr =0 I wonder how much added value do we have with these h

[PATCH] D84187: [clang][cli] Port DependencyOutput string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311861. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84187/new/ https://reviews.llvm.org/D84187 Files: clang/include/clang/Driver/

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

martong added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:148 nameSET_PTR_VAR_TO_NULL - expansionptr = 0 + expansionptr =0 martong wrote: > I wonder how much added value do we

[PATCH] D84190: Port FrontendOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

ChuanqiXu added a comment. In D91245#2454504 , @MyDeveloperDay wrote: > Aside: Would you be prepared to take a look at D34225: [clang-format] Teach > clang-format how to handle C++ coroutines > which is pretty much been

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

MyDeveloperDay added a comment. not that rare it seems https://github.com/search?q=%22co_return+%28%22&type=code https://github.com/search?q=%22for+co_await+%28%22&type=code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91245/new/ https://reviews.llvm.org/D91245 __

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

MyDeveloperDay added a comment. I don't like seeing users having to use ```// clang-format off``` auto try_sequence = [](int& ref) -> return_ignore { /* clang-format off */ for co_await(int v : return_random_int()) ref = v; /* clang-fo

[PATCH] D84190: [clang][cli] Port FrontendOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311865. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84190/new/ https://reviews.llvm.org/D84190 Files: clang/include/clang/Driver/

[PATCH] D84668: Port TargetOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

ChuanqiXu added a comment. In D91245#2454610 , @MyDeveloperDay wrote: > I don't like seeing users having to use ```// clang-format off``` > > auto try_sequence = [](int& ref) -> return_ignore { > /* clang-format off */ > for

[clang] 8b48d24 - [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

Author: Chuanqi Xu Date: 2020-12-15T20:50:46+08:00 New Revision: 8b48d24373204fc2fe6aac1f1f850fa3b6c18445 URL: https://github.com/llvm/llvm-project/commit/8b48d24373204fc2fe6aac1f1f850fa3b6c18445 DIFF: https://github.com/llvm/llvm-project/commit/8b48d24373204fc2fe6aac1f1f850fa3b6c18445.diff LO

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b48d2437320: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid… (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311872. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84668/new/ https://reviews.llvm.org/D84668 Files: clang/include/clang/Driver/

[PATCH] D84669: Port CodeGenOpts simple string flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84669/new/ https://reviews.llvm.org/D

[PATCH] D1810: [ARM] Fix AArch32 and pre-v8 poly types to be unsigned

bsmith abandoned this revision. bsmith added a comment. Herald added subscribers: danielkiss, kristof.beyls. This change is very old and almost certainly out of date, therefore abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1810/new/ https://reviews.llvm.org/D1810 __

[clang-tools-extra] 965d71c - [clangd] Avoid traversing C:\ -> C: when looking for CDBs

Author: Sam McCall Date: 2020-12-15T13:59:00+01:00 New Revision: 965d71c69acce658e9e3de00b25a351b00937820 URL: https://github.com/llvm/llvm-project/commit/965d71c69acce658e9e3de00b25a351b00937820 DIFF: https://github.com/llvm/llvm-project/commit/965d71c69acce658e9e3de00b25a351b00937820.diff LO

[clang-tools-extra] 92dd077 - Reland [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

Author: Sam McCall Date: 2020-12-15T14:00:03+01:00 New Revision: 92dd077af1ff89929f5502c6c887358f51d5afc1 URL: https://github.com/llvm/llvm-project/commit/92dd077af1ff89929f5502c6c887358f51d5afc1 DIFF: https://github.com/llvm/llvm-project/commit/92dd077af1ff89929f5502c6c887358f51d5afc1.diff LO

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

xazax.hun added a comment. Overall looks good to me, I have some minor nits and questions inline. Comment at: clang/lib/Analysis/MacroExpansionContext.cpp:22 +: PP(PP), SM(PP.getSourceManager()), LangOpts(LangOpts) { + class MacroExpansionRangeRecorder : public PPCallbacks

[clang-tools-extra] 5186eda - [clangd] Oops, fix code in #ifdef WIN32

Author: Sam McCall Date: 2020-12-15T14:17:54+01:00 New Revision: 5186eda3269333b2fb38800e9ded2a27ae87f99b URL: https://github.com/llvm/llvm-project/commit/5186eda3269333b2fb38800e9ded2a27ae87f99b DIFF: https://github.com/llvm/llvm-project/commit/5186eda3269333b2fb38800e9ded2a27ae87f99b.diff LO

[PATCH] D93223: [RFC][analyzer] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:129 +Plugins(plugins), Injector(injector), CTU(CI), +MacroExpansions(PP, CI.getLangOpts()) { DigestAnalyzerOptions(); This will always record

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Yay! Deleting code is always nice. Comment at: clang/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:148 nameSET_PTR_VAR_TO_NULL -

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

steakhal added a comment. Internally we analyzed 16 projects with this patch-stack. No reports were changed! Now we don't crash on macro expansions in our test set, yey. I've checked a few expansions and seemed to be readable enough. Comment at: clang/test/Analysis/Inputs/ex

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:742 "the argument to %0 has side effects that will be discarded">, - InGroup>; + InGroup; +def warn_assume_attribute_string_unknown : Warning< aaron.ballman wro

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with one fix around the atomic Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:49 +auto NewStatus = Channel->GetState(/*try_to_connect=*/false); +

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

erichkeane added a comment. From the CFE's perspective, this is all that should be needed. Is there a BPF code-owner who can test it and see if it is acceptable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D9

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

aaron.ballman added a comment. In general, I think this is reasonable -- there's a bit more work to be done before it's ready to land, but this is heading in the right direction. Comment at: clang/include/clang/Basic/Attr.td:559 +/// A attribute is either a declaration attribu

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

sammccall added a subscriber: hokein. sammccall added a comment. Sorry about being slow here. Just a couple of suggestions to avoid cluttering the config parsing bits too much, and IIUC fixits can be removed. Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:211 +llvm::S

[PATCH] D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, curdeius, JakeMerdichAMD, mnem. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=35514 Initializer lists with a try-block are

[PATCH] D51650: Implement target_clones multiversioning

erichkeane updated this revision to Diff 311890. erichkeane added a comment. Since there seems to be at least a little renewed interest in this from a handful of people lately, I spend the time to rebase this and do some minor cleanup tasks. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

sammccall added a comment. Thanks! Just some organization nits. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:26 +#include "../clang-tidy/ClangTidyModuleRegistry.h" #include "CompileCommands.h" This is a pretty weird place to depend on clang-tidy. C

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: HsiangKai, rkruppe, kito-cheng, craig.topper, jrtc27, luismarques. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, j

[PATCH] D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

saghir accepted this revision. saghir added a comment. LGTM. A minor nit regarding an incomplete comment in `llvm/test/CodeGen/PowerPC/paired-vector-intrinsics.ll` which can be addressed when committing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91819/new/ https://reviews.llvm.org/D91819 ___

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2453891 , @pengfei wrote: > LGTM. Thanks. > `update_test_prefix.py` assumes the conflicting output. You may need to > change the expection of it as well. oh yes - made it check the new warning. Thanks! Repository: r

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin updated this revision to Diff 311896. mtrofin added a comment. update_test_prefix.py change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93078/new/ https://reviews.llvm.org/D93078 Files: clang/test/utils/update_cc_test_checks/Inputs/pre

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added a comment. In D90159#2453805 , @Meinersbur wrote: > Can I help fixing the Windows build problem? I think I have a fix (please see the updated patch), but don't have access to a windows machine to verify. Would you be able to try building w

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour updated this revision to Diff 311897. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 Files: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp llvm/include/llvm/Analysis/CFGPrinter.h llvm/include/ll

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. In D90275#2453641 , @gulfem wrote: >> This is missing a lang ref entry for `nocallback` and the `attributes.ll` >> test is arguably broken (see below). > > Could you please elaborate on missing lang ref entry? Where that should

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. Firstly, please generate your diffs with full context (-U with a sufficiently-large number). Secondly, can we avoid having to do a bunch of duplication with some clever use of multiclasses for F/D/Zfh and pseudos? Though maybe it's small enough that the duplication is ea

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 311898. vsavchenko added a comment. Refine conventions for completion handlers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files: clang/include/clang/Analysis/

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

sammccall added a comment. Thanks! This seems more consistent with our other hovers, but is going to be better-formatted/more attractive in VSCode. There are a couple of wrinkles I'd like to discuss :-) Brevity --- This is clear and mostly consistent (documentation excepted), but uses three

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2dc306b1ac7: [utils] Fix UpdateTestChecks case where 2 runs differ for last label (authored by mtrofin). Repository: rG LLVM Github Monorepo CHA

[clang] e2dc306 - [utils] Fix UpdateTestChecks case where 2 runs differ for last label

Author: Mircea Trofin Date: 2020-12-15T07:16:54-08:00 New Revision: e2dc306b1ac71258e6ce40a66e778527f282c355 URL: https://github.com/llvm/llvm-project/commit/e2dc306b1ac71258e6ce40a66e778527f282c355 DIFF: https://github.com/llvm/llvm-project/commit/e2dc306b1ac71258e6ce40a66e778527f282c355.diff

[clang-tools-extra] bda7d0a - [clangd] Improve goToDefinition on auto and dectype

Author: Quentin Chateau Date: 2020-12-15T16:32:22+01:00 New Revision: bda7d0af970718c243d93b22a8449c20156e574f URL: https://github.com/llvm/llvm-project/commit/bda7d0af970718c243d93b22a8449c20156e574f DIFF: https://github.com/llvm/llvm-project/commit/bda7d0af970718c243d93b22a8449c20156e574f.dif

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbda7d0af9707: [clangd] Improve goToDefinition on auto and dectype (authored by qchateau, committed by sammccall). Repository: rG LLVM Github Monor

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 311903. vsavchenko added a comment. Fix minor things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files: clang/include/clang/Analysis/Analyses/CalledOnceCheck.h

[PATCH] D92751: Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 311906. DavidTruby added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added extra tests for additional conditions and IR -> assembly tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D93164: [AST] Add generator for source location introspection

aaron.ballman added a comment. Do I understand correctly that the workflow is to use the new dumping tool to generate the needed JSON file that then gets used as input to generate_cxx_src_locs.py which creates NodeLocationIntrospection.cpp/.h that then gets used by clang-query (eventually)? So

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a frontend action for emitting object files. While Flang does

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski added a comment. @dang , I would appreciate if you could take a look at the diff in Options.td - you introduced the most recent changes there: https://reviews.llvm.org/D82574. I got a bit confused with the nested `let` statements there. I couldn't find a better way of marking `-emit-

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311915. jansvoboda11 added a comment. Fix: avoid template instantiations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84668/new/ https://reviews.llvm.org/D84668 Files: clang/include/clang/Driver/Option

[clang] 8acb5f2 - [clang][driver][NFC] Use StringRef instead of std::string

Author: Nathan James Date: 2020-12-15T16:19:12Z New Revision: 8acb5f2723ecaf0f1904a085ad79d0623cec38f6 URL: https://github.com/llvm/llvm-project/commit/8acb5f2723ecaf0f1904a085ad79d0623cec38f6 DIFF: https://github.com/llvm/llvm-project/commit/8acb5f2723ecaf0f1904a085ad79d0623cec38f6.diff LOG:

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 311911. abhina.sreeskantharajan added a comment. Thanks for your quick reviews! I haven't addressed all the comments yet but I plan to address all of them. I put up this patch early because it has a few major changes: - moves LiteralTranslat

[PATCH] D84669: WIP [clang][cli] Port CodeGenOpts simple string flags to new option parsing system

jansvoboda11 updated this revision to Diff 311919. jansvoboda11 added a comment. Rebase, move options back to their original lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84669/new/ https://reviews.llvm.org/D84669 Files: clang/include/clan

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 311922. jdoerfert marked 5 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1689 + +llvm::StringSet<> Sema::KnownAssumptionStrings({ +"omp_no_openmp", // OpenMP 5.1 aaron.ballman wrote: > The current approach is reasonable, but I wonder if there's a

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 9 inline comments as done. abhina.sreeskantharajan added a comment. In D93031#2447230 , @rsmith wrote: > I'm overall pretty happy about how clean and non-invasive the changes > required here are. But please make sure you don

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93008/new/ https://reviews.llvm.org/D93008 __

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:87 + defaultKinds, features, ci.allCookedSources()}; + semanticsContext.set_moduleDirectory("."s); + Fortran::semantics::Semantics semantics{ CarolineConcatto wrote: > Jus

[PATCH] D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93247/new/ https://reviews.llvm.org/D93247 ___ cfe-commits mailing list cfe-comm

[PATCH] D93094: [clang][cli] Prevent double denormalization

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the test fix. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267 - ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager"))); +

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM (found one very minor late nit in a cmake file though). Thank you for the discussion on this! Comment at: clang/lib/Sema/CMakeLists.txt:3 FrontendOpenM

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 311925. awarzynski added a comment. Address comment from @CarolineConcatto + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 Files: clang/include/clang/Driv

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:26 +#include "../clang-tidy/ClangTidyModuleRegistry.h" #include "CompileCommands.h" sammccall wrote: > This is a pretty weird plac

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 updated this revision to Diff 311926. njames93 added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92874/new/ https://reviews.llvm.org/D92874 Files: clang-tools-extra/clangd/ConfigCompile.cpp clang-too

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert added a comment. In D93079#2451782 , @JonChesterfield wrote: > Is this for cases where we are compiling a subset of the target code, i.e. > without link time optimisation? Upstream cannot to LTO on any target code as of now :( > It's interest

  1   2   3   >