[PATCH] D93094: [clang][cli] Prevent double denormalization

dexonsmith added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267 - ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager"))); + ASSERT_EQ(count(GeneratedArgs, "-fdebug-pass-manager"), 1); ASSERT_THAT(GeneratedArgs, Not(Contain

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

dexonsmith accepted this revision. dexonsmith added a comment. (LGTM, in case my conditional approval earlier wasn't clear...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/ https://reviews.llvm.org/D92775 ___

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]legacy-pass-manager

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https://reviews.llvm.org/D92857 ___ cfe-commits mailing list cfe-commits@

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

mehdi_amini added a comment. Clang is crashing after this change when bootstrapping and building lib/Support/CMakeFiles/LLVMSupport.dir/Hashing.cpp.o (our log if it helps: https://buildkite.com/mlir/mlir-core/builds/10003#80a5b6a9-d8d9-4420-ab2a-c24f398bc5d4 ) Repository: rG LLVM Github Mon

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:1292-1303 def fdwarf_exceptions : Flag<["-"], "fdwarf-exceptions">, Group, - Flags<[CC1Option]>, Hel

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, it's usually better to land first and ask questions later. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

dexonsmith added a comment. In D93104#2449783 , @dexonsmith wrote: > LGTM. BTW, for partial reverts or potentially time-sensitive fixes like this, > it's usually better to land first and ask questions later. (It'd be nice to have a test for this too if p

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

dexonsmith added a reviewer: MaskRay. dexonsmith added a comment. In D93104#2449787 , @dexonsmith wrote: > In D93104#2449783 , @dexonsmith > wrote: > >> LGTM. BTW, for partial reverts or potentially time-sensitive

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Thanks for the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 ___ cfe-commits

[clang] 8d4b139 - Revert "Consider reference, pointer, and pointer-to-member TemplateArguments to be different if they have different types."

Author: Nikita Popov Date: 2020-12-12T00:04:10+01:00 New Revision: 8d4b139e9dceb43aa91d0451f5458fd05a9fba33 URL: https://github.com/llvm/llvm-project/commit/8d4b139e9dceb43aa91d0451f5458fd05a9fba33 DIFF: https://github.com/llvm/llvm-project/commit/8d4b139e9dceb43aa91d0451f5458fd05a9fba33.diff

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

nikic added a comment. This also crashes test-suite, so I've reverted the change for now. (Stack trace for tramp3d-v4 crash: https://llvm-compile-time-tracker.com/show_error.php?commit=7b3470baf8bab1919e3ad4c18e2b776c1f7be2d5) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

MaskRay accepted this revision. MaskRay added a comment. Thanks! Sorry for the breakage. Actually, neither `-fno-access-control` nor `-faccess-control` has any test.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93104/new/ https://reviews.llvm.or

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

mnatsuhara added a comment. After following up with the team responsible for `__builtin_zero_non_value_bits` on MSVC, I have some more information to offer in conjunction with @BillyONeal's report: - For unions, we always assume that it has unique object representations and thus does not have

[PATCH] D93148: Basic: Add native support for stdin to SourceManager and FileManager

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Add support for stdin to SourceManager and FileManager. Adds FileManager::getSTDIN,

[clang] a600432 - Frontend: Migrate to FileEntryRef in TextDiagnosticTest, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-11T17:06:28-08:00 New Revision: a60043219907b8f370263b7d3d4827b83388d8cf URL: https://github.com/llvm/llvm-project/commit/a60043219907b8f370263b7d3d4827b83388d8cf DIFF: https://github.com/llvm/llvm-project/commit/a60043219907b8f370263b7d3d4827b83388

[PATCH] D92968: Frontend: Migrate to FileEntryRef in TextDiagnosticTest, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa60043219907: Frontend: Migrate to FileEntryRef in TextDiagnosticTest, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES

[clang] 8c86197 - clang-import-test: Clean up error output for files that cannot be found

Author: Duncan P. N. Exon Smith Date: 2020-12-11T17:07:58-08:00 New Revision: 8c86197de3cba4257f26133e837d64e5f8ece210 URL: https://github.com/llvm/llvm-project/commit/8c86197de3cba4257f26133e837d64e5f8ece210 DIFF: https://github.com/llvm/llvm-project/commit/8c86197de3cba4257f26133e837d64e5f8ec

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8c86197de3cb: clang-import-test: Clean up error output for files that cannot be found (authored by dexonsmith). Repository: rG LLVM Github Monorep

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/29686/step_7.txt PTAL, and please revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92971/new/ https://reviews.llvm.org/D92971 ___

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

dexonsmith added a comment. In D92971#2449932 , @thakis wrote: > This breaks tests on Windows: http://45.33.8.238/win/29686/step_7.txt > > PTAL, and please revert for now if it takes a while to fix. I'll fix now. Repository: rG LLVM Github Monorepo C

[clang] e095959 - Fixup for 8c86197de3cba4257f26133e837d64e5f8ece210 to avoid making it platform-dependent

Author: Duncan P. N. Exon Smith Date: 2020-12-11T17:34:00-08:00 New Revision: e095959e0c23e250d6ad1dbe3612291736d12e1a URL: https://github.com/llvm/llvm-project/commit/e095959e0c23e250d6ad1dbe3612291736d12e1a DIFF: https://github.com/llvm/llvm-project/commit/e095959e0c23e250d6ad1dbe3612291736d1

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

dexonsmith added a comment. In D92971#2449934 , @dexonsmith wrote: > In D92971#2449932 , @thakis wrote: > >> This breaks tests on Windows: http://45.33.8.238/win/29686/step_7.txt >> >> PTAL, and please revert for no

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

thakis added a comment. Thanks for the quick fix! The bot is happy again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92971/new/ https://reviews.llvm.org/D92971 ___ cfe-commits mailing list cfe-commits

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism updated this revision to Diff 311357. swamulism added a comment. Herald added subscribers: dexonsmith, hiraditya. Updating to set npm OptBisect to use global singleton OptBisect instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92897/n

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism added a comment. Thank you for the comments and code review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92897/new/ https://reviews.llvm.org/D92897 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

aeubanks added inline comments. Comment at: llvm/include/llvm/IR/OptBisect.h:58 + /// Checks the bisect limit to determine if the specified pass should run. + /// This calls checkPass + bool shouldRunPass(const Pass *P, StringRef IRDescription) override; ==

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism updated this revision to Diff 311358. swamulism marked 5 inline comments as done. swamulism added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92897/new/ https://reviews.llvm.org/D92897 Files: clang/test/Co

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin updated this revision to Diff 311359. mtrofin marked an inline comment as done. mtrofin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. added check for when a prefix has conflicts for all functions Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism updated this revision to Diff 311360. swamulism added a comment. Update comment strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92897/new/ https://reviews.llvm.org/D92897 Files: clang/test/CodeGen/new-pass-manager-opt-bisect.c

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob marked an inline comment as done. dougpuob added a comment. Hi @njames93, thank you for your review suggestions, I have improved them and against my change to the main branch. I encounter a problem on the Buildbot for Windows only. Several people encounter also to the same problem that

[PATCH] D93031: Enable fexec-charset option

tahonermann added inline comments. Comment at: clang/include/clang/Driver/Options.td:3583-3584 +def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">, + HelpText<"Set the execution for string and character literals">; def target_cpu : Separate<["-"], "target

<    1   2