dexonsmith added a reviewer: MaskRay.
dexonsmith added a comment.

In D93104#2449787 <https://reviews.llvm.org/D93104#2449787>, @dexonsmith wrote:

> In D93104#2449783 <https://reviews.llvm.org/D93104#2449783>, @dexonsmith 
> wrote:
>
>> LGTM. BTW, for partial reverts or potentially time-sensitive fixes like 
>> this, it's usually better to land first and ask questions later.

Ah, I see the original commit was a while ago, so maybe not so time-sensitive.

> (It'd be nice to have a test for this too if possible...)

(Or maybe OptOutFFLag could reject an option beginning with `"no-"`?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93104/new/

https://reviews.llvm.org/D93104

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to