[PATCH] D92662: [Clang][Coroutine] Drop const attribute on pthread_self when coroutine is enabled

2020-12-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D92662#2444196 , @lxfind wrote: > In D92662#2443970 , @MaskRay wrote: > >> If the attribute is not suitable, glibc should drop it. The compiler can add >> `readnone`/`readonly` if approp

[clang] 7127fd1 - MSABI: Basic mangling for access to member subobjects in a class

2020-12-09 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-12-09T18:08:49-08:00 New Revision: 7127fd1786e607990ada5ade2bf473e6cad68d9d URL: https://github.com/llvm/llvm-project/commit/7127fd1786e607990ada5ade2bf473e6cad68d9d DIFF: https://github.com/llvm/llvm-project/commit/7127fd1786e607990ada5ade2bf473e6cad68d9d.diff

[clang] fc39425 - [NFCI] Add a missing triple in clang/test/CodeGen/ppc64le-varargs-f128.c

2020-12-09 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-12-09T18:17:34-08:00 New Revision: fc3942526f5c048759e90d10289ecef75410f728 URL: https://github.com/llvm/llvm-project/commit/fc3942526f5c048759e90d10289ecef75410f728 DIFF: https://github.com/llvm/llvm-project/commit/fc3942526f5c048759e90d10289ecef75410f728.diff

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

2020-12-09 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 310741. rsmith added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91488/new/ https://reviews.llvm.org/D91488 Files: clang/include/clang/Basic/LangOptions.h clang/lib/AST/ItaniumMangle.cp

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

2020-12-09 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Update the config file warning whe

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

2020-12-09 Thread Ella Ma via Phabricator via cfe-commits
OikawaKirie added a comment. In D92160#2443405 , @dexonsmith wrote: > In D92160#2443413 , @dexonsmith wrote: > Replies on my own: > Can you tell me more about the scenario this happens? You can first manual

[PATCH] D92992: [clang-tidy] Add make_unique_for_overwrite/make_shared_for_overwrite check.

2020-12-09 Thread Chris Kennelly via Phabricator via cfe-commits
ckennelly created this revision. ckennelly added reviewers: hokein, njames93, alexfh, aaron.ballman. Herald added subscribers: xazax.hun, mgorny. ckennelly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. std::make_unique_for_overwrite and s

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

2020-12-09 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3758 TemplateArgument TA(T->getNumBitsExpr()); - mangleTemplateArgs(&TA, 1); + mangleTemplateArgs(TemplateName(), &TA, 1); if (T->isUnsigned()) Passing a null TemplateName here ca

[PATCH] D92954: [clang-offload-bundler] Add option -list

2020-12-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 310748. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Artem's comments: removing unnecessary output to temporary file, extract forEachBundle. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92954/new/ https://reviews.llvm

[PATCH] D92954: [clang-offload-bundler] Add option -list

2020-12-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:763 + +// Create an intermediate temporary file for reading the bundles. +TempFileHandlerRAII TempFiles; tra wrote: > Having to create a temporary file in

[PATCH] D92995: Indicate that AddressSanitizer is supported on Apple Silicon.

2020-12-09 Thread Corey Farwell via Phabricator via cfe-commits
frewsxcv created this revision. frewsxcv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Confirmed that AddressSanitizer works on my new Macbook Air. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92995 Files: clang/d

[PATCH] D92954: [clang-offload-bundler] Add option -list

2020-12-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 310751. yaxunl added a comment. Remove unnecessary formatting changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92954/new/ https://reviews.llvm.org/D92954 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/Cl

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

2020-12-09 Thread Min-Yih Hsu via Phabricator via cfe-commits
myhsu updated this revision to Diff 310755. myhsu marked an inline comment as done. myhsu added a comment. - [NFC] Fix minor formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

2020-12-09 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: MaskRay, simoll, k-ishizaka. kaz7 added projects: VE, clang. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Remove explicitly declared -faddrsig and -fnoaddrsig option tests since those are already tested in addrsig

[PATCH] D92800: [Clang] Add disable-merge function attribute which generates nomerge function attribute in IR

2020-12-09 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 310760. zequanwu added a comment. start a new diff to make nomerge attribute a function attribute as well as a statement attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llv

[PATCH] D92992: [clang-tidy] Add make_unique_for_overwrite/make_shared_for_overwrite check.

2020-12-09 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:143 +- New :doc:`modernize-make-shared-for-overwrite + ` check. Please keep alphabetical order. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146

[PATCH] D93002: [NPM] Support -fmerge-functions

2020-12-09 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. aeubanks added reviewers: ychen, asbirlea, nikic. Herald added a subscriber: hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. I tried to put it in the same place in the pi

[PATCH] D87981: [X86] AMX programming model.

2020-12-09 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke added a comment. Hi, I'm going to land the patch if there is no objection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 ___ cfe-commits mailing list

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-09 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

2020-12-09 Thread Ella Ma via Phabricator via cfe-commits
OikawaKirie added a comment. Replies from the original author Hao Zhang (Sorry for the wrong email address in the previous reply.) -- Thanks for your reply. I noticed this problem when I was using clang-check to analyze a project whic

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

2020-12-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/ve-toolchain.cpp:72 // RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DEFINITARRAY %s // DEFINITARRAY: clang{{.*}} "-cc1" Most newer toolchains default to -fuse-init-array. There i

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

2020-12-09 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM, it would be great if someone else stamps this too, in case I missed something. Comment at: clang/include/clang/Driver/Options.td:164 +def m_m68k_Features_Group: OptionGr

[PATCH] D87981: [X86] AMX programming model.

2020-12-09 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. LGTM. I think we can land this patch as a beginning. Cheers~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981

<    1   2   3