MaskRay added inline comments.
================
Comment at: clang/test/Driver/ve-toolchain.cpp:72
// RUN: %clangxx -### -target ve %s 2>&1 | FileCheck
-check-prefix=DEFINITARRAY %s
// DEFINITARRAY: clang{{.*}} "-cc1"
----------------
Most newer toolchains default to -fuse-init-array. There is probably very
little value testing -f[no-]use-init-array
================
Comment at: clang/test/Driver/ve-toolchain.cpp:112
// RUN: %clangxx -### -target ve --stdlib=c++ %s 2>&1 | \
// RUN: FileCheck -check-prefix=LINK %s
----------------
Such tests should use `--sysroot` and a fake tree (see `Inputs/basic_*_tree`),
otherwise clang may find the toolchain under /usr
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92996/new/
https://reviews.llvm.org/D92996
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
