[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

2020-12-02 Thread Albion Fung via Phabricator via cfe-commits
Conanap added a comment. Replied to a comment Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9213 + + if (bot) { +SplatNode = DAG.getNode( NeHuang wrote: > I do not quite understand the `if` and `else` logic here, current logic seems > we

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

2020-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2524 // defined. - if (Ty->getPointeeType().isVolatileQualified()) + if (!Ty->getPointeeType().isNull() && Ty->getPointeeType().isVolatileQualified()) return; lebede

[clang] 0849047 - Add a less ambiguous macro for Android version.

2020-12-02 Thread Dan Albert via cfe-commits
Author: Dan Albert Date: 2020-12-02T13:26:28-08:00 New Revision: 0849047860a343d8bcf1f828a82d585e89079943 URL: https://github.com/llvm/llvm-project/commit/0849047860a343d8bcf1f828a82d585e89079943 DIFF: https://github.com/llvm/llvm-project/commit/0849047860a343d8bcf1f828a82d585e89079943.diff LO

[clang] acb6f80 - [CUDA][HIP] Fix overloading resolution

2020-12-02 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-12-02T16:33:33-05:00 New Revision: acb6f80d96b74af3ec515bb9811d213abb406c31 URL: https://github.com/llvm/llvm-project/commit/acb6f80d96b74af3ec515bb9811d213abb406c31 DIFF: https://github.com/llvm/llvm-project/commit/acb6f80d96b74af3ec515bb9811d213abb406c31.dif

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

2020-12-02 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGacb6f80d96b7: [CUDA][HIP] Fix overloading resolution (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D80450?vs=308515&id=309044#toc Repo

[clang] 24d4291 - [CSSPGO] Pseudo probes for function calls.

2020-12-02 Thread Hongtao Yu via cfe-commits
Author: Hongtao Yu Date: 2020-12-02T13:45:20-08:00 New Revision: 24d4291ca704fa5ee2419b4163aa324eca693fd6 URL: https://github.com/llvm/llvm-project/commit/24d4291ca704fa5ee2419b4163aa324eca693fd6 DIFF: https://github.com/llvm/llvm-project/commit/24d4291ca704fa5ee2419b4163aa324eca693fd6.diff LO

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

2020-12-02 Thread Hongtao Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24d4291ca704: [CSSPGO] Pseudo probes for function calls. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3310 + case OMPC_DEFAULTMAP_MODIFIER_present: +// If implicit-behavior is present, each variable referenced in the +// construct in the category specified by variable-category is treated as if

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

2020-12-02 Thread Jamie Schmeiser via Phabricator via cfe-commits
jamieschmeiser added a comment. I previously saw unrelated changes showing up in the differences here but this no longer seems to be the case so that comment can be ignored. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:126 + void addClassToPassName(StringRef Class

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

2020-12-02 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 309052. aeubanks added a comment. add comments to new methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: llvm/include/llvm/IR/IRPrintingPasses.h llvm/i

[clang] 32c501d - Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-02T14:07:23-08:00 New Revision: 32c501dd88b62787d3a5ffda7aabcf4650dbe3cd URL: https://github.com/llvm/llvm-project/commit/32c501dd88b62787d3a5ffda7aabcf4650dbe3cd DIFF: https://github.com/llvm/llvm-project/commit/32c501dd88b62787d3a5ffda7aabcf4650db

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG32c501dd88b6: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and… (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D90497?v

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

2020-12-02 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490 +OMPC_MAP_MODIFIER_present); +ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation()); + } ABataev wrote: > Why need to add an empty `SourceLoc

[PATCH] D78058: option to write files to memory instead of disk

2020-12-02 Thread Marc Rasi via Phabricator via cfe-commits
marcrasi added a comment. Ping on this. Could anyone take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78058/new/ https://reviews.llvm.org/D78058 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

2020-12-02 Thread Jacob Weightman via Phabricator via cfe-commits
jacobdweightman added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16869 +// Allow results of method calls to be mapped. +if (isa(ME->getMemberDecl())) { + RelevantExpr = ME; ABataev wrote: > I don't think it should always return `true`

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

2020-12-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1296-1297 +: Error<"'#pragma omp end assumes' with no matching '#pragma omp begin assumes'">; +def err_expected_assumption_clause +: Error<"'%0' directive requires at least one c

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

2020-12-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 309058. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: cfe-commits, sunfish, aheejin, dschuff. Herald added a project: clang. Fix two clang/test/CodeGen tests Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

2020-12-02 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. In D92101#2428104 , @martong wrote: > In D92101#2423685 , @shafik wrote: > >> Should we add a test for the `regular function template` case as well? > > I think this issue is specific for a `

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

2020-12-02 Thread Jacob Weightman via Phabricator via cfe-commits
jacobdweightman updated this revision to Diff 309056. jacobdweightman added a comment. I separated the handling of `ConditionalOperator`s and `BinaryConditionalOperator`s in order to eliminate handling of `OpaqueValueExpression`s in general, and asserted that the OVE's `SourceExpr` is not null.

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

2020-12-02 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Still unsure if we should also error out for NVPTX but that is a different story. Looks OK from my side, assuming you address the earlier comment. Maybe someone else should accept though. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAu

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added a reviewer: rnk. Herald added subscribers: ributzka, martong, hiraditya. Herald added a reviewer: shafik. Herald added projects: clang, LLVM. dexonsmith requested review of this revision. Update all the users of `AlignedCharArrayUnion` to stop pee

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Optionally, I could commit everything but the change to `AlignedCharArrayUnion` separately, just updating all the users to stop looking inside. If we think there's a chance of a revert that might be better... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

2020-12-02 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 309067. jyu2 retitled this revision from "Fix missing error for use of 128-bit integer inside SPIR64 device code." to "[CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.". jyu2 added a comment. Fix problem with @jdoerfert pointed wh

[PATCH] D88220: [C++20] P1825R0: More implicit moves

2020-12-02 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a subscriber: davidstone. Quuxplusone added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:22 + return c; +} +#else Quuxplusone wrote: > @rsmith @david_stone (or anyone), what is the status in C++20 of th

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

2020-12-02 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jdoerfert wrote: > jyu

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

2020-12-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: llvm/include/llvm/Support/ErrorOr.h:256-257 union { AlignedCharArrayUnion TStorage; AlignedCharArrayUnion ErrorStorage; }; ---

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 309071. dexonsmith added a comment. Fix some build errors on the clang side of the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92512/new/ https://reviews.llvm.org/D92512 Files: clang/include/clang/AST/APValue.h clang/include/clang/A

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

2020-12-02 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Sorry, racing updates. I agree, landing them together is better, since there is risk that some corner case platform won't have this support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92512/new/ https://reviews.llvm.org/D92512 __

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

2020-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. Yeah, looks good to me - I'd probably go with your suggestion of committing the cleanup pre-emptively, then the alias change. But dealer's choice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92512/new/ https://reviews.llvm.or

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

2020-12-02 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/include/clang/AST/APValue.h:405 assert(isInt() && "Invalid accessor"); -return *(APSInt*)(char*)Data.buffer; +return *(APSInt *)(char *)&Data; } I notice that in `ASTTypeTraits.h` we use `reinterpret

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/include/clang/AST/APValue.h:405 assert(isInt() && "Invalid accessor"); -return *(APSInt*)(char*)Data.buffer; +return *(APSInt *)(char *)&Data; } shafik wrote: > I notice that in `ASTTypeTraits.h`

[PATCH] D92516: ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: rnk, dblaikie. Herald added subscribers: ributzka, jfb, hiraditya. Herald added projects: clang, LLVM. dexonsmith requested review of this revision. Prepare to delete `AlignedCharArrayUnion` by migrating its users over to `std::aligned_

[PATCH] D92516: ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

2020-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92516/new/ https://reviews.llvm.org/D92516

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

2020-12-02 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 309093. njames93 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix assertion due to a pointer stored in a ManagedStatic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang] 3a781b9 - Fix assertion in tryEmitAsConstant

2020-12-02 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-12-02T19:10:01-05:00 New Revision: 3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab URL: https://github.com/llvm/llvm-project/commit/3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab DIFF: https://github.com/llvm/llvm-project/commit/3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab.dif

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

2020-12-02 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir removed a reviewer: benlangmuir. benlangmuir added a comment. Removing myself as reviewer since I no longer work in this area. Someone who is more involved with llvm Support/ADT should review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

2020-12-02 Thread Nathan James via Phabricator via cfe-commits
njames93 added reviewers: chandlerc, dblaikie. njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:190-196 +// Use a custom deleter for the TrueMatcherInstance ManagedStatic. This prevents +// an assert firing when the refcount is nonzero wh

[clang] dcc4f7f - ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-02T16:28:33-08:00 New Revision: dcc4f7f3c4b4442710ae73d6f73cded665426678 URL: https://github.com/llvm/llvm-project/commit/dcc4f7f3c4b4442710ae73d6f73cded665426678 DIFF: https://github.com/llvm/llvm-project/commit/dcc4f7f3c4b4442710ae73d6f73cded66542

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdcc4f7f3c4b4: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

2020-12-02 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. In D92439#2429511 , @jdoerfert wrote: > Still unsure if we should also error out for NVPTX but that is a different > story. Looks OK from my side, assuming you address the earlier comment. With this change if NVPTX need diagnostic f

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

2020-12-02 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:75-76 RefCountedBase() = default; + // Copy and move constructors/assignments are no-ops as the RefCount isn't + // dictated by the class directly. RefCountedBase(const RefCountedBase &

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:75-80 + // Copy and move constructors/assignments are no-ops as the RefCount isn't + // dictated by the class directly. RefCountedBase(const RefCountedBase &) {} + RefCountedBase(RefCou

[PATCH] D88220: [C++20] P1825R0: More implicit moves

2020-12-02 Thread David Stone via Phabricator via cfe-commits
davidstone added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:22 + return c; +} +#else Quuxplusone wrote: > Quuxplusone wrote: > > @rsmith @david_stone (or anyone), what is the status in C++20 of the > > following test

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

2020-12-02 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2522 + // Add to the lookupTable because we could not do that in MapImported. + Importer.AddToLookupTable(ToTypedef); + I am not super excited about this solution, I feel like several bugs

[clang] 3b18a59 - Frontend: Sink named pipe logic from CompilerInstance down to FileManager

2020-12-02 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-02T17:14:27-08:00 New Revision: 3b18a594c7717a328c33b9c1eba675e9f4bd367c URL: https://github.com/llvm/llvm-project/commit/3b18a594c7717a328c33b9c1eba675e9f4bd367c DIFF: https://github.com/llvm/llvm-project/commit/3b18a594c7717a328c33b9c1eba675e9f4bd

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3b18a594c771: Frontend: Sink named pipe logic from CompilerInstance down to FileManager (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 432d051 - [RISCV] Handle zfh in the arch string.

2020-12-02 Thread Hsiangkai Wang via cfe-commits
Author: Hsiangkai Wang Date: 2020-12-03T09:16:44+08:00 New Revision: 432d05174ed00a217c0ad37e2e823154624c1311 URL: https://github.com/llvm/llvm-project/commit/432d05174ed00a217c0ad37e2e823154624c1311 DIFF: https://github.com/llvm/llvm-project/commit/432d05174ed00a217c0ad37e2e823154624c1311.diff

[PATCH] D91315: [RISCV] Handle zfh in the arch string.

2020-12-02 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG432d05174ed0: [RISCV] Handle zfh in the arch string. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D92529: ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: shafik, arphaman, jansvoboda11. Herald added subscribers: teemperor, ributzka, martong. Herald added a reviewer: a.sidorin. Herald added a project: clang. dexonsmith requested review of this revision. Migrate `ASTImporter::Import` over

[clang] b346322 - Revert "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

2020-12-02 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-02T17:36:20-08:00 New Revision: b34632201987eed369bb7ef4646f341b901c95b8 URL: https://github.com/llvm/llvm-project/commit/b34632201987eed369bb7ef4646f341b901c95b8 DIFF: https://github.com/llvm/llvm-project/commit/b34632201987eed369bb7ef4646f341b901c

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Hmm, I had to revert this in b34632201987eed369bb7ef4646f341b901c95b8 due to a bot failure; I'll need to look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] c4fb772 - PR48339: Improve diagnostics for invalid dependent unqualified function calls.

2020-12-02 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-12-02T17:54:55-08:00 New Revision: c4fb7720ceb30f25c38d994fb375e4d1978de144 URL: https://github.com/llvm/llvm-project/commit/c4fb7720ceb30f25c38d994fb375e4d1978de144 DIFF: https://github.com/llvm/llvm-project/commit/c4fb7720ceb30f25c38d994fb375e4d1978de144.diff

[PATCH] D92531: Reapply "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese, jansvoboda11. Herald added subscribers: ributzka, JDevlieghere. Herald added a project: clang. dexonsmith requested review of this revision. This reverts commit b34632201987eed369bb7ef4646f341b901c95b8

[PATCH] D92531: Reapply "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Note that the original commit was reviewed here: https://reviews.llvm.org/D90733. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92531/new/ https://reviews.llvm.org/D92531 ___

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

2020-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D90733#2429976 , @dexonsmith wrote: > Hmm, I had to revert this in b34632201987eed369bb7ef4646f341b901c95b8 > due to > a bot failure; I'll need to look i

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

2020-12-02 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 309120. njames93 added a comment. Added test cases demonstrating copy and move behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files: clang/lib/ASTMatcher

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

2020-12-02 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good with a minor cleanup. Thanks! Comment at: clang/lib/Sema/SemaTemplate.cpp:2081-2085 TypeLocBuilder InnerTLB; QualType Transformed = TransformTyp

[PATCH] D92529: ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

2020-12-02 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92529/new/ https://reviews.llvm.org/D92529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

2020-12-02 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I've added test cases which demonstrate what these copies/moves are about. The move constructor probably would never get used. I can't see of a reason to move the contents of a ref counted pointer. In which case there could be an argument to delete it. The copy construc

[clang] 222da77 - [NFC] [Clang] Move ppc64le f128 vaargs OpenMP test

2020-12-02 Thread Qiu Chaofan via cfe-commits
Author: Qiu Chaofan Date: 2020-12-03T10:50:42+08:00 New Revision: 222da77a82d17cbc6b989779e2ba2bb4904bb672 URL: https://github.com/llvm/llvm-project/commit/222da77a82d17cbc6b989779e2ba2bb4904bb672 DIFF: https://github.com/llvm/llvm-project/commit/222da77a82d17cbc6b989779e2ba2bb4904bb672.diff L

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

2020-12-02 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ MaskRay wrote: > Generall

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

2020-12-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ qiucf wrote: > MaskRay

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

2020-12-02 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ MaskRay

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

2020-12-02 Thread Gerolf Hoflehner via Phabricator via cfe-commits
Gerolf accepted this revision. Gerolf added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91147/new/ https://reviews.llvm.org/D91147 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

2020-12-02 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ hubert.reinterpretcast wr

[clang] a36f8fb - [NFC] Add proper triple for arc.ll test

2020-12-02 Thread via cfe-commits
Author: Yuanfang Chen Date: 2020-12-02T23:31:06-08:00 New Revision: a36f8fb021d0a1719400eda446131290be21c3ed URL: https://github.com/llvm/llvm-project/commit/a36f8fb021d0a1719400eda446131290be21c3ed DIFF: https://github.com/llvm/llvm-project/commit/a36f8fb021d0a1719400eda446131290be21c3ed.diff

[PATCH] D72184: [BPF] support atomic instructions

2020-12-02 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 309167. yonghong-song added a comment. fix clang-format warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72184/new/ https://reviews.llvm.org/D72184 Files: llvm/lib/Target/BPF/BPFInstrFormats.td

<    1   2