ABataev added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:3310
+ case OMPC_DEFAULTMAP_MODIFIER_present:
+ // If implicit-behavior is present, each variable referenced in the
+ // construct in the category specified by variable-category is treated as
if
----------------
Add a reference to the OpenMP standard, section and related text.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490
+ OMPC_MAP_MODIFIER_present);
+ ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation());
+ }
----------------
Why need to add an empty `SourceLocation`?
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:18592
if (!isDefaultmapKind || !isDefaultmapModifier) {
- std::string ModifierValue = "'alloc', 'from', 'to', 'tofrom', "
- "'firstprivate', 'none', 'default'";
std::string KindValue = "'scalar', 'aggregate', 'pointer'";
+ if (LangOpts.OpenMP == 50) {
----------------
You can make it `StringRef`
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:18594
+ if (LangOpts.OpenMP == 50) {
+ std::string ModifierValue = "'alloc', 'from', 'to', 'tofrom', "
+ "'firstprivate', 'none', 'default'";
----------------
Same, `StringRef`
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:18609
} else {
- Diag(MLoc, diag::err_omp_unexpected_clause_value)
- << ModifierValue << getOpenMPClauseName(OMPC_defaultmap);
- Diag(KindLoc, diag::err_omp_unexpected_clause_value)
- << KindValue << getOpenMPClauseName(OMPC_defaultmap);
+ std::string ModifierValue =
+ "'alloc', 'from', 'to', 'tofrom', "
----------------
`StringRef`
================
Comment at: clang/test/OpenMP/target_defaultmap_codegen.cpp:1557
+#endif
+///==========================================================================///
+// RUN: %clang_cc1 -DCK27 -verify -fopenmp -fopenmp-version=51
-fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple
powerpc64le-unknown-unknown -emit-llvm %s -o - | FileCheck
-allow-deprecated-dag-overlap %s --check-prefix CK27 --check-prefix CK27-64
----------------
Add in a separate test file
================
Comment at: clang/test/OpenMP/target_defaultmap_messages.cpp:5
// RUN: %clang_cc1 -verify -fopenmp -fopenmp-version=50 %s
-verify=expected,omp5 -Wuninitialized -DOMP5
-// RUN: %clang_cc1 -verify -fopenmp-simd -fopenmp-version=50 %s
-verify=expected,omp5 -Wuninitialized -DOMP5
+// run: %clang_cc1 -verify -fopenmp-simd -fopenmp-version=50 %s
-verify=expected,omp5 -wuninitialized -domp5
----------------
Why this line is changed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92427/new/
https://reviews.llvm.org/D92427
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
