[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 308891. yonghong-song added a comment. use llvm_unreachable() in default case of the switch statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72184/new/ https://reviews.llvm.org/D72184 Files: llv

[clang] 3fca6a7 - [Clang] Don't adjust align for IBM extended double

Author: Qiu Chaofan Date: 2020-12-02T17:02:26+08:00 New Revision: 3fca6a7844b515496446667a18a9703c29cf6e88 URL: https://github.com/llvm/llvm-project/commit/3fca6a7844b515496446667a18a9703c29cf6e88 DIFF: https://github.com/llvm/llvm-project/commit/3fca6a7844b515496446667a18a9703c29cf6e88.diff L

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fca6a7844b5: [Clang] Don't adjust align for IBM extended double (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf added a comment. The regression should be fixed in rG3fca6a7844b5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91596/new/ https://reviews.llvm.org/D91596 ___

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. In D92361#2427652 , @zoecarver wrote: >> If it is not possible to copy or move the type at all, it is not possible to >> copy or move it trivially. > > This was a bit confusing to me because I think this changed between C++14 and

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

joechrisellis commandeered this revision. joechrisellis edited reviewers, added: fpetrogalli; removed: joechrisellis. joechrisellis added a comment. I am finishing up this patch. 😄 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://re

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

joechrisellis updated this revision to Diff 308910. joechrisellis added a comment. Reduce debug info in `debug-declare-no-warnings-on-scalable-vectors.ll`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 Fi

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong added a comment. In D92101#2423685 , @shafik wrote: > Should we add a test for the `regular function template` case as well? I think this issue is specific for `CXXDeductionGuideDecl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong updated this revision to Diff 308920. martong added a comment. - Move dependent context check into TransformTypedefType - Add new test case for param with pointer type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92101/new/ https://reviews

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong updated this revision to Diff 308922. martong added a comment. - Add to MaterializedTypedefs only when copying the Decl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92101/new/ https://reviews.llvm.org/D92101 Files: clang/lib/Sema/SemaTe

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong added a comment. @rsmith I have moved the check into `TransformTypedefType`. We do not add the typedef to the `MaterializedTypedefs` list if it's context is dependent because later we set the deduction guide as the DC for all typedefs in the list: for (auto *TD : MaterializedTypedefs)

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong added a comment. In D92101#2423685 , @shafik wrote: > Should we add a test for the `regular function template` case as well? I think this issue is specific for a `CXXDeductionGuideDecl` which is a `FunctionDecl`. I am not sure if I can follow wha

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

martong added a subscriber: balazske. martong added a comment. Hey Raphael, thanks for looking into the CTU crash! I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC 7. I think the discrepancy stems from GCC's libstdc++ and MacOS's libc++ implementation differences of `

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added a comment. In D92103#2428139 , @martong wrote: > Hey Raphael, thanks for looking into the CTU crash! > > I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC > 7. I think the discrepancy stems from GCC's libstdc++ an

[PATCH] D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92432/new/ https://reviews.llvm.org/D92432 ___ cfe-commits mailing list cfe-comm

[PATCH] D91997: APINotes: add bitcode format schema definitions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91997/new/ https://reviews.llvm.org/D91997

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

rengolin added a comment. Thanks for the changes. This looks good to me but I'll let others check again and approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/ https://reviews.llvm.org/D88393 ___ cfe-commits mailing list cfe-co

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

martong accepted this revision. martong added a comment. Looks good, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92432/new/ https://reviews.llvm.org/D92432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308933. ftynse marked 6 inline comments as done. ftynse added a comment. Address all remaining review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 Files:

[PATCH] D92269: [TableGen] Eliminate the 'code' type

Paul-C-Anagnostopoulos updated this revision to Diff 308711. Paul-C-Anagnostopoulos added a comment. Fixed some of the lint issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 Files: clang/utils/TableGen/ClangOptionDocEmitter.cpp llvm/do

[PATCH] D92269: [TableGen] Eliminate the 'code' type

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. Woot! Go Paul! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92269/new/ https://reviews.llvm.org/D92269 ___ cfe-commits mailing list cf

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

curdeius added a comment. @MyDeveloperDay, is there anything I can do to help you on that? BTW, libc++ would like to use clang-format (more than it does currently) and having concepts support would be awesome as there are more and more concept-related patches coming in. IMHO, even support for m

[PATCH] D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize

steakhal added a comment. I've double-checked the return values of each touched summary. Everything seems fine to me, besides the two I've highlighted. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1771 +.Case({ReturnValueCondition(Le

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308938. ftynse added a comment. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, rriddl

[clang] f770ec1 - [SystemZ][NFC]Move all SystemZ tests to init-s390x.c

Author: Abhina Sreeskantharajan Date: 2020-12-02T08:23:27-05:00 New Revision: f770ec1a4e8d9b274d205073e2c8b01d248cf9cb URL: https://github.com/llvm/llvm-project/commit/f770ec1a4e8d9b274d205073e2c8b01d248cf9cb DIFF: https://github.com/llvm/llvm-project/commit/f770ec1a4e8d9b274d205073e2c8b01d248c

[PATCH] D92048: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGf770ec1a4e8d: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92048

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

ASDenysPetrov added a comment. @steakhal > Losing **git blame** would have a signifficant impact in deed, however we > always have the option to add the renaming commit to the > `.git-blame-ignore-revs`. Using this git feature I can see no more obstacles to implement the renaming. Moreover LL

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse added a comment. Windows failure is unrelated, broken by an earlier commit to MLIR PDL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 ___ cfe-commits mai

[clang] 240dd92 - [OpenMPIRBuilder] forward arguments as pointers to outlined function

Author: Alex Zinenko Date: 2020-12-02T14:59:41+01:00 New Revision: 240dd92432ebbfbf24ef85779f2cdf93e6ddf605 URL: https://github.com/llvm/llvm-project/commit/240dd92432ebbfbf24ef85779f2cdf93e6ddf605 DIFF: https://github.com/llvm/llvm-project/commit/240dd92432ebbfbf24ef85779f2cdf93e6ddf605.diff

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG240dd92432eb: [OpenMPIRBuilder] forward arguments as pointers to outlined function (authored by ftynse). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

jamieschmeiser added a comment. I see you have made the requested changes (nit: clang-tidy complained about the capitalization of the function) but why are there so many other, unrelated changes shown? Is there a problem with the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. Just as a heads-up, I haven't forgotten about this. Freeing up the server just takes a little longer as I need to backup files through a DSL line. Should be ready by tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1771 +.Case({ReturnValueCondition(LessThanOrEq, ArgNo(2)), + ReturnValueCondition(WithinRange, Rang

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1957 +// host variable in a device or host device lambda. +static bool isCapturingReferenceToHostVarInCUDADeviceLambda(Sema &S, +

[PATCH] D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:2076 Summary(NoEvalCall) +.Case({ReturnValueCondition(WithinRange, Range(-1, 0))}) .ArgConstrai

[PATCH] D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize

martong updated this revision to Diff 308951. martong marked an inline comment as done. martong added a comment. - Remove comments - Hoist Range(-1,0) to ReturnsZeroOrMinusOne Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92474/new/ https://reviews

[PATCH] D92484: [clangd] Relations should not be accounted when computing backing storage size

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. ilya-golovenko requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

sdesmalen added a comment. Please rename `debug-declare-no-warnings-on-scalable-vectors.ll` to something different, because these 'warnings' are only temporary and will be replaced by errors in the future. Having 'no warnings' in the name of the test name seems wrong from that perspective. In

[clang] cd95338 - [CUDA][HIP] Fix capturing reference to host variable

Author: Yaxun (Sam) Liu Date: 2020-12-02T10:14:46-05:00 New Revision: cd95338ee3022bffd658e52cd3eb9419b4c218ca URL: https://github.com/llvm/llvm-project/commit/cd95338ee3022bffd658e52cd3eb9419b4c218ca DIFF: https://github.com/llvm/llvm-project/commit/cd95338ee3022bffd658e52cd3eb9419b4c218ca.dif

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGcd95338ee302: [CUDA][HIP] Fix capturing reference to host variable (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 308963. trixirt added a comment. address precheckin issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

joechrisellis updated this revision to Diff 308964. joechrisellis added a comment. Address @sdesmalen's comments. - Update commit message to better reflect the changes in this patch. - Rename `debug-declare-no-warnings-on-scalable-vectors.ll` to `dbg-info-scalable-typesize-warning.ll`. Reposit

[clang] 5c8911d - [CUDA][HIP] Diagnose reference of host variable

Author: Yaxun (Sam) Liu Date: 2020-12-02T10:15:56-05:00 New Revision: 5c8911d0ba3862119d2507aa55b94766263be13b URL: https://github.com/llvm/llvm-project/commit/5c8911d0ba3862119d2507aa55b94766263be13b DIFF: https://github.com/llvm/llvm-project/commit/5c8911d0ba3862119d2507aa55b94766263be13b.dif

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG5c8911d0ba38: [CUDA][HIP] Diagnose reference of host variable (authored by yaxunl). Herald added a subscriber: jvesely. Herald added a project: clang. Changed prio

[clang] d8949a8 - [hip] Fix host object creation from fatbin

Author: Michael Liao Date: 2020-12-02T10:36:01-05:00 New Revision: d8949a8ad3ca2a39ffe69df76e2c3f5fd73efec0 URL: https://github.com/llvm/llvm-project/commit/d8949a8ad3ca2a39ffe69df76e2c3f5fd73efec0 DIFF: https://github.com/llvm/llvm-project/commit/d8949a8ad3ca2a39ffe69df76e2c3f5fd73efec0.diff

[PATCH] D92418: [hip] Fix host object creation from fatbin

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8949a8ad3ca: [hip] Fix host object creation from fatbin (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92418/new/ https://reviews.llvm.

[PATCH] D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Awesome, thank you. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1771 +.Case({ReturnValueCondition(LessThanOrEq, ArgNo(2)), +

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. I stumbled over one problem with my patch which is that when I run an x32 version of clang in a x32 environment, it will still default to "-m64" instead of "-mx32". Thus: glaubitz@epyc:..llvm-project/build> ./bin/clang hello.c -o hello /usr/bin/ld: cannot find crt

[PATCH] D92445: [PowerPC] Add powerpcle target.

sfertile added a comment. > On FreeBSD, the main use of this will be on the new powerpc64le arch, where > we need to build a 32-bit LE bootloader for use with pseries. (it is easier > to retarget LLVM than make a cross-endian bootloader, as it would involve > rewriting filesystem code etc.) Ex

[PATCH] D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend

peterwaller-arm created this revision. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. peterwaller-arm requested review of this revision. ... and give more guidance to users. If specifying -msve-vector-bits

[PATCH] D92445: [PowerPC] Add powerpcle target.

tstellar added a comment. Could you add some more information to the commit message to better describe the powerpcle target. It's not clear from the target name exactly what it is for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ htt

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2428560 , @glaubitz wrote: > Any idea how it could make clang default to `-mx32` if this condition is met: > `getToolChain().getTriple().getEnvironment() == llvm::Triple::GNUX32`? That sounds like it's one thing in http

[PATCH] D92354: [clang] add a new `swift_attr` attribute

erik.pilkington added a comment. Do we need to add APINotes support for this? Comment at: clang/include/clang/Basic/Attr.td:2155 + let Args = [StringArgument<"Attribute">]; + let Documentation = [SwiftAttrDocs]; +} Should we limit this to appear on certain su

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. I don't think it was far off, I just I agreed with @klimek in trying to address the many different cases that came up I started to feel that `parseConstraintExpression` was becoming fragile Having said that I like to think because they are in concepts specific p

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D80450#2426507 , @tra wrote: > LGTM. > > I'd suggest adding more details on the background of this change to the > commit log (point to the comment in the `isBetterOverloadCandidate` ?) a

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92054/new/ https://reviews.llvm.org/D92054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D92355: [clang] add a `swift_async_name` attribute

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/AttrDocs.td:3640 +The argument is a string literal that contains the Swift name of the function or +method. The

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428590 , @hvdijk wrote: > That sounds like it's one thing in > https://lists.llvm.org/pipermail/llvm-dev/2020-October/146049.html I haven't > extracted into a separate patch for submission yet: LLVM does not call > `

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:108 + + virtual bool hasInt128Type() const { return false; } }; jdoerfert wrote: > Not virtual but override. Thank you. I will change that. Comment at: clang/lib/Sema/Sem

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428685 , @glaubitz wrote: > I have not found the place yet in clang where to adjust that. Maybe `sys::getDefaultTargetTriple()` needs to be adjusted. I'll have a look. Repository: rG LLVM Github Monorepo CHANGES S

[clang] b40b319 - [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize

Author: Gabor Marton Date: 2020-12-02T17:54:48+01:00 New Revision: b40b3196b32110f00b7610851f4ef182ac751ba0 URL: https://github.com/llvm/llvm-project/commit/b40b3196b32110f00b7610851f4ef182ac751ba0 DIFF: https://github.com/llvm/llvm-project/commit/b40b3196b32110f00b7610851f4ef182ac751ba0.diff

[PATCH] D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize

This revision was automatically updated to reflect the committed changes. Closed by commit rGb40b3196b321: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions… (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

orivej added a comment. Could somebody review this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92001/new/ https://reviews.llvm.org/D92001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Other than the nit, LGTM. Comment at: clang/lib/Sema/SemaType.cpp:7789 +S.Diag(Attr.getLoc(), diag::err_attribute_unsupported) +<< Attr << "'neon' or 'mve'

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2428693 , @glaubitz wrote: > Maybe `sys::getDefaultTargetTriple()` needs to be adjusted. I'll have a look. `sys::getDefaultTargetTriple()` defaults to `LLVM_DEFAULT_TARGET_TRIPLE`, which in turn defaults to `LLVM_HOST_TR

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. The problem seems to be that `LLVM_HOST_TRIPLE:STRING` is set to `x86_64-unknown-linux-gnu` instead of ``x86_64-unknown-linux-gnux32`. I haven't found the place to fix that yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428709 , @hvdijk wrote: > `sys::getDefaultTargetTriple()` defaults to `LLVM_DEFAULT_TARGET_TRIPLE`, > which in turn defaults to `LLVM_HOST_TRIPLE`, which in turn defaults to > `LLVM_INFERRED_HOST_TRIPLE`, which calls

[PATCH] D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend

peterwaller-arm updated this revision to Diff 308989. peterwaller-arm added a comment. Tweak message to address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92487/new/ https://reviews.llvm.org/D92487 Files: clang/include/clang/B

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2428735 , @glaubitz wrote: > Hmm, I was pretty sure that autoconf can deal with x32 inside an x32 chroot. Most autoconf-using software won't be dealing with a copy of `config.guess` that was last updated in 2011. Updatin

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428743 , @hvdijk wrote: > In D52050#2428735 , @glaubitz wrote: > >> Hmm, I was pretty sure that autoconf can deal with x32 inside an x32 chroot. > > Most autoconf-using software

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

jrtc27 added a comment. In D52050#2428743 , @hvdijk wrote: > In D52050#2428735 , @glaubitz wrote: > >> Hmm, I was pretty sure that autoconf can deal with x32 inside an x32 chroot. > > Most autoconf-using software wo

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jdoerfert added a comment. So, NVPTX seems to do something sensible with i128, though I haven't done rigorous testing. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 308995. aeubanks added a comment. fix capitalization remove extra declaration and fixup includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: llvm/include/

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 309000. aeubanks added a comment. clean up some more unnecessary llvm:: add comments to function declarations in PrintPasses.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jdoerfert wrote: > jyu

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added a comment. In D87216#2428359 , @jamieschmeiser wrote: > I see you have made the requested changes (nit: clang-tidy complained about > the capitalization of the function) but why are there so many other, > unrelated changes shown? Is ther

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

vsk added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2524 // defined. - if (Ty->getPointeeType().isVolatileQualified()) + if (!Ty->getPointeeType().isNull() && Ty->getPointeeType().isVolatileQualified()) return; Is the pointee t

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2524 // defined. - if (Ty->getPointeeType().isVolatileQualified()) + if (!Ty->getPointeeType().isNull() && Ty->getPointeeType().isVolatileQualified()) return; vsk wrote

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 308994. xndcn added a comment. `getHoverInfo(CXXThisExpr->getType()->getPointeeType(), ...)` does not output namespace scope and template parameters without specialization: F14499632: Pointee.png while `getHoverInfo(CXXThis

[PATCH] D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This can happen when, for example, merging results from an external index t

[PATCH] D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file.

adamcz updated this revision to Diff 309003. adamcz added a comment. -bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92494/new/ https://reviews.llvm.org/D92494 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/un

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, doug.gregor, aaron.ballman. Herald added subscribers: dexonsmith, ributzka, jfb, jkorous. erik.pilkington requested review of this revision. You can read more about the clang attributes for swift async here: https://

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

MaskRay added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ Generally `%clang` is o

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

tra added a comment. In D80450#2428631 , @yaxunl wrote: >> Also, naming. `-ffix-overload-resolution` is rather non-specific. I didn't >> mean to use it literally. The problem is that I can't think of a good >> descriptive name for what we do here. `-fgp

[clang] a65d8c5 - [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

Author: jasonliu Date: 2020-12-02T18:42:44Z New Revision: a65d8c5d720db8c646adb0ad9dac54da5d5fa230 URL: https://github.com/llvm/llvm-project/commit/a65d8c5d720db8c646adb0ad9dac54da5d5fa230 DIFF: https://github.com/llvm/llvm-project/commit/a65d8c5d720db8c646adb0ad9dac54da5d5fa230.diff LOG: [XCO

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGa65d8c5d720d: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX (authored by jasonliu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D91455?vs=308752&

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen updated this revision to Diff 309020. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

nickdesaulniers added a comment. Hi @trixirt , thanks for the follow up. I think the lint feedback about qualifying `auto` with pointers where applicable would be nice to have. Please make those suggested changes. Should https://reviews.llvm.org/D90180 be abandoned in favor of this patch? Wou

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. In D91756#2427795 , @hoy wrote: > In D91756#2427759 , @wmi wrote: > >> Another question. Sorry for not bringing it up

[PATCH] D92355: [clang] add a `swift_async_name` attribute

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. There's no information in either the attribute definition in Attr.td or in the documentation as to what subject this attribute applies to. Comment at

[PATCH] D92354: [clang] add a new `swift_attr` attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2153 +def SwiftAttr : InheritableAttr { + let Spellings = [Clang<"swift_attr">]; + let Args = [StringArgument<"Attribute">]; The other swift attributes use a GNU spelling and don

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2428563 , @sfertile wrote: >> On FreeBSD, the main use of this will be on the new powerpc64le arch, where >> we need to build a 32-bit LE bootloader for use with pseries. (it is easier >> to retarget LLVM than make a

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2710 +**SpacesInLineComments** (``SpacesInLineComment``) + How many spaces are allowed at the start of a line comment. To disable the MyDeveloperDay wrote: > Is this c

[clang] 70764c0 - [CMake][Fuchsia] Install llvm-elfabi

Author: Roland McGrath Date: 2020-12-02T11:59:14-08:00 New Revision: 70764c02e474504e2ebfb5b230a3b2ccdbedc5c2 URL: https://github.com/llvm/llvm-project/commit/70764c02e474504e2ebfb5b230a3b2ccdbedc5c2 DIFF: https://github.com/llvm/llvm-project/commit/70764c02e474504e2ebfb5b230a3b2ccdbedc5c2.diff

[PATCH] D92444: [CMake][Fuchsia] Install llvm-elfabi

This revision was automatically updated to reflect the committed changes. Closed by commit rG70764c02e474: [CMake][Fuchsia] Install llvm-elfabi (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92444/new/ https://reviews.llvm.org

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. This looks great to me, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https://reviews.llvm.org/D92495 ___

[clang] 2ac5880 - Update MS ABI mangling for union constants based on new information from

Author: Richard Smith Date: 2020-12-02T12:17:52-08:00 New Revision: 2ac58801873ab99dd5de48ad7557b76f1803100b URL: https://github.com/llvm/llvm-project/commit/2ac58801873ab99dd5de48ad7557b76f1803100b DIFF: https://github.com/llvm/llvm-project/commit/2ac58801873ab99dd5de48ad7557b76f1803100b.diff

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jyu2 wrote: > jdoerfer

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 309039. Conanap marked 6 inline comments as done. Conanap added a comment. Addressed some formatting comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.

  1   2   >