yaxunl marked 2 inline comments as done. yaxunl added a comment. In D80450#2426507 <https://reviews.llvm.org/D80450#2426507>, @tra wrote:
> LGTM. > > I'd suggest adding more details on the background of this change to the > commit log (point to the comment in the `isBetterOverloadCandidate` ?) and > outline the intention to enable the new way to do overloading after some soak > time. Will do. > Also, naming. `-ffix-overload-resolution` is rather non-specific. I didn't > mean to use it literally. The problem is that I can't think of a good > descriptive name for what we do here. `-fgpu-fix-wrong-side-overloads` ? > Something else? How about `-fgpu-exclude-wrong-side-overloads`? Since what this patch does is always excluding wrong side overloads whereas previously only excluding wrong side overloads if there are same side overloads. ================ Comment at: clang/lib/Sema/SemaOverload.cpp:9621 + // is never shown up here. The worst preference shown up here is 'wrong side', + // e.g. a host function called by a device host function in device + // compilation. This is valid AST as long as the host device function is not ---------------- tra wrote: > The comment uses device/host for both function attributes and when it refers > to the compilation phase. It would help to make it more readable if function > attributes would be distinct from compilation phase. E.g. by using `__host__ > __device__` or `HD`. will use H/D/HD for function attribute when committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
