[PATCH] D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG88b7b76a0b23: [AVR][clang] Pass the address of the data section to the linker for ATmega328 (authored by dylanmckay). Cha

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

martong added a comment. In D88859#2359399 , @compnerd wrote: >> I'd like to have maximum flexibility from the submitter by willing to change >> the details of the implementation > > I don't think that is a fair expectation - there are plenty of times whe

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

martong added inline comments. Comment at: clang/lib/APINotes/APINotesYAMLCompiler.cpp:33 +namespace yaml { +template <> +struct ScalarEnumerationTraits { Could you please clang-format the code? The `Lint: Pre-merge checks` are all over the code and makes the re

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jhuber6 added a comment. In D89802#2359504 , @tianshilei1992 wrote: > This patch caused segment fault in D90099 > where the map variable info pointer is `nullptr` but it is deferenced. Was it this one, or was it D90172

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. In D89802#2359537 , @jhuber6 wrote: > In D89802#2359504 , @tianshilei1992 > wrote: > >> This patch caused segment fault in D90099 >> where the map

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dblaikie added a comment. In D88603#2357973 , @dschuff wrote: > This broke the bots for some strange reason that didn't reproduce locally. > But because it was ~all of them, I probably just did something stupid. Good to have links to buildbots and/or quo

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay added a comment. In D89799#2345004 , @awarzynski wrote: > Thank you all for you comments! Please find my replies below. I've picked 4 > main points raised here. > > 1 > - > > In D89799#2342677 , @rnk wrote:

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante updated this revision to Diff 301332. Mordante marked an inline comment as done. Mordante added a comment. Addressed the review comments: - The likelhood attribute no longer affects the `do` statement. - Added a diagnotic when a likelihood attribute is used on an infinite while loop. No

[clang-tools-extra] 87f03e1 - [clangd] Don't offer to expand auto in structured binding declarations.

Author: Sam McCall Date: 2020-10-28T18:55:23+01:00 New Revision: 87f03e13ce0e840d7eb9a4a6d805d117fe165672 URL: https://github.com/llvm/llvm-project/commit/87f03e13ce0e840d7eb9a4a6d805d117fe165672 DIFF: https://github.com/llvm/llvm-project/commit/87f03e13ce0e840d7eb9a4a6d805d117fe165672.diff LO

[PATCH] D89700: [clangd] Don't offer to expand auto in structured binding declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG87f03e13ce0e: [clangd] Don't offer to expand auto in structured binding declarations. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

MaskRay added inline comments. Comment at: llvm/tools/llvm-mc/CMakeLists.txt:6 AllTargetsInfos + CodeGen MC craig.topper wrote: > Why did this patch need to make llvm-mc dependent on CodeGen? It doesn't. Deleted in 7011a2f3504b43e57eda5dbc1f23a3f9c1b44593

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM but is there a functional reason why CmdArgs was changed to be passed by reference? If just generic cleanup might be better to split up that into a separate commit. Repository:

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

yaxunl added a comment. In D89799#2359553 , @MaskRay wrote: > > The original purposes have mostly been eliminated. The remaining is now > -Xarch. OK. Then let's rename it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

mtrofin added a comment. In D90278#2359674 , @tejohnson wrote: > LGTM but is there a functional reason why CmdArgs was changed to be passed by > reference? If just generic cleanup might be better to split up that into a > separate commit. It avoids havi

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize Optional

dexonsmith added a comment. In D89834#2357910 , @dexonsmith wrote: > Dropped `MaybeFileEntryRef`, instead customizing `Optional`. As @arphaman pointed out offline, we can actually `OptionalStorage` instead, by adding add a private constructor to `FileEnt

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rnk added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2490 +ThisAdjustment += getASTRecordLayout(Derived).getBaseClassOffset(Base); +RD = Path[I]; + } rjmccall wrote: > What should we do on targets that allow virtual bases in member pointer

[PATCH] D81508: [PowerPC] Add __vector_pair and __vector_quad types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40dd4d5233d9: [Clang][PowerPC] Add __vector_pair and __vector_quad types (authored by bsaleil). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 40dd4d5 - [Clang][PowerPC] Add __vector_pair and __vector_quad types

Author: Baptiste Saleil Date: 2020-10-28T13:19:20-05:00 New Revision: 40dd4d5233d9f81705a24d91b48d2620e487b89d URL: https://github.com/llvm/llvm-project/commit/40dd4d5233d9f81705a24d91b48d2620e487b89d DIFF: https://github.com/llvm/llvm-project/commit/40dd4d5233d9f81705a24d91b48d2620e487b89d.dif

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdff3bd93287: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode (authored by nickdesaulniers). Repository: rG LLVM Github Mono

[clang] cdff3bd - [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

Author: Nick Desaulniers Date: 2020-10-28T11:20:30-07:00 New Revision: cdff3bd932870cc9f84c6828cb1a7bb0df3c5fa0 URL: https://github.com/llvm/llvm-project/commit/cdff3bd932870cc9f84c6828cb1a7bb0df3c5fa0 DIFF: https://github.com/llvm/llvm-project/commit/cdff3bd932870cc9f84c6828cb1a7bb0df3c5fa0.di

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301353. tianshilei1992 added a comment. Fixed all failed test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntime.cp

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall updated this revision to Diff 301357. sammccall marked 5 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89743/new/ https://reviews.llvm.org/D89743 Files: clang/docs/Li

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall added a comment. In D89743#2356172 , @aaron.ballman wrote: > I was sort of expecting `hasAttr()` to be deprecated because it is a leaky > abstraction (consumers of the API have to know about our internal naming > convention for attribute kind

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:323 + /// Describe the AST subtree for a piece of code. + void getAST(PathRef File, Range, Callback>); + adamcz wrote: > Any reason

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

sammccall updated this revision to Diff 301364. sammccall marked 2 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89571/new/ https://reviews.llvm.org/D89571 Files: clang-tools-e

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh created this revision. kernigh added reviewers: brad, nemanjai, efriedma. Herald added subscribers: cfe-commits, shchenz, kbarton. Herald added a project: clang. kernigh requested review of this revision. In the PPC32 SVR4 ABI, a va_list has copies of registers from the function call. va_

[PATCH] D90330: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule

mtrofin created this revision. mtrofin added a reviewer: tejohnson. Herald added subscribers: llvm-commits, cfe-commits, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. mtrofin requested review of this revision. Changing to pass by ref - less null checks to worry about. Rep

[clang-tools-extra] 0e94836 - [clangd] Go-to-definition from non-renaming alias is unambiguous.

Author: Sam McCall Date: 2020-10-28T20:17:35+01:00 New Revision: 0e94836989a12e11b4717f01099e34dbc0ff25d4 URL: https://github.com/llvm/llvm-project/commit/0e94836989a12e11b4717f01099e34dbc0ff25d4 DIFF: https://github.com/llvm/llvm-project/commit/0e94836989a12e11b4717f01099e34dbc0ff25d4.diff LO

[PATCH] D89238: [clangd] Go-to-definition from non-renaming alias is unambiguous.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e94836989a1: [clangd] Go-to-definition from non-renaming alias is unambiguous. (authored by sammccall). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D90330: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm except for the part that should go back into D90278 as noted below. Comment at: llvm/include/llvm/Bitcode/BitcodeWriter.h:165

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

davidxl added a comment. Herald added a subscriber: dexonsmith. There should be a related LLVM side of changes. Is it in a different patch? Comment at: clang/lib/CodeGen/CodeGenModule.cpp:587 - if (CodeGenOpts.CFProtectionBranch && - Target.checkCFProtectionBranchSuppor

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

davidxl added a comment. longer term, the profile will be dumped into PGO's raw file, so for now is there a need for a user level option? should an internal option good enough? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89087/new/ https://revie

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

Mordante created this revision. Mordante added reviewers: aaron.ballman, rjmccall, rsmith. Mordante added a project: clang. Mordante requested review of this revision. Adds a diagnostic when the user annotates an `if constexpr` with a likelihood attribute. The `if constexpr` statement is evaluate

[PATCH] D90330: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa35541a0af: [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule (authored by mtrofin). Changed prior to commit: https://reviews.l

[clang] 6fa3554 - [NFC][ThinLTO] Change command line passing to EmbedBitcodeInModule

Author: Mircea Trofin Date: 2020-10-28T12:33:39-07:00 New Revision: 6fa35541a0af9d5493e288f574896ee33a8eae92 URL: https://github.com/llvm/llvm-project/commit/6fa35541a0af9d5493e288f574896ee33a8eae92 DIFF: https://github.com/llvm/llvm-project/commit/6fa35541a0af9d5493e288f574896ee33a8eae92.diff

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 301388. flx added a comment. Add instantiated template method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop updated this revision to Diff 301331. russell.gallop added a comment. Herald added a subscriber: dexonsmith. Apologies for the delay, I've had a few other things on. I've worked through the tests. Several I've marked as unsupported on windows as they use things unixy things like n

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman added a reviewer: klimek. aaron.ballman added a comment. Adding @klimek as a reviewer since I forgot to do that last time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89743/new/ https://reviews.llvm.org/D89743 _

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D89743#2359764 , @sammccall wrote: > In D89743#2356172 , @aaron.ballman > wrote: > >> I was s

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 301389. flx added a comment. Comment out replaced parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cp

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx added a comment. In D90042#2357078 , @aaron.ballman wrote: > In D90042#2356265 , @flx wrote: > >> In D90042#2356180 , @aaron.ballman >> wrote: >> >>> In D90042#2350035

[PATCH] D90026: [FPEnv] Tests for rounding properties of constant evalution

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. The failing unit test reported above, sizes.cpp, looks like it should be an Expected Fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90026/

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

mtrofin updated this revision to Diff 301391. mtrofin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90278/new/ https://reviews.llvm.org/D90278 Files: clang/test/CodeGen/thinlto_embed_bitcode.ll llvm/include/llvm/Bitcode

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

tejohnson accepted this revision. tejohnson added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90278/new/ https://reviews.llvm.org/D90278 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

dexonsmith updated this revision to Diff 301394. dexonsmith retitled this revision from "FileManager: Improve the FileEntryRef API and customize Optional" to "FileManager: Improve the FileEntryRef API and customize its OptionalStorage". dexonsmith edited the summary of this revision. dexonsmith a

[PATCH] D90099: [Clang][OpenMP] Added the support for target data nowait

tianshilei1992 added a comment. The two failed test cases should have nothing to do with this patch. Will merge this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 _

[PATCH] D90099: [Clang][OpenMP] Added the support for target data nowait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0661328d7efb: [Clang][OpenMP] Added the support for target data nowait (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89836: Change Module::ASTFile and ModuleFile::File => Optional, NFC

dexonsmith updated this revision to Diff 301396. dexonsmith added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89836/new/ https://reviews.llvm.org/D89836 Files: clang/include/clang/Basic/FileEntry.h clang/include/clang/Basic/Module.h clang/include/clang/Seria

[clang] 0661328 - [Clang][OpenMP] Added the support for target data nowait

Author: Shilei Tian Date: 2020-10-28T15:53:30-04:00 New Revision: 0661328d7efb81a8ac7f2ca0734a65f9be105f29 URL: https://github.com/llvm/llvm-project/commit/0661328d7efb81a8ac7f2ca0734a65f9be105f29 DIFF: https://github.com/llvm/llvm-project/commit/0661328d7efb81a8ac7f2ca0734a65f9be105f29.diff L

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

dexonsmith updated this revision to Diff 301399. dexonsmith added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 Files: clang/include/clang/Basic/FileManager.h clang/include/clang/Basic/SourceManager.h clang/include/cl

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

dexonsmith updated this revision to Diff 301402. dexonsmith added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/ https://reviews.llvm.org/D89834 Files: clang/include/clang/Basic/FileEntry.h clang/unittests/Basic/CMakeLists.txt clang/unittests/Bas

[PATCH] D31363: [libc++] Remove cmake glob for source files

ldionne added a comment. This patch isn't necessary anymore, as we don't use globing anymore. Let's abandon it to clean up the review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31363/new/ https://reviews.llvm.org/D31363 ___ cfe-com

[PATCH] D31363: [libc++] Remove cmake glob for source files

ldionne added a comment. In D31363#2360132 , @ldionne wrote: > This patch isn't necessary anymore, as we don't use globing anymore. Let's > abandon it to clean up the review queue. Actually, I misspoke. We still use it, but only in a few places. If you s

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added inline comments. Comment at: clang/include/clang/APINotes/Types.h:25 +/// auditing. +enum class EnumExtensibilityKind { + None, martong wrote: > compnerd wrote: > > martong wrote: > > > compnerd wrote: > > > > martong wrote: > > > > > This seems a

[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

aeubanks added a comment. This was reverted due to crashes caused by adding branch weights overflowing uint64_t. Now in BranchProbabilityInfo.cpp, if the sum of weights overflows, scale down all weights by UINT32_MAX (See `ScaleWeights()`). Is that ok? Repository: rG LLVM Github Monorepo CH

[PATCH] D68997: Allow searching for prebuilt implicit modules.

dexonsmith added a comment. @arames, I see you've had a number of commits. I suggest you request commit access: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Comment at: clang/docs/Modules.rst:358 + +This way, a single directory containing multiple variant

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski updated this revision to Diff 301414. awarzynski added a comment. Remove the diagnostic - Deleted the `err_drv_invalid_Xarch_argument_unsupported` diagnostic - Removed `const` from &getDiags() - otherwise I couldn't use `getCustomDiagID` (which is a non-const member function). `Diagno

[clang] 23ed570 - Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-28T16:38:32-04:00 New Revision: 23ed570af1cc165afea1b70a533a4a39d6656501 URL: https://github.com/llvm/llvm-project/commit/23ed570af1cc165afea1b70a533a4a39d6656501 DIFF: https://github.com/llvm/llvm-project/commit/23ed570af1cc165afea1b70a533a4a39d665

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG23ed570af1cc: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

dexonsmith added a comment. Thanks @JDevlieghere for the review! This landed in 23ed570af1cc165afea1b70a533a4a39d6656501 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89761/new

[PATCH] D89835: ModuleManager: Simplify lookupModuleFile by only setting the out parameter once, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89835/new/ https://reviews.llvm.org/D89835 ___ cfe-commits mailing list cfe

[PATCH] D89836: Change Module::ASTFile and ModuleFile::File => Optional, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89836/new/ https://reviews.llvm.org/D89836 ___ cfe-commits mailing list cfe

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall added a comment. (while this is useful to you, let's keep discussing, but I'm also happy to stop and land this with your preferred API/semantics - just LMK if changes are needed) In D89743#2360032 , @aaron.ballman wrote: > Thank you for givin

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne added a comment. Re-reading this. the whole discussion about `filesystem` is now irrelevant, since it's part of the dylib. The comment I have is that `libc++.dylib` is considered to be a system library on macOS, not a toolchain-provided library. This matters because we make sure that `

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

krasimir added a comment. In D90121#2358730 , @dmikis wrote: > @krasimir What would our next steps be to get this change into LLVM source > tree? JIC, I don't have commit rights :) I'll commit this for you. If you're planning to commit regularly, and aft

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne added a comment. Note: This patch basically implements **Solution (1)**. I would love to see it rebased onto `master` and for tests to be added if we're all comfortable going down that route. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45639/new/ http

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers added a comment. > It's trivial to not create a new enum value and always pass -stack-protector > along That was incorrect. Rebasing this on top of D90271 causes 49 test failures, because the diff I posted above didn't actually remove the new

[PATCH] D81748: [PowerPC] Add MMA builtin decoding and definitions

bsaleil updated this revision to Diff 301437. bsaleil added a comment. Fix typo and add comment to explain why we add the `ASTContext::DecodeTypeStr` function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81748/new/ https://reviews.llvm.org/D8174

[clang] 09abece - PR48002: Fix injection of elaborated-type-specifiers within local

Author: Richard Smith Date: 2020-10-28T14:29:45-07:00 New Revision: 09abecef7bbfda18d34f046954eaa4d491062839 URL: https://github.com/llvm/llvm-project/commit/09abecef7bbfda18d34f046954eaa4d491062839 DIFF: https://github.com/llvm/llvm-project/commit/09abecef7bbfda18d34f046954eaa4d491062839.diff

[PATCH] D90336: [Sema] Diagnose annotating `if constexpr` with a likelihood attribute

rjmccall added a comment. Patch generally looks good. Minor complaint about how you're using notes. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3163 def note_attribute_has_no_effect_here : Note< - "annotating the %select{infinite loop}0 here">; + "annotatin

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 added a comment. Herald added a subscriber: dexonsmith. > What issues did you run into regarding testing, because I feel like the patch > should have test coverage (esp given that color vs ANSI escape codes are a > bit of an oddity to reason about)? I'm unable to create a debug build

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff added a comment. In D88603#2359554 , @dblaikie wrote: > In D88603#2357973 , @dschuff wrote: > >> This broke the bots for some strange reason that didn't reproduce locally. >> But because it was ~all of them

[clang] ebfc427 - [Sema] Let getters assert that trailing return type exists, NFCI

Author: Aaron Puchert Date: 2020-10-28T23:32:57+01:00 New Revision: ebfc427bbe08f0c36af9721d5a4e6d3ffe2e4bf5 URL: https://github.com/llvm/llvm-project/commit/ebfc427bbe08f0c36af9721d5a4e6d3ffe2e4bf5 DIFF: https://github.com/llvm/llvm-project/commit/ebfc427bbe08f0c36af9721d5a4e6d3ffe2e4bf5.diff

[clang] 5dbccc6 - Better source location for -Wignored-qualifiers on trailing return types

Author: Aaron Puchert Date: 2020-10-28T23:32:57+01:00 New Revision: 5dbccc6c89c0f6c6dc6277cc304057f6d50b298d URL: https://github.com/llvm/llvm-project/commit/5dbccc6c89c0f6c6dc6277cc304057f6d50b298d DIFF: https://github.com/llvm/llvm-project/commit/5dbccc6c89c0f6c6dc6277cc304057f6d50b298d.diff

[PATCH] D90129: Better source location for -Wignored-qualifiers on trailing return types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG5dbccc6c89c0: Better source location for -Wignored-qualifiers on trailing return types (authored by aa

[PATCH] D90129: Better source location for -Wignored-qualifiers on trailing return types

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Added the assertions in a follow-up change rGebfc427bbe08f0c36af9721d5a4e6d3ffe2e4bf5 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers updated this revision to Diff 301458. nickdesaulniers added a comment. - rebase on D90271 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90194/new/ https://reviews.llvm.org/D90194 Files: clang/inc

[PATCH] D90348: [Driver] specify -stack-protector 0 for -fno-stack-protector

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, manojgupta. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers requested review of this revision. `-fno-stack-protector` now explicitly sets `-stack-protector 0` for the invocation of

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

smeenai added a comment. In D45639#2360267 , @ldionne wrote: > - AppleClang prefers the headers in the SDK, and the library in the SDK. (The > headers are currently still shipped in the toolchain but they should be > ignored if you have a sufficiently re

[PATCH] D90348: [Driver] specify -stack-protector 0 for -fno-stack-protector

nickdesaulniers added a comment. Might be nice to add an integration test where `-fno-stack-protector` results in `nossp` function attributes (so `-fno-stack-protector` -> `-stack-protector 0` -> `nossp` fn attrs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D90348: [Driver] specify -stack-protector 0 for -fno-stack-protector

nickdesaulniers added a comment. In D90348#2360621 , @nickdesaulniers wrote: > Might be nice to add an integration test where `-fno-stack-protector` results > in `nossp` function attributes (so `-fno-stack-protector` -> > `-stack-protector 0` -> `nossp`

[clang] 946406a - ModuleManager: Simplify lookupModuleFile by only setting the out parameter once, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-28T19:04:22-04:00 New Revision: 946406aebce298725b07097934cb39b1e5bee656 URL: https://github.com/llvm/llvm-project/commit/946406aebce298725b07097934cb39b1e5bee656 DIFF: https://github.com/llvm/llvm-project/commit/946406aebce298725b07097934cb39b1e5be

[PATCH] D89835: ModuleManager: Simplify lookupModuleFile by only setting the out parameter once, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG946406aebce2: ModuleManager: Simplify lookupModuleFile by only setting the out parameter once… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. Thank you for all your work! IIRC everything was working except as you point out some of the very Unixy tests. Is your build creating a `clang_rt.scudo_cxx` library that also needs to be link as well? The C++ specific interceptors usually end up in a separate library t

[PATCH] D89988: adds basic -Wfree-nonheap-object functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG425a83a5f069: [Sema] adds basic -Wfree-nonheap-object functionality (authored by cjdb, committed by george.burgess.iv). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANG

[clang] 425a83a - [Sema] adds basic -Wfree-nonheap-object functionality

Author: Christopher Di Bella Date: 2020-10-28T16:18:23-07:00 New Revision: 425a83a5f069eb1a692145d2c92e6d3bfe564a62 URL: https://github.com/llvm/llvm-project/commit/425a83a5f069eb1a692145d2c92e6d3bfe564a62 DIFF: https://github.com/llvm/llvm-project/commit/425a83a5f069eb1a692145d2c92e6d3bfe564a6

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7669f3c0f69d: Recommit "[CodeView] Emit static data members as S_CONSTANTs." (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 7669f3c - Recommit "[CodeView] Emit static data members as S_CONSTANTs."

Author: Amy Huang Date: 2020-10-28T16:35:59-07:00 New Revision: 7669f3c0f69db78cdd3deef066abc99f60fc580d URL: https://github.com/llvm/llvm-project/commit/7669f3c0f69db78cdd3deef066abc99f60fc580d DIFF: https://github.com/llvm/llvm-project/commit/7669f3c0f69db78cdd3deef066abc99f60fc580d.diff LOG

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh added a comment. I'm using this TargetInfo.cpp diff in clang 10.0.1 on OpenBSD/macppc to build GNUstep. For me, it fixes the build of gnustep-gui. I rebuilt libobjc2, gnustep-make, and gnustep-base before building gnustep-gui. This diff doesn't change 64-bit PowerPC, because 64-bit does

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff updated this revision to Diff 301486. dschuff added a comment. use getOrCreate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/ https://reviews.llvm.org/D88603 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/debu

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff updated this revision to Diff 301488. dschuff added a comment. can't just getOrCreate symbol without dealing with the section just disable the test for now as we don't need dw5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/ https:

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff updated this revision to Diff 301490. dschuff added a comment. fix diff; it should be against master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/ https://reviews.llvm.org/D88603 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D89184: Support complex target features combinations

LiuChen3 added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 77973f8 - [WebAssembly] Add support for DWARF type units

Author: Derek Schuff Date: 2020-10-28T17:41:22-07:00 New Revision: 77973f8dee6d4d6f1b7c2a026249c1f7068f267b URL: https://github.com/llvm/llvm-project/commit/77973f8dee6d4d6f1b7c2a026249c1f7068f267b DIFF: https://github.com/llvm/llvm-project/commit/77973f8dee6d4d6f1b7c2a026249c1f7068f267b.diff

[PATCH] D89184: Support complex target features combinations

echristo added a comment. I'll take a look tomorrow, sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

dschuff added a comment. @sbc100 I found that the cause of the assertion is that in dwarf 5, the type units apparently go in the .debug_info section (instead of the .debug_type section), and this section already exists (but it was created as a non-comdat). So when `getWasmSection` tries to look

[PATCH] D89184: Support complex target features combinations

LiuChen3 added a comment. In D89184#2360846 , @echristo wrote: > I'll take a look tomorrow, sorry for the delay. No problem. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 _

[PATCH] D90357: [WebAssembly] Implement SIMD signselect instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in https://github.com

[clang] 735ab4b - [ThinLTO] Fix .llvmcmd emission

Author: Mircea Trofin Date: 2020-10-28T17:45:30-07:00 New Revision: 735ab4be35695df9f9da7ae8b584cec28eabf1fe URL: https://github.com/llvm/llvm-project/commit/735ab4be35695df9f9da7ae8b584cec28eabf1fe DIFF: https://github.com/llvm/llvm-project/commit/735ab4be35695df9f9da7ae8b584cec28eabf1fe.diff

[PATCH] D90278: [ThinLTO] Fix .llvmcmd emission

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG735ab4be3569: [ThinLTO] Fix .llvmcmd emission (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

<    1   2   3   >