mtrofin added a comment. In D90278#2359674 <https://reviews.llvm.org/D90278#2359674>, @tejohnson wrote:
> LGTM but is there a functional reason why CmdArgs was changed to be passed by > reference? If just generic cleanup might be better to split up that into a > separate commit. It avoids having to also check if that thing's empty. I can do that first as a NFC and re-sync. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90278/new/ https://reviews.llvm.org/D90278 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
