[PATCH] D87981: [X86] AMX programming model prototype.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin.h:259 +__DEFAULT_FN_ATTRS +void __tile_loadd(__tile *dst, const void *base, long stride) { + dst->tile = _tile_loadd_internal(dst->row, dst->col, base, stride); unsigned long long?

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

uabelho added a comment. We got similar problems for our downstream target. We worked around that by bailing out early in PragmaSTDC_FENV_ACCESSHandler::HandlePragma for our target but perhaps one could check hasStrictFP() instead and ignore the pragma if that is false? Repository: rG LLVM

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:33 + + for (const FunctionDecl *D : Node.redecls()) +if (D->getASTContext().getSourceManager().isInSystemHeader( a

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

nikic added a comment. If you are not invoking all the needed callbacks in invokeRegisteredO0EPCallbacks(), I would suggest to instead provide a set of methods like invokePipelineStartEPCallbacks(), invokeOptimizerLastEPCallbacks() that allow the consumer to chose which callbacks to invoke. (Ju

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/include/llvm/CodeGen/TileShapeInfo.h:9 +// +// This file defines TileShapeInfo for AMX. +// pengfei wrote: > Do you want to use `TileShapeInfo` for the class name or forget to change the > comment to `ShapeT`? I

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. Ping I don't have commit access, can anyone help me commit this with "Yang Fan " ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 _

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas updated this revision to Diff 301198. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. - `replaceChildRangeLowLevel` now takes Begin instead of BeforeBegin - `appendChildLowLevel` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

sammccall added a comment. Thanks for doing this! Main points: - I think we should have one high-level concept of "the optional associated directory" rather than two low-level ones of "the location of the config file" and "should we use the location to form relative paths" - We need to be care

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:109 Node *getNextSibling() { return NextSibling; } + const Node *getPreviousSibling() const { return PreviousSibling; } + Node *getPreviousSib

[PATCH] D89794: [SyntaxTree] Implement "by-pointer output parameter to return value" refactoring.

eduucaldas added a subscriber: gribozavr2. eduucaldas added a comment. This patch will build upon https://reviews.llvm.org/D90240 and https://reviews.llvm.org/D90161 When those patches land, work on this patch will resume. It is here to illustrate the relevance of the previous patches and the ge

[PATCH] D90221: Include attribute details when dumping AST in JSON

aronsky added a comment. In D90221#2357060 , @aaron.ballman wrote: > In D90221#2356110 , @aronsky wrote: > >> In D90221#2356062 , @lebedev.ri >> wrote: >> >>> Are there tes

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 301205. LuoYuanke added a comment. Address Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke marked an inline comment as done. LuoYuanke added inline comments. Comment at: clang/lib/Headers/amxintrin.h:259 +__DEFAULT_FN_ATTRS +void __tile_loadd(__tile *dst, const void *base, long stride) { + dst->tile = _tile_loadd_internal(dst->row, dst->col, base, stride); -

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorep

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske updated this revision to Diff 301215. balazske added a comment. Handled review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cp

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added a comment. I think this diff looks very close to what we need. I hope it will be the last iteration. Please also update title and description with the new name of the option, etc. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/config-file.cp

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske added a comment. I think the name of this checker should be changed. It could in future not only check for the SIG30-C rule. (Plan is to include C++ checks too, and SIG31-C could be checked in this checker too.) It can be called "bugprone-signal-handler" instead? Co

[PATCH] D90294: [WebAssembly] Clang-format builtins generation (NFC)

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:263 +// TODO: Add a new LLVMMatchType that can describe the relationship between the +// result and parameter

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

sammccall added a comment. LG from my side. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:189 /// EXPECTS: Child->Role != Detached void prependChildLowLevel(Node *Child); friend class TreeBuilder; eduucaldas wrote: > eduucaldas wrote: > > sammc

[clang] d4934eb - [Syntax] Add iterators over children of syntax trees.

Author: Sam McCall Date: 2020-10-28T12:37:57+01:00 New Revision: d4934eb5f876cdc97a9a8665bd654351fbbcb66b URL: https://github.com/llvm/llvm-project/commit/d4934eb5f876cdc97a9a8665bd654351fbbcb66b DIFF: https://github.com/llvm/llvm-project/commit/d4934eb5f876cdc97a9a8665bd654351fbbcb66b.diff LO

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4934eb5f876: [Syntax] Add iterators over children of syntax trees. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D90

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @krasimir What would our next steps be to get this change into LLVM source tree? JIC, I don't have commit rights :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 _

[PATCH] D89794: [SyntaxTree] Implement "by-pointer output parameter to return value" refactoring.

eduucaldas added a subscriber: sammccall. eduucaldas added a comment. Sam, this patch is outdated, as we're still making decisions on https://reviews.llvm.org/D90161 and we haven't yet landed https://reviews.llvm.org/D90240, please don't bother reviewing it. This is where we started thinking ab

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

martong added a comment. In D88859#2354377 , @gribozavr2 wrote: >> I am having a hard time to accept "this is how it is implemented in our >> fork" as a technical argument. Besides, I am not sure how could the Clang >> community benefit about being backw

Re: [llvm-dev] Upcoming upgrade of LLVM buildbot

Hello Galina! On 10/28/20 2:53 AM, Galina Kistanova via llvm-dev wrote: > llvm-zorg source code has been updated, and now is open for new changes. If > you have pending patches, please rebase them on top of the llvm-zorg master > and update your reviews on the Phabricator. I'll start reviewing the

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

gribozavr2 added a comment. > Fair enough. But I don't think that Clang developers just copied the > implementation from GCC or from MSVC. No (nor we could copy the implementation for a number of reasons). However, we did have to be bug-for-bug compatible sometimes for compatibility. Reposito

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:188 + /// Similar but appends. + void appendChildLowLevel(Node *Child, NodeRole Role); + This is a complete nitpick, but could you put append before prepend? I think a lot

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

aaronpuchert added a comment. Can't really add anything to the discussion between @Quuxplusone and the author, just a few comments about the test. Comment at: clang/test/SemaCXX/implicitly-movable.cpp:1 +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -fcxx-exceptions -verify %s +

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek updated this revision to Diff 301253. klimek marked 3 inline comments as done. klimek added a comment. Adapted based on review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299 Files: clang

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek added inline comments. Comment at: clang/lib/Format/FormatToken.h:449 + /// When macro expansion introduces parents, those are marked as + /// \c MacroParent, so formatting knows their children need to be formatted. sammccall wrote: > I can't really un

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas updated this revision to Diff 301255. eduucaldas added a comment. Rebase to include ChildIterator patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90240/new/ https://reviews.llvm.org/D90240 Files: clang/include/clang/Tooling/Synta

[PATCH] D90129: Better source location for -Wignored-qualifiers on trailing return types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a question about a potential assert to add. Comment at: clang/include/clang/Sema/DeclSpec.h:1509 +SourceLocation getTrailingReturnTypeLoc()

[clang] 90a9f97 - [openmp] Use front() instead of *begin() to not hide bugs when CurTypes is empty.

Author: Benjamin Kramer Date: 2020-10-28T13:58:23+01:00 New Revision: 90a9f97cbda3bef63d9866d300b73b8ccf65c7f5 URL: https://github.com/llvm/llvm-project/commit/90a9f97cbda3bef63d9866d300b73b8ccf65c7f5 DIFF: https://github.com/llvm/llvm-project/commit/90a9f97cbda3bef63d9866d300b73b8ccf65c7f5.dif

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas updated this revision to Diff 301256. eduucaldas added a comment. I was silly on the last rebase. Ignore this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90240/new/ https://reviews.llvm.org/D90240 Files: clang/include/clang/Tooling

[PATCH] D90303: [ASTMatchers] Made isExpandedFromMacro Polymorphic

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 requested review of this revision. Made the isExpandedFromMacro matcher work on Stmt's, TypeLocs and Decls in line with the other macro

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/implicitly-movable.cpp:14 + +private: + A(const A &); aaronpuchert wrote: > Is this testing what we want it to test? The private functions are just not > part of the overload set, right? > > I

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/implicitly-movable.cpp:14 + +private: + A(const A &); aaronpuchert wrote: > Is this testing what we want it to test? The private functions are just not > part of the overload set, right? > > I t

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301268. kbobyrev added a comment. Fix test except shutting down part :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/CMakeLis

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp:2 +// REQUIRES: shell +// RUN: clang-tidy --config-file=%S/Inputs/config-file/config-file %T/read-file-config/test.cpp | grep "warning: .*\[hicpp-uppercase-literal-suffix\

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

fpetrogalli added a comment. Hi @c-rhodes, Peter asked me to take a look at this. LGTM, I only have minor stuff. In the commit message: > Arm C Language Extensions (ACLE, version 00bet5, section 3.7.3.3) for SVE [1]. It seems that a reference to [1] is missing: https://developer.arm.com/docu

[PATCH] D90248: [libomptarget][nvptx] Undef, weak shared variables

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, not totally convinced about weak linkage but ok Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90248/new/ https://reviews.llvm.org/D9

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo marked an inline comment as done. Hiralo added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp:2 +// REQUIRES: shell +// RUN: clang-tidy --config-file=%S/Inputs/config-file/config-file %T/read-file-config/test.cpp | grep "warn

[PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D90244#2357510 , @njames93 wrote: > In D90244#2357130 , @aaron.ballman > wrote: > >> Was this

[PATCH] D90129: Better source location for -Wignored-qualifiers on trailing return types

aaronpuchert marked an inline comment as done. aaronpuchert added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1509 +SourceLocation getTrailingReturnTypeLoc() const { + return SourceLocation::getFromRawEncoding(TrailingReturnTypeLoc); +} -

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo updated this revision to Diff 301277. Hiralo retitled this revision from "[clang-tidy] adding "--clang-tidy-config=" to specify custom config file" to "[clang-tidy] adding "--config-file=" to specify custom config file.". Hiralo edited the summary of this revision. Hiralo added a comment.

[PATCH] D89481: [scan-build] Fix clang++ pathname again

sberg updated this revision to Diff 301273. sberg edited the summary of this revision. sberg added a comment. Is there a reason why "NoQ accepted this revision." kept this at "Needs Review" rather than moving it to "This revision is now accepted and ready to land."? Anyway, I added a test now.

[PATCH] D90248: [libomptarget][nvptx] Undef, weak shared variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d02ca49a294: [libomptarget][nvptx] Undef, weak shared variables (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 5d02ca4 - [libomptarget][nvptx] Undef, weak shared variables

Author: JonChesterfield Date: 2020-10-28T14:25:36Z New Revision: 5d02ca49a294848b533adf7dc1d1275d125ef587 URL: https://github.com/llvm/llvm-project/commit/5d02ca49a294848b533adf7dc1d1275d125ef587 DIFF: https://github.com/llvm/llvm-project/commit/5d02ca49a294848b533adf7dc1d1275d125ef587.diff LO

[PATCH] D89936: [clang-tidy] adding "--config-file=" to specify custom config file.

Hiralo added a comment. In D89936#2358572 , @DmitryPolukhin wrote: > I think this diff looks very close to what we need. I hope it will be the > last iteration. > Please also update title and description with the new name of the option, etc. Updated lat

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet updated this revision to Diff 301280. kadircet marked 9 inline comments as done. kadircet added a comment. - Drop PathSpec, deduce it from emptyness of FragmentDirectory. - Make tests more homogenous. - Add path cannonicalization to compile stage. Repository: rG LLVM Github Monorepo

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:124 std::vector Result; - Cache.read(FS, DC, P.FreshTime, Result); + Cache.read(FS, DC, P.FreshTime, Fragment::SourceInfo::Absolute, Result); return Result; ---

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:75 llvm::SourceMgr *SourceMgr; + // Directory containing the fragment. Absolute path with forward slashes

[PATCH] D90311: [CUDA][HIP] Fix linkage for -fgpu-rdc

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently for explicit template function instantiation in CUDA/HIP device compilation clang emits instantiated kernel with external linkage and instantiated device function with internal linkage.

[PATCH] D90129: Better source location for -Wignored-qualifiers on trailing return types

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1509 +SourceLocation getTrailingReturnTypeLoc() const { + return SourceLocation::getFromRawEncoding(TrailingReturnTypeLoc); +} aaronpuchert wrote: > aaron.ballman wr

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/implicitly-movable.cpp:14 + +private: + A(const A &); aaronpuchert wrote: > Quuxplusone wrote: > > aaronpuchert wrote: > > > Is this testing what we want it to test? The private functions are jus

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301298. kbobyrev added a comment. Push the Franken-pytest. Benefits: doesn't fail, is platform independent (to be determined). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/

[clang] c0053c6 - [Syntax] Add missing default constructor for ConstChildIterator

Author: Simon Pilgrim Date: 2020-10-28T15:38:18Z New Revision: c0053c62d9a0b798b42686499de9bb2e7391b111 URL: https://github.com/llvm/llvm-project/commit/c0053c62d9a0b798b42686499de9bb2e7391b111 DIFF: https://github.com/llvm/llvm-project/commit/c0053c62d9a0b798b42686499de9bb2e7391b111.diff LOG:

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

RKSimon added a comment. @sammccall I've pushed rGc0053c62d9a0 to fix MSVC builds which were struggling to find a default constructor for ConstChildIterator http://lab.llvm.org:8011/#/builders/83 Repository: rG LLVM Gith

[clang] 8279ea1 - Fix Wdocumentation unknown parameter warnings. NFCI.

Author: Simon Pilgrim Date: 2020-10-28T15:47:17Z New Revision: 8279ea1a2ae5f59bce1a0db675c82a8849ab9f58 URL: https://github.com/llvm/llvm-project/commit/8279ea1a2ae5f59bce1a0db675c82a8849ab9f58 DIFF: https://github.com/llvm/llvm-project/commit/8279ea1a2ae5f59bce1a0db675c82a8849ab9f58.diff LOG:

[clang-tools-extra] 556ee67 - [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations

Author: Nathan James Date: 2020-10-28T15:49:51Z New Revision: 556ee675c1471d9c571c58cc8e396b70e6cc7bc6 URL: https://github.com/llvm/llvm-project/commit/556ee675c1471d9c571c58cc8e396b70e6cc7bc6 DIFF: https://github.com/llvm/llvm-project/commit/556ee675c1471d9c571c58cc8e396b70e6cc7bc6.diff LOG:

[PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations

This revision was automatically updated to reflect the committed changes. Closed by commit rG556ee675c147: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D90244?vs=301032&id=301300#toc Reposito

Re: [clang] d4934eb - [Syntax] Add iterators over children of syntax trees.

Hi Sam, It looks like some Windows buildbots fail to build this, for example: http://lab.llvm.org:8011/#/builders/119/builds/349 In the build step, [Big long cl.exe command line for] C:\buildbot\as-builder-2\x-aarch64\llvm-project\clang\lib\Tooling\Syntax\ComputeReplacements.cpp C:\build

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301303. kbobyrev added a comment. Don't change the existing Python formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/C

Re: [PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

Ah, thanks a lot, sorry for missing that! On Wed, Oct 28, 2020 at 4:41 PM Simon Pilgrim via Phabricator < revi...@reviews.llvm.org> wrote: > RKSimon added a comment. > > @sammccall I've pushed rGc0053c62d9a0 < > https://reviews.llvm.org/rGc0053c62d9a0b798b42686499de9bb2e7391b111> to > fix MSVC bu

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet updated this revision to Diff 301311. kadircet marked 6 inline comments as done. kadircet added a comment. - Make Directory a parameter of fromYAMLFile. - Factor out configRelative logic to a helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

mibintc created this revision. mibintc added reviewers: kpn, sepavloff, aaron.ballman, pengfei. Herald added a project: clang. mibintc requested review of this revision. Herald added a subscriber: aheejin. If the target doesn't support setting StrictFP, then ignore pragmas that modify the setting

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas updated this revision to Diff 301315. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. Answered all comments but: - Add tests for `replaceChildRangeLowLevel` - Asymmetry of `replaceChildRangeLowLevel`, do we need to separate children of the replaced range? Re

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

tlively added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:263 +// TODO: Add a new LLVMMatchType that can describe the relationship between the +// result and parameter types here. +def int_wasm_extmul_low_signed : aheejin wrote: > I

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

kpn added a comment. I also added "-fexperimental-strict-floating-point" which makes it possible to write tests for a target when bringing up the support on that target. I think it would be confusing for that flag to work on command line arguments but not pragmas. Repository: rG LLVM Github

[clang] 31e9445 - [WebAssembly] Prototype extending multiplication SIMD instructions

Author: Thomas Lively Date: 2020-10-28T09:38:59-07:00 New Revision: 31e944556f5464b5a488c42f1d727d5b27734169 URL: https://github.com/llvm/llvm-project/commit/31e944556f5464b5a488c42f1d727d5b27734169 DIFF: https://github.com/llvm/llvm-project/commit/31e944556f5464b5a488c42f1d727d5b27734169.diff

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31e944556f54: [WebAssembly] Prototype extending multiplication SIMD instructions (authored by tlively). Changed prior to commit: https://reviews.l

[PATCH] D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328

dylanmckay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:40 +llvm::Optional GetMcuSectionAddressData(StringRef MCU) { + return llvm::StringSwitch>(MCU) benshi001 wrote: > aykevl wrote: > > I don't think the LLVM coding style says somet

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

tra added a comment. Looks like it breaks CUDA: http://lab.llvm.org:8011/#/builders/46/builds/304 [10/873] Building CXX object External/CUDA/CMakeFiles/printf-cuda-11.0-c++14-libstdc++-6.dir/printf.cu.o FAILED: External/CUDA/CMakeFiles/printf-cuda-11.0-c++14-libstdc++-6.dir/printf.cu.o

[PATCH] D90294: [WebAssembly] Clang-format builtins generation (NFC)

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90294/new/ https://reviews.llvm.org/D90294

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked an inline comment as done. compnerd added a comment. > I'd like to have maximum flexibility from the submitter by willing to change > the details of the implementation I don't think that is a fair expectation - there are plenty of times where this is technical disagreement on fu

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

tra added a comment. Never mind. I see that you've fixed it in 17c8251bca83072d2f3e00f936d6ce24500e6b02 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89971/new/ https://reviews

[PATCH] D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328

dylanmckay added a comment. Regarding TableGen; I would like to send an RFC to llvm-dev to come up with a proper API to expose backend-specific device-specific information and constants to LLVM frontends, as I can imagine that many backends could stand to benefit. I note that there is in genera

[PATCH] D88352: [clang][AVR] Add more devices

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Approved, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88352/new/ https://reviews.llvm.org/D88352 ___ cfe-commits mailing

[PATCH] D81748: [PowerPC] Add MMA builtin decoding and definitions

amyk added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2050 + QualType DecodeTypeStr(const char *&Str, const ASTContext &Context, + ASTContext::GetBuiltinTypeError &Error, I think it might be good to add a small co

[clang] 9894127 - [WebAssembly] Clang-format builtins generation (NFC)

Author: Heejin Ahn Date: 2020-10-28T10:01:21-07:00 New Revision: 98941279b90ee096a7d34f09d320d8e1d5fcb61b URL: https://github.com/llvm/llvm-project/commit/98941279b90ee096a7d34f09d320d8e1d5fcb61b DIFF: https://github.com/llvm/llvm-project/commit/98941279b90ee096a7d34f09d320d8e1d5fcb61b.diff LO

[PATCH] D90294: [WebAssembly] Clang-format builtins generation (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98941279b90e: [WebAssembly] Clang-format builtins generation (NFC) (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486 + if (LangOpts.HIP) +Options.AllowFPOpFusion = llvm::FPOpFusion::Standard; + rjmccall wrote: > tra wrote: > > yaxunl wrote: > > > tra wrote: > > > > yaxunl wrote: > > > > > tra w

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

martong added a comment. FYI, I am working on repeating and reevaluating Peter's measurements with the current master. And if possible then I'd like to extend the measures for new C and C++ projects. I am planning to sh

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

jdoerfert added a comment. In D89971#2359398 , @tra wrote: > Never mind. I see that you've fixed it in > 17c8251bca83072d2f3e00f936d6ce24500e6b02 > Yeah, as I write in the commit mess

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

tra added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486 + if (LangOpts.HIP) +Options.AllowFPOpFusion = llvm::FPOpFusion::Standard; + yaxunl wrote: > rjmccall wrote: > > tra wrote: > > > yaxunl wrote: > > > > tra wrote: > > > > > yaxunl w

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

mibintc updated this revision to Diff 301322. mibintc added a comment. Modified according to @kpn suggestion: if the command line has option fexperimental-strict-floating-point, the float pragmas will not be ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

tra added a comment. I'll take a look at what broke the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89971/new/ https://reviews.llvm.org/D89971 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

mibintc added a comment. In D90316#2359366 , @kpn wrote: > I also added "-fexperimental-strict-floating-point" which makes it possible > to write tests for a target when bringing up the support on that target. I > think it would be confusing for that fla

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc added a comment. In D87528#2357970 , @pengfei wrote: > I agreed with Craig. Emitting constrained intrinsics on an unsupported target > may result in problems. It's better to check if it is supported and prevent > from the front end. Here's a pat

[clang] 5b464f2 - [WebAssembly] Fix incorrectly named target builtin

Author: Thomas Lively Date: 2020-10-28T10:22:43-07:00 New Revision: 5b464f2aa514903cad2f2160dd613b74b0cee3da URL: https://github.com/llvm/llvm-project/commit/5b464f2aa514903cad2f2160dd613b74b0cee3da DIFF: https://github.com/llvm/llvm-project/commit/5b464f2aa514903cad2f2160dd613b74b0cee3da.diff

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added a comment. In D89980#2357208 , @hliao wrote: > Besides the unpromotable `alloca` issue due to indirect accesses, such > coercion to GLOBAL pointer directly is not safe as, in HIP/CUDA, both > CONSTANT and GLOBAL pointers would be passed as t

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 301325. tianshilei1992 added a comment. Rebased (again) to involve the reversion of another patch that can cause clang crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm

[clang-tools-extra] 68b4833 - [clangd] Fix a null dereference in tests.

Author: Kadir Cetinkaya Date: 2020-10-28T18:24:26+01:00 New Revision: 68b48339e5b2e7c5f9b74e790b4a4e2419a0a50b URL: https://github.com/llvm/llvm-project/commit/68b48339e5b2e7c5f9b74e790b4a4e2419a0a50b DIFF: https://github.com/llvm/llvm-project/commit/68b48339e5b2e7c5f9b74e790b4a4e2419a0a50b.dif

[PATCH] D39086: Performance tracing facility for clangd.

kadircet added inline comments. Comment at: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp:57 +} +std::string VS = V->getValue(Tmp).str(); +if (VS != I->second) { RKSimon wrote: > @sammccall PVS Studio is reporting a potential null dereferenc

[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

amyk added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3310 +// Check that the given type is a valid type for the PPC target. Return true +// if the type is invalid. Would this be a better comment for this function (since it may be confusing to

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

awarzynski added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89799/new/ https://reviews.llvm.org/D89799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

craig.topper added inline comments. Comment at: llvm/tools/llvm-mc/CMakeLists.txt:6 AllTargetsInfos + CodeGen MC Why did this patch need to make llvm-mc dependent on CodeGen? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. This patch caused segment fault in D90099 where the map variable info pointer is `nullptr` but it is deferenced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89802/new/ https://rev

[clang] 88b7b76 - [AVR][clang] Pass the address of the data section to the linker for ATmega328

Author: Dylan McKay Date: 2020-10-29T06:35:15+13:00 New Revision: 88b7b76a0b2365fe4ea9f686c6346667bfe48488 URL: https://github.com/llvm/llvm-project/commit/88b7b76a0b2365fe4ea9f686c6346667bfe48488 DIFF: https://github.com/llvm/llvm-project/commit/88b7b76a0b2365fe4ea9f686c6346667bfe48488.diff L

  1   2   3   >