[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

LiuChen3 added a comment. In D90009#2354849 , @kiranchandramohan wrote: > I have added a fix to run the test only when the X86 target is available. > Please feel free to change if it is not the correct fix. > https://github.com/llvm/llvm-project/commit/c

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

sbc100 added a comment. still lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/ https://reviews.llvm.org/D88603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc added a comment. In D80488#2341009 , @vitalybuka wrote: > LGTM, but it could be better with a test Thanks, added test and landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80488/new/ https://reviews.llvm.org/D80488 _

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc updated this revision to Diff 300842. chandlerc marked an inline comment as done. chandlerc added a comment. Update with a regression test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80488/new/ https://reviews.llvm.org/D80488 Files: clang/lib/Driver/ToolChains/CommonArgs

[clang] aab50af - SourceManager: Use the same fake SLocEntry whenever it fails to load

Author: Duncan P. N. Exon Smith Date: 2020-10-26T20:56:28-04:00 New Revision: aab50af8c18ab2eb2149bb516c8a0993ffc5abb7 URL: https://github.com/llvm/llvm-project/commit/aab50af8c18ab2eb2149bb516c8a0993ffc5abb7 DIFF: https://github.com/llvm/llvm-project/commit/aab50af8c18ab2eb2149bb516c8a0993ffc5

[PATCH] D89748: SourceManager: Use the same fake SLocEntry whenever it fails to load

This revision was automatically updated to reflect the committed changes. Closed by commit rGaab50af8c18a: SourceManager: Use the same fake SLocEntry whenever it fails to load (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89748?vs=29

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

sbc100 added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962 + case Triple::Wasm: +return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash), + ~0); dschuff wrote: > dblaikie wrote: > > dschuff

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 9pm PST. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] aaf7ffd - Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

Author: Chandler Carruth Date: 2020-10-27T01:36:54Z New Revision: aaf7ffd4e1aa81c7f4cc8da4f943982ca2e131f4 URL: https://github.com/llvm/llvm-project/commit/aaf7ffd4e1aa81c7f4cc8da4f943982ca2e131f4 DIFF: https://github.com/llvm/llvm-project/commit/aaf7ffd4e1aa81c7f4cc8da4f943982ca2e131f4.diff L

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf7ffd4e1aa: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when… (authored by chandlerc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] f057e6d - SourceManager: clang-format the SrcMgr namespace, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-26T21:58:52-04:00 New Revision: f057e6dc5e29751dbba700bc62d8c42c57a502b0 URL: https://github.com/llvm/llvm-project/commit/f057e6dc5e29751dbba700bc62d8c42c57a502b0 DIFF: https://github.com/llvm/llvm-project/commit/f057e6dc5e29751dbba700bc62d8c42c57a5

[clang] e20d64c - [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

Author: Shilei Tian Date: 2020-10-26T22:33:22-04:00 New Revision: e20d64c3d9d81cad701f31d8481367222c76c787 URL: https://github.com/llvm/llvm-project/commit/e20d64c3d9d81cad701f31d8481367222c76c787 DIFF: https://github.com/llvm/llvm-project/commit/e20d64c3d9d81cad701f31d8481367222c76c787.diff L

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe20d64c3d9d8: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait (authored by tianshilei1992). Repository: rG LLVM Github Mo

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

tianshilei1992 updated this revision to Diff 300859. tianshilei1992 added a comment. Fixed a major issue and one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMP

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 ___

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

catskul added a comment. @FStefanni, after managing to update this patch to work with the latest code, and trying out your example it appears this patch doesn't quite cover your case. I did manage to fix it to cover your case, but I suppose at this point I should ask @MyDeveloperDay and @djaspe

[PATCH] D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 updated this revision to Diff 300869. tianshilei1992 added a comment. Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo added a comment. In D90010#2352556 , @njames93 wrote: > Isn't `llvm::errs()` buffered, negating most of the benefit here. If it is buffered, we would expect single write call to stderr. But we are seeing 7 write calls! Yes, please suggest how to

[PATCH] D89936: clang-tidy: adding "--clang-tidy-config=" to specify custom config file

Hiralo added a comment. Thanks for your kind review. Working on it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

dblaikie added a comment. In D90010#2355421 , @Hiralo wrote: > In D90010#2352556 , @njames93 wrote: > >> Isn't `llvm::errs()` buffered, negating most of the benefit here. > > If it is buffered, we would expect singl

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo added a comment. In D90010#2355432 , @dblaikie wrote: > Looks like you might be able to do something like > "llvm::errs().setBuffered()" ? Do we need to set it for each function using llvm:errs() (e.g. here printStats() ) OR can it be set once fo

[clang] d38788b - [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

Author: Shilei Tian Date: 2020-10-27T00:02:32-04:00 New Revision: d38788b357ad29083eb3b03027db908559aae2a6 URL: https://github.com/llvm/llvm-project/commit/d38788b357ad29083eb3b03027db908559aae2a6 DIFF: https://github.com/llvm/llvm-project/commit/d38788b357ad29083eb3b03027db908559aae2a6.diff L

[PATCH] D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd38788b357ad: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is… (authored by tianshilei1992). Repository: rG LLVM Git

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo added a comment. Tried using llvm::errs().SetBuffered() within printStats()... static void printStats(const ClangTidyStats &Stats) { + llvm::errs().SetBuffered() but still I see below stderr write calls... ... write(2, "10712", 5)= 5 write(2, " warning", 8)

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

dblaikie added a comment. In D90010#2355443 , @Hiralo wrote: > In D90010#2355432 , @dblaikie wrote: > >> Looks like you might be able to do something like >> "llvm::errs().setBuffered()" ? > > Do we need to set it

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, steven.zhang, PowerPC, kbarton. Herald added subscribers: cfe-commits, dexonsmith, shchenz. Herald added a project: clang. qiucf requested review of this revision. We have option `-mabi=ieeelongdouble` to set current `long double`

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf updated this revision to Diff 300887. qiucf added a comment. Remove `FIXME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ https://reviews.llvm.org/D90208 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/CodeGen/ppc64-long-dou

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo added a comment. In D90010#2355460 , @dblaikie wrote: > In D90010#2355443 , @Hiralo wrote: > >> In D90010#2355432 , @dblaikie wrote: >> >>> Looks like you might be abl

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

dblaikie added a comment. In D90010#2355489 , @Hiralo wrote: > In D90010#2355460 , @dblaikie wrote: > >> In D90010#2355443 , @Hiralo wrote: >> >>> In D90010#2355432

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo added a comment. In D90010#2355490 , @dblaikie wrote: > By the looks of the code, you may want to call SetBufferSize only (do not > call SetBuffered after that - or it'll go back to the default buffer size of > 0. Oh! I missed it! For examp

[PATCH] D90209: add test for PAS_Right + RAS_Left + commentedout '* &' example

catskul created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. catskul requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90209 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/Fo

[PATCH] D90209: add test for PAS_Right + RAS_Left + commentedout '* &' example

catskul abandoned this revision. catskul added a comment. Accidental creation of diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90209/new/ https://reviews.llvm.org/D90209 ___ cfe-commits mailing list

[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2756e2ee0bce: [libTooling] Recognize sccache as a compiler wrapper in compilation database… (authored by nridge). Repository: rG LLVM Github Monor

[clang] 2756e2e - [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

Author: Nathan Ridge Date: 2020-10-27T01:46:32-04:00 New Revision: 2756e2ee0bceaf532d4990cbb4f2a84fe62b6b84 URL: https://github.com/llvm/llvm-project/commit/2756e2ee0bceaf532d4990cbb4f2a84fe62b6b84 DIFF: https://github.com/llvm/llvm-project/commit/2756e2ee0bceaf532d4990cbb4f2a84fe62b6b84.diff

[PATCH] D90134: [clangd] Increase the TooMany limit for index-based textual navigation to 5

nridge added a comment. In D90134#2352932 , @kadircet wrote: >> My experience using this feature in real codebases has been that we take >> this early-exit too often; the limit of 3 is fairly easy to hit due to >> things like layers of wrappers that repe

[clang-tools-extra] 245b61a - [clangd] Increase the TooMany limit for index-based textual navigation to 5

Author: Nathan Ridge Date: 2020-10-27T01:49:09-04:00 New Revision: 245b61a330abee06b81ac7d93da4582db51b1de7 URL: https://github.com/llvm/llvm-project/commit/245b61a330abee06b81ac7d93da4582db51b1de7 DIFF: https://github.com/llvm/llvm-project/commit/245b61a330abee06b81ac7d93da4582db51b1de7.diff

[PATCH] D90134: [clangd] Increase the TooMany limit for index-based textual navigation to 5

This revision was automatically updated to reflect the committed changes. Closed by commit rG245b61a330ab: [clangd] Increase the TooMany limit for index-based textual navigation to 5 (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D89936: clang-tidy: adding "--clang-tidy-config=" to specify custom config file

Hiralo marked an inline comment as done. Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.h:68 + /// Clang-tidy-config + llvm::Optional ClangTidyConfig; + DmitryPolukhin wrote: > I'm not sure that we need it here. I would

[PATCH] D89936: clang-tidy: adding "--clang-tidy-config=" to specify custom config file

Hiralo marked an inline comment as done. Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:324 +llvm::sys::fs::is_symlink_file(Twine(AbsoluteFilePath), IsLink); +if (!(IsFile || IsLink)) { + std::string Msg;

<    1   2   3