nridge added a comment. In D90134#2352932 <https://reviews.llvm.org/D90134#2352932>, @kadircet wrote:
>> My experience using this feature in real codebases has been that we take >> this early-exit too often; the limit of 3 is fairly easy to hit due to >> things like layers of wrappers that repeat a function name. Bumping the >> limit to 5 has increased the usefulness for me. > > What about counting number of different files, rather than number of symbols ? If you mean counting the number of different files but keeping the limit at 3, I don't think that would change much; in my experience, you often have wrappers that repeat the same names in a different file than the functions they are wrapping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90134/new/ https://reviews.llvm.org/D90134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
