[libunwind] 8c03fdf - [libcxxabi, libunwind] support running tests in standalone mode

Author: Dominik Montada Date: 2020-10-14T09:10:20+02:00 New Revision: 8c03fdf34a659925a3f09c8f54016e47ea1c7519 URL: https://github.com/llvm/llvm-project/commit/8c03fdf34a659925a3f09c8f54016e47ea1c7519 DIFF: https://github.com/llvm/llvm-project/commit/8c03fdf34a659925a3f09c8f54016e47ea1c7519.dif

[PATCH] D89184: Support complex target features combinations

pengfei added a comment. > D89105 appears to use only `"avx512vl , > avx512vnni | avxvnni"`. > Does it mean `(avx512vl , avx512vnni) | avxvnni` or `avx512vl , (avx512vnni | > avxvnni)` ? We need to express combination to `(avx512vl , avx512vnni) | avxvnni`, th

[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27c691cf62a9: [clang-rename] Simplify the code of handling class paritial specializations… (authored by hokein). Repository: rG LLVM Github Monore

[clang] 27c691c - [clang-rename] Simplify the code of handling class paritial specializations, NFC.

Author: Haojian Wu Date: 2020-10-14T09:57:55+02:00 New Revision: 27c691cf62a9b34789516a24233fa0ee7bbd8111 URL: https://github.com/llvm/llvm-project/commit/27c691cf62a9b34789516a24233fa0ee7bbd8111 DIFF: https://github.com/llvm/llvm-project/commit/27c691cf62a9b34789516a24233fa0ee7bbd8111.diff LO

[PATCH] D89221: [clang-rename] Fix rename on function template specializations.

hokein updated this revision to Diff 298061. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89221/new/ https://reviews.llvm.org/D89221 Files: clang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp clang/test/cl

[PATCH] D89221: [clang-rename] Fix rename on function template specializations.

hokein added a comment. @kbobyrev you may miss this patch, this is a separate patch from D89300 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89221/new/ https://reviews.llvm.org/D89221 __

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng updated this revision to Diff 298060. kito-cheng added a comment. ChangeLog - Fix wording in comment - Add more comment in testcase - Fix format issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89025/new/ https://reviews.llvm.org/D89025 Files: clang/include/clang/Driv

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

hokein added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:3098 llvm::FoldingSetVector & - getPartialSpecializations(); + getPartialSpecializations() const; kbobyrev wrote: > I believe these are from https://reviews.llvm.org/D89221, s

[PATCH] D89025: [RISCV] Add -mtune support

kito-cheng marked 3 inline comments as done. kito-cheng added a comment. In D89025#2327749 , @luismarques wrote: > In D89025#2324334 , @khchen wrote: > >> RISCV supports `-mcpu` with default empty arch to align gcc'

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

kbobyrev added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:3098 llvm::FoldingSetVector & - getPartialSpecializations(); + getPartialSpecializations() const; hokein wrote: > kbobyrev wrote: > > I believe these are from https://review

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas updated this revision to Diff 298079. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Answer to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89303/new/ https://reviews.llvm.org/D89303 Files: clang/li

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:122 #endif + Node *&Begin = BeforeBegin ? BeforeBegin->NextSibling : FirstChild; + Could you move

[clang] 4178f8f - [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

Author: Eduardo Caldas Date: 2020-10-14T09:18:32Z New Revision: 4178f8f2f08e14abb341fb32dd0f4cc9320df072 URL: https://github.com/llvm/llvm-project/commit/4178f8f2f08e14abb341fb32dd0f4cc9320df072 DIFF: https://github.com/llvm/llvm-project/commit/4178f8f2f08e14abb341fb32dd0f4cc9320df072.diff LOG

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4178f8f2f08e: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D89314: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72732acade77: [SyntaxTree] Bug fix in `MutationsImpl::addAfter`. (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 72732ac - [SyntaxTree] Bug fix in `MutationsImpl::addAfter`.

Author: Eduardo Caldas Date: 2020-10-14T09:22:01Z New Revision: 72732acade77d5ee55a818e2da77a2c5b7033ccb URL: https://github.com/llvm/llvm-project/commit/72732acade77d5ee55a818e2da77a2c5b7033ccb DIFF: https://github.com/llvm/llvm-project/commit/72732acade77d5ee55a818e2da77a2c5b7033ccb.diff LOG

[clang] 6fbad9b - [SyntaxTree][NFC] Nit on `replaceChildRangeLowLevel`

Author: Eduardo Caldas Date: 2020-10-14T09:40:37Z New Revision: 6fbad9bf304c05d37454420f7d5a1c2ab3adab20 URL: https://github.com/llvm/llvm-project/commit/6fbad9bf304c05d37454420f7d5a1c2ab3adab20 DIFF: https://github.com/llvm/llvm-project/commit/6fbad9bf304c05d37454420f7d5a1c2ab3adab20.diff LOG

[PATCH] D89303: [SyntaxTree] Improve safety of `replaceChildRangeLowLevel`

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:122 #endif + Node *&Begin = BeforeBegin ? BeforeBegin->NextSibling : FirstChild; + gribozavr2 wrote: > Could you move this definition up

[PATCH] D89148: [SyntaxTree] Artificial use of the Mutations API.

eduucaldas updated this revision to Diff 298092. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89148/new/ https://reviews.llvm.org/D89148 Files: clang/include/clang/Tooling/Syntax/Mutations.h clang/lib/Toolin

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +/

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: aaron.ballman, gribozavr2. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs, kbarton, xazax.hun, whisperity, nemanjai. Herald added a projec

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 +TARGET_BUILTIN(__builtin_wasm_load32_lane, "V4iIii*", "nU", "simd128") +TARGET_BUILTIN(__builtin_wasm

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Compiler.cpp:84 - // Recovery expression currently only works for C++. - if (CI->getLangOpts()->CPlusPlus) { -CI->getLangOpts()->RecoveryAST = Inputs.Opts.BuildReco

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

hokein updated this revision to Diff 298116. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89233/new/ https://reviews.llvm.org/D89233 Files: clang-tools-extra/clangd/ClangdServer.h clang-tools-extra/cl

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini created this revision. Herald added subscribers: cfe-commits, kerbowa, Anastasia, yaxunl, nhaehnle, jvesely, jholewinski. Herald added a project: clang. mantognini updated this revision to Diff 298093. mantognini added a comment. mantognini published this revision for review. Addressed

[clang-tools-extra] 3fcca80 - [clangd] Refine recoveryAST flags in clangd

Author: Haojian Wu Date: 2020-10-14T13:42:11+02:00 New Revision: 3fcca804b2916b68d34523e9f88c77272a256d77 URL: https://github.com/llvm/llvm-project/commit/3fcca804b2916b68d34523e9f88c77272a256d77 DIFF: https://github.com/llvm/llvm-project/commit/3fcca804b2916b68d34523e9f88c77272a256d77.diff LO

[PATCH] D89233: [clangd] Refine recoveryAST flags in clangd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fcca804b291: [clangd] Refine recoveryAST flags in clangd (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff updated this revision to Diff 298119. sepavloff added a comment. Updated patch - Reverted check to the previous version, in which it applied to C++ file level variables also. - Added workaround for constexpr functions. Now they are parsed with constant rounding mode, which allows to u

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

martong added a comment. Thanks for the review! Comment at: clang/test/ASTMerge/attr/Inputs/FormatAttr.cpp:2 +int foo(const char * fmt, ...) +__attribute__ ((__format__ (__scanf__, 1, 2))); teemperor wrote: > (Not sure if we care about that in tests, but that's

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rGdd965711c9f0: [ASTImporter] Fix crash caused by unimported type of FromatAttr (authored by martong). Chang

[clang] dd96571 - [ASTImporter] Fix crash caused by unimported type of FromatAttr

Author: Gabor Marton Date: 2020-10-14T13:54:48+02:00 New Revision: dd965711c9f0e4b6e1dc9b465fe049c38e05d5aa URL: https://github.com/llvm/llvm-project/commit/dd965711c9f0e4b6e1dc9b465fe049c38e05d5aa DIFF: https://github.com/llvm/llvm-project/commit/dd965711c9f0e4b6e1dc9b465fe049c38e05d5aa.diff

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

sepavloff added a comment. I would propose to consider solution in D88498 . It tries to fix the real reason of the malfunction - using dynamic rounding mode for evaluation of global variable initializers. With the workaround for constexpr functions it allows to

[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

danilaml added inline comments. Comment at: clang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp:119 +llvm::for_each(PartialSpecs, + [&](const auto *Spec) { addUSRsOfCtorDtors(Spec); }); addUSRsOfCtorDtors(TemplateDecl->getTemplatedDecl()); ---

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

martong marked an inline comment as done. martong added a comment. Thanks for the reivew! Comment at: clang/lib/AST/ASTImporter.cpp:8109 + FromAttr->getAttributeSpellingListIndex()); + ToAttr->setPackExpansion(FromAttr->isPackExpansion()); + ToAttr->setImplicit(FromAttr-

[PATCH] D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG73c6beb2f705: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex (authored by martong). Ch

[clang] 73c6beb - [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex

Author: Gabor Marton Date: 2020-10-14T14:10:08+02:00 New Revision: 73c6beb2f7053fe8b5150072c2b5cd930de38a22 URL: https://github.com/llvm/llvm-project/commit/73c6beb2f7053fe8b5150072c2b5cd930de38a22 DIFF: https://github.com/llvm/llvm-project/commit/73c6beb2f7053fe8b5150072c2b5cd930de38a22.diff

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl updated this revision to Diff 298125. yaxunl added a comment. revised by John's comments. Extracted common part of DiagnosticEngine and PartialDiagnostics as DiagnosticStorage. Make member functions of the base class of DiagnosticBuilder and ParticalDiagnostics non-virtual. CHANGES SI

[clang-tools-extra] 82a7182 - [clangd] Disable extract variable for RHS of assignments

Author: Kadir Cetinkaya Date: 2020-10-14T14:22:47+02:00 New Revision: 82a71822a54d76c62bf730d8c0e8e86d68c60159 URL: https://github.com/llvm/llvm-project/commit/82a71822a54d76c62bf730d8c0e8e86d68c60159 DIFF: https://github.com/llvm/llvm-project/commit/82a71822a54d76c62bf730d8c0e8e86d68c60159.dif

[PATCH] D89307: [clangd] Disable extract variable for RHS of assignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82a71822a54d: [clangd] Disable extract variable for RHS of assignments (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D89372: [OpenCL] Remove unused extensions

yaxunl added a comment. what if users rely on the predefined macros associated with the extension e.g. cl_khr_srgb_image_writes to enable/disable certain code? What's the issue with these extensions not removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D89212: PR47663: Warn if an entity becomes weak after its first use.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some very small nits (feel free to ignore any that don't make sense to you). Comment at: clang/lib/AST/DeclBase.cpp:622 +AvailabilityResult A

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

sammccall added a comment. (sorry out today and haven't looked at code yet) If it's a custom method, I think it should return the data as a json structure - the client already has to have custom support to invoke it, displaying the result isn't much extra work. And I would really love to add a

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy updated this revision to Diff 298133. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 Files: clang/lib/Frontend/ASTUnit.cpp clang/unittests/Frontend/ASTUnitTest.cpp Index: clang/unittests/Frontend/ASTUnitTest.cpp

[clang] e6b4179 - Fix a broken build for gcc <= 7.1

Author: Haojian Wu Date: 2020-10-14T15:14:59+02:00 New Revision: e6b4179c5d282905a8ad17c57153b991c42d1126 URL: https://github.com/llvm/llvm-project/commit/e6b4179c5d282905a8ad17c57153b991c42d1126 DIFF: https://github.com/llvm/llvm-project/commit/e6b4179c5d282905a8ad17c57153b991c42d1126.diff LO

[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

hokein added inline comments. Comment at: clang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp:119 +llvm::for_each(PartialSpecs, + [&](const auto *Spec) { addUSRsOfCtorDtors(Spec); }); addUSRsOfCtorDtors(TemplateDecl->getTemplatedDecl()); -

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini added a comment. In D89372#2329939 , @yaxunl wrote: > what if users rely on the predefined macros associated with the extension > e.g. cl_khr_srgb_image_writes to enable/disable certain code? > > What's the issue with these extensions not remov

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. Yes, this is a group of extensions that doesn't seem to change anything in the kernel language. So if the macro is available I don't understand how it can be used to do anything different in the kernel code because it just doesn't modify anything in the kernel code.

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

alexfh added a comment. Thanks for the fix! However, I'm not sure it's possible to correctly rewrite code in all cases where macros are involved. See a couple of motivating examples in the comment. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pref

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:170 + auto Diag = +diag(BeginLoc, "%0 should be initia

[clang] b21ad3b - Fix `-Wparentheses` warnings. NFC.

Author: Michael Liao Date: 2020-10-14T10:11:19-04:00 New Revision: b21ad3b66bce942ee6e0f5b1fcfdea31928005a7 URL: https://github.com/llvm/llvm-project/commit/b21ad3b66bce942ee6e0f5b1fcfdea31928005a7 DIFF: https://github.com/llvm/llvm-project/commit/b21ad3b66bce942ee6e0f5b1fcfdea31928005a7.diff

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

dexonsmith updated this revision to Diff 298144. dexonsmith added a comment. Cleaned up the (fixed) `Invalid` logic to reduce the size of the diff and use a consistent pattern. Thanks for you patience with the false start; I think this is ready now. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D89348: clang/Basic: Replace ContentCache::getBuffer with Optional semantics

dexonsmith updated this revision to Diff 298145. dexonsmith added a comment. Hah, and now I notice while working on a follow-up that `SourceManager::getBufferOrNone` was missing a `const`-qualifier (the use in this patch didn't need it). Fixed that too. CHANGES SINCE LAST ACTION https://revi

[PATCH] D89143: [OpenCL][Docs] Improved description of the supported language functionality.

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Looks good to me, thanks for the note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89143/new/ https://reviews.llvm.org/D89143 ___

[PATCH] D89394: clang/Basic: Stop using SourceManager::getBuffer, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update `Basic` to stop relying on a `MemoryBuffer*`, using the `MemoryBufferRef` from `getBufferOrNone` or `getBufferOrFake` instead of `getBu

[PATCH] D89372: [OpenCL] Remove unused extensions

azabaznov requested changes to this revision. azabaznov added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:74 OPENCLEXT_INTERNAL(cl_khr_mipmap_image_writes, 200, ~0U) -OPENCLEXT_INTERNAL(cl_khr_srgb_im

[PATCH] D89394: clang/Basic: Stop using SourceManager::getBuffer, NFC

dexonsmith updated this revision to Diff 298152. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89394/new/ https://reviews.llvm.org/D89394 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic/Diagnostic.cpp clang/lib/Basic/SourceLocation.cpp clang/lib/Basic/SourceManag

[PATCH] D89372: [OpenCL] Remove unused extensions

yaxunl added a comment. With this change, clang basically will have no knowledge about the removed extensions, i.e., it will not know which extension is supported in which version of OpenCL and have no way to enable/disable those extensions. There will be no way to define corresponding macros i

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 298156. eduucaldas marked an inline comment as done. eduucaldas added a comment. - Make `ElementAndDelimiterIterator` templated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas added a comment. Haven't yet implemented `BeforeBegin`, waiting for a heads up on the patch as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 ___

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:269 + return EDI == Other.EDI; +} + gribozavr2 wrote: > Please also define `operator!=`. this is defined by the `iterato_facade_base`, take a look at the comments in

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:241-242 /// "a; b; c" <=> [("a" , ";"), ("b" , ";" ), ("c" , null)] + template + class ElementAndDelimiterIterator + : public llvm::iterator_facade_base< Since we'

[PATCH] D89398: Lexer: Update the Lexer to use MemoryBufferRef, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. Update `Lexer` / `Lexer::Lexer` to use `MemoryBufferRef` instead of `MemoryBuffer*`. Callers that were acquiring a `Memory

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85bcc21ddad: [AIX] Turn -fdata-sections on by default in Clang (authored by jasonliu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D88737?vs=296965&id=298160#toc R

[clang] f85bcc2 - [AIX] Turn -fdata-sections on by default in Clang

Author: jasonliu Date: 2020-10-14T15:58:31Z New Revision: f85bcc21ddadd07f38e1db7aa286ff985bd0eb10 URL: https://github.com/llvm/llvm-project/commit/f85bcc21ddadd07f38e1db7aa286ff985bd0eb10 DIFF: https://github.com/llvm/llvm-project/commit/f85bcc21ddadd07f38e1db7aa286ff985bd0eb10.diff LOG: [AIX

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet added a comment. In D89277#2329947 , @sammccall wrote: > (sorry out today and haven't looked at code yet) no worries it is a prototype, I wouldn't spend time looking at the implementation until we agree on the interaction :D OTHO, checking out t

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

jdenny added a comment. Thanks for working on this. Sorry to take so long to review. Before I try to digest the code, I have a few high-level questions. Based on the test suite changes, `TARGET_PARAM` is disappearing from many cases. Can you explain a bit how that supports overlapping and re

[clang-tools-extra] fc2fb60 - [clangd] clang-format TweakTests, NFC

Author: Kadir Cetinkaya Date: 2020-10-14T18:14:27+02:00 New Revision: fc2fb60bab75955cea341907b252cc1c760481a8 URL: https://github.com/llvm/llvm-project/commit/fc2fb60bab75955cea341907b252cc1c760481a8 DIFF: https://github.com/llvm/llvm-project/commit/fc2fb60bab75955cea341907b252cc1c760481a8.dif

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2330310 , @jdenny wrote: > Thanks for working on this. Sorry to take so long to review. Before I try > to digest the code, I have a few high-level questions. > > Based on the test suite changes, `TARGET_PARAM` is disap

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2330217 , @yaxunl wrote: > With this change, clang basically will have no knowledge about the removed > extensions, i.e., it will not know which extension is supported in which > version of OpenCL and have no way to e

[clang] b967b9a - [CodeGen] Move x86 specific ms intrinsic tests into x86 target subfolder. NFCI.

Author: Simon Pilgrim Date: 2020-10-14T17:37:26+01:00 New Revision: b967b9a7116babdf8aafacdcb4aae3a33d57aaa0 URL: https://github.com/llvm/llvm-project/commit/b967b9a7116babdf8aafacdcb4aae3a33d57aaa0 DIFF: https://github.com/llvm/llvm-project/commit/b967b9a7116babdf8aafacdcb4aae3a33d57aaa0.diff

[PATCH] D89362: [MS] Apply `inreg` to AArch64 sret parms on instance methods

rnk added inline comments. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:1108 + bool isTrivialForABI = + RD->canPassInRegisters() && !(isAArch64 && !isCXX14Aggregate(RD)); bool isIndirectReturn = efriedma wrote: > isTrivialForABI is only used if isAA

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 +TARGET_BUILTIN(__builtin_wasm_load32_lane, "V4iIii*", "nU", "simd128") +TARGET_BUILTIN(__builtin_wasm_load64_lane, "V2LLiIiLLi*", "nU", "simd128") +TARGET_BUILTIN(__builtin_wasm_stor

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

tlively planned changes to this revision. tlively added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-load-lane-offset.ll:4 + +; Test SIMD v128.load{8,16,32,64}_lane instructions. TODO: Use the offset field. + aheejin wrote: > Maybe add a comme

[PATCH] D89402: clang/Lex: Stop using SourceManager::getBuffer

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update clang/lib/Lex to stop relying on a `MemoryBuffer*`, using the `MemoryBufferRef` from `getBufferOrNone` since both locations had logic f

[PATCH] D89025: [RISCV] Add -mtune support

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:91 +// MTUNE-E31-MCPU-E76: "-target-feature" "+a" +// MTUNE-E31-MCPU-E76-NOT: "-target-feature" "+f" +// MTUNE-E31-MCPU-E76: "-target-feature" "+c" A NOT pattern depends on the feature orde

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:74 OPENCLEXT_INTERNAL(cl_khr_mipmap_image_writes, 200, ~0U) -OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U) OPENCLEXT_INTERNAL(cl_khr_subgroups, 200, ~0U) azaba

[PATCH] D89405: [CodeGen][X86] Emit fshl/fshr ir intrinsics for shiftleft128/shiftright128 ms intrinsics

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel, rnk, thakis. Herald added a subscriber: pengfei. Herald added a project: clang. RKSimon requested review of this revision. Now that funnel shift handling is pretty good, we can use the intrinsics directly and avoid a lo

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Mordante marked 8 inline comments as done. Mordante added a comment. In D89210#2328378 , @aaron.ballman wrote: > Thank you for the continued work on this feature! I'd like to better > understand the behavior of fallthrough labels because I think there ar

[PATCH] D89406: clang/{Format,Rewrite}: Stop using SourceManager::getBuffer, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update clang/lib/Format and clang/lib/Rewrite to use a `MemoryBufferRef` from `getBufferOrFake` instead of `MemoryBuffer*` from `getBuffer`.

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Mordante updated this revision to Diff 298176. Mordante marked 3 inline comments as done. Mordante added a comment. Address review comments: - Improved the documentation - Enabled clang-format on the new code - Added unit tests - Removed some unneeded code from the unit tests due to -disable-llvm

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

njames93 created this revision. njames93 added reviewers: alexfh, JonasToth, aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Added option `ScopedEnumConstant(Prefix|Case|Suffix)` to readability

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rsmith added a comment. In D89360#2329856 , @sepavloff wrote: > I would propose to consider solution in D88498 > . It tries to fix the real reason of the > malfunction - using dynamic rounding mode for evaluation of globa

[PATCH] D89327: fixes compiler-rt bug when printing libgcc for baremetal

This revision was automatically updated to reflect the committed changes. Closed by commit rG18432bea7648: [Driver]: fix compiler-rt path when printing libgcc for baremetal (authored by cjdb, committed by manojgupta). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed

[clang] 18432be - [Driver]: fix compiler-rt path when printing libgcc for baremetal

Author: Christopher Di Bella Date: 2020-10-14T10:29:35-07:00 New Revision: 18432bea764863d1c42fd569bd3846673ee4e802 URL: https://github.com/llvm/llvm-project/commit/18432bea764863d1c42fd569bd3846673ee4e802 DIFF: https://github.com/llvm/llvm-project/commit/18432bea764863d1c42fd569bd3846673ee4e80

[PATCH] D89409: clang/Frontend: Mostly stop using SourceManager::getBuffer, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update clang/lib/Frontend to use a `MemoryBufferRef` from `getBufferOrFake` instead of `MemoryBuffer*` from `getBuffer`, with the exception

[PATCH] D89411: clang/CodeGen: Mostly stop using SourceManager::getBuffer, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update `clang/lib/CodeGen` to use a `MemoryBufferRef` from `getBufferOrNone` instead of `MemoryBuffer*` from `getBuffer`. No functionality ch

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

jdenny added a comment. In D86119#2330339 , @ABataev wrote: > In D86119#2330310 , @jdenny wrote: > >> Thanks for working on this. Sorry to take so long to review. Before I try >> to digest the code, I have a few

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2330601 , @jdenny wrote: > In D86119#2330339 , @ABataev wrote: > >> In D86119#2330310 , @jdenny wrote: >> >>> Thanks for working on this.

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. In case my previous comment is not clear: we can do renaming in LLVM, but the benefit is small (for a few libcalls (only some really simple libcalls) with custom code emitting, if they have `asm(...)`, they are now optimizable). We will require a renaming infrastructure

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra added inline comments. Comment at: clang/include/clang/Basic/PartialDiagnostic.h:51 + : DiagID(DiagID) { +Allocator = &Allocator_; + } Is there a particular reason to move field initialization into the body here and in other constructors? CHANGES

[PATCH] D89414: clang/StaticAnalyzer: Stop using SourceManager::getBuffer

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: steakhal, ASDenysPetrov, martong, ributzka, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. dexonsmith requested review of this revision. Update clang/lib/StaticAnalyzer to stop relyin

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. Is this diff been created incorrectly again? Taking a step back, Is Hungarian notation really a case style, Seems to me its mainly about the prefix and a user may want `DWORD dwUPPER_CASE`, Right now there is no way of adopting that. Maybe extend the options for hungar

[PATCH] D89372: [OpenCL] Remove unused extensions

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:74 OPENCLEXT_INTERNAL(cl_khr_mipmap_image_writes, 200, ~0U) -OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U) OPENCLEXT_INTERNAL(cl_khr_subgroups, 200, ~0U) mantog

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

njames93 updated this revision to Diff 298200. njames93 added a comment. Small tweak to the docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89407/new/ https://reviews.llvm.org/D89407 Files: clang-tools-extra/clang-tidy/readability/IdentifierN

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/PartialDiagnostic.h:51 + : DiagID(DiagID) { +Allocator = &Allocator_; + } tra wrote: > Is there a particular reason to move field initialization

[PATCH] D89416: clang-{tools,unittests}: Stop using SourceManager::getBuffer, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: usaxena95, ributzka, kadircet. Herald added a reviewer: shafik. dexonsmith requested review of this revision. Update clang-tools-extra, clang/tools, clang/unittests to migrate from `SourceManager::ge

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2165 +assert(getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0 && + "Expected `this` pointer without address space attribute."); + jdoerfert wrote: > I'm unsure why t

[PATCH] D89276: Support ObjC in IncludeInserter

compositeprimes updated this revision to Diff 298203. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89276/new/ https://reviews.llvm.org/D89276 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/clang-tidy/utils/Include

[PATCH] D89416: clang-{tools,unittests}: Stop using SourceManager::getBuffer, NFC

dexonsmith updated this revision to Diff 298206. dexonsmith added a comment. Removed the now-unused `Invalid` local variable from the libclang change; not sure how I missed the warning before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89416/new/ https://reviews.llvm.org/D89416 Fil

[PATCH] D88227: [clang-format] Add a SpaceAroundPointerQualifiers style option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88227/new/ https://reviews.llvm.org/D88227 _

  1   2   >