yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: clang/include/clang/Basic/PartialDiagnostic.h:51
+ : DiagID(DiagID) {
+ Allocator = &Allocator_;
+ }
----------------
tra wrote:
> Is there a particular reason to move field initialization into the body here
> and in other constructors?
Allocator is now a member of the base class, therefore needs to be initialized
directly. I could add ctor to the base class but I did not see too much benefit
of doing that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84362/new/
https://reviews.llvm.org/D84362
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
