[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Shouldn't this compare the actual width expressions? In other words, this patch wouldn't pass the test below: TEST_F(StructuralEquivalenceTemplateTest, DependentFieldDeclDiff

[PATCH] D88634: [clangd] Extend the rename API.

hokein updated this revision to Diff 295747. hokein marked 6 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88634/new/ https://reviews.llvm.org/D88634 Files: clang-tools-ex

[clang-tools-extra] bc18d8d - [clangd] Drop dependence on standard library in check.test

Author: Sam McCall Date: 2020-10-02T09:53:06+02:00 New Revision: bc18d8d9b705d31a94c51900c8b18e4feaf9c7fb URL: https://github.com/llvm/llvm-project/commit/bc18d8d9b705d31a94c51900c8b18e4feaf9c7fb DIFF: https://github.com/llvm/llvm-project/commit/bc18d8d9b705d31a94c51900c8b18e4feaf9c7fb.diff LO

[PATCH] D88634: [clangd] Extend the rename API.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:416 +auto Results = clangd::rename( +{Pos, "dummy", InpAST->AST, File, + RenameOpts.AllowCrossFile ? &EmptyIndex : Index, RenameOpts}); sammccall wrote: > we'r

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall added a comment. Sorry @rsmith @hoy, I've replaced the test with one without such dependencies in bc18d8d9b705d31a94c51900c8b18e4feaf9c7fb . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal added a comment. In D85528#2307785 , @NoQ wrote: > Aha, ok, thanks, I now understand what the problem is because I was able to > run the test before the patch and see how the patch changes the behavior. > > What do you think about flattening the

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo http

[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.

mstorsjo added a comment. This broke use of setjmp for mingw on x86_64. IIRC, in MSVC environments, the `_setjmp` function is considered built-in, which is given an implicit second argument by the compiler. In mingw targets on the other hand, the compiler normally doesn't know of any such extra

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232 +TEST_F(BackgroundIndexTest, RelationsMultiFile) { + MockFS FS; kadircet wrote: > do we still need this test? this one was marked as resolved but i stil

[PATCH] D88634: [clangd] Extend the rename API.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, introducing a separate field for locally affected ranges is up to you. Comment at: clang-tools-extra/clangd/ClangdServer.h:277 + /// + /// It is equal to invoke r

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/test/document-link.test:1 -# RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s +# %resource_dir actually points at b

[clang-tools-extra] 17747d2 - [clangd] Remove Tweak::Intent, use CodeAction kind directly. NFC

Author: Sam McCall Date: 2020-10-02T11:14:23+02:00 New Revision: 17747d2ec8ec4471748197db54c8703f0c07c91c URL: https://github.com/llvm/llvm-project/commit/17747d2ec8ec4471748197db54c8703f0c07c91c DIFF: https://github.com/llvm/llvm-project/commit/17747d2ec8ec4471748197db54c8703f0c07c91c.diff LO

[PATCH] D88427: [clangd] Remove Tweak::Intent, use CodeAction kind directly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17747d2ec8ec: [clangd] Remove Tweak::Intent, use CodeAction kind directly. NFC (authored by sammccall). Changed prior to commit: https://reviews.l

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 295766. nomanous added a comment. I change the four-char constants back to "Warning" in this revision, but set it to be ignored by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 Files: clang/in

[PATCH] D88724: [clangd] Make the tweak filter a parameter to enumerateTweaks. NFC

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. (Required for CodeActionContext

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous updated this revision to Diff 295771. nomanous added a comment. I restore some needless modification in the previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:33 + + for (const FunctionDecl *D : Node.redecls()) +if (D->getASTContext().getSourceManager().isInSystemHeader( a

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske added a comment. I plan to add the option for extended set of asynchronous-safe functions (defined by the POSIX list) in a next patch. There is other possible improvement to check at least something of the criteria listed here

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.cpp:28 +size_t ChildrenSize = 0; +for (const auto &C : Children) { + C.traverseTree(CollapseDetails, sammccall wrote: >

[PATCH] D88726: [clangd] Make PopulateSwitch a fix.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. It fixes the -Wswitch warning, though we

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

kadircet updated this revision to Diff 295779. kadircet added a comment. - update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88721/new/ https://reviews.llvm.org/D88721 Files: clang-tools-extra/clangd/test/document-link.test Index: c

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54c03d8f7da7: [clangd][lit] Update document-link.test to respect custom resource-dir locations (authored by kadircet). Repository: rG LLVM Github

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 added a comment. Also, I wanted to mention that clang-cl.exe actually crashes deterministically when running precompiles for 2 of our headers when using '-fpch-instantiate-templates' with the following signature: 1. parser at end of file 2. Per-file LLVM IR generation

[clang-tools-extra] 54c03d8 - [clangd][lit] Update document-link.test to respect custom resource-dir locations

Author: Kadir Cetinkaya Date: 2020-10-02T12:24:06+02:00 New Revision: 54c03d8f7da72fdf1a9e122391c51c2f0ea7b298 URL: https://github.com/llvm/llvm-project/commit/54c03d8f7da72fdf1a9e122391c51c2f0ea7b298 DIFF: https://github.com/llvm/llvm-project/commit/54c03d8f7da72fdf1a9e122391c51c2f0ea7b298.dif

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

ArcsinX added a comment. Just a question. On Windows `%resource_dir/..` looks a bit inconsistent after substitution (`d:\llvm-project\build\lib\clang\12.0.0\include/..`), but this test passes. As far as Windows accepts forward and back slashes, I expect something like this `%/resource_dir/..` to

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @steakhal > Till then, I recommend you to follow my effort at D88477 > . I'm aleady on this way. I'm debugging the Store. I think we load a wrong type because we store a wrong type. CHANGES SINCE LAST ACTION https://reviews.ll

[clang-tools-extra] 57ac47d - [clangd] Make PopulateSwitch a fix.

Author: Sam McCall Date: 2020-10-02T13:24:24+02:00 New Revision: 57ac47d78885c9a3d712692b1476d99840591db1 URL: https://github.com/llvm/llvm-project/commit/57ac47d78885c9a3d712692b1476d99840591db1 DIFF: https://github.com/llvm/llvm-project/commit/57ac47d78885c9a3d712692b1476d99840591db1.diff LO

[PATCH] D88726: [clangd] Make PopulateSwitch a fix.

This revision was automatically updated to reflect the committed changes. Closed by commit rG57ac47d78885: [clangd] Make PopulateSwitch a fix. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88726/new/ https://reviews.llvm.org

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

sammccall added a comment. > As far as Windows accepts forward and back slashes Note we don't rely on windows itself for this support. All access through `llvm::sys::fs` APIs on windows ultimately goes through `widenPath` to convert to UTF-16, and this substitutes slashes. So LLVM tools do alway

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.cpp:28 +size_t ChildrenSize = 0; +for (const auto &C : Children) { + C.traverseTree(CollapseDetails, kadircet wrote: > sammccall wrote: > > Here the detailed nod

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

steakhal added a comment. In D71524#2304742 , @boga95 wrote: > As far as I remember I tried to make `std::cin` tainted, but it was > complicated. What sort of issues did you find by implementing that approach? Could you elaborate? > I run the checker a

[clang] 8825fec - [AArch64] Add CPU Cortex-R82

Author: Sjoerd Meijer Date: 2020-10-02T12:47:23+01:00 New Revision: 8825fec37e73eea1bc3e4f5c125e1fd02d002d6c URL: https://github.com/llvm/llvm-project/commit/8825fec37e73eea1bc3e4f5c125e1fd02d002d6c DIFF: https://github.com/llvm/llvm-project/commit/8825fec37e73eea1bc3e4f5c125e1fd02d002d6c.diff

[PATCH] D88660: [AArch64] Add CPU Cortex-R82

This revision was automatically updated to reflect the committed changes. Closed by commit rG8825fec37e73: [AArch64] Add CPU Cortex-R82 (authored by SjoerdMeijer). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D88660?vs=

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295796. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments: Default seeded the RNG for the benchmark. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://re

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295797. usaxena95 added a comment. Added newline at end of files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tools-extra/clangd/benchmarks/CMakeLi

[PATCH] D87030: Adapt CastExpr::getSubExprAsWritten to ConstantExpr

sberg added a comment. friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87030/new/ https://reviews.llvm.org/D87030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88634: [clangd] Extend the rename API.

hokein updated this revision to Diff 295798. hokein marked 2 inline comments as done. hokein added a comment. address comment: add the LocalChanges field in RenameResult. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88634/new/ https://reviews.llvm

[PATCH] D88634: [clangd] Extend the rename API.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.h:61 + Range R; + FileEdits Edits; +}; sammccall wrote: > hokein wrote: > > sammccall wrote: > > > It's slightly awkward to have the half-populated state (may or may not > > > c

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

ArcsinX added a comment. In D88721#2308296 , @sammccall wrote: >> As far as Windows accepts forward and back slashes > > Note we don't rely on windows itself for this support. > All access through `llvm::sys::fs` APIs on windows ultimately goes through >

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

martong added a comment. > In D88665#2307562 , @shafik wrote: > >> So was the bug we were saying there were falsely equivalent or falsely not >> equivalent? > > I think the bug is the crash :) Yes. More specifically, the call of `getBitWidthValue()` cause

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

martong updated this revision to Diff 295800. martong added a comment. - Delegate to BitWidth Expr matching in case of BitFields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88665/new/ https://reviews.llvm.org/D88665 Files: clang/lib/AST/ASTStr

[PATCH] D88199: Introduce and use a new section type for the bb_addr_map section.

rahmanl updated this revision to Diff 295666. rahmanl added a comment. Herald added subscribers: libcxx-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commits, tatianashp, wenlei, ThomasRaoux, AlexeySotkin, msifontes, sstefan1, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, ker

Re: [PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

not that i know of. On Fri, Oct 2, 2020 at 12:34 PM Aleksandr Platonov via Phabricator < revi...@reviews.llvm.org> wrote: > ArcsinX added a comment. > > Just a question. > On Windows `%resource_dir/..` looks a bit inconsistent after substitution > (`d:\llvm-project\build\lib\clang\12.0.0\include/

[PATCH] D88199: Introduce and use a new section type for the bb_addr_map section.

rahmanl updated this revision to Diff 295668. rahmanl added a comment. Diff reupload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88199/new/ https://reviews.llvm.org/D88199 Files: llvm/include/llvm/BinaryFormat/ELF.h llvm/lib/CodeGen/AsmPrin

[PATCH] D88730: [HIP] Fix default output file for -E

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. By convention the default output file for -E is "-" (stdout). This is expected by tools like ccache, which uses output of -E to determine if a file and its dependence has changed. Currently clang

[PATCH] D88721: [clangd][lit] Update document-link.test to respect custom resource-dir locations

sammccall added a comment. In D88721#2308361 , @ArcsinX wrote: > In D88721#2308296 , @sammccall wrote: > >>> As far as Windows accepts forward and back slashes >> >> Note we don't rely on windows itself for this sup

[PATCH] D88634: [clangd] Extend the rename API.

sammccall accepted this revision. sammccall added a comment. LG, thanks! Comment at: clang-tools-extra/clangd/refactor/Rename.h:62 + // Edits for the current main file. + Edit LocalChanges; + // Complete edits for the rename, including LocalChanges. this cou

[PATCH] D88734: [HIP] Align device binary

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. To facilitate faster loading of device binaries and share them among processes, HIP runtime favors their alignment be

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:33 + + for (const FunctionDecl *D : Node.redecls()) +if (D->getASTContext().getSourceManager().isInSystemHeader( balazske wrote: > aaron.ballman wrote:

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295810. bogser01 added a comment. Removed residual conflict markers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/CMakeLis

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 295811. bogser01 added a comment. Remove conflict markers 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D87962#2307824 , @rsmith wrote: > In D87962#2306043 , @aaron.ballman > wrote: > >> That doesn

[PATCH] D88700: [clang-tidy] modernize-use-trailing-return-type fix #44206

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88700/new/ https://reviews.llvm.org/D88700 __

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:33 + + for (const FunctionDecl *D : Node.redecls()) +if (D->getASTContext().getSourceManager().isInSystemHeader( aaron.ballman wrote: > balazske wrote: > > a

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

martong requested changes to this revision. martong added a comment. This revision now requires changes to proceed. Sorry for the late review, I just noticed something which is not a logical error, but we could make the ASTImporter code much cleaner. Comment at: clang/lib/AST/

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

lebedev.ri updated this revision to Diff 295817. lebedev.ri added a comment. Herald added a subscriber: pengfei. Rebased, NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org/D87972 Files: llvm/lib/Target/AMDGPU/

[PATCH] D88314: Added llvm-string-referencing check

bogser01 added a comment. @alexfh does this look alright? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88634: [clangd] Extend the rename API.

hokein updated this revision to Diff 295819. hokein marked an inline comment as done. hokein added a comment. change LocalChanges type to vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88634/new/ https://reviews.llvm.org/D88634 Files: clan

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:33 + + for (const FunctionDecl *D : Node.redecls()) +if (D->getASTContext().getSourceManager().isInSystemHeader( balazske wrote: > aaron.ballman wrote:

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu created this revision. jasonliu added reviewers: hubert.reinterpretcast, daltenty, sfertile, Xiangling_L, DiggerLin. Herald added subscribers: dang, dexonsmith, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. jasonl

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Still a couple of lint warnings, otherwise LGTM Comment at: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:74 + for (auto _ : State) { +

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:9010 + ToPath[Idx] = + cast(const_cast(ImpDecl.get())); +} Tyker wrote: > rsmith wrote: > > We want the path in an `APValue` to be canonical, but importing a canonical > >

[clang-tools-extra] 0f0cbcc - [clangd] Extend the rename API.

Author: Haojian Wu Date: 2020-10-02T16:03:44+02:00 New Revision: 0f0cbcc4b166f32603371fb1d62ef3816cf8425f URL: https://github.com/llvm/llvm-project/commit/0f0cbcc4b166f32603371fb1d62ef3816cf8425f DIFF: https://github.com/llvm/llvm-project/commit/0f0cbcc4b166f32603371fb1d62ef3816cf8425f.diff LO

[PATCH] D88634: [clangd] Extend the rename API.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f0cbcc4b166: [clangd] Extend the rename API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

yaxunl added inline comments. Comment at: clang/test/SemaCUDA/device-var-init.cu:404 __host__ __device__ void hd_sema() { static int x = 42; } tra wrote: > yaxunl wrote: > > how does this work in device compilation? Is this equivalent to `static > > __devic

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-hungarian-notation.cpp:25 +// RUN: {key: readability-identifier-naming.FunctionCase , value: CamelCase }, \ +// RUN: {key: readabili

[clang] 36501b1 - Emit predefined macro for wavefront size for amdgcn

Author: Yaxun (Sam) Liu Date: 2020-10-02T10:17:21-04:00 New Revision: 36501b180a4f0194f0cfb4374d096ae660182827 URL: https://github.com/llvm/llvm-project/commit/36501b180a4f0194f0cfb4374d096ae660182827 DIFF: https://github.com/llvm/llvm-project/commit/36501b180a4f0194f0cfb4374d096ae660182827.dif

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

This revision was automatically updated to reflect the committed changes. Closed by commit rG36501b180a4f: Emit predefined macro for wavefront size for amdgcn (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added a comment. Not sure if there is a better way to do this. But I have to admit this approach along with D88493 is a bit fragile. If plug-in writer forgets to set `HasExplicitDataSections` to true, then the final result that TargetMachine give for `

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

zahen added a comment. This patch doesn't need a test case outside of the one that @rnk requested to make sure that the flag flows from the clang-cl driver appropriately. `pch-instantiate-templates` as authored doesn't match cl.exe behavior and being unable to turn it off will prevent our adop

[clang] c87c017 - Fix failure in test hip-macros.hip

Author: Yaxun (Sam) Liu Date: 2020-10-02T10:33:32-04:00 New Revision: c87c017a4c47c47b002b9f55f25285298cd07093 URL: https://github.com/llvm/llvm-project/commit/c87c017a4c47c47b002b9f55f25285298cd07093 DIFF: https://github.com/llvm/llvm-project/commit/c87c017a4c47c47b002b9f55f25285298cd07093.dif

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin marked 5 inline comments as done. DiggerLin added inline comments. Comment at: clang/test/CodeGen/aix-no-xcoff-visibility.cpp:75 + +// VISIBILITY-IR:@b = protected global i32 0 +// VISIBILITY-IR:@pramb = hidden global i32 0 jasonliu wrote: > Not

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/KernelNameRestrictionCheck.cpp:90 +Check.diag(SM.getLocForStartOfFile(SM.getMainFileID()), + "Naming your OpenCL kernel source file 'kernel.cl', 'Verilog.cl'" +

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge added a comment. Sorry, I had a response to that comment but accidentally left it as unsubmitted... Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232 +TEST_F(BackgroundIndexTest, RelationsMultiFile) { + MockFS FS; kadircet w

[PATCH] D88446: docs: add documentation describing API Notes

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/docs/APINotes.rst:216 +Due to a compiler bug, 'NullabilityOfRet' may change nullability of the +parameters as well (rdar://30544062). Avoid using it and instead use +'ResultTy

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/CodeGenOptions.def:47 +CODEGENOPT(DataSections , 1, 0) ///< Set by default, or when -f[no-]data-sections. +CODEGEN

[PATCH] D88446: docs: add documentation describing API Notes

compnerd updated this revision to Diff 295835. compnerd added a comment. Update text based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88446/new/ https://reviews.llvm.org/D88446 Files: clang/docs/APINotes.rst clang/test/APINote

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295837. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tool

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:74 + for (auto _ : State) { +srand(0); +State.PauseTiming(); adamcz wrote: > Move this out of the loop. Right now we re-generate

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin updated this revision to Diff 295838. DiggerLin marked an inline comment as done. DiggerLin added a comment. address comment and merger the patch https://reviews.llvm.org/D88234 into the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske updated this revision to Diff 295840. balazske added a comment. Updated check for system function. Updated documentation. Added more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87449/new/ https://reviews.llvm.org/D87449 File

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske marked 9 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:33 + + for (const FunctionDecl *D : Node.redecls()) +if (D->getASTContext().getSourceManager().isInSystemHeader( a

[clang-tools-extra] db2a646 - [clangd] Add bencmark for measuring latency of DecisionForest model.

Author: Utkarsh Saxena Date: 2020-10-02T18:04:31+02:00 New Revision: db2a646c5f002cc16d02d6fac0b2d715cdd4a809 URL: https://github.com/llvm/llvm-project/commit/db2a646c5f002cc16d02d6fac0b2d715cdd4a809 DIFF: https://github.com/llvm/llvm-project/commit/db2a646c5f002cc16d02d6fac0b2d715cdd4a809.diff

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb2a646c5f00: [clangd] Add bencmark for measuring latency of DecisionForest model. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D885

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

cchen added a comment. In D74144#2307494 , @ABataev wrote: > In D74144#2307454 , @cchen wrote: > >> @ABataev, the below test is extracted from Sollve test suite and Clang now >> emit: >> >> test.c:17:35: error: s

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:27 + // Find a possible redeclaration in system header. + for (const FunctionDecl *D : FD->redecls()) +if (FD->getASTContext().getSourceManager().isInSystemHeader(

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:41 +static bool isAllowedSystemCall(const FunctionDecl *FD) { + if (!FD->getIdentifier()) +return true; balazske wrote: > aaron.ballman wrote: > > A fun

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:47 +CODEGENOPT(DataSections , 1, 0) ///< Set by default, or when -f[no-]data-sections. +CODEGENOPT(HasExplicitDataSections, 1, 0) ///< Set when -f[no-]data-sections is set. CODEGENOPT

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88377/new/ https://reviews.llvm.org/D88377 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

hoy added a comment. In D88338#2307976 , @sammccall wrote: > Sorry @rsmith @hoy, I've replaced the test with one without such dependencies > in bc18d8d9b705d31a94c51900c8b18e4feaf9c7fb >

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. In D74144#2308796 , @cchen wrote: > In D74144#2307494 , @ABataev wrote: > >> In D74144#2307454 , @cchen wrote: >> >>> @ABataev, the below test is ext

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:47 +CODEGENOPT(DataSections , 1, 0) ///< Set by default, or when -f[no-]data-sections. +CODEGENOPT(HasExplicitDataSections, 1, 0) ///< Set when -f[no-]data-sections is set. CODEGENOPT

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

lebedev.ri added a comment. In D87972#2294614 , @lebedev.ri wrote: > In D87972#2294488 , @xbolva00 wrote: > Does that sound reasonable? >> >> Yes IMHO. >> What are the next suggested steps? >> >> It would

[PATCH] D87451: add new option ignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) + nit: add a space before parens

[PATCH] D88745: [clangd][WIP] Add new code completion signals to improve MRR by 3%.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Adds two more signals. - NumNameInContext: Strength of match of name with conte

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

xbolva00 added a comment. >> I'm not really sure what are my potential next steps here. Maybe just add option to disable late SROA? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org/D87972 _

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

lattner added a comment. Hi all, The LLVM foundation board discussed this offline -- it looks like the contributor is a bit confused about the LLVM project policies towards copyright, license, patent stuff etc. I really appreciate the dilligence here to capture the ideas that went into this c

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:47 +CODEGENOPT(DataSections , 1, 0) ///< Set by default, or when -f[no-]data-sections. +CODEGENOPT(HasExplicitDataSections, 1, 0) ///< Set when -f[no-]data-sections is set. CODEGENOPT(

[clang] eb55735 - Reland [AlwaysInliner] Update BFI when inlining

Author: Arthur Eubanks Date: 2020-10-02T10:46:57-07:00 New Revision: eb55735073d53f7816b9a4080e6f54dfeda5ae50 URL: https://github.com/llvm/llvm-project/commit/eb55735073d53f7816b9a4080e6f54dfeda5ae50 DIFF: https://github.com/llvm/llvm-project/commit/eb55735073d53f7816b9a4080e6f54dfeda5ae50.diff

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:487 + + // Walk both lists to get the full set of implied protocols + llvm::DenseSet AllImpliedProtocols; rjmccall wrote: > You should add something like ", including all the runtime protocol

  1   2   >