kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232
+TEST_F(BackgroundIndexTest, RelationsMultiFile) {
+ MockFS FS;
----------------
kadircet wrote:
> do we still need this test?
this one was marked as resolved but i still don't see the reasoning. can we
test this in fileindextests instead?
we already test the sharding logic, we need to test the merging logic now. can
we rather test it at FileSymbols layer directly? or is there something extra
that i am misisng?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87256/new/
https://reviews.llvm.org/D87256
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
