[PATCH] D87953: [xray] Function coverage groups

ianlevesque added a comment. Thanks @MaskRay - I tried to answer that question in https://reviews.llvm.org/D87953#2286430. At present we are deploying instrumentation to an arbitrary subset of our application using the instruction threshold. I would like to make the selection of how many and wh

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

MaskRay added a comment. In D81865#2293158 , @froydnj wrote: > In D81865#2293146 , @MaskRay wrote: > >> In D81865#2293066 , @dblaikie wrote: >> >>> In D81865#2293059

[PATCH] D88195: Remove stale assert.

nickdesaulniers added a comment. I'm super confused between the commit message and initial hunk, that seem to make sense and probably should go in clang-11 if it's not too late, and the additional tests for modules which the commit message does not address. Were these meant to be separate comm

[PATCH] D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88240/new/ https://reviews.llvm.org/D88240 ___

[PATCH] D87953: [xray] Function coverage groups

MaskRay added a comment. In D87953#2293162 , @ianlevesque wrote: > Thanks @MaskRay - I tried to answer that question in > https://reviews.llvm.org/D87953#2286430. At present we are deploying > instrumentation to an arbitrary subset of our application usi

[PATCH] D87953: [xray] Function coverage groups

MaskRay added a comment. I probably have asked too much... but it'd be nice if you also add some documentation to `llvm/docs/XRay*.rst` That helps users :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 _

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:2427 +FPOptions FPFeatures = Cast->getFPFeaturesInEffect(Info.Ctx.getLangOpts()); +RM = FPFeatures.getRoundingMode(

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. `llvm::call_once` is fine, but IMO the static local version is preferable: it's built in to the language, no headers to include. Comment at: clang/lib/Driver/Distro.cpp:224 + if

[clang] d1419c9 - [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default

Author: Alexey Bataev Date: 2020-09-24T13:51:21-04:00 New Revision: d1419c9fdab141617b6aa9f028191b9bfc8be260 URL: https://github.com/llvm/llvm-project/commit/d1419c9fdab141617b6aa9f028191b9bfc8be260 DIFF: https://github.com/llvm/llvm-project/commit/d1419c9fdab141617b6aa9f028191b9bfc8be260.diff

[PATCH] D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1419c9fdab1: [OPENMP]Fix PR47621: Variable used by task inside a template function is not… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

mibintc added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2438 +/// Check if the given evaluation result is allowed for constant evaluation. +static bool checkFloatingPointResult(EvalInfo &Info, const Expr *E, + APFloat::opStatu

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Xiangling_L updated this revision to Diff 294116. Xiangling_L added a comment. Updated the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/CodeGen

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2148 +CommonElementType == nullptr && !NumInitElts) { const ArrayType *AT = CGM.getContext().getAsArrayType(DestType); CommonElementType = CGM.getTypes().ConvertType(AT->getElem

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: sanjoy.google, bixia, yaxunl. Herald added a project: clang. tra requested review of this revision. This is needed to compile some headers in CUDA-11 that assume that threadIdx is implicitly convertible to dim3. Wit

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I know it comes in a separate change, but can we add a check to the test-suite? Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:381 +__device__ inline __cuda_bui

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rnk added subscribers: rjmccall, rnk. rnk added inline comments. Comment at: clang/include/clang/Basic/Diagnostic.h:1086-1090 /// Note that many of these will be created as temporary objects (many call /// sites), so we want them to be small and we never want their address take

[clang] b62fd43 - Revert "Recommit [NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

Author: Reid Kleckner Date: 2020-09-24T11:16:55-07:00 New Revision: b62fd436a3e613cbfe0654305cbc0e4f142bfcf9 URL: https://github.com/llvm/llvm-project/commit/b62fd436a3e613cbfe0654305cbc0e4f142bfcf9 DIFF: https://github.com/llvm/llvm-project/commit/b62fd436a3e613cbfe0654305cbc0e4f142bfcf9.diff

[clang] 3453b69 - Revert "Recommit "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions""

Author: Reid Kleckner Date: 2020-09-24T11:16:54-07:00 New Revision: 3453b6928da332bb67f902add71f5cd80f61c136 URL: https://github.com/llvm/llvm-project/commit/3453b6928da332bb67f902add71f5cd80f61c136 DIFF: https://github.com/llvm/llvm-project/commit/3453b6928da332bb67f902add71f5cd80f61c136.diff

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added inline comments. Comment at: flang/lib/Frontend/TextDiagnostic.cpp:26 +static const enum llvm::raw_ostream::Colors savedColor = +llvm::raw_ostream::SAVEDCOLOR; + awarzynski wrote: > sameeranjoshi wrote: > > Unless Flang is not changing the

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added a comment. In D87774#2292034 , @awarzynski wrote: > @sameeranjoshi Apologies, I missed some of your comments. > > In D87774#2287927 , @sameeranjoshi > wrote: > >> Thanks for working on it. >> Fe

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi added inline comments. Comment at: flang/lib/Frontend/TextDiagnosticPrinter.cpp:37 + // this later as we print out the diagnostic to the terminal. + SmallString<100> outStr; + info.FormatDiagnostic(outStr); awarzynski wrote: > awarzynski wrote: >

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

erichkeane updated this revision to Diff 294121. erichkeane marked an inline comment as done. erichkeane added a comment. @rjmccall Done! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88236/new/ https://reviews.llvm.org/D88236 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/test/

[clang] cde7d90 - Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default"

Author: Alexey Bataev Date: 2020-09-24T14:42:04-04:00 New Revision: cde7d90cc7c20d73d14225517cf11ffc6073018a URL: https://github.com/llvm/llvm-project/commit/cde7d90cc7c20d73d14225517cf11ffc6073018a DIFF: https://github.com/llvm/llvm-project/commit/cde7d90cc7c20d73d14225517cf11ffc6073018a.diff

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd marked 4 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2189 + let Subjects = + SubjectList<[Enum, Function, Struct, TypedefName, + ObjCClassMethod, ObjCInstanceMethod, ObjCInterface, ObjCPr

[PATCH] D87451: add new clang option -mno-xcoff-visibility

jasonliu added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2310 +.. option:: -mno-xcoff-visibility + It's rare to see an option with only the negative form. Could we rename and make it a positive form somehow? Also we would need to mo

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd updated this revision to Diff 294124. compnerd marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87720/new/ https://reviews.llvm.org/D87720 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic

[clang] d34c8c7 - Basic: add an extra newline for sphinx (NFC)

Author: Saleem Abdulrasool Date: 2020-09-24T18:51:10Z New Revision: d34c8c70aae2a5421337c2ccac91130c70511f94 URL: https://github.com/llvm/llvm-project/commit/d34c8c70aae2a5421337c2ccac91130c70511f94 DIFF: https://github.com/llvm/llvm-project/commit/d34c8c70aae2a5421337c2ccac91130c70511f94.diff

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

tra updated this revision to Diff 294125. tra edited the summary of this revision. tra added a comment. Fixed compatibility with pre-c++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88250/new/ https://reviews.llvm.org/D88250 Files: clang/lib/

[PATCH] D87451: add new clang option -mno-xcoff-visibility

jasonliu added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + DiggerLin wrote: > daltenty wrote: > > This seems

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

tra marked an inline comment as done. tra added a comment. In D88250#2293270 , @jlebar wrote: > I know it comes in a separate change, but can we add a check to the > test-suite? Will do. Comment at: clang/lib/Headers/__clang_cuda_runt

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. Okay, the result of internal review is that we're comfortable with this feature. Reviewers brought up the point that it would be interesting to add some way to ensure unique emission of a protocol, so that protocols that can't be non-runtime could avoid bloating binary

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88236/new/ https://reviews.llvm.org/D88236 ___ cfe-commits mailing list cf

[clang] 606a734 - [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

Author: Erich Keane Date: 2020-09-24T12:09:22-07:00 New Revision: 606a734755d1fb6c35a17680d0c251f834b79334 URL: https://github.com/llvm/llvm-project/commit/606a734755d1fb6c35a17680d0c251f834b79334 DIFF: https://github.com/llvm/llvm-project/commit/606a734755d1fb6c35a17680d0c251f834b79334.diff L

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2efb5742cc9: [LLD][COFF] Cover usage of LLD-as-a-library in tests (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D70378?

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

erichkeane closed this revision. erichkeane added a comment. Gah, forgot 'Differential Revision' again :/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88236/new/ https://reviews.llvm.org/D88236 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

rsmith added inline comments. Comment at: clang/test/CodeGenCXX/pr47636.cpp:2 +// RUN: %clang_cc1 -o - -emit-llvm -triple x86_64-linux-pc %s | FileCheck %s +int(&&intu_rvref)[] {1,2,3,4}; +// CHECK: @_ZGR10intu_rvref_ = internal global [4 x i32] [i32 1, i32 2, i32 3, i32 4]

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

tra marked an inline comment as done. tra added a comment. In D88250#2293346 , @tra wrote: > In D88250#2293270 , @jlebar wrote: > >> I know it comes in a separate change, but can we add a check to the >> test-suite

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

rjmccall added a comment. Yeah, that would also be a completely reasonable approach. We already preserve the source spelling of the incomplete array type in the appropriate expression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88236/new/ https://reviews.llvm.org/D88236 __

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:330-336 +SVal getReturnIterator(const CallEvent &Call) { + Optional RetValUnderConstr = Call.getReturnValueUnderConstruction(); + if (RetValUnderConstr.hasValue()) +return *

[clang] c4bacc3 - [Modules] Add stats to measure performance of building and loading modules.

Author: Volodymyr Sapsai Date: 2020-09-24T12:23:47-07:00 New Revision: c4bacc3c9b333bb7032fb96f41d6f5b851623132 URL: https://github.com/llvm/llvm-project/commit/c4bacc3c9b333bb7032fb96f41d6f5b851623132 DIFF: https://github.com/llvm/llvm-project/commit/c4bacc3c9b333bb7032fb96f41d6f5b851623132.di

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2148 +CommonElementType == nullptr && !NumInitElts) { const ArrayType *AT = CGM.getContext().getAsArrayType(DestType); CommonElementType = CGM.getTypes().ConvertType(AT->getElemen

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4bacc3c9b33: [Modules] Add stats to measure performance of building and loading modules. (authored by vsapsai). Repository: rG LLVM Github Monore

[PATCH] D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes

erichkeane added a comment. Ok then, I'll take a look to see what it would take to make the MaterializeTemporaryExpr be created with the complete type here instead. Thanks! Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2148 +CommonElementType == nullptr && !NumIni

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

vsapsai added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86895/new/ https://reviews.llvm.org/D86895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] 9eba6b2 - Revert "[Modules] Add stats to measure performance of building and loading modules."

Author: Volodymyr Sapsai Date: 2020-09-24T12:36:06-07:00 New Revision: 9eba6b20a0579d3441e1b0f3cb3942f86d32679f URL: https://github.com/llvm/llvm-project/commit/9eba6b20a0579d3441e1b0f3cb3942f86d32679f DIFF: https://github.com/llvm/llvm-project/commit/9eba6b20a0579d3441e1b0f3cb3942f86d32679f.di

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L marked an inline comment as done. Xiangling_L added a comment. In D87029#2285398 , @jasonliu wrote: > I think it would help the review if we could put the NFC portion(e.g. > TypeSize -> StorageUnitSize) to a new patch, and give some rationale

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd updated this revision to Diff 294140. compnerd added a comment. add more tests to cover the confusing case of attribute merge handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87720/new/ https://reviews.llvm.org/D87720 Files: clang

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 294141. void added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/a.h clang/te

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein updated this revision to Diff 294143. hokein marked 2 inline comments as done. hokein added a comment. store the actual expression in DecltypeTypeLoc and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87349/new/ https://revi

[PATCH] D88195: Remove stale assert.

void added a comment. In D88195#2293165 , @nickdesaulniers wrote: > I'm super confused between the commit message and initial hunk, that seem to > make sense and probably should go in clang-11 if it's not too late, and the > additional tests for modules

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein added inline comments. Comment at: clang/include/clang/AST/Type.h:4499-4508 /// Internal representation of canonical, dependent /// decltype(expr) types. /// /// This class is used internally by the ASTContext to manage /// canonical, dependent types, only. Clients wi

[clang] f8a92ad - Remove dead branch identified by @rsmith on post-commit for D88236

Author: Erich Keane Date: 2020-09-24T13:05:15-07:00 New Revision: f8a92adfa242a94052f583ef7b483ae1b493ebdc URL: https://github.com/llvm/llvm-project/commit/f8a92adfa242a94052f583ef7b483ae1b493ebdc DIFF: https://github.com/llvm/llvm-project/commit/f8a92adfa242a94052f583ef7b483ae1b493ebdc.diff L

[PATCH] D88195: Remove stale assert.

nickdesaulniers added a comment. In D88195#2293533 , @void wrote: > In D88195#2293165 , @nickdesaulniers > wrote: > >> I'm super confused between the commit message and initial hunk, that seem to >> make sense and

[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

rnk abandoned this revision. rnk added a comment. I actually forgot about this change entirely and uploaded and landed a new one: https://reviews.llvm.org/D87923 I suppose they are functionally different: if we have an overaligned type that can be passed in registers due to [[trivial_abi]], we s

[clang] 579c422 - [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default

Author: Alexey Bataev Date: 2020-09-24T16:18:09-04:00 New Revision: 579c42225ac373688dbdbe3a1ce62986a6bf638a URL: https://github.com/llvm/llvm-project/commit/579c42225ac373688dbdbe3a1ce62986a6bf638a DIFF: https://github.com/llvm/llvm-project/commit/579c42225ac373688dbdbe3a1ce62986a6bf638a.diff

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang updated this revision to Diff 294149. akhuang added a comment. Add to comment for lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/new/ https://reviews.llvm.org/D87808 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Cod

[PATCH] D88195: Remove stale assert.

void added a comment. In D88195#2293559 , @nickdesaulniers wrote: > In D88195#2293533 , @void wrote: > >> In D88195#2293165 , >> @nickdesaulniers wrote: >> >>> I'm super co

[PATCH] D88195: Remove stale assert.

nickdesaulniers added a comment. In D88195#2293559 , @nickdesaulniers wrote: > In D88195#2293533 , @void wrote: > >> In D88195#2293165 , >> @nickdesaulniers wrote: >> >>> I

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 294150. void added a comment. Clarify commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/

[PATCH] D87451: add new clang option -mno-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + jason

[PATCH] D88195: Remove stale assert.

nickdesaulniers added a comment. In D88195#2293589 , @void wrote: > Clarify commit message. Phabricator unfortunately won't amend the review description when the commit message is updated; you'll need to manually edit the description via phab's UI for o

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. @MyDeveloperDay that's the exact point. I authored this change to close a gap in some lambda formatting cases. The tests (existing, modified and added) express all relevant cases that I knew at the time. @jaafar, @curdeius - this is just C++ code. Nothing is set in

[clang] 1ad9462 - [AST] Use data-recursion when building ParentMap, avoid stack overflow.

Author: Sam McCall Date: 2020-09-24T22:49:44+02:00 New Revision: 1ad94624f8a092fbfcb74685e11243c186b04c8f URL: https://github.com/llvm/llvm-project/commit/1ad94624f8a092fbfcb74685e11243c186b04c8f DIFF: https://github.com/llvm/llvm-project/commit/1ad94624f8a092fbfcb74685e11243c186b04c8f.diff LO

[PATCH] D88222: [AST] Use data-recursion when building ParentMap, avoid stack overflow.

sammccall updated this revision to Diff 294154. sammccall marked an inline comment as done. sammccall added a comment. Address comments. Also remove a stale fixme, and simplify a little. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88222/new/ htt

[PATCH] D88222: [AST] Use data-recursion when building ParentMap, avoid stack overflow.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ad94624f8a0: [AST] Use data-recursion when building ParentMap, avoid stack overflow. (authored by sammccall). Repository: rG LLVM Github Monorepo

[PATCH] D88260: [NFC][FE] Replace TypeSize with StorageUnitSize

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. On some targets like AIX, last bitfield size is not always equal to last

[PATCH] D88195: Remove stale assert.

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. In D88195#2293597 , @nickdesaulniers wrote: > In D88195#2293589 , @void wrote: > >> Clarify commit message

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 294156. baloghadamsoftware added a comment. Test coverage was hugely increased by rebasing this patch to D88216 . Two kind of tests failed. This last update addreses them: 1. Handle the assignment operator of iter

[PATCH] D88195: Remove stale assert.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. In D88195#2293637 , @jyknight wrote: > In D88195#2293597 , @nickdesaulniers > wrote: > >> In D88195#2293589

[clang] 34ca5b3 - Remove stale assert.

Author: Bill Wendling Date: 2020-09-24T13:59:42-07:00 New Revision: 34ca5b3392ced08e2320fb4236cca5c7df4ec6e9 URL: https://github.com/llvm/llvm-project/commit/34ca5b3392ced08e2320fb4236cca5c7df4ec6e9 DIFF: https://github.com/llvm/llvm-project/commit/34ca5b3392ced08e2320fb4236cca5c7df4ec6e9.diff

[PATCH] D88195: Remove stale assert.

This revision was automatically updated to reflect the committed changes. Closed by commit rG34ca5b3392ce: Remove stale assert. (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: cla

[PATCH] D87451: add new clang option -mno-xcoff-visibility

daltenty added inline comments. Comment at: llvm/include/llvm/Target/TargetMachine.h:265 + /// corresponding to -mno-xcoff-visibility. + bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; } + DiggerLin wrote: > jasonliu wrote: > > DiggerLin w

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

MyDeveloperDay added a comment. @oleg.smolsky I agree, what you have here covers a myriad of other cases and was committed in 2018, we can't call this commit a regression it was a feature ;-), if we want to improve the feature that is something else. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a96f47c5ffc: [AArch64] __builtin_return_address for PAuth. (authored by danielkiss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://revie

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2181 + /// \endcode + bool SpaceBeforePointerQualifiers; + I wonder if a request would ever say they wanted this Space before to be Left/Middle/Right? perhaps this should not

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:2613-2614 SNA->getName(), AMK == Sema::AMK_Override); + else if (isa(Attr) && AMK == Sema::AMK_Override) +NewAttr = nullptr;

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd updated this revision to Diff 294167. compnerd marked an inline comment as done. compnerd added a comment. - address all feedback, add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87720/new/ https://reviews.llvm.org/D87720

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2889 + return true; +return Style.PointerAlignment != FormatStyle::PAS_Left; } I wish more of these horrendous expressions all over the code were written like this,

[PATCH] D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30514f0afa3e: [CUDA] Added conversion functions to builtin vars. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 30514f0 - [CUDA] Added conversion functions to builtin vars.

Author: Artem Belevich Date: 2020-09-24T14:33:04-07:00 New Revision: 30514f0afa3ee1e6da6bf9c41e83c28e884f0740 URL: https://github.com/llvm/llvm-project/commit/30514f0afa3ee1e6da6bf9c41e83c28e884f0740 DIFF: https://github.com/llvm/llvm-project/commit/30514f0afa3ee1e6da6bf9c41e83c28e884f0740.diff

[clang] f97b68e - Fix testcase.

Author: Bill Wendling Date: 2020-09-24T14:34:28-07:00 New Revision: f97b68ef4ddd28a685e502653768c2a34c314cba URL: https://github.com/llvm/llvm-project/commit/f97b68ef4ddd28a685e502653768c2a34c314cba DIFF: https://github.com/llvm/llvm-project/commit/f97b68ef4ddd28a685e502653768c2a34c314cba.diff

[clang] c8df781 - [DebugInfo] Fix bug in constructor homing with classes with trivial

Author: Amy Huang Date: 2020-09-24T14:43:48-07:00 New Revision: c8df781e54a43593eafd993a5a5cd647866955f8 URL: https://github.com/llvm/llvm-project/commit/c8df781e54a43593eafd993a5a5cd647866955f8 DIFF: https://github.com/llvm/llvm-project/commit/c8df781e54a43593eafd993a5a5cd647866955f8.diff LOG

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8df781e54a4: [DebugInfo] Fix bug in constructor homing with classes with trivial (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87808/

[PATCH] D88263: Sema: remove unnecessary parameter for SwiftName handling (NFCI)

compnerd created this revision. compnerd added reviewers: aaron.ballman, gribozavr2. Herald added a project: clang. compnerd requested review of this revision. This code never actually did anything in the implementation. `mergeDeclAttribute` is declared as `static`, and referenced exactly once in

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 294157. Xiangling_L added a comment. Rebased on the NFC patch; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029 Files: clang/lib/AST/RecordLayoutBuilder.cpp clang/lib/Sema/SemaDecl.cpp clang/test/La

[clang] c9b53b3 - Fix regex in test.

Author: Bill Wendling Date: 2020-09-24T15:21:28-07:00 New Revision: c9b53b3bf20d20d5752876be32a9e5887c702e53 URL: https://github.com/llvm/llvm-project/commit/c9b53b3bf20d20d5752876be32a9e5887c702e53 DIFF: https://github.com/llvm/llvm-project/commit/c9b53b3bf20d20d5752876be32a9e5887c702e53.diff

[PATCH] D88265: Fix comma with half vectors.

arames created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. arames requested review of this revision. The current half vector was enforcing an assert expecting "(LHS is half vector) == (RHS is half vector)" for comma. Repository: rG LLVM Github Monorep

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

arichardson added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6636 + verifyFormat("a* a = aaa, * b = bb,\n" + " * b = bbb, * d = ;", Style); --

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

hubert.reinterpretcast added a comment. Off-list discussion seems to indicate that only the NFC portion of the patch was intended to be approved. That is, the scope of this patch is supposed to be https://reviews.llvm.org/D88105?id=293625 plus formatting changes. CHANGES SINCE LAST ACTION ht

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson added inline comments. Comment at: clang/include/clang/Format/Format.h:2181 + /// \endcode + bool SpaceBeforePointerQualifiers; + MyDeveloperDay wrote: > I wonder if a request would ever say they wanted this Space before to be > Left/Middle/Right?

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2291926 , @rjmccall wrote: > Okay. I think we're on the same page about representation now. If you can > come up with a good replacement for "eha" in the intrinsic names, I think > this is pretty much ready to go. ho

[PATCH] D87953: [xray] Function coverage groups

dberris added a comment. There's two tensions I'm trying to resolve in my mind with this patch: - Is there a way to make this more deterministic, instead of using a random sampling mechanism based on the name? - This looks like it's a subset of a more general facility to group functions by "mod

[clang] b8a50e9 - [MS] Simplify rules for passing C++ records

Author: Reid Kleckner Date: 2020-09-24T16:29:47-07:00 New Revision: b8a50e920704436ddcbe0cc9d2020935d7e37095 URL: https://github.com/llvm/llvm-project/commit/b8a50e920704436ddcbe0cc9d2020935d7e37095 DIFF: https://github.com/llvm/llvm-project/commit/b8a50e920704436ddcbe0cc9d2020935d7e37095.diff

[clang] ecfc9b9 - [MS] For unknown ISAs, pass non-trivially copyable arguments indirectly

Author: Reid Kleckner Date: 2020-09-24T16:29:48-07:00 New Revision: ecfc9b971269a86b101cddf1fd9f0976be4096d0 URL: https://github.com/llvm/llvm-project/commit/ecfc9b971269a86b101cddf1fd9f0976be4096d0 DIFF: https://github.com/llvm/llvm-project/commit/ecfc9b971269a86b101cddf1fd9f0976be4096d0.diff

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

leonardchan added a comment. Hi. Our GCC builders are failing with [182/12433] CXX kernel-x64-gcc/obj/kernel/lib/ktl/ktl.dummy-new.cc.o FAILED: kernel-x64-gcc/obj/kernel/lib/ktl/ktl.dummy-new.cc.o /b/s/w/ir/k/fuchsia/prebuilt/third_party/goma/linux-x64/gomacc ../../prebuilt/third_party/gc

[clang] a32feed - Add a static_assert confirming that DiagnosticBuilder is small

Author: Reid Kleckner Date: 2020-09-24T16:38:41-07:00 New Revision: a32feed0dbeac7606d042d0d7e041c9eaf12cd51 URL: https://github.com/llvm/llvm-project/commit/a32feed0dbeac7606d042d0d7e041c9eaf12cd51 DIFF: https://github.com/llvm/llvm-project/commit/a32feed0dbeac7606d042d0d7e041c9eaf12cd51.diff

[clang] 276f68e - Revert "Add a static_assert confirming that DiagnosticBuilder is small"

Author: Reid Kleckner Date: 2020-09-24T16:39:46-07:00 New Revision: 276f68eace7c27f6805d69a30a4b2f186e42c56c URL: https://github.com/llvm/llvm-project/commit/276f68eace7c27f6805d69a30a4b2f186e42c56c DIFF: https://github.com/llvm/llvm-project/commit/276f68eace7c27f6805d69a30a4b2f186e42c56c.diff

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. In D80344#2293954 , @tentzen wrote: > In D80344#2291926 , @rjmccall wrote: > >> Okay. I think we're on the same page about representation now. If you can >> come up with a good replaceme

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza updated this revision to Diff 294207. lanza added a comment. Fix duplicate inheritance issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 Files: clang/include/clang/AST/DeclObjC.h clang/include

[PATCH] D87332: [profile] Add %t LLVM_PROFILE_FILE option to substitute $TMPDIR

ejvaughan accepted this revision. ejvaughan added a comment. This revision is now accepted and ready to land. Changes look good to me. Thanks for implementing this, Vedant! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87332/new/ https://reviews.ll

<    1   2   3   >