[PATCH] D85808: [remarks] Optimization remarks hotness filtering from profile summary

tejohnson added inline comments. Comment at: lld/ELF/Config.h:280 + // If threshold option is not specified, it is disabled by default. + llvm::Optional optRemarksHotnessThreshold = 0; weiwang wrote: > tejohnson wrote: > > Since this field is being added in p

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:85 +//(note that we do not create implicit base functions here). To avoid +//this clash we add a new trait to some of them that is always true +//(this is LLVM after all ;)

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. In D79773#2141164 , @MyDeveloperDay wrote: > This is actually failing in the handling of parsing the `<>` in > (`parseAngle()` actually `parseBrace()` inside of that), it is not really > concepts specific except it may be seen

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

jdoerfert added a comment. Root cause: We sometimes, depending on the invocation and potentially other factors, use a full path and sometimes not: So wen I run this with clang locally I get this: @98 = private unnamed_addr constant [98 x i8] c";/data/src/llvm-project/clang/test/OpenMP/irbuild

[PATCH] D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`

fghanim added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85619/new/ https://reviews.llvm.org/D85619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

JonChesterfield added a comment. I think this is reasonable. It's unfortunate to have isnan return bool or int depending on the system headers, but considering we have that in a language that doesn't mangle the return type into the name the workaround seems OK. I think `#define isnan()` in a sy

[PATCH] D85877: [OpenMP] Support nested OpenMP context selectors (declare variant)

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Probably good to implement this just at the time math headers needs it as that gives us a real world example of the change working. Repository: rG LLVM Github Mono

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

JonChesterfield added a comment. If I recall correctly, &foo with variants of foo returns a pointer to the base. If we have no base, and disable_implicit_base, what does &foo yield? It should probably be a compilation error with some descriptive message Repository: rG LLVM Github Monorepo C

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

vitalybuka added a comment. LGTM with some nits Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:124 + +namespace { + maybe remove all static about and extend namespace {} Comment at: llvm/lib/Transforms/Instrumentation/HeapPr

[PATCH] D85938: [OpenMP][NFC] Update check lines after D85099

jdoerfert updated this revision to Diff 285551. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. Resolve the root cause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D85810: [clang] Pass-through remarks options to lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:71 + + bool isLLD = llvm::sys::path::filename(LinkerPath) == "ld.lld" || + llvm::sys::path::stem(LinkerPath) != "ld.lld"; Checking the path is brittle. Consider

[PATCH] D85810: [clang] Pass-through remarks options to lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:81 +CmdArgs.push_back("-mllvm"); +std::string Passes = std::string("-pass-remarks=") + A->getValue(); +CmdArgs.push_back(Args.MakeArgString(Passes)); Delete such one

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

jdoerfert added a comment. In D85878#2217408 , @JonChesterfield wrote: > If I recall correctly, &foo with variants of foo returns a pointer to the > base. Correct. > If we have no base, and disable_implicit_base, what does &foo yield? It > should prob

[PATCH] D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:619 getCheckerManager().runCheckersForEvalCall(DstEvaluated, *I, *Call, *this, - CallOpts); +

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

davidxl added a comment. one nit: since the same instrumentation can be used to profiling global variable accesses (especially those indirect accessed), the option name seems excluding those cases. Shall it be renamed to fmem-prof? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

davidxl added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:512 + +int ModuleHeapProfiler::GetHeapProfVersion(const Module &M) const { return 1; } + define a macro for the version number? Repository: rG LLVM Github Monorepo

[PATCH] D85938: [OpenMP][OMPIRBuilder] Use the source (=directory + filename) for locations

lebedev.ri added a comment. still lg, i guess Comment at: clang/test/OpenMP/irbuilder_nested_parallel_for.c:258 +// CHECK-DEBUG-NEXT:call void @__kmpc_barrier(%struct.ident_t* [[GLOB83:@.*]], i32 [[OMP_GLOBAL_THREAD_NUM239]]), [[DBG107]] +// CHECK-DEBUG-NEXT:ret void,

[PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

hlopko added a comment. Herald added a subscriber: JDevlieghere. Friendly ping, this change will remove HAVE_VCS_VERSION_INC define. If you disagree, please complain :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84623/new/ https://reviews.llvm.

<    1   2   3