[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

hliao created this revision. hliao added reviewers: tra, yaxunl, bogner. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao requested review of this revision. - Skip generating profile data on `__global__` function in the host compilation. It's a host-side stub function

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

yonghong-song added a comment. > Hm.. This root type is used by libbpf to find candidate in kernel BTF. Name > and kind of that type is what is used. When you have typedef t and struct t, > their names match, but their kinds don't. So it could lead to inability to > find a candidate. The inpro

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

vsavchenko added a comment. Other than parameter names, it looks totally reasonable to me. Comment at: clang/lib/Analysis/HTMLPathDiagnosticConsumer.cpp:70 + const std::string &OutputDir, + const Preprocessor &pp, bool su

[PATCH] D85185: [SyntaxTree] Add test coverage for `->*` operator

eduucaldas updated this revision to Diff 283144. eduucaldas added a comment. Answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85185/new/ https://reviews.llvm.org/D85185 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: cla

[clang] c5cdc3e - [SyntaxTree] Add test coverage for `->*` operator

Author: Eduardo Caldas Date: 2020-08-05T07:36:39Z New Revision: c5cdc3e801ad1b0aceaf220d78a3ff3fab1e0fdb URL: https://github.com/llvm/llvm-project/commit/c5cdc3e801ad1b0aceaf220d78a3ff3fab1e0fdb DIFF: https://github.com/llvm/llvm-project/commit/c5cdc3e801ad1b0aceaf220d78a3ff3fab1e0fdb.diff LOG

[PATCH] D85185: [SyntaxTree] Add test coverage for `->*` operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5cdc3e801ad: [SyntaxTree] Add test coverage for `->*` operator (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

vsavchenko added a comment. Great job, I'm on board with this change! I think that our code is a bit under commented when it comes to the logic inside of functions, so I would really appreciate if we can add a good chunk of comments here! Also, I believe integration tests would be pretty much

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

hokein created this revision. hokein added a reviewer: nridge. Herald added a subscriber: kristof.beyls. Herald added a project: clang. hokein requested review of this revision. The template arguments were dumped as part of the TemplateTypeParmDecl, which was incorrect. Repository: rG LLVM Git

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305 + break; +default:; +} nit: move the trailing `;` to a new line. Reposit

[PATCH] D85285: [clangd] WIP experimentation with finding static grpc++ libraries

kbobyrev created this revision. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added projects: clang, LLVM. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monor

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

c-rhodes added a comment. In D85128#2193309 , @tschuett wrote: > Sorry. I meant ABI. Can link GCC .o files with Clang .o files using the > attributes? Yes they should be compatible. The machine-level ABI distinguishes 4 types of SVE vector [1]: - VG×64

[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

sberg created this revision. sberg added reviewers: jordan_rose, rtrieu. Herald added a project: clang. sberg requested review of this revision. ...to C++ constant expression operands. (I had been puzzled why Clang had not found

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss updated this revision to Diff 283172. danielkiss edited the summary of this revision. danielkiss added a comment. This version of the patch behaves as `gcc` for case when no function present and when function has `-mbranch-protection` attribute without compiler flag. The logic should b

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

kadircet added a comment. Sigh, (I think) this is working for macros defined in preamble region as a side effect of preamble being loaded separately and before anything in the main file. E.g. #define FO^O 1 #define FOO 2 void foo() { int x = FOO; }; hovering over the first definition

[clang] 3ab0155 - Revert "[CMake] Simplify CMake handling for zlib"

Author: Hans Wennborg Date: 2020-08-05T12:31:44+02:00 New Revision: 3ab01550b632dad46f9595d74855749557ffd25c URL: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c DIFF: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c.diff

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

steakhal planned changes to this revision. steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1035-1038 +return evalBinOpNN(state, BO_Mul, Index, + makeArrayI

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Anastasia added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +// R

[clang-tools-extra] a441616 - Support member expressions in bugprone-bool-pointer-implicit-conversion.

Author: Alex Cameron Date: 2020-08-05T07:14:28-04:00 New Revision: a44161692ae879068d4086a7e568a348800ba01d URL: https://github.com/llvm/llvm-project/commit/a44161692ae879068d4086a7e568a348800ba01d DIFF: https://github.com/llvm/llvm-project/commit/a44161692ae879068d4086a7e568a348800ba01d.diff

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

ebevhan added a comment. In D85191#2193645 , @rsmith wrote: >> This is not ideal, since it makes the calculations char size dependent, and >> breaks for sizes that are not a multiple of the char size. > > How can we have a non-bitfield member whose size i

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Re-accepting the changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-c

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've gone ahead and commit on your behalf in a44161692ae879068d4086a7e568a348800ba01d . CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

ebevhan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1841 auto setDeclInfo = [&](bool IsIncompleteArrayType) { -TypeInfo TI = Context.getTypeInfo(D->getType()); -FieldAlign = Context.toCharUnitsFromBits(TI.Align); +auto TI = Context.getT

[PATCH] D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit. Comment at: clang/lib/AST/Decl.cpp:2130 + // the pretty-printed name of the capture instead. + if (isa(DD) && + maybePrintFi

[PATCH] D85291: [clangd] Fix a crash in DefineInline

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:33 +bool isExitFunction(StringRef FnName) { + return FnName == "_Exit" || FnName == "exit" || FnName == "quick_exit"; +} njames93 wrote: > whisperity wrote: >

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith added a comment. In D85239#2194604 , @MaskRay wrote: > This file is auto generated. The real documentation should go to > `clang/include/clang/Driver/Options.td` Thanks for pointing that out! I regenerated the ClangCommandLineReference.rst from O

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith updated this revision to Diff 283201. psmith added a comment. Herald added a subscriber: dang. uploaded diff with both Options.td and ClangCommandLineReference.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85239/new/ https://reviews.llvm.org/D85239 Files: clang/docs/ClangC

[clang] 45f2a56 - [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

Author: Yaxun (Sam) Liu Date: 2020-08-05T07:57:38-04:00 New Revision: 45f2a56856e29b8cb038b2e559289b91fb98fedf URL: https://github.com/llvm/llvm-project/commit/45f2a56856e29b8cb038b2e559289b91fb98fedf DIFF: https://github.com/llvm/llvm-project/commit/45f2a56856e29b8cb038b2e559289b91fb98fedf.dif

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG45f2a56856e2: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu… (authored by yaxunl). Herald

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

psmith marked an inline comment as done. psmith added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2139 -Enable stack protectors for some functions vulnerable to stack smashing. This uses a loose heuristic which considers functions vulnerable if they c

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:64 +/// argument. +void ExitHandlerCheck::registerMatchers(MatchFinder *Finder) { + const auto IsRegisterFunction = aaron.ballman wrote: > whisperity wrote: > >

[PATCH] D85295: [SyntaxTree] Implement the List construct.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. We defined a List construct to help with the implementation of list-like grammar rules. This is a first implementation of this API. Repository:

[PATCH] D85295: [SyntaxTree] Implement the List construct.

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:223 + + // These can't be implemented with the information we have! + As this is a base List, we don't have the necessary informatio

[PATCH] D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings

sberg updated this revision to Diff 283204. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85287/new/ https://reviews.llvm.org/D85287 Files: clang/lib/Analysis/CFG.cpp clang/test/Sema/warn-bitwise-compare.c clang/test/SemaCXX/warn-bitwise-compare.cpp Index: clang/test/SemaCXX/warn-

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:64 +/// argument. +void ExitHandlerCheck::registerMatchers(MatchFinder *Finder) { + const auto IsRegisterFunction = whisperity wrote: > aaron.ballman wrote: >

[PATCH] D85295: [SyntaxTree] Implement the List construct.

gribozavr2 added a comment. I feel uneasy about adding this code without tests. Could we maybe port the function parameter list to use this infrastructure, and then add tests that exercise `getElementsAsNodesAndDelimiters`? Comment at: clang/include/clang/Tooling/Syntax/Tree.

[clang] 00b89f6 - [clang][NFC] Remove spurious +x flag on DeclTemplate.cpp and DeclTemplate.h

Author: Bruno Ricci Date: 2020-08-05T13:54:30+01:00 New Revision: 00b89f66f988e9ec6f366ed46a51ace39fac07c8 URL: https://github.com/llvm/llvm-project/commit/00b89f66f988e9ec6f366ed46a51ace39fac07c8 DIFF: https://github.com/llvm/llvm-project/commit/00b89f66f988e9ec6f366ed46a51ace39fac07c8.diff L

[clang] 6f2fa9d - [clang][NFC] Document NamedDecl::printName

Author: Bruno Ricci Date: 2020-08-05T13:54:37+01:00 New Revision: 6f2fa9d312fcea2448706a8e410c7bc1b6436ea7 URL: https://github.com/llvm/llvm-project/commit/6f2fa9d312fcea2448706a8e410c7bc1b6436ea7 DIFF: https://github.com/llvm/llvm-project/commit/6f2fa9d312fcea2448706a8e410c7bc1b6436ea7.diff L

[clang] bc29634 - [clang][NFC] Remove an old workaround for MSVC 2013

Author: Bruno Ricci Date: 2020-08-05T13:54:37+01:00 New Revision: bc29634b93acf2e55c82dd906f0d9af196c66ff3 URL: https://github.com/llvm/llvm-project/commit/bc29634b93acf2e55c82dd906f0d9af196c66ff3 DIFF: https://github.com/llvm/llvm-project/commit/bc29634b93acf2e55c82dd906f0d9af196c66ff3.diff L

[clang] 1970145 - [clang][nearly-NFC] Remove some superfluous uses of NamedDecl::getNameAsString

Author: Bruno Ricci Date: 2020-08-05T13:54:37+01:00 New Revision: 19701458d4691ee7ec59e5aa7217a479b0fb10e7 URL: https://github.com/llvm/llvm-project/commit/19701458d4691ee7ec59e5aa7217a479b0fb10e7 DIFF: https://github.com/llvm/llvm-project/commit/19701458d4691ee7ec59e5aa7217a479b0fb10e7.diff L

[clang] 94b4311 - [clang][NFCI] Get rid of ConstantMatrixTypeBitfields to avoid increasing the size of every type.

Author: Bruno Ricci Date: 2020-08-05T13:54:37+01:00 New Revision: 94b43118e2203fed8ca0377ae762c08189aa6f3d URL: https://github.com/llvm/llvm-project/commit/94b43118e2203fed8ca0377ae762c08189aa6f3d DIFF: https://github.com/llvm/llvm-project/commit/94b43118e2203fed8ca0377ae762c08189aa6f3d.diff L

[clang] 98b4b45 - [clang][NFC] Add a test showcasing an unnamed template parameter in a diagnostic

Author: Bruno Ricci Date: 2020-08-05T13:54:36+01:00 New Revision: 98b4b4570542a255e9a81e4a349183402a2d478d URL: https://github.com/llvm/llvm-project/commit/98b4b4570542a255e9a81e4a349183402a2d478d DIFF: https://github.com/llvm/llvm-project/commit/98b4b4570542a255e9a81e4a349183402a2d478d.diff L

[clang] f7a039d - [clang][NFC] DeclPrinter: use NamedDecl::getDeclName instead of NamedDecl::printName to print the name of enumerations, namespaces and template parameters.

Author: Bruno Ricci Date: 2020-08-05T13:54:38+01:00 New Revision: f7a039de7af7b83105f3e0345d65dceda1a0e0d4 URL: https://github.com/llvm/llvm-project/commit/f7a039de7af7b83105f3e0345d65dceda1a0e0d4 DIFF: https://github.com/llvm/llvm-project/commit/f7a039de7af7b83105f3e0345d65dceda1a0e0d4.diff L

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997 case ABIArgInfo::Ignore: + case ABIArgInfo::IndirectAliased: return false; arsenm wrote: > rjmccall wrote: > > arsenm wrote: > > > rjmccall wrote: > > > > In principle, this

[clang] 4dcbb9c - [clang] Add -fno-delayed-template-parsing to the added unit tests in DeclPrinterTest.cpp

Author: Bruno Ricci Date: 2020-08-05T14:13:05+01:00 New Revision: 4dcbb9cef71afa549afe8f6b4d335b1c996f8079 URL: https://github.com/llvm/llvm-project/commit/4dcbb9cef71afa549afe8f6b4d335b1c996f8079 DIFF: https://github.com/llvm/llvm-project/commit/4dcbb9cef71afa549afe8f6b4d335b1c996f8079.diff L

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1035-1038 +return evalBinOpNN(state, BO_Mul, Index, + makeArrayIndex(SingleElementSize.getQuantity()), + ArrayIndexTy) +

[PATCH] D85301: [clang-tidy] Fix crashes in bugprone-bad-signal-to-kill-thread check.

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, steven_wu, jkorous, hiraditya, xazax.hun. Herald added a project: clang. ArcsinX requested review of this revision. Herald added a subscriber: ilya-biryukov. This patch fixes crashes i

[PATCH] D85305: [SyntaxTree] Remove dead code on dump functions

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. - `Node::dumpTokens` was never used. - `::dumpTokens(llvm::raw_ostream, ArrayRef, const SourceManager &SM)` was used twice, once by `Node::dumpTok

[PATCH] D85304: [clang-format] fix BreakBeforeBraces.MultiLine with for each macros

vthib created this revision. vthib added reviewers: MyDeveloperDay, mitchell-stellar. vthib added projects: clang-format, clang, clang-tools-extra. Herald added a subscriber: cfe-commits. vthib requested review of this revision. The MultiLine option in BreakBeforeBraces was only handling standard

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

This revision was automatically updated to reflect the committed changes. Closed by commit rG002d61db2b77: [OpenMP] Fix `present` for exit from `omp target data` (authored by jdenny). Changed prior to commit: https://reviews.llvm.org/D84422?vs=281330&id=283224#toc Repository: rG LLVM Github

[clang] 03bb545 - [OpenMP][Docs] Mark `present` map type modifier as done

Author: Joel E. Denny Date: 2020-08-05T10:03:31-04:00 New Revision: 03bb545b68c2edb9dc5bd092104bdb83a8e5e347 URL: https://github.com/llvm/llvm-project/commit/03bb545b68c2edb9dc5bd092104bdb83a8e5e347 DIFF: https://github.com/llvm/llvm-project/commit/03bb545b68c2edb9dc5bd092104bdb83a8e5e347.diff

[clang] 002d61d - [OpenMP] Fix `present` for exit from `omp target data`

Author: Joel E. Denny Date: 2020-08-05T10:03:31-04:00 New Revision: 002d61db2b7790dc884953bf9271878bf0af3a8e URL: https://github.com/llvm/llvm-project/commit/002d61db2b7790dc884953bf9271878bf0af3a8e DIFF: https://github.com/llvm/llvm-project/commit/002d61db2b7790dc884953bf9271878bf0af3a8e.diff

[clang] 26cf9c1 - [OpenMP][Docs] Add map clause reordering status as unclaimed

Author: Joel E. Denny Date: 2020-08-05T10:03:31-04:00 New Revision: 26cf9c17044515cdde3e7baeea843001ba33be59 URL: https://github.com/llvm/llvm-project/commit/26cf9c17044515cdde3e7baeea843001ba33be59 DIFF: https://github.com/llvm/llvm-project/commit/26cf9c17044515cdde3e7baeea843001ba33be59.diff

[PATCH] D85105: [doxygen] Fix bad doxygen results for BugReporterVisitors.h

vsavchenko added a comment. Hey, thanks again for cleaning up the analyzer's docs 😄 Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:56 /// last node should be unique. - /// Use {@code getEndPath} to customize the note associated with t

[PATCH] D85309: [WIP][clang][Driver] Support GNU ld on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, mgorny. ro requested review of this revision. This patch is posted just for reference on top of D84029 and D84412

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

ro updated this revision to Diff 283232. ro added a comment. Incorporate review comments: clarify comment and arg name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 Files: clang/lib/Driver/ToolChains/C

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

ro marked 3 inline comments as done. ro added a comment. In D84412#2193600 , @MaskRay wrote: > #clang does not have many people. You > might need to add people explicitly.. I always found finding reviewers sort of a

[PATCH] D85311: [analyzer][tests] Understand when diagnostics change between builds

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. vsavch

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

jasonliu added inline comments. Comment at: format:1 +//===-- PPCAsmPrinter.cpp - Print machine instrs to PowerPC assembly --===// +// Redundant file? Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:455 } + struct Structor { -

[PATCH] D85312: [ADT] Move FixedPoint.h from Clang to LLVM.

ebevhan created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya, mgorny. Herald added projects: clang, LLVM. ebevhan requested review of this revision. This patch moves FixedPointSemantics and APFixedPoint from Clang to LLVM ADT. This will make it easier

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

ktkachov added a comment. In D75181#2193447 , @danielkiss wrote: > Would it be better to add a new value to `"sign-return-address"` as `"none"`? > I don't see any other alternative option, I'm open to any other idea. FWIW GCC has a "sign-return-address"

[PATCH] D85315: [AIX][Clang] Add C++ linker option to the driver toolchain

ShuhongL created this revision. ShuhongL added reviewers: daltenty, hubert.reinterpretcast, stevewan. ShuhongL added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. ShuhongL requested review of this revision. Add C++ linker option to the AIX clang driver too

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

ilya-golovenko added a comment. I agree the fix is not correct. I will check how it currently works with clangd built from master branch. I'm not quite sure there should be no tooltip for a `#define`. Such tooltip is not really useful, but at the same time clangd shows tooltips for function de

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:125 "Couldn't get range for function."); // Include template parameter list. if (auto *FTD = FD->getDescribedFunctionTemplate())

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added a comment. In D79219#2153585 , @phosek wrote: > In D79219#2152747 , @labath wrote: > >> I wouldn't mind separate (internal) cache variable, though I am somewhat >> surprised by this problem. A (non-cache

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added a comment. Reverted in 3ab01550b632dad46f9595d74855749557ffd25c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219

[PATCH] D85315: [AIX][Clang] Add C++ linker option to the driver toolchain

ShuhongL added a comment. Working on adding lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85315/new/ https://reviews.llvm.org/D85315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:305 + break; +default:; +} hokein wrote: > nit: move the trailing `;` to a new line. I have done this, but clang-format moves it back... do we really want to

[PATCH] D85316: [SyntaxTree] Proposition of new tree dump

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Some key choices to highlight: - Surround Tokens with "''" - Do not print `UnknownRole`, to reduce noise - Surround Roles with "<", to clarify the

[PATCH] D85318: [clangd] Hide "swap if branch" tweak

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This tweak is more like a demo, and doesn't provide mu

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

martong created this revision. martong added reviewers: NoQ, Szelethus, balazske, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. H

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

hans added a comment. In D84782#2191429 , @yamauchi wrote: > In D84782#2191243 , @MaskRay wrote: > >> @yamauchi Do we need cd890944ad344b1b8cac58332ab11c9eec6b61e9 >>

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

martong updated this revision to Diff 283254. martong added a comment. - Remove dummy test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85319/new/ https://reviews.llvm.org/D85319 Files: clang/include/clang/CodeGen/CodeGenMangling.h clang

[clang-tools-extra] 0117328 - [clangd] Fix a crash in DefineInline

Author: Kadir Cetinkaya Date: 2020-08-05T17:38:17+02:00 New Revision: 011732852c2c1ca1015fac1bed831308dc521583 URL: https://github.com/llvm/llvm-project/commit/011732852c2c1ca1015fac1bed831308dc521583 DIFF: https://github.com/llvm/llvm-project/commit/011732852c2c1ca1015fac1bed831308dc521583.dif

[PATCH] D85291: [clangd] Fix a crash in DefineInline

This revision was automatically updated to reflect the committed changes. Closed by commit rG011732852c2c: [clangd] Fix a crash in DefineInline (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85291/new/ https://reviews.llvm.org

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss added a comment. > FWIW GCC has a "sign-return-address" function attribute with a default value > of "none". It is considered deprecated, however, in favour of > "branch-protection" This is just the internal representation, the function attribute in C/C++ source is the "branch-prote

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

nsz added a comment. the gcc behaviour is not exactly ideal, but it's better if llvm is compatible with it or fix gcc if something is broken there. the assumption is that the intended branch protection is implied via cmdline flags for the tu and function attributes are only used in source code

[PATCH] D85321: [OPENMP]Do not capture base pointer by reference if it is used as a base for array-like reduction.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. If the declaration is used in the reduction clause, it is captured by refer

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5550 +auto &VMContext = CGM.getLLVMContext(); +M->addModuleFlag(llvm::Module::Override, "sign-return-address", + Scope == LangOptions::SignReturnAddressScopeKind::All

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

whisperity added subscribers: dcoughlin, rjmccall, rsmith. whisperity added a comment. What will happen with the ability to analyse a translation unit whose target was not part of `LLVM_TARGETS_TO_BUILD` of the current `clang` binary? Will it break, because the binary lacks the information on ho

[PATCH] D85305: [SyntaxTree] Remove dead code on dump functions

gribozavr2 added a comment. > Node::dumpTokens was never used. I think it is because it was meant to be a debugger-only helper. I think we should keep it. However, simplifying `static void dumpTokens` to only take one token instead of `ArrayRef` makes sense! Repository: rG LLVM Github Monor

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet updated this revision to Diff 283266. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85310/new/ https://reviews.llvm.org/D85310 Files: clang-tools-ex

[PATCH] D85310: [clangd] Disable define out-of-line code action on templates

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:393 +if (auto *PT = Source->getDescribedFunctionTemplate()) { + if (PT->getTemplatedDecl() == Source) +return false;

[PATCH] D85316: [SyntaxTree] Proposition of new tree dump

gribozavr2 added a comment. I'd suggest to drop the `<>` quotes (because the AST dump does not add quotes unless it is printing a multi-word thing, and because `<>` don't exactly scream "role" helping to read the output). I'd also suggest to replace multiple spaces before `<>` with a single spa

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/IRContext.h:39-41 + // Get the LLVM code for a function. We use the complete versions of the + // constructors and desctructors in this overload. Use the

[PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

Meinersbur added a comment. Hasn't this already been done in 80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84780/new/ https://reviews.l

[PATCH] D85319: [analyzer] Get info from the LLVM IR for precision

martong marked 3 inline comments as done. martong added a comment. In D85319#2196648 , @whisperity wrote: > What will happen with the ability to analyse a translation unit whose target > was not part of `LLVM_TARGETS_TO_BUILD` of the current `clang` binar

[PATCH] D84636: [RFC] Make the default LibCall implementations from compiler-rt builtins library more customizable

atrosinenko added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84636/new/ https://reviews.llvm.org/D84636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

kadircet added a comment. > I'm not quite sure there should be no tooltip for a #define. Such tooltip is > not really useful, but at the same time clangd shows tooltips for function > declarations/defnitions, namespaces, variables, etc. and not showing it for > macro definition will be a little

Re: [PATCH] D84782: [PGO] Include the mem ops into the function hash.

On Wed, Aug 5, 2020 at 8:30 AM Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added a comment. > > In D84782#2191429 , @yamauchi > wrote: > > > In D84782#2191243 , @MaskRay > wrote: > > > >>

[PATCH] D85318: [clangd] Hide "swap if branch" tweak

kadircet added a comment. you might want this to be cherry-picked into 11 release Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85318/new/ https://reviews.llvm.org/D85318 ___ cfe-commits mailing list cfe

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: uweigand, Kai, hubert.reinterpretcast, yusra.syeda, SeanP. Herald added a project: clang. Herald added a subscriber: cfe-commits. abhina.sreeskantharajan requested review of this revision. This patch adds the

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

anirudhp added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:745 +if (this->PointerWidth == 64) { + Builder.defineMacro("__64BIT__"); +} What about the `__LP64__` and the `_LP64` macros? Repository: rG LLVM Github Monorepo CHA

[PATCH] D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions.

tra added a comment. LGTM for CUDA. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:839-840 + // Skip host-only functions in the CUDA device compilation and device-only + // functions in the host compilation. + if (CGM.getLangOpts().CUDA && We will still have

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:745 +if (this->PointerWidth == 64) { + Builder.defineMacro("__64BIT__"); +} anirudhp wrote: > What about the `__LP64__` and the `_LP64` macros? These two a

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

anirudhp added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:745 +if (this->PointerWidth == 64) { + Builder.defineMacro("__64BIT__"); +} abhina.sreeskantharajan wrote: > anirudhp wrote: > > What about the `__LP64__` and the `_LP64`

Re: [PATCH] D84782: [PGO] Include the mem ops into the function hash.

On Wed, Aug 5, 2020 at 6:26 PM Hiroshi Yamauchi via llvm-commits wrote: > > > > On Wed, Aug 5, 2020 at 8:30 AM Hans Wennborg via Phabricator > wrote: >> >> hans added a comment. >> >> In D84782#2191429 , @yamauchi wrote: >> >> > In D84782#2191243

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:745 +if (this->PointerWidth == 64) { + Builder.defineMacro("__64BIT__"); +} anirudhp wrote: > abhina.sreeskantharajan wrote: > > anirudhp wrote: > > > What about the `__LP

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau planned changes to this revision. ctetreau added a comment. I plan to investigate the changes proposed by @c-rhodes. I'm a bit swamped right now so it may take a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://review

  1   2   3   >