[clang-tools-extra] 1603470 - [clangd] Fix clangd-indexeer builds after D84697

Author: Kirill Bobyrev Date: 2020-07-29T10:27:11+02:00 New Revision: 1603470e59a99a39ebdc4bf62a3a16c8c4ebea36 URL: https://github.com/llvm/llvm-project/commit/1603470e59a99a39ebdc4bf62a3a16c8c4ebea36 DIFF: https://github.com/llvm/llvm-project/commit/1603470e59a99a39ebdc4bf62a3a16c8c4ebea36.diff

[libunwind] 380fee3 - [libunwind] Provide a way to set '_LIBUNWIND_IS_BAREMETAL' through cmake.

Author: Hafiz Abid Qadeer Date: 2020-07-29T11:48:28+01:00 New Revision: 380fee34d2794361f9e222fe3c8c065be3b9fff8 URL: https://github.com/llvm/llvm-project/commit/380fee34d2794361f9e222fe3c8c065be3b9fff8 DIFF: https://github.com/llvm/llvm-project/commit/380fee34d2794361f9e222fe3c8c065be3b9fff8.d

[PATCH] D84831: [clang-tidy] Fix RedundantStringCStrCheck with r values

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. The previous fix for this, https://reviews.llvm.org/D76761, Passed test cases b

[PATCH] D84812: [clang-tidy][NFC] Added convienence methods for getting optional options

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:224 + else +consumeError(ValueOr.takeError()); + return llvm::None; gribozavr2 wrote: > Is this specialization defined onl

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:481 +{"-dotprod", "-fp16fml", "-bf16", "-mve.fp"}); +if (!hasIntegerMVE(Features)) {

[PATCH] D84812: [clang-tidy][NFC] Added convienence methods for getting optional options

njames93 updated this revision to Diff 281492. njames93 added a comment. Rename logOptionParsingError Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84812/new/ https://reviews.llvm.org/D84812 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

njames93 updated this revision to Diff 281494. njames93 added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84814/new/ https://reviews.llvm.org/D84814 Files: clang-tools-extra/clang-tidy/readability/IdentifierNaming

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

JonChesterfield added a comment. We probably do want a macro to indicate 'compiling for amdgcn as the device half of a combined host+device language'. I'm having a tough time with the control flow in this header so we probably want tests to check the overall behaviour is as intended. E.g. stati

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

mgorny added a comment. This commit breaks standalone clang builds. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19 +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" +#include "llvm/Config/config.h" +#include "gtest/gtest.h" ---

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

nikic added a comment. This change had a significant negative compile-time impact: https://llvm-compile-time-tracker.com/compare.php?from=0b161def6cacff1a63d3cf1a1efe95b550814d7a&to=e22de4e46d1dd1aacc3a7060d24bcbe89908ba6c&stat=instructions Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89247792c5bd: [clang] Fix ConceptSpecializationExpr::getEndLoc() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good with suggestions applied, and with the portability problems in the test fixed. (Maybe just add a `-triple`? Though it would be good to also test `inalloca` and ARM constructor `this

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 281345. guiand added a comment. Fix typo in MayDropFunctionReturn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand updated this revision to Diff 281452. guiand added a comment. All tests up to date. Of particular note are the `ppc-*mmintrin.c` tests, which seemed to drastically change upon rerunning the test autogen script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal added inline comments. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19 +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" +#include "llvm/Config/config.h" +#include "gtest/gtest.h" mgorny wrote: > `config.

[PATCH] D84831: [clang-tidy] Fix RedundantStringCStrCheck with r values

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. > Passed test cases but failed in the real world as std::string has a non > trivial destructor so creates a CXXBindTemporaryExpr. An idea for a future change: move the std::string mock

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:172 std::vector resolveDependentExprToDecls(const Expr *E) { assert(E->isTypeDependent()); if (const auto *ME = dyn_cast(E)) { hokein wrote: > @nridge, the assertion is not t

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h:76 + /// Stores the style options for a given directory. + mutable llvm::StringMap>

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

aaron.ballman accepted this revision. aaron.ballman added a comment. LG! Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:703 + Apply[Event.ErrorId] = false; +continue; + case Event::ET_Insert: njames93 wrote: > aar

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84658/new/ https://reviews.llvm.org/D84658 __

[PATCH] D84473: Dump Accumulator

jhenderson requested changes to this revision. jhenderson added a comment. This revision now requires changes to proceed. I'm assuming you need llvm-readobj to test your changes? In which case, the llvm-readobj change needs to come first, and then you can write tests using it to test this change

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:5112 if (FTI.NumParams != 1 || FTI.isVariadic) { - S.Diag(DeclType.Loc, diag::err_void_only_param); + S.Diag(FTI.Params[i].IdentLoc, diag::err_void_only_param);

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281525. MForster marked 4 inline comments as done. MForster added a comment. Store the VarDecl instead of the identifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident)); aaron.ballman wrote: > MForster wrote: > > aaron.ballman wrote: > > > Shouldn'

[PATCH] D84837: [clangd] Fix an assertion failure in TargetFinder's heuristic resolution of dependent type.

hokein created this revision. hokein added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The assertion is not true anymore after D82739

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281531. MForster added a comment. Rebase against master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[PATCH] D84473: Dump Accumulator

jhenderson added a comment. By the way, has the design of this been discussed on llvm-dev? It seems like something should have an RFC if it hasn't already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84473/new/ https://reviews.llvm.org/D84473 _

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

ABataev added a comment. In D84767#2180433 , @ye-luo wrote: > In D84767#2180280 , @ye-luo wrote: > >> This patch >> GPU activities: 96.99% 350.05ms10 35.005ms 1.5680us 350.00ms >> [CUDA memcpy HtoD]

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ilya-golovenko requested review of this revision. It is necessary to traverse children of unnamed declaration contexts to get symbols which are curren

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos updated this revision to Diff 281540. pmatos added a comment. Update patch to compile against current master branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: .gitlab-ci.yml lld/wasm/

[PATCH] D84005: Introduce ns_error_domain attribute.

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5342 +S.Diag(Loc, diag::err_nserrordomain_invalid_decl) +<< 1 << DRE->getNameInfo().getName(); +return; Just send the declaration into the diagnostic. See the recent D84

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko updated this revision to Diff 281542. ilya-golovenko added a comment. Trigger new build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D84839 Files: clang-tools-extra/clangd/FindSymbols.cpp cla

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:116-121 + unsigned Priority = 0; for (ClangTidyModuleRegistry::iterator I = ClangTidyModuleRegistry::begin(), E = ClangTidyModuleRegis

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:200 auto *ND = llvm::dyn_cast(D); -if (!ND) +if (!ND) { + // Traverse children of unnamed contexts, e.g. extern "C". this will result in traversal of other decl

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

whisperity added inline comments. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19 +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" +#include "llvm/Config/config.h" +#include "gtest/gtest.h" steakhal wrote: > mgor

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281546. MForster added a comment. Use declaration in diagnostics instead of name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Att

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: clang/lib/AST/OpenMPClause.cpp:2304-2306 + auto it = FeatureMap.find(RawString); + if (it != FeatureMap.end()) +return it->second;

[clang] d1a3396 - [Driver][ARM] Disable unsupported features when nofp arch extension is used

Author: Victor Campos Date: 2020-07-29T14:13:22+01:00 New Revision: d1a3396bfbc6fd6df927f2864c18d86e742cabff URL: https://github.com/llvm/llvm-project/commit/d1a3396bfbc6fd6df927f2864c18d86e742cabff DIFF: https://github.com/llvm/llvm-project/commit/d1a3396bfbc6fd6df927f2864c18d86e742cabff.diff

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a3396bfbc6: [Driver][ARM] Disable unsupported features when nofp arch extension is used (authored by vhscampos). Changed prior to commit: https:

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281550. MForster added a comment. Apply ClangTidy suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D84005: Introduce ns_error_domain attribute.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3650 S.Diag(Field->getLocation(), diag::warn_transparent_union_attribute_field_size_align) << isSize << *Field << FieldBits; --

[clang] 71bf6dd - [Driver][ARM] Fix testcase that should only run on ARM

Author: Victor Campos Date: 2020-07-29T14:35:14+01:00 New Revision: 71bf6dd682c03c8c29a365f602f5168d44757abe URL: https://github.com/llvm/llvm-project/commit/71bf6dd682c03c8c29a365f602f5168d44757abe DIFF: https://github.com/llvm/llvm-project/commit/71bf6dd682c03c8c29a365f602f5168d44757abe.diff

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. I will be splitting the part enabling the target feature through clang into a separate revision as suggested by @tlively Comment at: clang/lib/Basic/Targets/WebAssembly.cpp:43 .Case("exception-handling", HasExceptionHandling) + .Case("refere

[PATCH] D84843: [Analyzer] Remove inclusion of uniqueing decl from diagnostic profile.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske request

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

steakhal updated this revision to Diff 281556. steakhal marked 3 inline comments as done. steakhal added a comment. Reworked `ElementRegion` handling. Previously it handled only element regions in the form of: `Element{X,n} OP Element{X,m}` Now supports `Element{X,n} OP X` and `X OP Element{X,n}`

[clang] 1ae63b4 - [clang][NFC] Pass the ASTContext to CXXRecordDecl::setCaptures

Author: Bruno Ricci Date: 2020-07-29T14:55:15+01:00 New Revision: 1ae63b4179c222431cd6a4b2397abceaa5bc3d30 URL: https://github.com/llvm/llvm-project/commit/1ae63b4179c222431cd6a4b2397abceaa5bc3d30 DIFF: https://github.com/llvm/llvm-project/commit/1ae63b4179c222431cd6a4b2397abceaa5bc3d30.diff L

[clang] 517fe05 - [clang][NFC] clang-format fix after eb10b065f2a870b425dcc2040b9955e0eee464b4

Author: Bruno Ricci Date: 2020-07-29T14:55:16+01:00 New Revision: 517fe058d42a1f937e14de4b61a5ac2ad326c850 URL: https://github.com/llvm/llvm-project/commit/517fe058d42a1f937e14de4b61a5ac2ad326c850 DIFF: https://github.com/llvm/llvm-project/commit/517fe058d42a1f937e14de4b61a5ac2ad326c850.diff L

[PATCH] D84005: Introduce ns_error_domain attribute.

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3650 S.Diag(Field->getLocation(), diag::warn_transparent_union_attribute_field_size_align) << isSize << *Field << FieldBits; gribozavr2 wrote: > Please u

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal added inline comments. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19 +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" +#include "llvm/Config/config.h" +#include "gtest/gtest.h" whisperity wrote: > stea

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

balazske added a comment. Crash is fixed here: D84843 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83115/new/ https://reviews.llvm.org/D83115 ___ cfe-commits mailing li

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5, 5.0, and default - Part 1

ABataev added a comment. I'm not sure if this is profitable. All these changes increase the time of the test execution significantly in many cases while execution goes the same control paths. Some smart changes are required, only for things changed from version to version. Repository: rG LL

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:200 auto *ND = llvm::dyn_cast(D); -if (!ND) +if (!ND) { + // Traverse children of unnamed contexts, e.g. extern "C". kadircet wrote: > this will result in

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya, emaste. Herald added a reviewer: espindola. Herald added projects: clang, LLVM. tbaeder requested review of this revision. Herald added a subscriber: MaskRay. Add support for generating missing GNU

[clang] 8d27be8 - [OpenCL] Add global_device and global_host address spaces

Author: Alexey Bader Date: 2020-07-29T17:24:53+03:00 New Revision: 8d27be8dbaffce0519ac41173d51923fc2524b1b URL: https://github.com/llvm/llvm-project/commit/8d27be8dbaffce0519ac41173d51923fc2524b1b DIFF: https://github.com/llvm/llvm-project/commit/8d27be8dbaffce0519ac41173d51923fc2524b1b.diff

[PATCH] D82174: [OpenCL] Add global_device and global_host address spaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d27be8dbaff: [OpenCL] Add global_device and global_host address spaces (authored by bader). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. ping. I think I have addressed all the issues in FE. I think issues in AtomicExpandPass should be addressed by separate patches. Can we land this? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726

[clang-tools-extra] b99630e - [clang-tidy] Fix RedundantStringCStrCheck with r values

Author: Nathan James Date: 2020-07-29T15:35:31+01:00 New Revision: b99630e432614d06b380afb15c45065eaa0a URL: https://github.com/llvm/llvm-project/commit/b99630e432614d06b380afb15c45065eaa0a DIFF: https://github.com/llvm/llvm-project/commit/b99630e432614d06b380afb15c45065eaa0a.diff

[PATCH] D84831: [clang-tidy] Fix RedundantStringCStrCheck with r values

This revision was automatically updated to reflect the committed changes. Closed by commit rGb99630e43261: [clang-tidy] Fix RedundantStringCStrCheck with r values (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84831/new/ https

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

gregrodgers added a comment. This is all excellent feedback. Thank you. I don't understand what I see on the godbolt link. So far, we have only tested with clang. We will test with gcc to understand the fail. I will make the change to use numeric values for _DEVICE_ARCH and change "UNKNO

[PATCH] D83242: [clang][BPF] support type existence/size and enum value relocations

yonghong-song added a comment. One potential missing relocation is to test whether a particular enum value (from an enum type) exists or not. One way is to create a new relocation type ENUM_VALUE_EXISTENCE where "access_string" to encode the enum value. This is different from TYPE_EXISTENCE fo

[PATCH] D84850: [clang-tidy] Fix module options being registered with different priorities

njames93 created this revision. njames93 added a reviewer: DmitryPolukhin. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Not a bug that is ever likely to materialise, but still worth fixing Repository: rG LLVM Githu

[PATCH] D84850: [clang-tidy] Fix module options being registered with different priorities

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. Thank you for identifying and fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84850/new/ https://reviews.llvm.org/D84850

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:51 + +/// Get the maximum number of threads in a block of the GPU. +llvm::Value *CGOpenMPRuntimeAMDGCN::getGPUNumThreads(CodeGenFunction &CGF) { Move these comments to the head

[PATCH] D84831: [clang-tidy] Fix RedundantStringCStrCheck with r values

njames93 added a comment. In D84831#2181336 , @gribozavr2 wrote: >> Passed test cases but failed in the real world as std::string has a non >> trivial destructor so creates a CXXBindTemporaryExpr. > > An idea for a future change: move the std::string mock

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 281602. arames added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Options.td clang/i

[clang-tools-extra] 62beb7c - [clang-tidy] Fix module options being registered with different priorities

Author: Nathan James Date: 2020-07-29T16:19:07+01:00 New Revision: 62beb7c6f4f2288793751740f06edc0dc25d01f6 URL: https://github.com/llvm/llvm-project/commit/62beb7c6f4f2288793751740f06edc0dc25d01f6 DIFF: https://github.com/llvm/llvm-project/commit/62beb7c6f4f2288793751740f06edc0dc25d01f6.diff

[PATCH] D84850: [clang-tidy] Fix module options being registered with different priorities

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62beb7c6f4f2: [clang-tidy] Fix module options being registered with different priorities (authored by njames93). Repository: rG LLVM Github Monore

[clang] 7db017b - [OpenMP][Docs] Update Clang Support docs after D75591

Author: Johannes Doerfert Date: 2020-07-29T10:21:05-05:00 New Revision: 7db017bf3405c7fa43786fe27380d88702e19584 URL: https://github.com/llvm/llvm-project/commit/7db017bf3405c7fa43786fe27380d88702e19584 DIFF: https://github.com/llvm/llvm-project/commit/7db017bf3405c7fa43786fe27380d88702e19584.d

[clang] ee05167 - [OpenMP] Allow traits for the OpenMP context selector `isa`

Author: Johannes Doerfert Date: 2020-07-29T10:22:27-05:00 New Revision: ee05167cc42b95f70bc2ff1bd4402969f356f53b URL: https://github.com/llvm/llvm-project/commit/ee05167cc42b95f70bc2ff1bd4402969f356f53b DIFF: https://github.com/llvm/llvm-project/commit/ee05167cc42b95f70bc2ff1bd4402969f356f53b.d

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee05167cc42b: [OpenMP] Allow traits for the OpenMP context selector `isa` (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.o

[PATCH] D83296: [clang-format] Add a MacroExpander.

klimek updated this revision to Diff 281611. klimek marked 27 inline comments as done. klimek added a comment. Addressed code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83296/new/ https://reviews.llvm.org/D83296 Files: clang/

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc2ddecbd34: [clang-tidy] Handled insertion only fixits when determining conflicts. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82

[clang-tools-extra] bbc2dde - [clang-tidy] Handled insertion only fixits when determining conflicts.

Author: Nathan James Date: 2020-07-29T16:35:44+01:00 New Revision: bbc2ddecbd342d4502fe43466bd3658b89ddad7d URL: https://github.com/llvm/llvm-project/commit/bbc2ddecbd342d4502fe43466bd3658b89ddad7d DIFF: https://github.com/llvm/llvm-project/commit/bbc2ddecbd342d4502fe43466bd3658b89ddad7d.diff

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

dang updated this revision to Diff 281614. dang added a comment. Ensure that the default value is assigned even if the option should not get parsed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/ https://reviews.llvm.org/D84674 Files:

[PATCH] D83296: [clang-format] Add a MacroExpander.

klimek added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:35 + SmallVector Params; + SmallVector Tokens; +}; sammccall wrote: > Tokens -> Expansion? (semantics rather than type) Changed to "Body". Comment at: clang/lib/Form

[PATCH] D84843: [Analyzer] Remove inclusion of uniqueing decl from diagnostic profile.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the fast fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84843/new/ https://reviews.llvm.org/D84843 __

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi updated this revision to Diff 281626. yamauchi added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files: clang/test/CodeGen/Inputs/thinlto_expect1.proftext clang/

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:266 +PGOOldCFGHashing("pgo-instr-old-cfg-hashing", cl::init(false), cl::Hidden, + cl::desc("Use the old CFG function hashing.")); + Mask

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

morehouse added inline comments. Comment at: llvm/lib/Passes/PassRegistry.def:92 MODULE_PASS("verify", VerifierPass()) +MODULE_PASS("dfsan", DataFlowSanitizerPass()) MODULE_PASS("asan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/false, false, true, false)) ---

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997 case ABIArgInfo::Ignore: + case ABIArgInfo::IndirectAliased: return false; rjmccall wrote: > In principle, this can be `inreg` just as much as Indirect can. The IR verifier c

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm updated this revision to Diff 281629. arsenm marked 5 inline comments as done. arsenm added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79744/new/ https://reviews.llvm.org/D79744 Files: clang/include/clang/CodeGen/CGFunctionInfo.h clang/lib/Code

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassRegistry.def:92 MODULE_PASS("verify", VerifierPass()) +MODULE_PASS("dfsan", DataFlowSanitizerPass()) MODULE_PASS("asan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/false, false, true, false))

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

balazske updated this revision to Diff 281631. balazske added a comment. Changed MemoryError back to LogicError. Improved placement and text of changed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84494/new/ https://reviews.llvm.org/D8449

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84572/new/ https://reviews.llvm.org/D84572 __

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:158 +def DeprecatedCopy : DiagGroup<"deprecated-copy", [DeprecatedCopyUserProvided]>; +def DeprecatedCopyDtor : DiagGroup<"deprecated-copy-dtor", [DeprecatedCopyDtorUserProvided]>; def

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added a comment. In D84782#2180626 , @davidxl wrote: > changes like in llvm/test/Transforms/PGOProfile/PR41279.ll etc can be > independently committed. Uploaded D84865 for this. Repository: rG LLVM Github Mo

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

balazske marked 2 inline comments as done. balazske added a comment. The category string seems to be not really important, better not to change it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84494/new/ https://reviews.llvm.org/D84494 __

[clang] 9f2f3b9 - [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

Author: Joel E. Denny Date: 2020-07-29T12:18:45-04:00 New Revision: 9f2f3b9de6314a009322b6081c792ebf9a469460 URL: https://github.com/llvm/llvm-project/commit/9f2f3b9de6314a009322b6081c792ebf9a469460 DIFF: https://github.com/llvm/llvm-project/commit/9f2f3b9de6314a009322b6081c792ebf9a469460.diff

[PATCH] D84868: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Ordering of options isn't important so an `llvm::StringMap` is a much better container

[PATCH] D84868: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap

njames93 updated this revision to Diff 281639. njames93 added a comment. Missing call to getValue() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84868/new/ https://reviews.llvm.org/D84868 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clan

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8055 for (const auto L : C->component_lists()) { -InfoGen(std::get<0>(L), std::get<1>(L), OMPC_MAP_to, llvm::None, +SmallVector MapModifiers; +translateMotionModifiers(C

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added a comment. In D80391#2179182 , @MaskRay wrote: > Ping... Was hoping to get some more discussion on the general debug flag naming thread on the GCC list, but that hasn't happened - so I've replied/poked it a bit: https://gcc.gnu.org/piperm

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. akhuang requested review of this revision. Previously ctor homing was omitting debug info for classes if they have both trival and nontrivial constructo

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 281644. Jac1494 added a comment. Address @aaron.ballman review comments. I have added your test case that is passing as well. This patch covers this scenario also. Thanks @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/ https:

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

dblaikie added a comment. I think it'd be good to separate these two issues/patches. In part because I'm curious whether, even with a trivial ctor - if we did the retained types thing - would that be enough? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D84837: [clangd] Fix an assertion failure in TargetFinder's heuristic resolution of dependent type.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:171 // or more declarations that it likely references. -std::vector resolveDependentExprToDecls(const Expr *E) {

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

morehouse accepted this revision. morehouse added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84707/new/ https://reviews.llvm.org/D84707 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

thakis added a comment. This breaks check-clang on Windows: http://45.33.8.238/win/20850/step_7.txt Please take a look, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://r

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

vsavchenko accepted this revision. vsavchenko added a comment. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84494/new/ https://reviews.llvm.org/D84494 ___ cfe-commits mailing list cfe-c

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

NoQ accepted this revision. NoQ added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84494/new/ https://reviews.llvm.org/D84494 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

  1   2   >