aaron.ballman accepted this revision. aaron.ballman added a comment. LG!
================ Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:703 + Apply[Event.ErrorId] = false; + continue; + case Event::ET_Insert: ---------------- njames93 wrote: > aaron.ballman wrote: > > Similar here with `continue` and the unreachable. > As this is in a loop, I'm torn whether using `break` makes it less readable. > WDYT? I tend to prefer `break` to `continue` because it's terribly easy to miss the fact that the `switch` statement is continuing the loop should someone decide they want to stick some code below the `switch` but within the loop for some reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82898/new/ https://reviews.llvm.org/D82898 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
