[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev updated this revision to Diff 278329. kbobyrev added a comment. Add some missing ranges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 Files: clang-tools-extra/clangd/unittests/SemanticSelectio

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. This seems like something that we should then revert until we know that instsimplify can be updated with a fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 _

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

lebedev.ri added a comment. In D83360#2154540 , @echristo wrote: > This seems like something that we should then revert until we know that > instsimplify can be updated with a fix? Possibility for a miscompile sounds much worse to me than a false-positi

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. We're starting to see miscompiles as we do more testing as well, just nothing smaller at the moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

lebedev.ri added a comment. In D83360#2154545 , @echristo wrote: > We're starting to see miscompiles as we do more testing as well, just nothing > smaller at the moment. Could you clarify, do you mean that this fix is causing (new) miscompiles? Reposi

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

jlebar added a comment. tra and I talked offline and I...think this makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83893/new/ https://reviews.llvm.org/D83893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. It's that even before the msan instrumentation the IR doesn't look correct - thus a miscompile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 _

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 278341. dokyungs added a comment. Ensure the fuzzer RT module is initialized at the beginning of the interceptors. Interceptors can be called before __fuzzer_init is called. So I added a check at the beginning of the interceptors, which ensures that __fuzze

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

aqjune added a comment. In D83360#2154584 , @echristo wrote: > It's that even before the msan instrumentation the IR doesn't look correct - > thus a miscompile. I'll share a prototype of the InstSimplify patch on Phabricator, in a day or two; it would

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 278344. lildmh added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Include the llvm part CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: clang/include/clang/AST/Op

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. In D67833#2154312 , @grokos wrote: > I tried to build clang with this patch and I get errors like: > > CGOpenMPRuntime.cpp:9463:38: error: > ‘OMPRTL___tgt_target_teams_nowait_mapper’ was not declared in this scope >

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, Meinersbur, kkwli0, grokos, sfantao, gtbercea, Hahnfeld. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. For example, without this patch: $ cat test.c int main

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny updated this revision to Diff 278343. jdenny edited the summary of this revision. jdenny set the repository for this revision to rG LLVM Github Monorepo. jdenny added a comment. Rebased, and extracted D83922 as discussed. Repository: rG LLVM Github Mono

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. In D83360#2154637 , @aqjune wrote: > In D83360#2154584 , @echristo wrote: > > > It's that even before the msan instrumentation the IR doesn't look correct > > - thus a miscompile. > > > I'

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

grokos added a comment. OK, now it works. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG537b16e9b8da: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime (authored by grokos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[libunwind] fd802cc - [libunwind] Fix getSLEB128 on large values

Author: Ryan Prichard Date: 2020-07-15T19:12:56-07:00 New Revision: fd802cc4dea4ed1a233ff725f98c686dc2836bf3 URL: https://github.com/llvm/llvm-project/commit/fd802cc4dea4ed1a233ff725f98c686dc2836bf3 DIFF: https://github.com/llvm/llvm-project/commit/fd802cc4dea4ed1a233ff725f98c686dc2836bf3.diff

[libunwind] 52d0a78 - [libunwind] Fix CIE v1 return address parsing

Author: Ryan Prichard Date: 2020-07-15T19:12:55-07:00 New Revision: 52d0a78b831584c46eda78b7cf349ab93ce13df0 URL: https://github.com/llvm/llvm-project/commit/52d0a78b831584c46eda78b7cf349ab93ce13df0 DIFF: https://github.com/llvm/llvm-project/commit/52d0a78b831584c46eda78b7cf349ab93ce13df0.diff

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng marked 2 inline comments as done. pzheng added a comment. In D83648#2146606 , @MaskRay wrote: > Created http://lists.llvm.org/pipermail/cfe-dev/2020-July/066245.html > [cfe-dev] Usage of clang::driver::options::DriverOption (-Xarch_ & gcc > toolch

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

pzheng updated this revision to Diff 278361. pzheng added a comment. Add target triple used in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648 Files: clang/include/clang/Driver/Options.td clang/tes

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso updated this revision to Diff 278368. Charusso marked 18 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. - Resolve most of the review comments. - We really need to specify the design of future checkers. CHANGES SINCE LAST ACTION https:/

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso added a comment. Thanks for the reviews! In D70411#2153562 , @Szelethus wrote: > Please do not bypass the previous comments that hadn't reached a conclusion > -- littering inlines about miscellaneous stuff at this stage does more harm > then go

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. I'm going to revert this as Eric requested. And I'll ask to merge the revert to the 11 branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 __

[clang] 00f3579 - Revert "[InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X transforms" and subsequent patches

Author: Craig Topper Date: 2020-07-15T22:02:33-07:00 New Revision: 00f3579aea6e3d4a4b7464c3db47294f71cef9e4 URL: https://github.com/llvm/llvm-project/commit/00f3579aea6e3d4a4b7464c3db47294f71cef9e4 DIFF: https://github.com/llvm/llvm-project/commit/00f3579aea6e3d4a4b7464c3db47294f71cef9e4.diff

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper reopened this revision. craig.topper added a comment. This revision is now accepted and ready to land. Reverted in 00f3579aea6e3d4a4b7464c3db47294f71cef9e4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. Merge request for 11.0 https://bugs.llvm.org/show_bug.cgi?id=46740 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 ___ cfe-commits

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5530862870: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to… (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] fc55308 - [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

Author: Amy Kwan Date: 2020-07-16T00:30:24-05:00 New Revision: fc55308628709bfc64b100dadf9a030fbb2afaee URL: https://github.com/llvm/llvm-project/commit/fc55308628709bfc64b100dadf9a030fbb2afaee DIFF: https://github.com/llvm/llvm-project/commit/fc55308628709bfc64b100dadf9a030fbb2afaee.diff LOG:

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278086. kbobyrev added a comment. Don't allow empty paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org/D83826 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D83855: [clang] fix printing of lambdas with capture expressions

walrus created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83855 Files: clang/lib/AST/StmtPrinter.cpp clang/test/AST/ast-printer-lambda.cpp Index: clang/test/AST/ast-printer-lambda.cpp

[PATCH] D82767: clang-format: Explicitly use python3

serge-sans-paille added a comment. >> My understanding is that explicitly requiring python3 may make sense if the >> script is not backward-compatible with python2, while requiring python means >> the version is not important. >> At the end-of-year, we should be able to harmonize shebangs to

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX added a comment. In D83621#2151716 , @sammccall wrote: > In D83621#2146750 , @ArcsinX wrote: > > > > - don't scan for equivalences if the set of candidates exceeds some size > > > threshold (10 or so) > > >

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

balazske marked an inline comment as done. balazske added a comment. The problems with bug reporting should be fixed in another patch. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of

[clang] de7bf72 - [RISCV] Add error checking for extensions missing separating underscores

Author: Simon Cook Date: 2020-07-15T09:23:35+01:00 New Revision: de7bf722c23a1ab006bd306165c094669071577f URL: https://github.com/llvm/llvm-project/commit/de7bf722c23a1ab006bd306165c094669071577f DIFF: https://github.com/llvm/llvm-project/commit/de7bf722c23a1ab006bd306165c094669071577f.diff LO

[PATCH] D83819: [RISCV] Add error checking for extensions missing separating underscores

This revision was automatically updated to reflect the committed changes. Closed by commit rGde7bf722c23a: [RISCV] Add error checking for extensions missing separating underscores (authored by simoncook). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rGfe5912249efa: [clang][Driver] Fix tool path priority test failures (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] fe59122 - [clang][Driver] Fix tool path priority test failures

Author: David Spickett Date: 2020-07-15T09:37:09+01:00 New Revision: fe5912249efa1ec5e6aa6e565f722dd4d33d1e54 URL: https://github.com/llvm/llvm-project/commit/fe5912249efa1ec5e6aa6e565f722dd4d33d1e54 DIFF: https://github.com/llvm/llvm-project/commit/fe5912249efa1ec5e6aa6e565f722dd4d33d1e54.diff

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 278106. khchen marked 8 inline comments as done. khchen added a comment. address @asb's comment. thanks. Thanks for @lenary bug report. I cannot reproduce the crash in local, but I though the problem is cause by removing "Choose a default based on the triple"

[PATCH] D83802: [clangd] Config: also propagate in sync (testing) mode

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1241 + // Avoid null checks everywhere. + if (!Opts.ContextProvider) +this->Opts.ContextProvider

[clang] 5165b2b - AArch64+ARM: make LLVM consider system registers volatile.

Author: Tim Northover Date: 2020-07-15T09:47:36+01:00 New Revision: 5165b2b5fd5fd62c5a34970be81c79231844804c URL: https://github.com/llvm/llvm-project/commit/5165b2b5fd5fd62c5a34970be81c79231844804c DIFF: https://github.com/llvm/llvm-project/commit/5165b2b5fd5fd62c5a34970be81c79231844804c.diff

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

t.p.northover closed this revision. t.p.northover added a comment. Thanks. Pushed to master as 5165b2b5fd5 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80911/new/ https://revi

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

sammccall added a subscriber: chandlerc. sammccall added a comment. In D83621#2152618 , @ArcsinX wrote: > In D83621#2151716 , @sammccall wrote: > > > In D83621#2146750 , @Arc

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

balazske updated this revision to Diff 278110. balazske added a comment. Fixed commit message and added FIXME about bug report location problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83120/new/ https://reviews.llvm.org/D83120 Files: clan

[clang] 9697a9e - Fix typo in identifier in assert.

Author: Tim Northover Date: 2020-07-15T09:57:53+01:00 New Revision: 9697a9e2d316f0d9d588f4de536b0a6bbef2810f URL: https://github.com/llvm/llvm-project/commit/9697a9e2d316f0d9d588f4de536b0a6bbef2810f DIFF: https://github.com/llvm/llvm-project/commit/9697a9e2d316f0d9d588f4de536b0a6bbef2810f.diff

[clang-tools-extra] f782d9c - [clangd] Fix use-after-free in ArgStripper

Author: Sam McCall Date: 2020-07-15T11:03:11+02:00 New Revision: f782d9c7002edaaf56c06a6cc1775f8f67713a29 URL: https://github.com/llvm/llvm-project/commit/f782d9c7002edaaf56c06a6cc1775f8f67713a29 DIFF: https://github.com/llvm/llvm-project/commit/f782d9c7002edaaf56c06a6cc1775f8f67713a29.diff LO

[PATCH] D83695: Port Diagnostic option flags to new option parsing system

dang updated this revision to Diff 278112. dang added a comment. Add back -pg option that was accidentaly removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83695/new/ https://reviews.llvm.org/D83695 Files: clang/include/clang/Driver/Options

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 278116. gamesh411 marked 2 inline comments as done. gamesh411 added a comment. use move instead of copy fix documentation issues fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://revi

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

labath added a comment. I wouldn't mind separate (internal) cache variable, though I am somewhat surprised by this problem. A (non-cache) variable set in one of the parent scopes should still take precedence over a cache variable with the same name. And since config-ix.cmake is included from th

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 278117. sepavloff added a comment. Addressed reviewer's notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 Files: llvm/include/llvm/Support/Program.h llvm/lib/

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 marked 12 inline comments as done. gamesh411 added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:132 + "terminate by returning"); + break; +} steakhal wrote: > Why don't we `return` here? > Same f

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff added a comment. Thank you for your detailed feedback! > Round down to 32,000 to leave us wiggle room. As there is no requirement to use response files as rarely as possible, the choice of the limit is an implementation detail. Having some wiggle room is a good idea in this case. >

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 marked an inline comment as done. gamesh411 added a comment. In D83717#2150977 , @njames93 wrote: > Alternatively you could do something like this, though it would be a pain > https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/te

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 added a comment. @steakhal @Eugene.Zelenko Thanks for checking this patch! I have tried my best to adhere to your suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 __

[clang] c872e80 - [Matrix] Only pass vector arg as overloaded type in MatrixBuilder.

Author: Florian Hahn Date: 2020-07-15T10:42:24+01:00 New Revision: c872e809d1ac4aa405ae510e271f93d7662e26dd URL: https://github.com/llvm/llvm-project/commit/c872e809d1ac4aa405ae510e271f93d7662e26dd DIFF: https://github.com/llvm/llvm-project/commit/c872e809d1ac4aa405ae510e271f93d7662e26dd.diff

[clang-tools-extra] 7ab7b97 - Bump the trunk major version to 12

Author: Hans Wennborg Date: 2020-07-15T12:05:05+02:00 New Revision: 7ab7b979d29e1e43701cf690f5cf1903740f50e3 URL: https://github.com/llvm/llvm-project/commit/7ab7b979d29e1e43701cf690f5cf1903740f50e3 DIFF: https://github.com/llvm/llvm-project/commit/7ab7b979d29e1e43701cf690f5cf1903740f50e3.diff

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:734 //expressions which we currently do not know how to negate. - const RangeSet *getRangeForMinusSymbol(ProgramStateRef State, SymbolRef Sym) { + Optional getR

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. One more :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] 22a084c - [Analyzer] Report every bug if only uniqueing location differs.

Author: Balázs Kéri Date: 2020-07-15T12:19:25+02:00 New Revision: 22a084cfa337d5e5ea90eba5261f7937e28d250b URL: https://github.com/llvm/llvm-project/commit/22a084cfa337d5e5ea90eba5261f7937e28d250b DIFF: https://github.com/llvm/llvm-project/commit/22a084cfa337d5e5ea90eba5261f7937e28d250b.diff L

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG22a084cfa337: [Analyzer] Report every bug if only uniqueing location differs. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83115/new

[PATCH] D83822: [clangd] Support config over LSP.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1220 CDB->setCompileCommand(File, std::move(New)); ModifiedFiles.insert(File); } nit: maybe just set `ReparseAllFiles` in here too, and change the conditio

[PATCH] D83802: [clangd] Config: also propagate in sync (testing) mode

sammccall marked an inline comment as done. sammccall added a comment. Also added one direct test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83802/new/ https://reviews.llvm.org/D83802 ___

[clang-tools-extra] cf7160c - [clangd] Config: also propagate in sync (testing) mode

Author: Sam McCall Date: 2020-07-15T12:30:08+02:00 New Revision: cf7160c0b0c1250596cc9b2ba0e41423ac465a8f URL: https://github.com/llvm/llvm-project/commit/cf7160c0b0c1250596cc9b2ba0e41423ac465a8f DIFF: https://github.com/llvm/llvm-project/commit/cf7160c0b0c1250596cc9b2ba0e41423ac465a8f.diff LO

[PATCH] D83802: [clangd] Config: also propagate in sync (testing) mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf7160c0b0c1: [clangd] Config: also propagate in sync (testing) mode (authored by sammccall). Herald added a subscriber: jfb. Changed prior to commit: https://reviews.llvm.org/D83802?vs=277920&id=278130

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 278132. sepavloff added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 Files: llvm/include/llvm/Support/Program.h llvm/lib/Support/Windows/

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

sammccall added a comment. Server-side tracing looks nice, but you'll need some flags to allow actually extracting a trace, right? Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:62 grpc::ServerWriter *Reply) override { +trace::Sp

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

sammccall added a comment. > Also add more error messages and logs. I'm not sure about the error-handling strategy here: - it's very verbose in the marshalling code. Are we sure it pays for itself? For comparison, the marshalling code for LSP itself silently returns `false` on error, which is

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

sammccall added a comment. In D83826#2151979 , @kbobyrev wrote: > Use the same style for elog messages (1-based indexing, message format). As far as I can tell, 1-based indexing isn't an option that's available. Where do you see that it is? Repository

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; c-rhodes wrote: > sdesmalen wrote: > > aaron.ballman wrote: > > > sdesmalen wrote: > > > > nit: Can you add a co

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

Szelethus accepted this revision. Szelethus added a comment. Now that we found the answer to the only lingering question this revision raised, I think you can safely land it while we start looking into fixing this newfound bug. LGTM. Comment at: clang/test/Analysis/stream.c:2

[PATCH] D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report.

Szelethus added a comment. Unless @NoQ has anything else to add :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83120/new/ https://reviews.llvm.org/D83120 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:268 -inline ASTEdit withMetadata(ASTEdit edit, llvm::Any Metadata) { - edit.Metadata = std::m

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai added a comment. Is there a comment on the clang part? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

aaron.ballman added inline comments. Comment at: clang/test/Sema/arm-feature-sve-bits-macro.c:24 +#define __ARM_FEATURE_SVE_BITS N +typedef svint8_t macro_non_int_size2 __attribute__((arm_sve_vector_bits(N))); // expected-error {{'__ARM_FEATURE_SVE_BITS' must expand to an intege

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

saiislam added a comment. [Work in progress] Among all the test files in clang/test/OpenMP which were running only for version 4.5, I am yet to fix following files (rest all are given in this patch): 1. clang/test/OpenMP/distribute_parallel_for_codegen.cpp 2. clang/test/OpenMP/distribute_paralle

[PATCH] D83855: [clang] Fix printing of lambdas with capture expressions

kadircet added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2011 + Expr *Init = D->getInit(); + if (D->getInitStyle() == VarDecl::CallInit && !isa(Init)) +OS << "("; what about having a `Pre` and `Post` print blocks, set to `"(" an

[PATCH] D83681: [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:937 + return Invalid([&] { +Diag(Tok.getLocation(), diag::err_capture_default_first); + }); Would it make sense to provide a fix-it to move the capture default to

[PATCH] D83681: [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

riccibruno updated this revision to Diff 278150. riccibruno added a comment. clang-format again, sigh... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83681/new/ https://reviews.llvm.org/D83681 Files: clang/include/clang/Basic/DiagnosticParseKin

[PATCH] D83864: [ClangTidy] Fix false positives of readability-non-const-parameters check

JacquesLucke created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We recently started using Clang Tidy on the Blender source. We found a couple of false positives of the `readability-non-const-parameters` check. One of those is fixed by this patch. str

[PATCH] D83864: [ClangTidy] Fix false positives of readability-non-const-parameters check

JacquesLucke updated this revision to Diff 278154. JacquesLucke added a comment. For some reason `arc` did not upload all the changes. Maybe because I cloned from github, will check. Anyway, here is the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83864/new/ https://reviews.llv

[PATCH] D82575: [OpenMP] OpenMP Clang tests without 50 version string after upgrading to 5.0

ABataev added a comment. Check that default tests have additional -fopenmp-version=45 flag since they are expected to be executed in OpenMP 4.5 mode. Comment at: clang/test/OpenMP/declare_target_ast_print.cpp:5-7 +// RUN: %clang_cc1 -verify -fopenmp -I %S/Inputs -ast-print %s

[clang-tools-extra] c11c78a - [clangd] Use llvm::errs() instead of outs() for errors

Author: Kirill Bobyrev Date: 2020-07-15T14:34:29+02:00 New Revision: c11c78a1bd0b3275bf845604aae3c94e97acceed URL: https://github.com/llvm/llvm-project/commit/c11c78a1bd0b3275bf845604aae3c94e97acceed DIFF: https://github.com/llvm/llvm-project/commit/c11c78a1bd0b3275bf845604aae3c94e97acceed.diff

[PATCH] D83827: [clangd] Use llvm::errs() instead of outs() for errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGc11c78a1bd0b: [clangd] Use llvm::errs() instead of outs() for errors (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83827/new/ https:

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

ABataev added a comment. Not sure that this is really required. If we want to check for the default version, it would be good to check that it still works for 4.5. It means, need to add additional RUN lines. But I don't think it is profitable to test the same functionality several times without

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

saiislam added a comment. In D83863#2153008 , @ABataev wrote: > Not sure that this is really required. If we want to check for the default > version, it would be good to check that it still works for 4.5. It means, > need to add additional RUN lines. But

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. Thanks for the fix! Please can you also update `clang/test/Misc/target-invalid-cpu-note.c` for riscv32 and riscv64 - it's likely you'll need the fix in the inline note below. Also, there are a bunch of clang-tidy issues, which I think we can fix now rather than later.

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

ABataev added a comment. In D83863#2153021 , @saiislam wrote: > In D83863#2153008 , @ABataev wrote: > > > Not sure that this is really required. If we want to check for the default > > version, it would be good to

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

saiislam added a comment. In D83863#2153031 , @ABataev wrote: > In D83863#2153021 , @saiislam wrote: > > > In D83863#2153008 , @ABataev wrote: > > > > > Not sure that this is

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

ABataev added inline comments. Comment at: clang/test/OpenMP/parallel_default_messages.cpp:7-8 // RUN: %clang_cc1 -verify -fopenmp-version=30 -fopenmp -ferror-limit 100 -o - %s -Wuninitialized +// RUN: %clang_cc1 -verify=expected,ge40 -fopenmp -ferror-limit 100 -o - %s -Wunini

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

ArcsinX updated this revision to Diff 278161. ArcsinX added a comment. Support only directory simlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83621/new/ https://reviews.llvm.org/D83621 Files: clang/lib/Tooling/FileMatchTrie.cpp clang/u

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev marked 4 inline comments as done. kbobyrev added a comment. In D83826#2152857 , @sammccall wrote: > > Also add more error messages and logs. > > I'm not sure about the error-handling strategy here: > > - it's very verbose in the marshalling code.

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278162. kbobyrev marked an inline comment as done. kbobyrev added a comment. Small update: resolve a couple of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org/D83826

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Herald added a subscriber: dang. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D83868: Use TestClangConfig in AST Matchers tests and run them in more configurations

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I am changing tests for AST Matchers to run in multiple language standards versions, and under multiple triples that have different behavior with regards to templates. This change is similar to

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/test/OpenMP/target_ast_print.cpp:5-11 +// RUN: %clang_cc1 -DOMP45 -verify -fopenmp -ast-print %s | FileCheck %s --check-prefix=OMP45 +// RUN: %clang_cc1 -DOMP45 -fopenmp -x c++ -std=c++1

[PATCH] D83681: [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

riccibruno updated this revision to Diff 278164. riccibruno marked 3 inline comments as done. riccibruno added a comment. Add some tests showing that a by-ref capture is still parsed properly, including some tests with a capture containing a pack expansion. Repository: rG LLVM Github Monorepo

[PATCH] D83697: Port Frontend option flags to new option parsing system

dang updated this revision to Diff 278167. dang added a comment. Make sure that ast_dump_* are correctly labelled as belonging to Action_Group. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83697/new/ https://reviews.llvm.org/D83697 Files: clang

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278170. kbobyrev added a comment. Use DebugStrings instead of ShortDebugStrings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org/D83826 Files: clang-tools-extra/clangd/inde

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-env32-c.rst:6 + +This check implements SEI CERT rule ENV32-C by finding functions registered by +``atexit`` and ``at_quick_exit`` that are calling exit functions ``_Exit``, ---

[PATCH] D83681: [clang] Provide a more specific diagnostic for a misplaced lambda capture-default.

aaron.ballman added a comment. Thanks for the additional tests. This LGTM, though I still wonder about the fix-it (not certain if you saw the comment). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83681/new/ https://reviews.llvm.org/D83681 ___

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 marked 2 inline comments as done. gamesh411 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-env32-c.rst:6 + +This check implements SEI CERT rule ENV32-C by finding functions registered by +``atexit`` and ``at_quick_exit`` that are callin

  1   2   3   >