[PATCH] D83173: [VE] Correct stack alignment

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a project: clang. Change stack alignment from 64 bits to 128 bits to follow ABI correctly. And add a regression test for

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 created this revision. gargvaibhav64 added reviewers: rsmith, v.g.vassilev. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit attaches teaches ASTDeclReader::attachPreviousDecl to successfully merge two Decl's when one contains an inheritable attribu

[clang-tools-extra] e8158bf - [NFC] Clean up braces and anon namespace

Author: Nathan James Date: 2020-07-05T11:16:40+01:00 New Revision: e8158bf0e770e7a4cf73df91552af1e156a3ea17 URL: https://github.com/llvm/llvm-project/commit/e8158bf0e770e7a4cf73df91552af1e156a3ea17 DIFF: https://github.com/llvm/llvm-project/commit/e8158bf0e770e7a4cf73df91552af1e156a3ea17.diff

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for tracking this down, this is a really nasty bug... The fix itself is obviously fine, but I think I'm out of the loop regarding the testing strategy. We talked about a

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

tschuett added a comment. You could try: clangxx_host -Xclang -fdump-record-layouts %p/Inputs/layout.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

sstefan1 created this revision. sstefan1 added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, aaron.ballman, dexonsmith, guansong, hiraditya, yaxunl. Herald added projects: clang, LLVM. D82193 exposed a problem with global type defin

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

sstefan1 marked an inline comment as done. sstefan1 added a subscriber: hoyFB. sstefan1 added a comment. Since this is not a small change, I think it would be good if @hoyFB could test if this resolves the issue. There is one small issue though: Comment at: llvm/lib/Transform

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

sstefan1 updated this revision to Diff 275549. sstefan1 added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83176/new/ https://reviews.llvm.org/D83176 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGExpr.cpp clan

[clang-tools-extra] edba286 - [clangd] Fix stack-use-after-scope

Author: Benjamin Kramer Date: 2020-07-05T17:09:08+02:00 New Revision: edba2864a7a86a97276c555d02276712e45d60fc URL: https://github.com/llvm/llvm-project/commit/edba2864a7a86a97276c555d02276712e45d60fc DIFF: https://github.com/llvm/llvm-project/commit/edba2864a7a86a97276c555d02276712e45d60fc.dif

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker updated this revision to Diff 275550. Tyker added a comment. fixed the issue with multiple align in a single assume. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeGenF

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added a comment. In D77598#2111606 , @rsmith wrote: > In D77598#2064193 , @rsmith wrote: > > > In D77598#1990197 , @rsmith wrote: > > > > > Is is feasible to check wh

[clang] b0b5162 - [Driver] Pass -gno-column-info instead of -dwarf-column-info

Author: Fangrui Song Date: 2020-07-05T11:50:38-07:00 New Revision: b0b5162fc23c55906a461366f8acef2431d951c5 URL: https://github.com/llvm/llvm-project/commit/b0b5162fc23c55906a461366f8acef2431d951c5 DIFF: https://github.com/llvm/llvm-project/commit/b0b5162fc23c55906a461366f8acef2431d951c5.diff

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Some clang-tidy checkers, e.g. llvm-include-order can emit diagnostics at this callback (as mentioned i

[PATCH] D77598: Integral template argument suffix and cast printing

Quuxplusone added inline comments. Comment at: clang/test/SemaTemplate/matrix-type.cpp:77 void use_matrix_3(matrix &m) {} -// expected-note@-1 {{candidate template ignored: deduced type 'matrix<[...], 5UL - 2, 5UL>' of 1st parameter does not match adjusted type 'matrix<[...], 5

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 275558. zequanwu added a comment. Enable CGProfilePass for opt with LPM by default, like opt with NPM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 Files: clang/l

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:435 if ((*I)->getType().isConstQualified()) -classify((*I), ConstRefUse); +if (!hasTrivialBody(CE)) + classify((*I), C

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added subscribers: zhizhouy, void. MaskRay added inline comments. Comment at: llvm/tools/opt/opt.cpp:281 +static cl::opt EnableCallGraphProfile( +"enable-call-graph-profile", cl::init(true), cl::Hidden, If there is no strong need for tuning this, pl

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

sammccall added a comment. > can emit diagnostics at this callback (as mentioned in the comments). I'm a bit puzzled about this. The case that the code handles and the comment refers to is if a check installs PPCallbacks and overrides EndSourceFile. And I believe the existing code is ok for thi

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

kadircet added a comment. In D83178#2131914 , @sammccall wrote: > > can emit diagnostics at this callback (as mentioned in the comments). > > I'm a bit puzzled about this. The case that the code handles and the comment > refers to is if a check installs P

[clang] a378c04 - [Fuchsia] Set projects and runtimes in the cache file

Author: Petr Hosek Date: 2020-07-05T14:48:52-07:00 New Revision: a378c0449507e00e96534ff9ce9034e185425182 URL: https://github.com/llvm/llvm-project/commit/a378c0449507e00e96534ff9ce9034e185425182 DIFF: https://github.com/llvm/llvm-project/commit/a378c0449507e00e96534ff9ce9034e185425182.diff LO

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

sammccall added a comment. In D83178#2131976 , @sammccall wrote: > Maybe this originally worked and there was another change at some point that > broke it. Initial commit looks pretty broken at first glance though: https://github.com/llvm/llvm-project/

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zhizhouy added inline comments. Comment at: llvm/tools/opt/opt.cpp:281 +static cl::opt EnableCallGraphProfile( +"enable-call-graph-profile", cl::init(true), cl::Hidden, MaskRay wrote: > If there is no strong need for tuning this, please delete the option an

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D83178#2131948 , @kadircet wrote: > In D83178#2131914 , @sammccall wrote: > > > > can emit diagnostics

[PATCH] D81514: [Fuchsia] Set projects and runtimes in the cache file

This revision was automatically updated to reflect the committed changes. Closed by commit rGa378c0449507: [Fuchsia] Set projects and runtimes in the cache file (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D81514?vs=269692&id=275579#toc Repository: rG LLVM Github M

[PATCH] D83183: [clang] Rework how and when APValues are dumped

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, steveire, ilya-biryukov, sammccall, martong. riccibruno added a project: clang. Herald added subscribers: cfe-commits, rnkovacs. Currently `APValue`s are dumped as a single string. This becomes quickly completely unread

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added inline comments. Comment at: llvm/tools/opt/opt.cpp:281 +static cl::opt EnableCallGraphProfile( +"enable-call-graph-profile", cl::init(true), cl::Hidden, zhizhouy wrote: > MaskRay wrote: > > If there is no strong need for tuning this, please d

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:347 // FIXME: the PP callbacks skip the entire preamble. // Checks that want to see #includes in the main file do not see them. Check->registerPPCallbacks(Clang->getSourceManag

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zhizhouy added inline comments. Comment at: llvm/tools/opt/opt.cpp:281 +static cl::opt EnableCallGraphProfile( +"enable-call-graph-profile", cl::init(true), cl::Hidden, MaskRay wrote: > zhizhouy wrote: > > MaskRay wrote: > > > If there is no strong need for

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge added reviewers: sammccall, kadircet, hokein. nridge added a comment. Adding some reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 ___ cfe-comm

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

njames93 added a comment. We should also disable any header-guard related checks. Currently with this patch llvm-header-guard will fire on every header file as no macros get marked as being used for header guards by the pre processor. I'm guessing this is preamble related. Repository: rG LL

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

sammccall added a comment. In D83178#2132034 , @njames93 wrote: > We should also disable any header-guard related checks. Currently with this > patch llvm-header-guard will fire on every header file as no macros get > marked as being used for header guar

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added inline comments. Comment at: llvm/tools/opt/opt.cpp:281 +static cl::opt EnableCallGraphProfile( +"enable-call-graph-profile", cl::init(true), cl::Hidden, zhizhouy wrote: > MaskRay wrote: > > zhizhouy wrote: > > > MaskRay wrote: > > > > If ther

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

hoyFB added a comment. Thanks for the quick turnaround! I confirm the change fixes our build break. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:313 { \ SmallVector ArgsTypes({__VA_ARGS__})

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

echristo added reviewers: chandlerc, asbirlea. echristo added a comment. Adding Chandler and Alina here as well. In general, I don't think that this is such a great idea. Being able to have this sort of thing work more reliably is one of the reasons for the new pass manager. I think I'd like to

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

vsk requested changes to this revision. vsk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: Please factor out OptCustom

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. Another weird formatting when direct-initializing a variable with a non-parenthesized requires-expression: constexpr void test_width() { bool invalid_rep{!requires {typename jge::width; } } ; } vs constexpr void test_width() { bool invalid_

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

aeubanks added a comment. In D83013#2132070 , @echristo wrote: > Adding Chandler and Alina here as well. > > In general, I don't think that this is such a great idea. Being able to have > this sort of thing work more reliably is one of the reasons for the

Re: [PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

On Sun, Jul 5, 2020 at 8:47 PM Arthur Eubanks via Phabricator < revi...@reviews.llvm.org> wrote: > aeubanks added a comment. > > In D83013#2132070 , @echristo > wrote: > > > Adding Chandler and Alina here as well. > > > > In general, I don't think that this

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 275586. dang added a comment. Revert accidental namespace removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td clang/l

[clang] 8849831 - [Coroutines] Warning if return type of coroutine_handle::address is not void*

Author: Chuanqi Xu Date: 2020-07-06T13:46:01+08:00 New Revision: 8849831d55a203eca1069a0e11877ab7e7e0ac57 URL: https://github.com/llvm/llvm-project/commit/8849831d55a203eca1069a0e11877ab7e7e0ac57 DIFF: https://github.com/llvm/llvm-project/commit/8849831d55a203eca1069a0e11877ab7e7e0ac57.diff LO

[PATCH] D82442: [Coroutines] Warning if the return type of coroutine_handle::address is not void*

This revision was automatically updated to reflect the committed changes. Closed by commit rG8849831d55a2: [Coroutines] Warning if return type of coroutine_handle::address is not void* (authored by ChuanqiXu, committed by junparser). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang marked 5 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:150 -static llvm::Optional normalizeSimpleEnum(OptSpecifier Opt, -unsigned TableIndex, d

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 275591. dang marked an inline comment as done. dang added a comment. Address some code review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/incl

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp created this revision. tetsuo-cpp added reviewers: njames93, MaskRay. tetsuo-cpp added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=45189 This patch is adding support for members to the `bugprone-b

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp updated this revision to Diff 275592. tetsuo-cpp added a comment. Remove the unnecessary template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We should not call getFieldOffset on invalid record decls. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:188 + case OO_Comma: + case OO_ArrowStar: +return syntax::NodeKind::UnknownExpression; Actually arrow star is treated like a normal binary operator in the [[ https://eel.i