sstefan1 marked an inline comment as done.
sstefan1 added a subscriber: hoyFB.
sstefan1 added a comment.
Since this is not a small change, I think it would be good if @hoyFB could test
if this resolves the issue.
There is one small issue though:
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:313
{
\
SmallVector<Type *, 8> ArgsTypes({__VA_ARGS__});
\
Function *F = M.getFunction(_Name);
\
----------------
I wasn't sure how to handle `__VA_ARGS__` here, since we would need
`OMPBuilder` in front of every type.
That is why helper macros above exist. The problem with this is that this
creates some unused variables in `OpenMPOpt`.
Not sure if `-Wno-unused-variable` would be a good thing to do temporarily? Is
there another way to handle `__VA_ARGS__` here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83176/new/
https://reviews.llvm.org/D83176
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
