[PATCH] D82668: [AArch64][SVE] clang: Add missing svbfloat16_t tests

c-rhodes added inline comments. Comment at: clang/test/CodeGenCXX/aarch64-sve-typeinfo.cpp:4 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu %s -emit-llvm -o - \ -// RUN: -target-feature +sve | FileCheck %s +// RUN: -target-feature +sve,+bf16 | FileCheck %s -

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS aprantl wrote: > ap

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-faster-string-find.rst:27 + ``::std::basic_string`` and ``::std::basic_string_view`` are considered. + The list of methods to consired is fixed. I'm not

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274054. djtodoro added a comment. -Update the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/

[clang] ce1fa20 - [Driver] When forcing a crash print the bug report message

Author: John Brawn Date: 2020-06-29T13:13:12+01:00 New Revision: ce1fa201af77e60d31b48571ffa1f85b919f6245 URL: https://github.com/llvm/llvm-project/commit/ce1fa201af77e60d31b48571ffa1f85b919f6245 DIFF: https://github.com/llvm/llvm-project/commit/ce1fa201af77e60d31b48571ffa1f85b919f6245.diff LO

[PATCH] D82668: [AArch64][SVE] clang: Add missing svbfloat16_t tests

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82668/new/ https://reviews.llvm.org/D82668

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1fa201af77: [Driver] When forcing a crash print the bug report message (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/

[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

njames93 added a comment. In D82711#2119651 , @aaron.ballman wrote: > I do not understand the justification here -- `IdentifierNamingCheck` and > `NamedParameterCheck` are two different checks. How do you know that this > swap continues to honor the HIC

[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D82711#2119714 , @njames93 wrote: > In D82711#2119651 , @aaron.ballman > wrote: > > > I do no

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler updated this revision to Diff 274071. ckandeler added a comment. Fixed formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82629/new/ https://reviews.llvm.org/D82629 Files: clang/test/Index/evaluate-cursor.cpp clang/tool

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus added a comment. Note to self: rename `debug.DumpLiveStmts` to `debug.DumpLiveExprs`. Thanks for the review btw! I don't immediately have something to add to your discussion though :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82598/n

[PATCH] D82760: RecursiveASTVisitor: inline a macro that is only used once

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: eduucaldas, ymandel. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82760 Files: clang/include/clang/AST/RecursiveASTVisitor.h Index: clang/inc

[PATCH] D81728: [InstCombine] Add target-specific inst combining

nhaehnle added a comment. We've been handling target-specific intrinsics in InstCombine for a long time, and that's the place where they should naturally sit. This is a pretty clean refactoring in my opinion, I'm in favor. It's substantial enough as a change that it should probably receive a he

[clang] bd46a56 - [OpenCL] Reject block arguments

Author: Sven van Haastregt Date: 2020-06-29T14:13:12+01:00 New Revision: bd46a56474d3b27a4fb520503d5714e23097d495 URL: https://github.com/llvm/llvm-project/commit/bd46a56474d3b27a4fb520503d5714e23097d495 DIFF: https://github.com/llvm/llvm-project/commit/bd46a56474d3b27a4fb520503d5714e23097d495.

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

c-rhodes updated this revision to Diff 274081. c-rhodes added a comment. Changes: - Cover all indexes in get/set ACLE tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82665/new/ https://reviews.llvm.org/D82665 Files: clang/include/clang/Basic/arm_sve.td clang/test/CodeGen/aarch

[PATCH] D82313: [OpenCL] Reject block arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd46a56474d3: [OpenCL] Reject block arguments (authored by svenvh). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82313/new/

[clang] d1df560 - [Analyzer][StreamChecker] Use BugType instead of BuiltinBug (NFC) .

Author: Balázs Kéri Date: 2020-06-29T15:37:13+02:00 New Revision: d1df56023132914b877e34f6cf475758a96540f2 URL: https://github.com/llvm/llvm-project/commit/d1df56023132914b877e34f6cf475758a96540f2 DIFF: https://github.com/llvm/llvm-project/commit/d1df56023132914b877e34f6cf475758a96540f2.diff L

[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. A bunch of clang-format, plus 1 odd looking equation, otherwise this like good. Comment at: llvm/lib/Support/X86TargetParser.cpp:27 +class FeatureBitset { + static c

[PATCH] D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj"

gribozavr created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. gribozavr2 added a reviewer: erichkeane. erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at

[PATCH] D82764: [NFC] Fixed ignored .hip test.

dfukalov created this revision. dfukalov added a reviewer: hliao. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82764 Files: clang/test/CodeGenHIP/lit.local.cfg Index: clang/test/CodeGenHIP/lit.lo

[PATCH] D82767: clang-format: Explicitly use python3

arsenm created this revision. arsenm added reviewers: djasper, compnerd. Herald added a subscriber: wdng. On Ubuntu 20.04, /usr/bin/env python always fails and requires explicitly choosing python2 or python3. Grep shows there are a lot of other places still relying on the old, sensible be

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

fpetrogalli added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:1 -; RUN: llc -mtriple aarch64 -mattr=+sve -asm-verbose=1 < %s | FileCheck %s +; RUN: llc -mtriple aarch64 -mattr=+sve,+bf16 -asm-verbose=1 < %s | FileCheck %s -

[PATCH] D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj"

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/CMakeLists.txt:10 if (MSVC) + set_source_files_properties(RecursiveASTVisitorTests/Callbacks.cpp PROPERTIES COMPILE_FLAGS /

[PATCH] D82741: [Analyzer][StreamChecker] Use BugType instead of BuiltinBug (NFC) .

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1df56023132: [Analyzer][StreamChecker] Use BugType instead of BuiltinBug (NFC) . (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82741

[clang] 0c332a7 - [clang-format] Preserve whitespace in selected macros

Author: Jake Merdich Date: 2020-06-29T09:57:47-04:00 New Revision: 0c332a7784c649038bd237a60fa18b45a3dea90d URL: https://github.com/llvm/llvm-project/commit/0c332a7784c649038bd237a60fa18b45a3dea90d DIFF: https://github.com/llvm/llvm-project/commit/0c332a7784c649038bd237a60fa18b45a3dea90d.diff

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 274097. Conanap marked an inline comment as done. Conanap added a comment. Reordered some declarations in test cases and removed unecessary extra CHECKs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c332a7784c6: [clang-format] Preserve whitespace in selected macros (authored by JakeMerdichAMD). Changed prior to commit: https://reviews.llvm.org/D82620?vs=273722&id=274102#toc Repository: rG LLVM

[clang-tools-extra] 1f228e5 - [clang-tidy] Fix hicpp-named-paramater

Author: Nathan James Date: 2020-06-29T15:28:09+01:00 New Revision: 1f228e572da238c656958bf7f85b371d773eb588 URL: https://github.com/llvm/llvm-project/commit/1f228e572da238c656958bf7f85b371d773eb588 DIFF: https://github.com/llvm/llvm-project/commit/1f228e572da238c656958bf7f85b371d773eb588.diff

[clang] fefa34f - [CodeGen] Use the common semantic for fixed-point codegen, not the result semantic.

Author: Bevin Hansson Date: 2020-06-29T16:22:29+02:00 New Revision: fefa34faf551d10967cf2547003f2dd1b2efa887 URL: https://github.com/llvm/llvm-project/commit/fefa34faf551d10967cf2547003f2dd1b2efa887 DIFF: https://github.com/llvm/llvm-project/commit/fefa34faf551d10967cf2547003f2dd1b2efa887.diff

[PATCH] D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj"

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/CMakeLists.txt:10 if (MSVC) + set_source_files_properties(RecursiveASTVisitorTests/Callbacks.cpp PROPERTIES COMPILE_FLAGS /bigobj) set_source_files_properties(RecursiveASTVisitorTest.cpp PROPERTIES COMPI

[PATCH] D82764: [NFC] Fixed ignored .hip test.

hliao accepted this revision. hliao added a comment. This revision is now accepted and ready to land. Thanks for catching that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82764/new/ https://reviews.llvm.org/D82764

[PATCH] D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj"

gribozavr updated this revision to Diff 274108. gribozavr added a comment. Order lines alphabetically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82766/new/ https://reviews.llvm.org/D82766 Files: clang/unittests/Tooling/CMakeLists.txt Index

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane updated this revision to Diff 274106. erichkeane marked 6 inline comments as done. erichkeane added a comment. Do all feedback as @craig.topper recommended. Instead of using 'find', I was able to use 'lookup' on the map, which seemed to be exactly what I want. CHANGES SINCE LAST ACT

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. In D82188#2119393 , @njames93 wrote: > @thakis Do those bots use `gn`, could that be the cause of the failures? It's possible, but unlikely, given that your change doesn't touch any build files. …and indeed, I checked out `8f73c

[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f228e572da2: [clang-tidy] Fix hicpp-named-paramater (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82711/new/ https://reviews.llvm.o

[PATCH] D82662: [CodeGen] Use the common semantic for fixed-point codegen, not the result semantic.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfefa34faf551: [CodeGen] Use the common semantic for fixed-point codegen, not the result… (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] e22cae3 - [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

Author: Balazs Benics Date: 2020-06-29T16:54:17+02:00 New Revision: e22cae32c5c4cf8c49b674cea34c105a6cb015f9 URL: https://github.com/llvm/llvm-project/commit/e22cae32c5c4cf8c49b674cea34c105a6cb015f9 DIFF: https://github.com/llvm/llvm-project/commit/e22cae32c5c4cf8c49b674cea34c105a6cb015f9.diff

[clang] a44425f - Revert "[analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor"

Author: Dmitri Gribenko Date: 2020-06-29T17:00:15+02:00 New Revision: a44425f25b5ca417e7ecee6e7e00040224e50a69 URL: https://github.com/llvm/llvm-project/commit/a44425f25b5ca417e7ecee6e7e00040224e50a69 DIFF: https://github.com/llvm/llvm-project/commit/a44425f25b5ca417e7ecee6e7e00040224e50a69.dif

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

baloghadamsoftware requested changes to this revision. baloghadamsoftware added inline comments. This revision now requires changes to proceed. Herald added a subscriber: rnkovacs. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:55 + // they can cause a not nul

[PATCH] D82226: Add Metadata to Transformer tooling

asoffer added a comment. I'm not against a map, but I don't see the need for it right now. We don't have multiple stages that write to the same AtomicChange in any tool I'm aware of. Given that these are immutable after construction, I think just the Any is simpler. So long as we're willing to

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

hokein created this revision. hokein added reviewers: klimek, sammccall. Herald added a project: clang. D80025 introduced a performance regression: in some cases, it makes clang-tidy readability-container-size-empty ~80x slower (running on an internal huge TU, be

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-faster-string-find.rst:27 + ``::std::basic_string`` and ``::std::basic_string_view`` are considered. + The list of methods to consired

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

kees added a comment. Should the per-function analysis warning actually be removed? That seems like a helpful check to catch a different form of bad behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

Quuxplusone added a comment. In D82736#2119262 , @sammccall wrote: > `viewWithDefaultCWD` suggests to me the default has some semantics which > don't exist, if using this API "shape" I'd substitute `Arbitrary` here I'm naturally 100% fine with that. I c

[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google-module.cpp:4 +// CHECK-DAG: {{- key: *google-readability-braces-around-statements.ShortStatementLines[[:space:]] value: *'1'}} +// CHECK-DAG:

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

gribozavr2 added a comment. I reverted your commit because it seemed to have broken the build: FalsePositiveRefutationBRVisitorTest.cpp:112:3: error: use of undeclared identifier 'LLVM_WITH_Z3' https://github.com/llvm/llvm-project/commit/a44425f25b5ca417e7ecee6e7e00040224e50a69 CHANGES SINC

[clang] 1cf2e45 - Compile the RecursiveASTVisitor callbacks test with "/bigobj"

Author: Dmitri Gribenko Date: 2020-06-29T17:04:45+02:00 New Revision: 1cf2e45c19ffc0635c96279779df43ba51630bba URL: https://github.com/llvm/llvm-project/commit/1cf2e45c19ffc0635c96279779df43ba51630bba DIFF: https://github.com/llvm/llvm-project/commit/1cf2e45c19ffc0635c96279779df43ba51630bba.dif

[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files

njames93 updated this revision to Diff 274129. njames93 added a comment. Remove unnecessary test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D78759: Add Statically Linked Libraries

ashi1 added a comment. Hi Jon, I may have committed this in combination with D81963 as the parent commit. It should have waited for a LGTM from someone outside our org. Please let me know unaddressed comments on this change, and I will fix them asap. Sorry abo

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rGe22cae32c5c4: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D78704?vs=260104&id=274133#toc Repository: rG

[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG860aefd0784e: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files (authored by njames93). Re

[PATCH] D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj"

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cf2e45c19ff: Compile the RecursiveASTVisitor callbacks test with "/bigobj" (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82766/new/

[clang-tools-extra] 860aefd - [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files

Author: Nathan James Date: 2020-06-29T16:05:52+01:00 New Revision: 860aefd0784ed05ffc0d56f36b0d56009776002a URL: https://github.com/llvm/llvm-project/commit/860aefd0784ed05ffc0d56f36b0d56009776002a DIFF: https://github.com/llvm/llvm-project/commit/860aefd0784ed05ffc0d56f36b0d56009776002a.diff

[clang] 58f2be9 - RecursiveASTVisitor: inline a macro that is only used once

Author: Dmitri Gribenko Date: 2020-06-29T17:06:30+02:00 New Revision: 58f2be9671a802acda2f74d2d8105a59ed119933 URL: https://github.com/llvm/llvm-project/commit/58f2be9671a802acda2f74d2d8105a59ed119933 DIFF: https://github.com/llvm/llvm-project/commit/58f2be9671a802acda2f74d2d8105a59ed119933.dif

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-faster-string-find.rst:27 + ``::std::basic_string`` and ``::std::basic_string_view`` are considered. + The list of methods to consired is fixed. njames93

[PATCH] D81728: [InstCombine] Add target-specific inst combining

arsenm added a comment. I think an interface usable by InstructionSimplify would be helpful too, so I think that would be a separate thing from TTI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81728/new/ https://reviews.llvm.org/D81728 ___

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

c-rhodes added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:100 + +define @test_svcreate2_bf16_vec0(i1 %p, %z0, %z1) local_unnamed_addr #0 { +; CHECK-LABEL: test_svcreate2_bf16_vec0: fpetrogalli wrote: > nit: remove `lo

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

kees added a comment. Specifically, this appears to be a legitimate bug, found by the warnings: https://bugs.llvm.org/show_bug.cgi?id=46258 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791 ___

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:577-583 + CheckerOptions<[ +CmdLineOption, + ]>, Szelethus wrote: > This goes against D81750 -- Sorry for not bringing this up earlier, but you > can't emit diag

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

c-rhodes updated this revision to Diff 274138. c-rhodes added a comment. Changes: - Use function attribute for `+bf16` target feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82665/new/ https://reviews.llvm.org/D82665 Files: clang/include/clang/Basic/arm_sve.td clang/test/Co

[clang] 8cc722f - [NFC] Fixed ignored .hip test.

Author: dfukalov Date: 2020-06-29T18:57:14+03:00 New Revision: 8cc722ffc749b83fcd9f55264ee359ff41cb0ac8 URL: https://github.com/llvm/llvm-project/commit/8cc722ffc749b83fcd9f55264ee359ff41cb0ac8 DIFF: https://github.com/llvm/llvm-project/commit/8cc722ffc749b83fcd9f55264ee359ff41cb0ac8.diff LOG:

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

NoQ added a comment. In D82598#2119545 , @xazax.hun wrote: > > Given that we'd also barely ever notice that we forgot one of those, i'm > > very much in favor of having liveness analysis instead, that would > > declaratively describe which expressions ar

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

klimek added a comment. In what situation are we calling child matchers repeatedly with the same matcher on the same node? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82771/new/ https://reviews.llvm.org/D82771

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss added a comment. Function level attributes could set different attributes for functions. If function attribute is used then I assume the user know what he/she is doing so no need to emit a warning. Maybe some would ensure the function is only directly called and never called indirect

[PATCH] D82760: RecursiveASTVisitor: inline a macro that is only used once

This revision was automatically updated to reflect the committed changes. Closed by commit rG58f2be9671a8: RecursiveASTVisitor: inline a macro that is only used once (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82760/new/ h

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

klimek added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:467 Key.Traversal = Ctx.getParentMapContext().getTraversalKind(); -Key.Type = MatchType::Descendants; +// Memorize result even doing a single-level match, it might be expensive. +K

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:577-583 + CheckerOptions<[ +CmdLineOption, + ]>, NoQ wrote: > Szelethus wrote: > > This goes against D81750 -- Sorry for not bringing this up earlier, but y

[PATCH] D81169: [clangd] Improve hover on arguments to function call

adamcz updated this revision to Diff 274147. adamcz marked 8 inline comments as done. adamcz added a comment. Addressed review comments, also added some "const" here and there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81169/new/ https://review

[PATCH] D81169: [clangd] Improve hover on arguments to function call

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:721 +// Extract matching argument from function declaration. +if (const ParmVarDecl *PVD = FD->getParamDecl(I)) { + HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, Policy));

[PATCH] D82777: Clang Driver: Use Apple ld64's new @response-file support.

jyknight created this revision. jyknight added reviewers: steven_wu, arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. jyknight added a child revision: D82782: Clang Driver: refactor support for writing response files to be specified at Command creation, r

[PATCH] D82782: Clang Driver: refactor support for writing response files to be specified at Command creation, rather than as part of the Tool.

jyknight created this revision. jyknight added reviewers: rnk, arphaman, steven_wu. Herald added subscribers: cfe-commits, sstefan1, kerbowa, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, mstorsjo, jocewei, PkmX, dexonsmith, the_o, brucehoult, MartinMosbeck, rogfer01, edwar

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

olestrohm created this revision. olestrohm added reviewers: Anastasia, rjmccall. olestrohm added a project: clang. Herald added a subscriber: yaxunl. This patch fixes two instances of not deducing address spaces for global template variables. I've added OpenCL address space deduction to the funct

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

This revision was automatically updated to reflect the committed changes. Closed by commit rG67e4330facfb: [sve][acle] Implement some of the C intrinsics for brain float. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82345/

[clang] 67e4330 - [sve][acle] Implement some of the C intrinsics for brain float.

Author: Francesco Petrogalli Date: 2020-06-29T16:09:08Z New Revision: 67e4330facfbf798ecc40cd2449f70e6758078b9 URL: https://github.com/llvm/llvm-project/commit/67e4330facfbf798ecc40cd2449f70e6758078b9 DIFF: https://github.com/llvm/llvm-project/commit/67e4330facfbf798ecc40cd2449f70e6758078b9.dif

[PATCH] D82764: [NFC] Fixed ignored .hip test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc722ffc749: [NFC] Fixed ignored .hip test. (authored by dfukalov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82764/new/ https://reviews.llvm.org/D8276

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

fpetrogalli updated this revision to Diff 274149. fpetrogalli added a comment. Rebase on top of master. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82345/new/ https://reviews.llvm.org/D82345 Files: clang/include/clang/Basic/arm_sve.td cl

[PATCH] D82696: [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82696/new/ https://reviews.llvm.org/D82696 ___ cfe-commits mailing list cfe-com

[PATCH] D71033: [analyzer] CERT STR rule checkers: STR32-C

baloghadamsoftware requested changes to this revision. baloghadamsoftware added inline comments. This revision now requires changes to proceed. Herald added a subscriber: rnkovacs. Comment at: clang/docs/analyzer/checkers.rst:1982 +It warns on reading non-null-terminated strings.

[PATCH] D82784: [clang-tidy] For `run-clang-tidy.py` do not treat `allow_enabling_alpha_checkers` as a none value.

Abpostelnicu created this revision. Abpostelnicu added a reviewer: JonasToth. Herald added subscribers: cfe-commits, Charusso, xazax.hun. Herald added a project: clang. Abpostelnicu edited the summary of this revision. `allow_enabling_alpha_checkers` will never be None, it will be `True` or `Fals

[clang] fe0a555 - [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

Author: Balazs Benics Date: 2020-06-29T18:18:43+02:00 New Revision: fe0a555aa3c6f37a5b5d79942215b07587893efa URL: https://github.com/llvm/llvm-project/commit/fe0a555aa3c6f37a5b5d79942215b07587893efa DIFF: https://github.com/llvm/llvm-project/commit/fe0a555aa3c6f37a5b5d79942215b07587893efa.diff

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82665/new/ https://reviews.llvm.org/D82665 ___ cfe-commits mail

[PATCH] D82668: [AArch64][SVE] clang: Add missing svbfloat16_t tests

fpetrogalli accepted this revision. fpetrogalli added a comment. Ship it! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82668/new/ https://reviews.llvm.org/D82668 ___ cfe-commits mailing list cfe-co

[PATCH] D71155: [analyzer] CERT STR rule checkers: STR30-C

baloghadamsoftware requested changes to this revision. baloghadamsoftware added inline comments. This revision now requires changes to proceed. Herald added a subscriber: rnkovacs. Comment at: clang/docs/analyzer/checkers.rst:1973 +``strpbrk()``, ``strchr()``, ``strrchr()``, ``st

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

Anastasia added a comment. So if I understand this correctly when the template is instantiated we don't have `QualType` with the address space deduced initially during parsing of a template global variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D82722: [OpenMP][IRBuilder] Support nested parallel regions

jdoerfert added a comment. In D82722#2118958 , @fghanim wrote: > Thanks for working on this. LGTM. > Did you make any changes other than splitting from D82470 > ? No. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82787 Files: clang/include/clang/AST/RecursiveASTVisitor.h clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp I

[clang] 1ef75f5 - [AArch64][SVE] clang: Add missing svbfloat16_t tests

Author: Cullen Rhodes Date: 2020-06-29T16:48:53Z New Revision: 1ef75f53e9e6aeb35a1d46798b3063192ee86f0f URL: https://github.com/llvm/llvm-project/commit/1ef75f53e9e6aeb35a1d46798b3063192ee86f0f DIFF: https://github.com/llvm/llvm-project/commit/1ef75f53e9e6aeb35a1d46798b3063192ee86f0f.diff LOG:

[clang] de361df - [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug

Author: Balazs Benics Date: 2020-06-29T18:51:24+02:00 New Revision: de361df3f6d0f20bf16a8deb9e6219556d028b81 URL: https://github.com/llvm/llvm-project/commit/de361df3f6d0f20bf16a8deb9e6219556d028b81 DIFF: https://github.com/llvm/llvm-project/commit/de361df3f6d0f20bf16a8deb9e6219556d028b81.diff

[clang] e73c3bb - [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

Author: Cullen Rhodes Date: 2020-06-29T17:00:58Z New Revision: e73c3bb06b5a35d13cf96d574ce3b849c5d3d56d URL: https://github.com/llvm/llvm-project/commit/e73c3bb06b5a35d13cf96d574ce3b849c5d3d56d DIFF: https://github.com/llvm/llvm-project/commit/e73c3bb06b5a35d13cf96d574ce3b849c5d3d56d.diff LOG:

[PATCH] D82722: [OpenMP][IRBuilder] Support nested parallel regions

fghanim added a comment. OK. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82722/new/ https://reviews.llvm.org/D82722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.

craig.topper updated this revision to Diff 274161. craig.topper added a comment. -Run clang-format. Some lines in the table are still slightly over 80 columns. -Fix the number of words in the FeatureBitset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug

This revision was automatically updated to reflect the committed changes. Closed by commit rGde361df3f6d0: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/n

[PATCH] D82668: [AArch64][SVE] clang: Add missing svbfloat16_t tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ef75f53e9e6: [AArch64][SVE] clang: Add missing svbfloat16_t tests (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82668/new/ https://

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGe73c3bb06b5a: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82665/

[PATCH] D82777: Clang Driver: Use Apple ld64's new @response-file support.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. Agree this is ugly but the clean up looks fine. Not sure how to write a test as well but I can see the `@` file path is triggered correctly. Repository: rG LLVM Github Monorepo

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

nickdesaulniers added a comment. In D80791#2120090 , @kees wrote: > Should the per-function analysis warning actually be removed? That seems like > a helpful check to catch a different form of bad behavior. Might someone wish to disable PAC/BTI on an in

[PATCH] D82782: Clang Driver: refactor support for writing response files to be specified at Command creation, rather than as part of the Tool.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82782/new/ https://reviews.llvm.org/D82782

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

arphaman added a comment. I'll fix up Clang.Preprocessor::aarch64-target-features.c test this morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new/ https://reviews.llvm.org/D82699 ___ cfe-c

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. In D82188#2119980 , @thakis wrote: > In this case, trunk was broken for > 12h, so I'd expect there's lots of > evidence of this being broken on cmake bots too. However, the mac bots aren't > on buildbot but on http://green.lab.l

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

JDevlieghere added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:477 + Note: on Darwin, when using :option:`-flto` along with :option:`-g` and + compiling and linking in separate steps, you also need to pass Any reason not to use the sphinx n

<    1   2   3   >