fpetrogalli added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:1
-; RUN: llc -mtriple aarch64 -mattr=+sve -asm-verbose=1 < %s | FileCheck %s
+; RUN: llc -mtriple aarch64 -mattr=+sve,+bf16 -asm-verbose=1 < %s | FileCheck
%s
----------------
I think you should use the function attribute trick in this test, not the
command line option, like we have done in other tests.
================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:100
+
+define <vscale x 8 x bfloat> @test_svcreate2_bf16_vec0(i1 %p, <vscale x 8 x
bfloat> %z0, <vscale x 8 x bfloat> %z1) local_unnamed_addr #0 {
+; CHECK-LABEL: test_svcreate2_bf16_vec0:
----------------
nit: remove `local_unnamed_addr ` from all tests you have added.
================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:109
+L2:
+ %extract = tail call <vscale x 8 x bfloat>
@llvm.aarch64.sve.tuple.get.nxv8bf16.nxv16bf16(<vscale x 16 x bfloat> %tuple,
i32 0)
+ ret <vscale x 8 x bfloat> %extract
----------------
out of curiosity.... why not test the create intrinsic directly?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82665/new/
https://reviews.llvm.org/D82665
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
