[clang] 12665f2 - [X86] Make XSAVEC/XSAVEOPT/XSAVES properly depend on XSAVE in both the frontend and the backend.

Author: Craig Topper Date: 2020-06-26T00:14:58-07:00 New Revision: 12665f28129a7aefc635dc36d6fe0ad26583dd8a URL: https://github.com/llvm/llvm-project/commit/12665f28129a7aefc635dc36d6fe0ad26583dd8a DIFF: https://github.com/llvm/llvm-project/commit/12665f28129a7aefc635dc36d6fe0ad26583dd8a.diff

[clang] ae47d15 - Remove "rm -f" workaround in acle_sve_adda.c

Author: David Sherwood Date: 2020-06-26T08:16:40+01:00 New Revision: ae47d158a096abad43d8f9056518d83b66c5a4b7 URL: https://github.com/llvm/llvm-project/commit/ae47d158a096abad43d8f9056518d83b66c5a4b7 DIFF: https://github.com/llvm/llvm-project/commit/ae47d158a096abad43d8f9056518d83b66c5a4b7.diff

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. Can you remove the duplicate tests before submitting? Otherwise LGTM! Comment at: llvm/test/CodeGen/AArch64/sve-bitcast-bfloat.ll:8 + +define @bitcast_bfloat_to_i8( %v

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82498/new/ https://reviews.llvm.org/D82498 __

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas added a comment. In D82312#2116028 , @vvereschaka wrote: > Hello Eduardo, > > sorry, but one of your these commits break the clang unit tests on the > following builders: > > - http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

curdeius added inline comments. Comment at: clang/include/clang/Format/Format.h:533 + /// If ``true``, always break before concept declarations + bool AlwaysBreakBeforeConceptDeclarations; It would be nice to have an example here in the doc. ===

[PATCH] D82497: [Clang][SourceManager] optimize getFileIDLocal()

kadircet added a comment. For the record: http://llvm-compile-time-tracker.com/compare.php?from=ed8184b7814df4310dbad065a9a1c3bb8f3bfa86&to=408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3&stat=instructions https://photos.app.goo.gl/fJUS5jrMaJjvvmo1A Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D82626: [CodeComplete] Tweak completion for else.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. If an `if` statement uses braces for its `then` block, suggest braces for the `else` and `else if` completion blocks, Otherwise don't suggest them.

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2706 + + For example: STRINGIZE + Shouldn't there be a configuration example like what's in `ForEachMacros` doc? ``` In the .clang-format configuration file, this can be configu

[clang-tools-extra] 1a30eab - Prevent unused error when assertions are disabled.

Author: Tres Popp Date: 2020-06-26T10:12:04+02:00 New Revision: 1a30eab413cefb18e733ef6aec42dc04a4a76592 URL: https://github.com/llvm/llvm-project/commit/1a30eab413cefb18e733ef6aec42dc04a4a76592 DIFF: https://github.com/llvm/llvm-project/commit/1a30eab413cefb18e733ef6aec42dc04a4a76592.diff LOG

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

gamesh411 added a comment. In D82561#2116091 , @balazske wrote: > In D82561#2115578 , @xazax.hun wrote: > > > The analyzer inlines small functions within a TU regardless of the > > thresholds. I think it would be s

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1856 + Selector IsKindOfClassSel = C.Selectors.getSelector( + llvm::array_lengthof(IsKindOfClassII), &IsKindOfClassII[0]); + CallArgList IsKindOfClassArgs; Can you use `Ge

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

atrosinenko added a comment. Meanwhile, msp430-gcc v9.2.0 was released on Jun 12. Will recheck against the new version slightly later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new

[clang] 834c718 - [CodeComplete] Tweak code completion for `typename`.

Author: Kadir Cetinkaya Date: 2020-06-26T10:32:12+02:00 New Revision: 834c71829cc2e22841bf75e86b988c46252c70dc URL: https://github.com/llvm/llvm-project/commit/834c71829cc2e22841bf75e86b988c46252c70dc DIFF: https://github.com/llvm/llvm-project/commit/834c71829cc2e22841bf75e86b988c46252c70dc.dif

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. this seems to be failing to merge, could you rebase on top of head? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

martong accepted this revision. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:324 "for import when inlining functions during CTU analysis. " "Lowering this threshold can alleviate the memor

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler created this revision. ckandeler added a reviewer: milianw. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. When a variable-length array is being captured in a lambda, the AST contains two captures, the first one having a null init expression. Visiting tha

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG834c71829cc2: [CodeComplete] Tweak code completion for `typename`. (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82373/new/ https://

[PATCH] D82631: [AST][RecoveryAST] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82631 Files: clang/include/clang/AST/NestedNameSpecifier.h clang/lib/AST/NestedNameSpecifier.cpp clang/lib/Sema/SemaDecl.cpp cl

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

xazax.hun added a comment. In D82561#2116194 , @gamesh411 wrote: > In D82561#2116091 , @balazske wrote: > > > That means perform a get CTU definition if the TU to be imported (where the > > function comes from) is

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273631. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeCompletion/or

[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6287 + Style.BreakBeforeTernaryOperators = false; + verifyFormat("int x = aaa ? aa :\n" + "

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

anchu-rajendran added a comment. Herald added a subscriber: rogfer01. The change looks good to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 ___ c

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

xazax.hun added a comment. In D82598#2115656 , @NoQ wrote: > > We could just kill all subexpr at the end of the full expression > > I suspect that it would be pretty bad if you, say, kill the condition of the > `if`-statement before picking the branch. Or

[clang] edcfef8 - [AArch64][SVE] Add bfloat16 support to store intrinsics

Author: Kerry McLaughlin Date: 2020-06-26T11:05:56+01:00 New Revision: edcfef8fee134cf98e0e812a6569c4900045d31c URL: https://github.com/llvm/llvm-project/commit/edcfef8fee134cf98e0e812a6569c4900045d31c DIFF: https://github.com/llvm/llvm-project/commit/edcfef8fee134cf98e0e812a6569c4900045d31c.di

[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is const-compatible. + for (auto &Edit : const_cast(Config::current()).CompileFlags.Edits

[PATCH] D82313: [OpenCL] Reject block arguments

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82313/new/ https://reviews.llvm.org/D82313 ___ cfe-commits mailing lis

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

c-rhodes added a comment. @fpetrogalli thanks for updating! I have a few more comments, sorry I missed a few things yesterday Comment at: clang/include/clang/Basic/arm_sve.td:725-727 + def NAME : SInst; + let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def _BF1

[PATCH] D82578: [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro

sdesmalen accepted this revision. sdesmalen added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82578/new/ https://reviews.llvm.org/D82578 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

gribozavr2 added a comment. @vvereschaka Sorry about that. It looks like a bug in MSVC. I implemented a workaround in https://reviews.llvm.org/D82636 -- please review if you have time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82312/new/ https

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGedcfef8fee13: [AArch64][SVE] Add bfloat16 support to store intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82448/new/ ht

[PATCH] D82636: Work around a bug in MSVC in the syntax tree test

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: eduucaldas, vvereschaka. MSVC does not handle raw string literals with embedded double quotes correctly. I switched the affected test case to use regular string liter

[clang] d45cf91 - [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro

Author: Cullen Rhodes Date: 2020-06-26T10:25:42Z New Revision: d45cf9105b5a88ed03382ffbbfcd54b461f1bb23 URL: https://github.com/llvm/llvm-project/commit/d45cf9105b5a88ed03382ffbbfcd54b461f1bb23 DIFF: https://github.com/llvm/llvm-project/commit/d45cf9105b5a88ed03382ffbbfcd54b461f1bb23.diff LOG:

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 273558. guiand added a comment. Made DetermineNoUndef more robust Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand updated this revision to Diff 273570. guiand retitled this revision from "[Clang/Test]: Update tests where `frozen` attribute is necessary" to "[Clang/Test]: Update tests where `noundef` attribute is necessary". guiand edited the summary of this revision. guiand added a comment. Herald add

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand marked an inline comment as done. guiand added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2082 + const Type *RetTyPtr = RetTy.getTypePtr(); + if (!RetTy->isVoidType() && !RetTyPtr->isRecordType() && + RetAI.getKind() != ABIArgInfo::Indirect) { ---

[PATCH] D82578: [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGd45cf9105b5a: [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D825

[PATCH] D82623: [sve][acle] Enable feature macros for SVE ACLE extensions.

sdesmalen added a comment. Hi @fpetrogalli , I see the patch is still missing a few tests to `clang/test/Preprocessor/aarch64-target-features.c`. Not specifically to be done in this patch, but we'll also needs changes to make sure that the bfloat macros are set for armv8.6 (e.g. `-march=armv8.6

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

hans added a comment. Herald added a subscriber: hiraditya. Would be possible to add some documentation for this flag? From a quick search it's not clear to me what it does and when one is supposed to use it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53891/new

[PATCH] D82642: [clangd] Run formatting operations asynchronously.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. They don't need ASTs or anything, so they should still run immediately. These were sync for

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

SouraVX added a comment. Overall this seems great Thanks! I have one minor concern: This patch seems to do 2 things: Support for nested parallel regions(which was crashing earlier) and some infrastructure change(introducing AllocBuilder..). I'm not sure of this, but is it possible to separate the

[clang] 94e8ec6 - [AST] Add fixed-point division constant evaluation.

Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: 94e8ec631dda98639930c3fcf6b84148cd58cd59 URL: https://github.com/llvm/llvm-project/commit/94e8ec631dda98639930c3fcf6b84148cd58cd59 DIFF: https://github.com/llvm/llvm-project/commit/94e8ec631dda98639930c3fcf6b84148cd58cd59.diff

[clang] da2f852 - [AST] Fix certain consteval assignment and comma operator issues with fixed-point types.

Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: da2f852e1913a16a1c6940ce3d3e47158ae5ba0e URL: https://github.com/llvm/llvm-project/commit/da2f852e1913a16a1c6940ce3d3e47158ae5ba0e DIFF: https://github.com/llvm/llvm-project/commit/da2f852e1913a16a1c6940ce3d3e47158ae5ba0e.diff

[clang] 53f5c8b - [AST] Add fixed-point multiplication constant evaluation.

Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: 53f5c8b4a14c2ef89d44062a3a045be064bdc0e7 URL: https://github.com/llvm/llvm-project/commit/53f5c8b4a14c2ef89d44062a3a045be064bdc0e7 DIFF: https://github.com/llvm/llvm-project/commit/53f5c8b4a14c2ef89d44062a3a045be064bdc0e7.diff

[clang] 474177c - [AST] Improve overflow diagnostics for fixed-point constant evaluation.

Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: 474177c05381a6eb2971e67753481b5efc78d848 URL: https://github.com/llvm/llvm-project/commit/474177c05381a6eb2971e67753481b5efc78d848 DIFF: https://github.com/llvm/llvm-project/commit/474177c05381a6eb2971e67753481b5efc78d848.diff

[clang] eccf7fc - [AST] Add fixed-point subtraction constant evaluation.

Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: eccf7fc7b31a00823a0fe6c782ef312b3ba743c4 URL: https://github.com/llvm/llvm-project/commit/eccf7fc7b31a00823a0fe6c782ef312b3ba743c4 DIFF: https://github.com/llvm/llvm-project/commit/eccf7fc7b31a00823a0fe6c782ef312b3ba743c4.diff

[clang] bb26838 - [clang driver] Move default module cache from system temporary directory

Author: David Zarzycki Date: 2020-06-26T07:46:03-04:00 New Revision: bb26838ceffb5feaa18186f55f7525a08084899e URL: https://github.com/llvm/llvm-project/commit/bb26838ceffb5feaa18186f55f7525a08084899e DIFF: https://github.com/llvm/llvm-project/commit/bb26838ceffb5feaa18186f55f7525a08084899e.diff

[PATCH] D82362: Move default module cache from system temporary directory

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb26838ceffb: [clang driver] Move default module cache from system temporary directory (authored by davezarzycki). Changed prior to commit: https://reviews.llvm.org/D82362?vs=272655&id=273674#toc Repos

[PATCH] D73187: [AST] Add fixed-point division constant evaluation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG94e8ec631dda: [AST] Add fixed-point division constant evaluation. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73187/new/ https://re

[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG474177c05381: [AST] Improve overflow diagnostics for fixed-point constant evaluation. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[PATCH] D73189: [AST] Fix certain consteval assignment and comma operator issues with fixed-point types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda2f852e1913: [AST] Fix certain consteval assignment and comma operator issues with fixed… (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53f5c8b4a14c: [AST] Add fixed-point multiplication constant evaluation. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73186/new/ http

[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeccf7fc7b31a: [AST] Add fixed-point subtraction constant evaluation. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73185/new/ https:/

[clang] f0bab78 - Triple.h - reduce Twine.h include to forward declarations. NFC.

Author: Simon Pilgrim Date: 2020-06-26T13:06:57+01:00 New Revision: f0bab7875e78e01c149d12302dcc4b6d4c43e25c URL: https://github.com/llvm/llvm-project/commit/f0bab7875e78e01c149d12302dcc4b6d4c43e25c DIFF: https://github.com/llvm/llvm-project/commit/f0bab7875e78e01c149d12302dcc4b6d4c43e25c.diff

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:859 + +def Str31cChecker : Checker<"31c">, + HelpText<"SEI CERT checker of rules defined in STR31-C">, Maybe we could have more descriptive names for th

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt:21 CastValueChecker.cpp + cert/StrChecker.cpp CheckObjCDealloc.cpp Are there so many things common among checkers for SEI CERT string rules that the bes

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader added a comment. In D80932#2085848 , @Anastasia wrote: > In D80932#2083185 , @bader wrote: > > > In D80932#2080631 , @Anastasia > > wrote: > > > > > > @Anastasia, if w

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

c-rhodes updated this revision to Diff 273685. c-rhodes added a comment. Changes: - Add tests for bfloat bitcast patterns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82391/new/ https://reviews.llvm.org/D82391 Files: clang/include/clang/Basic/arm_sve.td clang/test/CodeGen/aarch6

[clang] cb56fa2 - [MSP430] Update register names

Author: Anatoly Trosinenko Date: 2020-06-26T15:32:07+03:00 New Revision: cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77 URL: https://github.com/llvm/llvm-project/commit/cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77 DIFF: https://github.com/llvm/llvm-project/commit/cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77.

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

atrosinenko created this revision. atrosinenko added reviewers: krisb, awygle, pftbest. Herald added a project: clang. Assembler output is checked against msp430-gcc 9.2.0.50 from TI. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82646 Files: clang/lib/CodeGen/TargetInfo.cp

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

yaxunl added a comment. Would you please add the following lit test F12245277: diff.pch.txt If you change FastMath, FiniteMathOnly and UnsafeFPMath to COMPATIBLE_LANGOPT, the test should pass. Comment at: clang/include/clang/Basic/LangOpt

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

dfukalov created this revision. dfukalov added reviewers: yaxunl, b-sumner, rampitec. Herald added subscribers: cfe-commits, Anastasia. Herald added a project: clang. With the FAST default FP_CONTRACT mode' setting for `func(float a, float b, float c) { return a + b * c; }` FE generates pair `fmul

[PATCH] D82184: [MSP430] Update register names

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb56fa2196c5: [MSP430] Update register names (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82184/new/ https://r

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4e8f7fe3f38: [builtins] Improve compatibility with 16 bit targets (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc added a comment. In D81869#2116752 , @yaxunl wrote: > Would you please add the following lit test > > F12245277: diff.pch.txt > > If you change FastMath, FiniteMathOnly and UnsafeFPMath to > COMPATIBLE_LANGOPT,

[PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

Cartman0 added a comment. hi! I try to assemble the .asm outputted from `clang-cl` by ML/ML64.exe on windows10. The ".asm" files outputted from `clang-cl /FA` / are supports to assemble by ML/ML64.exe on windows? when assemble by ML64.exe, occured " A2008:syntax error" and A2044:invalid chara

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. This patch improves the error message provided by the stencil that handles source from a range selector. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82654 Files: clang/lib/

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

yaxunl added a comment. I think the point of -ffp-contract=fast is that it allows emitting fma across statements if there are such opportunities whereas -ffp-contract=on only allows fma in one statement https://llvm.org/docs/CompileCudaWithLLVM.html#flags-that-control-numerical-code Repositor

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 273708. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Corrected the comments; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 Files:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16665 // Record the component - we don't have any declaration associated. -Components.emplace_back(OASE, nullptr); +Components.emplace_back(OASE, nullptr, false); return RelevantExpr || Vis

[clang] 0069824 - Revert rGf0bab7875e78e01c149d12302dcc4b6d4c43e25c - "Triple.h - reduce Twine.h include to forward declarations. NFC."

Author: Simon Pilgrim Date: 2020-06-26T14:46:40+01:00 New Revision: 0069824feab0af5ade571d975deb1efd893c2466 URL: https://github.com/llvm/llvm-project/commit/0069824feab0af5ade571d975deb1efd893c2466 DIFF: https://github.com/llvm/llvm-project/commit/0069824feab0af5ade571d975deb1efd893c2466.diff

[clang] 5547a83 - [CodeComplete] Add code completion for using alias.

Author: Kadir Cetinkaya Date: 2020-06-26T15:55:45+02:00 New Revision: 5547a83c0b68a03a806d47782a4d3a6dc3b5d5f5 URL: https://github.com/llvm/llvm-project/commit/5547a83c0b68a03a806d47782a4d3a6dc3b5d5f5 DIFF: https://github.com/llvm/llvm-project/commit/5547a83c0b68a03a806d47782a4d3a6dc3b5d5f5.dif

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Any chance for a test? Comment at: clang/lib/Tooling/Transformer/Stencil.cpp:244 + llvm::make_error_code(errc::invalid_argument) && +

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DO NOT SUBMIT. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CXX/temp/temp.constr/temp.constr.order/funct

[PATCH] D82226: Add Metadata to Transformer tooling

gribozavr2 added a comment. In D82226#2115406 , @asoffer wrote: > I think the tradeoff here is > Dynamic typing -- faster compile times, type safety checked at run-time (in > tests), lower maintenance cost > Templates -- Faster runtime, type safety che

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5547a83c0b68: [CodeComplete] Add code completion for using alias. (authored by kadircet). Repository: rG LLVM Github Mo

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

JakeMerdichAMD marked 10 inline comments as done. JakeMerdichAMD added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2706 + + For example: STRINGIZE + curdeius wrote: > Shouldn't there be a configuration example like what's in `ForEachMacro

[clang] 056a539 - [libTooling] Rename overloaded `range` range selector.

Author: Yitzhak Mandelbaum Date: 2020-06-26T14:23:25Z New Revision: 056a539e570a49e27f88f4555d42f00be0500749 URL: https://github.com/llvm/llvm-project/commit/056a539e570a49e27f88f4555d42f00be0500749 DIFF: https://github.com/llvm/llvm-project/commit/056a539e570a49e27f88f4555d42f00be0500749.diff

[PATCH] D82606: [clangd] Config: config struct propagated through Context

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. oops, thought I've stamped it last time. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is const-compati

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

JakeMerdichAMD updated this revision to Diff 273722. JakeMerdichAMD marked 3 inline comments as done. JakeMerdichAMD added a comment. Address feedback (nits, better docs, more defaults) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

ymandel added a comment. In D82654#2116906 , @gribozavr2 wrote: > Any chance for a test? StencilTest.CatOfInvalidRangeFails essentially covers this (indeed, earlier versions of the code failed this test). https://github.com/llvm/llvm-project/blob/mast

[PATCH] D82226: Add Metadata to Transformer tooling

ymandel added a comment. In D82226#2116931 , @gribozavr2 wrote: > In D82226#2115406 , @asoffer wrote: > > > I think the tradeoff here is > > Dynamic typing -- faster compile times, type safety checked at run-time

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr updated this revision to Diff 273723. gribozavr added a comment. Addressed review comments, added more fixes that must be committed in the same change, because splitting them would break tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

JakeMerdichAMD added a comment. Thanks for the fast review, @curdeius, and thanks for mentioning PP_STRINGIZE and BOOST_PP_STRINGIZE too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https://reviews.llvm.org/D82620 _

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr2 marked 2 inline comments as done. gribozavr2 added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:335 + template struct is_same_method_impl { +static bool isSameMethod(...) { return false; } + }; ymandel wrote: > Why

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-bitcast-bfloat.ll:8 + +define @bitcast_bfloat_to_i8( %v) { +; CHECK-LABEL: bitcast_bfloat_to_i8: david-arm wrote: > Aren't these tests all

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:117-118 - // TODO: Add a note to bug reports describing this decision. - C.addTransition( - State->BindExpr(Call.getOriginExpr(), C.getLocationContext(), -

[PATCH] D82362: Move default module cache from system temporary directory

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/mac/16222/step_11.txt Please take a look and revert for now if this takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/ https://reviews.llvm

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

dfukalov planned changes to this revision. dfukalov added a comment. In D82650#2116849 , @yaxunl wrote: > I think the point of -ffp-contract=fast is that it allows emitting fma across > statements if there are such opportunities whereas -ffp-contract=on o

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked an inline comment as done. tejohnson added a comment. In D73242#1963451 , @evgeny777 wrote: > This needs to be rebased Sorry for the delay, I've been side tracked on other work. Rebased and beefed up the test as requested. Repository:

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson updated this revision to Diff 273730. tejohnson added a comment. Rebase and beef up test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73242/new/ https://reviews.llvm.org/D73242 Files: llvm/include/llvm/IR/ModuleSummaryIndex.h llvm/i

[PATCH] D82592: [libTooling] Rename overloaded `range` range selector.

This revision was automatically updated to reflect the committed changes. Closed by commit rG056a539e570a: [libTooling] Rename overloaded `range` range selector. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82592/new/ https:/

[clang] fa1b488 - Work around a bug in MSVC in the syntax tree test

Author: Dmitri Gribenko Date: 2020-06-26T16:43:30+02:00 New Revision: fa1b488776185827274637f8fdd38b20b6b5c036 URL: https://github.com/llvm/llvm-project/commit/fa1b488776185827274637f8fdd38b20b6b5c036 DIFF: https://github.com/llvm/llvm-project/commit/fa1b488776185827274637f8fdd38b20b6b5c036.dif

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:646 + * receives a DataRecursionQueue, can't call WalkUpFrom after traversing \ + * children because it only enqueues the children. and does not tra

[clang] e91c4b2 - [NFC] Eliminate an unneeded -vv used in test development.

Author: Kevin P. Neal Date: 2020-06-26T11:09:16-04:00 New Revision: e91c4b2af2c03ef599623243e625f347e166673d URL: https://github.com/llvm/llvm-project/commit/e91c4b2af2c03ef599623243e625f347e166673d DIFF: https://github.com/llvm/llvm-project/commit/e91c4b2af2c03ef599623243e625f347e166673d.diff

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

Quuxplusone added a comment. FWIW, I think the example you gave is **correct** for GCC to warn on. You said: class Base { virtual void foo(); // to be overridden void foo(int); // implemented in terms of foo() }; foo(int) is hidden in derived classes. So if someone derives from Base

[PATCH] D82259: Deprecate error prone temporary directory APIs

davezarzycki abandoned this revision. davezarzycki added a comment. Now that my core concern is addressed (moving clang's default module cache out of /tmp), I don't have the time to push for this deprecation. Sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

gribozavr2 added a comment. > I generally avoid testing error message content in tests, but I know there's > a variety of opinions on this subject... If you thought that the quality of the error message matters enough to improve it, then it is worth testing the message, I think. Repository:

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr updated this revision to Diff 273736. gribozavr added a comment. Removed a stray period in a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82486/new/ https://reviews.llvm.org/D82486 Files: clang/include/clang/AST/RecursiveASTV

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

Quuxplusone added inline comments. Comment at: clang-tools-extra/clangd/support/FSProvider.h:37 + /// This is an overload instead of an optional to make implicit string -> + /// StringRef conversion possible. + virtual llvm::IntrusiveRefCntPtr Re how to fix th

  1   2   3   >