ahatanak added inline comments.
================ Comment at: clang/lib/CodeGen/CGObjC.cpp:1856 + Selector IsKindOfClassSel = C.Selectors.getSelector( + llvm::array_lengthof(IsKindOfClassII), &IsKindOfClassII[0]); + CallArgList IsKindOfClassArgs; ---------------- Can you use `GetUnarySelector` here? ================ Comment at: clang/lib/CodeGen/CGObjC.cpp:1860 + CGM.getObjCRuntime().GetClass(*this, InterfaceTy->getDecl()); + Args.add(RValue::get(Cls), C.getObjCClassType()); + llvm::Value *IsClass = ---------------- It looks like `Args` should be cleared before adding the argument. Or should the argument be added to `IsKindOfClassArg`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
