[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269527. gamesh411 added a comment. Fix test case, and reorder warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTran

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

uabelho added a comment. Our out-of-tree target also have 16 bit ints and we've had to change a whole bunch of __builtin_clz to clzsi and __builtin_ctz to ctzsi to make things work so this patch is a step in the right direction for us too. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware added a comment. In D80522#2082095 , @teemperor wrote: > This introduced a compiler warning: > > > /Users/teemperor/1llvm/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1102:23: > warning: 'getDecl' ov

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

riccibruno added a comment. Warning (from eg: http://lab.llvm.org:8011/builders/clang-armv7-linux-build-cache/builds/32043): /home/buildslave/buildslave/clang-armv7-linux-build-cache/llvm/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1102:23: warning: 'getDecl' overrides a m

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl marked an inline comment as done. pestctrl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11571 + Diag(Loc, + getLangOpts().C11 + ? diag::ext_typecheck_compare_complete_incomplete_pointers efriedma

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

ABataev updated this revision to Diff 269529. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78232/new/ https://reviews.llvm.org/D78232 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema/SemaOpenMP.cpp cl

[PATCH] D81467: [clang-format] Microsoft style fixes for C# properties

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22b0727fe76: [clang-format] Microsoft style fixes for C# properties (authored by Jonathan Coe ). Changed prior to commit: https://reviews.llvm.org/D81467?vs=269517&id=269536#toc Repo

[PATCH] D81396: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

baloghadamsoftware updated this revision to Diff 269533. baloghadamsoftware added a comment. Thank you for the comment, @gribozavr2! Patch updated according to them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81396/new/ https://reviews.llvm.org/D81396 Files: clang-tools-extra/clan

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

glider added inline comments. Comment at: clang/test/CodeGen/asan-globals.cpp:16 +int aliased_global; +extern int __attribute__((alias("aliased_global"))) __global_alias; +int __special_global; Need a comment explaining this case a bit. Comment

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. tridac...@gmail.com https://github.com/Tridacnid Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

cfe-commits@lists.llvm.org

LukeGeeson added a comment. In D80752#2074882 , @stuij wrote: > For the backend tests, I suggest using `-asm-verbose=0` with llc to only > print instructions and get rid of `// kill: ..` and friends. Use > `update_cc_test_checks.py` again to regenerate t

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

whisperity added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:119-120 + return "Invocation list file contains multiple references to the same " + "source" + " file."; +case index_error_code::invocation_list_file_not_foun

cfe-commits@lists.llvm.org

LukeGeeson added a comment. In D80716#2074883 , @stuij wrote: > In D80716#2073251 , @LukeGeeson > wrote: > > > Besides from rebasing to get @pratlucas changes upstream. > > > > @stuij please could you confirm if y

[clang] 8dcc7ee - [clang][AST] Widen TypeTraitExprBitfields.NumArgs to 16 bits.

Author: Bruno Ricci Date: 2020-06-09T15:18:15+01:00 New Revision: 8dcc7eecb75b39d723fd6fee566369bf67e43fdf URL: https://github.com/llvm/llvm-project/commit/8dcc7eecb75b39d723fd6fee566369bf67e43fdf DIFF: https://github.com/llvm/llvm-project/commit/8dcc7eecb75b39d723fd6fee566369bf67e43fdf.diff L

[clang] 6d0f834 - [clang][AST] TextNodeDumper: dump the operator spelling for overloaded operators.

Author: Bruno Ricci Date: 2020-06-09T15:18:14+01:00 New Revision: 6d0f8345ac195990aea3776722f6de6e2957e6c2 URL: https://github.com/llvm/llvm-project/commit/6d0f8345ac195990aea3776722f6de6e2957e6c2 DIFF: https://github.com/llvm/llvm-project/commit/6d0f8345ac195990aea3776722f6de6e2957e6c2.diff L

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

aykevl added a comment. I'm not sure whether `native_int` is any clearer than just `int`. I'm afraid it only introduces more complexity ("What's `native_int`? Oh, it's just `int`"). Perhaps a controversial idea: what about changing to use stdint.h types? `si_int` -> `int32_t` `su_int` -> `uint32

cfe-commits@lists.llvm.org

LukeGeeson added a comment. In D80716#2082356 , @LukeGeeson wrote: > In D80716#2074883 , @stuij wrote: > > > In D80716#2073251 , @LukeGeeson > > wrote: > > > > > Besides fro

[PATCH] D81396: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.h:29 +/// pointer to ``n`` created in ``f()``. + +bool hasPtrOrReferenceInFunc(const FunctionDecl *Func, c

[PATCH] D81422: Change filecheck default to dump input on failure

jdenny added a comment. By the way, `-vv` combined with `-dump-input=fail` provides a lot of additional information that can be helpful when debugging. Bots could pass that via `FILECHECK_OPTS`, or it could become the default when `-dump-input` is not `never`. In the latter case, I suggest a

[PATCH] D81422: Change filecheck default to dump input on failure

jdenny added inline comments. Comment at: llvm/test/FileCheck/dump-input-enable.txt:77 ;-- -; Check no -dump-input, which defaults to never. ;-- The previous section

[PATCH] D81474: Handle delayed-template-parsing functions imported into a non-dtp TU

sammccall created this revision. sammccall added a reviewer: rsmith. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. DelayedTemplateParsing is marked as BENIGN_LANGOPT, so we are allowed to use a delayed template in a non-delayed TU. (This is clangd'

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

hliao updated this revision to Diff 269555. hliao added a comment. Revise following reviewer's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81427/new/ https://reviews.llvm.org/D81427 Files: clang/lib/Driver/Driver.cpp clang/test/Driv

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 269553. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Replace the transient status by a local var; Clean up the code; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ ht

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn marked 3 inline comments as done. fhahn added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12126 + ExprResult SemaBuiltinMatrixColumnMajorLoadOverload(CallExpr *TheCall, + ExprResult CallResult); --

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

fhahn updated this revision to Diff 269556. fhahn marked 2 inline comments as done. fhahn added a comment. Adjust naming as suggested, pass through volatile flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/ https://reviews.llvm.org/D72

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

atrosinenko added a comment. In D81285#2082394 , @aykevl wrote: > I'm not sure whether `native_int` is any clearer than just `int`. I'm afraid > it only introduces more complexity ("What's `native_int`? Oh, it's just > `int`"). I'm not particularly ins

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

sammccall added a comment. In D81351#2082174 , @thakis wrote: > Breaks tests on windows: http://45.33.8.238/win/17229/step_9.txt > > Please take a look and revert if it takes a while to fix. (Might just be the > usual delayed template parsing thing.) It

[clang-tools-extra] 406ac49 - [clangd][NFC] Explode ReceivedPreamble into a CV

Author: Kadir Cetinkaya Date: 2020-06-09T17:54:32+02:00 New Revision: 406ac49fb05e04e874623a3e955276a134dc82ea URL: https://github.com/llvm/llvm-project/commit/406ac49fb05e04e874623a3e955276a134dc82ea DIFF: https://github.com/llvm/llvm-project/commit/406ac49fb05e04e874623a3e955276a134dc82ea.dif

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/int_lib.h:112 -uint32_t __inline __builtin_ctz(uint32_t value) { +int __inline __builtin_ctz(uint32_t value) { unsigned long trailing_zero = 0; aykevl wrote: > Why `int` and not `native_

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80804/new/ https://reviews.llvm.org/D80804 ___

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel marked 2 inline comments as done. jtmott-intel added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1747-1748 break; case Builtin::BI__builtin_add_overflow: case Builtin::BI__builtin_sub_overflow: case Builtin::BI__builtin_mul_overflow: --

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel updated this revision to Diff 269564. jtmott-intel added a comment. Updated the diagnostic check and message for 128 rather than 64 bits. Added sema tests for 128/129 sizes. Added codegen tests for 127/128 sizes to mul. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81420/new

[PATCH] D80784: [clangd][NFC] Explode ReceivedPreamble into a CV

This revision was automatically updated to reflect the committed changes. Closed by commit rG406ac49fb05e: [clangd][NFC] Explode ReceivedPreamble into a CV (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80784/new/ https://revi

[clang] ce7d3e1 - Reland (again) D80966 [codeview] Put !heapallocsite on calls to operator new

Author: Arthur Eubanks Date: 2020-06-09T09:27:32-07:00 New Revision: ce7d3e1c5531fce828722379cfbd58cb5d4dfab9 URL: https://github.com/llvm/llvm-project/commit/ce7d3e1c5531fce828722379cfbd58cb5d4dfab9 DIFF: https://github.com/llvm/llvm-project/commit/ce7d3e1c5531fce828722379cfbd58cb5d4dfab9.diff

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Added codegen for scan directives in parallel for regions. Emits the code for the directive with inscan reductions. Original code: #pragma om

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

craig.topper marked 2 inline comments as done. craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:132 protected: - /// Enumeration of all of the X86 CPUs supported by Clang. - /// - /// Each enumeration represents a particular CPU supported by Clang

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. In current linux BPF uapi https://github.com/torvalds/linux/blob/master/include/uapi/linux/bpf.h `struct __sk_buff/xdp_md` have fields __u32

[PATCH] D79830: Add support of __builtin_expect_with_probability

davidxl added inline comments. Comment at: llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp:58 +std::pair setBranchWeight(Intrinsic::ID IntrinsicID, + CallInst *CI, int BranchCount) { nit: change name to getBranc

[clang] 675cefb - [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

Author: Saiyedul Islam Date: 2020-06-09T17:02:58Z New Revision: 675cefbf60270f59057972e33365a09590fb3694 URL: https://github.com/llvm/llvm-project/commit/675cefbf60270f59057972e33365a09590fb3694 DIFF: https://github.com/llvm/llvm-project/commit/675cefbf60270f59057972e33365a09590fb3694.diff LOG

Re: [clang] 059ba74 - Revert "[codeview] Put !heapallocsite on calls to operator new"

FWIW before you reapply this let me know. I've seen some other failures associated and would like to give it a run through. -eric On Sat, Jun 6, 2020 at 4:38 PM Douglas Yung via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Douglas Yung > Date: 2020-06-06T23:30:46Z > New Revision:

[clang] 9c2e770 - Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

Author: Yuanfang Chen Date: 2020-06-09T10:08:40-07:00 New Revision: 9c2e770034d04a0966b84cac14a9e3fb3b0d4ab7 URL: https://github.com/llvm/llvm-project/commit/9c2e770034d04a0966b84cac14a9e3fb3b0d4ab7 DIFF: https://github.com/llvm/llvm-project/commit/9c2e770034d04a0966b84cac14a9e3fb3b0d4ab7.diff

[clang] b7d3692 - [WebAssembly] Implement prototype SIMD rounding instructions

Author: Thomas Lively Date: 2020-06-09T10:14:14-07:00 New Revision: b7d369280ba6073a285811733f90cf7f2e0066be URL: https://github.com/llvm/llvm-project/commit/b7d369280ba6073a285811733f90cf7f2e0066be DIFF: https://github.com/llvm/llvm-project/commit/b7d369280ba6073a285811733f90cf7f2e0066be.diff

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

melver updated this revision to Diff 269578. melver marked 6 inline comments as done. melver added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81390/new/ https://reviews.llvm.org/D81390 Files: clang/test/CodeGen/as

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

melver added a comment. Thanks! PTAL. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:759 // do globals-gc. -UseCtorComdat(UseGlobalsGC && ClWithComdat) { -this->Recover = ClRecover.getNumOccurrences() > 0 ? ClRecover : Recover; -th

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

yonghong-song added a comment. The corresponding llvm change: https://reviews.llvm.org/D81480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81479/new/ https://reviews.llvm.org/D81479 ___ cfe-commits ma

[PATCH] D81427: [hip] Fix device-only relocatable code compilation.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81427/new/ https://reviews.llvm.org/D81427 ___

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim updated this revision to Diff 269583. fghanim added a comment. Herald added a subscriber: aaron.ballman. - Rebase + refactor based on D80222 - addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:132 protected: - /// Enumeration of all of the X86 CPUs supported by Clang. - /// - /// Each enumeration represents a particular CPU supported by Clang. These - /// loosely correspond to the options

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

melver updated this revision to Diff 269582. melver added a comment. Fix test broken by linter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81390/new/ https://reviews.llvm.org/D81390 Files: clang/test/CodeGen/asan-globals.cpp llvm/include/ll

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 ___

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

aeubanks created this revision. aeubanks added a reviewer: akhuang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move check inside of addHeapAllocSiteMetadata(). Change check to DebugInfo <= DebugLineTablesOnly. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

fghanim updated this revision to Diff 269584. fghanim added a comment. Herald added a subscriber: sstefan1. - rebase - addressing reviewer's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79676/new/ https://reviews.llvm.org/D79676 Files:

[PATCH] D81483: [Clang][OpenMP][OMPBuilder] (3/4) Privatize `parallel` for `OMPBuilder`

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, aaron.ballman, sstefan1, guansong, yaxunl. Herald added a project: clang. fghanim added a child revision: D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `p

[PATCH] D81484: [Clang][OpenMP][OMPBuilder] (4/4) Privatize `parallel` for `OMPBuilder`

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. fghanim added a child revision: D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directi

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen updated this revision to Diff 269586. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80944/new/ https://reviews.llvm.org/D80944 Files: clang/lib/Parse/ParsePragma.cpp clang/lib/Parse/ParseStmt.cpp

[PATCH] D81482: [Clang][OpenMP][OMPBuilder] (2/4) Privatize `parallel` for `OMPBuilder`

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. fghanim added a child revision: D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directi

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

fghanim added a comment. @jdoerfert Please suggest reviewer's for this, and I will add them to other clang related patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

fghanim updated this revision to Diff 269589. fghanim added a comment. Herald added subscribers: aaron.ballman, sstefan1. - rebase - splitting patch into 4 ( this, D81482 , D81483 , D81484 ) - a

[PATCH] D81483: [Clang][OpenMP][OMPBuilder] (3/4) Privatize `parallel` for `OMPBuilder`

fghanim marked 3 inline comments as done. fghanim added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1554 llvm::SmallVectorImpl &) {} +bool CodeGenFunction::OMPBuilderCBHelpers::EmitOMPCopyinClause( Note

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG675cefbf6027: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec… (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11571 + Diag(Loc, + getLangOpts().C11 + ? diag::ext_typecheck_compare_complete_incomplete_pointers pestctrl wrote: > efriedma wrote: > > I think this co

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c2e770034d0: Add begin source location for the attributed statement created from… (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80944/n

[PATCH] D81222: [WebAssembly] Implement prototype SIMD rounding instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d369280ba6: [WebAssembly] Implement prototype SIMD rounding instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81222/new/ h

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini updated this revision to Diff 269581. mehdi_amini marked 4 inline comments as done. mehdi_amini edited the summary of this revision. mehdi_amini added a comment. Address @jdenny's comments: - fix the example in lit.local.cfg - Test the default value for dump-input Repository: rG L

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini added inline comments. Comment at: llvm/test/FileCheck/lit.local.cfg:42 # ; RUN: %ProtectFileCheckOutput FILECHECK_OPTS=-v \ # ; RUN: FileCheck -input-file %s %s 2>&1 \ # ; RUN: | FileCheck -check-prefix TRACE %s jdenny wrote: > Please add `-

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

ast added inline comments. Comment at: clang/test/CodeGen/builtin-bpf-load-u32-to-ptr.c:5 +struct t { int a; int b; }; +void *test(struct t *arg) { return __builtin_load_u32_to_ptr(arg, 4); } + can it be expressed as: __builtin_load_u32_to_ptr(&arg->b) ? Reposi

[PATCH] D81484: [Clang][OpenMP][OMPBuilder] (4/4) Privatize `parallel` for `OMPBuilder`

fghanim marked 6 inline comments as done. fghanim added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1777 } + +bool CodeGenFunction::OMPBuilderCBHelpers::EmitOMPFirstprivateClause( Same as current implementation, with certain changes around th

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81481/new/ https://reviews.llvm.org/D81481

[clang] bc38793 - Change debuginfo check for addHeapAllocSiteMetadata

Author: Arthur Eubanks Date: 2020-06-09T11:01:06-07:00 New Revision: bc38793852c0552337bae54961eb14fb0bacf356 URL: https://github.com/llvm/llvm-project/commit/bc38793852c0552337bae54961eb14fb0bacf356 DIFF: https://github.com/llvm/llvm-project/commit/bc38793852c0552337bae54961eb14fb0bacf356.diff

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

efriedma added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11571 + Diag(Loc, + getLangOpts().C11 + ? diag::ext_typecheck_compare_complete_incomplete_pointers rsmith wrote: > pestctrl wrote: > > efriedma wrote:

[PATCH] D81479: [BPF] introduce __builtin_load_u32_to_ptr() intrinsic

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: clang/test/CodeGen/builtin-bpf-load-u32-to-ptr.c:5 +struct t { int a; int b; }; +void *test(struct t *arg) { return __builtin_load_u32_to_ptr(arg, 4); } + ast wrote:

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

dmgreen added reviewers: efriedma, ostannard, SjoerdMeijer. dmgreen added a comment. Love it. This will help optimise these more too. We can currently get into places where we can't prove only the bottom bits of a returned value are demanded so can't remove unnecessary vmovs. Test look good too

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

craig.topper updated this revision to Diff 269610. craig.topper added a comment. Flip polarity of the bool and rename it. Add doxygen comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81439/new/ https://reviews.llvm.org/D81439 Files: clang/include/clang/Basic/X86Target.def cl

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Bumping for review. Are there additional reviewers we can entrust code review to, to help share the code review responsibility? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269615. gamesh411 added a comment. use consumeError in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTranslationUni

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev updated this revision to Diff 269618. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D81422: Change filecheck default to dump input on failure

jdenny accepted this revision. jdenny added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/ https://reviews.llvm.org/D81422 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc38793852c0: Change debuginfo check for addHeapAllocSiteMetadata (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81481/new/ https://r

[clang-tools-extra] ce5fecb - Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Author: Tridacnid Date: 2020-06-09T19:45:57+01:00 New Revision: ce5fecb7d0a12c27763afe3f89d1d7e8a1893dc0 URL: https://github.com/llvm/llvm-project/commit/ce5fecb7d0a12c27763afe3f89d1d7e8a1893dc0 DIFF: https://github.com/llvm/llvm-project/commit/ce5fecb7d0a12c27763afe3f89d1d7e8a1893dc0.diff LOG

[clang] d31c9e5 - Change filecheck default to dump input on failure

Author: Mehdi Amini Date: 2020-06-09T18:57:46Z New Revision: d31c9e5a46ee692daf2430b52626afcea1db18ab URL: https://github.com/llvm/llvm-project/commit/d31c9e5a46ee692daf2430b52626afcea1db18ab DIFF: https://github.com/llvm/llvm-project/commit/d31c9e5a46ee692daf2430b52626afcea1db18ab.diff LOG: C

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo marked an inline comment as done. oontvoo added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14252 + FD->getReturnType().isConstQualified()) +return FD->getReturnTypeSourceRange().getBegin().getLocWithOffset( +/*strlen(

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw updated this revision to Diff 269628. zixuw added a comment. Update test case for `#pragma clang diagnostic` Update test case to verify that the state of `-Wundef` can still be modified using `#pragma clang diagnostic` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

oontvoo updated this revision to Diff 269627. oontvoo marked an inline comment as done. oontvoo added a comment. - Less brittle way to find the loc of const. - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81444/new/ https://reviews.

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 added a comment. Any additional changes/fixes regarding this patch? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 added a comment. In D79912#2082337 , @Tridacnid wrote: > tridac...@gmail.com > > https://github.com/Tridacnid > > Thanks! I've commited it on your behalf, w

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

This revision was automatically updated to reflect the committed changes. Closed by commit rGce5fecb7d0a1: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit… (authored by Tridacnid, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 113b0d7 - PR46255: Fix field diagnostics for C records with anonymous members.

Author: Erich Keane Date: 2020-06-09T12:27:44-07:00 New Revision: 113b0d7d0bd637743efb050ad619dd0c6d306e96 URL: https://github.com/llvm/llvm-project/commit/113b0d7d0bd637743efb050ad619dd0c6d306e96 DIFF: https://github.com/llvm/llvm-project/commit/113b0d7d0bd637743efb050ad619dd0c6d306e96.diff L

[libunwind] 0e04342 - [NFCI] Clean up exceptions related CMake and Lit options in libc++abi and libunwind

Author: Louis Dionne Date: 2020-06-09T15:34:29-04:00 New Revision: 0e04342ae0399876f3488464d12f5a4da5085456 URL: https://github.com/llvm/llvm-project/commit/0e04342ae0399876f3488464d12f5a4da5085456 DIFF: https://github.com/llvm/llvm-project/commit/0e04342ae0399876f3488464d12f5a4da5085456.diff

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan added a comment. Lemme know if there's any more feedback. Will aim for committing this sometime at the end of the day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77836/new/ https://reviews.llvm.org/D77836

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw added inline comments. Comment at: clang/lib/Lex/PPExpressions.cpp:262 + // string to UndefPrefixes as an explicit "-Wundef" does. + if (UndefPrefixes.empty() || + llvm::any_of(UndefPrefixes, ributzka wrote: > What happens whe

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak added a comment. Yes, I'm still interested in pursuing this. I'll rebase the patch and commit it if I don't get any more feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57626/new/ https://reviews.llvm.org/D57626 ___

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak updated this revision to Diff 269633. ahatanak added a comment. Rebase patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57626/new/ https://reviews.llvm.org/D57626 Files: clang/include/clang/Basic/AttrDocs.td clang/include/clang/Ba

[clang] 90ee8cf - Undo change inadvertently added in 113b0d7d

Author: Erich Keane Date: 2020-06-09T12:41:52-07:00 New Revision: 90ee8cf63613df525c4dab5e715fbae5f7310a78 URL: https://github.com/llvm/llvm-project/commit/90ee8cf63613df525c4dab5e715fbae5f7310a78 DIFF: https://github.com/llvm/llvm-project/commit/90ee8cf63613df525c4dab5e715fbae5f7310a78.diff L

[clang] d5c28c4 - [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

Author: Craig Topper Date: 2020-06-09T12:52:41-07:00 New Revision: d5c28c4094324e94f6eee403022ca21c8d76998e URL: https://github.com/llvm/llvm-project/commit/d5c28c4094324e94f6eee403022ca21c8d76998e DIFF: https://github.com/llvm/llvm-project/commit/d5c28c4094324e94f6eee403022ca21c8d76998e.diff

[libunwind] 168681a - [libc++abi][libunwind] Don't override libc++'s handling of exception features

Author: Louis Dionne Date: 2020-06-09T16:03:22-04:00 New Revision: 168681abce63d9cc0cec24cfc1d0caef6fa3a25f URL: https://github.com/llvm/llvm-project/commit/168681abce63d9cc0cec24cfc1d0caef6fa3a25f DIFF: https://github.com/llvm/llvm-project/commit/168681abce63d9cc0cec24cfc1d0caef6fa3a25f.diff

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader added a comment. In D80932#2080631 , @Anastasia wrote: > > @Anastasia, if we make this change specific to SYCL mode, will it address > > your concerns? > > I can't answer this question for the reasons I have explained above. Sorry, I'm not sure th

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269639. gamesh411 added a comment. add ambiguous invocation list test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/Cros

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

gribozavr2 added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1302 +bool Lexer::isConst(SourceLocation Loc, const SourceManager &SM, +const LangOptions &LangOpts) { I'm concerned about putting this API into Lexer, given this implemen

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai added a comment. Ping. Also suggested clang-format linter changes make the test useless as the order of imports is important. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 269642. LukeZhuang added a comment. **updated: 06/09/2020** (1) improve code in LowerExpectIntrinsic (2) update and simplify test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 Files: clang/include/cla

<    1   2   3   >