bader added a comment. In D80932#2080631 <https://reviews.llvm.org/D80932#2080631>, @Anastasia wrote:
> > @Anastasia, if we make this change specific to SYCL mode, will it address > > your concerns? > > I can't answer this question for the reasons I have explained above. Sorry, I'm not sure that I get your concern correctly, so let me clarify: is it allowing conversion between pointers w/ and w/o address space annotation in non-SYCL mode or using OpenCL address space attributes in SYCL mode? Just to help you to understand the proposed design, I created the full patch for address space handling in SYCL: https://github.com/bader/llvm/pull/18. There are few CodeGen tests validating LLVM IR for SPIR target. Fee free to ask any questions on this PR. I also merged it with https://reviews.llvm.org/D71016, which lowers C++ function object into OpenCL kernel in this PR (just revert last two commits - https://github.com/bader/llvm/pull/18/files/b2772482370844f33093a70e7d17a318caab49ce). It's not directly related to this review, but completes the picture of producing LLVM IR for SYCL kernels. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80932/new/ https://reviews.llvm.org/D80932 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
