[clang] 6dd738e - [StackSafety,NFC] Switch tests to aarch64

2020-06-05 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-06-05T00:24:02-07:00 New Revision: 6dd738e2f0609f7d3313b574a1d471263d2d3ba1 URL: https://github.com/llvm/llvm-project/commit/6dd738e2f0609f7d3313b574a1d471263d2d3ba1 DIFF: https://github.com/llvm/llvm-project/commit/6dd738e2f0609f7d3313b574a1d471263d2d3ba1.diff L

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

2020-06-05 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D74025#2073946 , @jaafar wrote: > I'm very happy this fix exists. I see it's in master, but not in 10.0.0 or > 10.0.1-rc1 either. Is there any chance it can be released? unfortunately, it is not picked up in 10.0.0 release, bu

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 268696. balazske added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp clang/test/An

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 268701. balazske added a comment. Removed bad empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

[clang-tools-extra] a7534dc - [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

2020-06-05 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-06-05T10:32:07+02:00 New Revision: a7534dc8198f2ff966f55fd9a68d2c444886f2b2 URL: https://github.com/llvm/llvm-project/commit/a7534dc8198f2ff966f55fd9a68d2c444886f2b2 DIFF: https://github.com/llvm/llvm-project/commit/a7534dc8198f2ff966f55fd9a68d2c444886f2b2.diff LO

[PATCH] D81242: [StackSafety] Run ThinLTO

2020-06-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. ThinLTO linking runs dataflow processing on collected function parameters. Then StackSa

[clang] 767516c - Fix gcc5 build of ASTMatchersTest.h

2020-06-05 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2020-06-05T10:38:03+02:00 New Revision: 767516c5463a58f64cc3e0e1125b761aedceecf5 URL: https://github.com/llvm/llvm-project/commit/767516c5463a58f64cc3e0e1125b761aedceecf5 DIFF: https://github.com/llvm/llvm-project/commit/767516c5463a58f64cc3e0e1125b761aedceecf5.diff

[PATCH] D81244: [StackSafety] Control paramer access summary from frontend

2020-06-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. MAYBE? let me know if you think we need it. I'll improve the patch. This way we don't need to rel

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

2020-06-05 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa7534dc8198f: [clangd] Populate the parse options to CodeCompletion/SignatureHelp. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D81066?vs=268164&id=268707#toc Repository: r

[clang] ecd682b - [ARM] Add __bf16 as new Bfloat16 C Type

2020-06-05 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-05T10:32:43+01:00 New Revision: ecd682bbf5e69e8690b7e3634258f05ae0a70448 URL: https://github.com/llvm/llvm-project/commit/ecd682bbf5e69e8690b7e3634258f05ae0a70448 DIFF: https://github.com/llvm/llvm-project/commit/ecd682bbf5e69e8690b7e3634258f05ae0a70448.diff LO

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGecd682bbf5e6: [ARM] Add __bf16 as new Bfloat16 C Type (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org

[clang] a30b5c5 - Fix MSVC "not all control paths return a value" warning. NFC.

2020-06-05 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-06-05T10:45:59+01:00 New Revision: a30b5c5a51f95dc81fdfbeea42cc01b451cd5a08 URL: https://github.com/llvm/llvm-project/commit/a30b5c5a51f95dc81fdfbeea42cc01b451cd5a08 DIFF: https://github.com/llvm/llvm-project/commit/a30b5c5a51f95dc81fdfbeea42cc01b451cd5a08.diff

[clang] c31d213 - [clang][test] Put output into temp directory

2020-06-05 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-05T13:02:32+02:00 New Revision: c31d2134639bb87d6705fe8fb1a46de61bc4cebf URL: https://github.com/llvm/llvm-project/commit/c31d2134639bb87d6705fe8fb1a46de61bc4cebf DIFF: https://github.com/llvm/llvm-project/commit/c31d2134639bb87d6705fe8fb1a46de61bc4cebf.dif

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-05 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added inline comments. Comment at: llvm/lib/Support/YAMLTraits.cpp:894 + std::string &Val) { + Val.clear(); + size_t CurrentPos = 0; njames93 wrote: > If you want to do the same here... > ``` > SmallVec

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-05 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 268736. DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. Rewrite input string split too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-05 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 268737. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Fix spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files: cl

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

2020-06-05 Thread Kerry McLaughlin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG89fc0166f532: [CodeGen][SVE] Legalisation of extends with scalable types (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/

[PATCH] D81252: [SVE ACLE] Remove redundant bool_t typedef.

2020-06-05 Thread Paul Walker via Phabricator via cfe-commits
paulwalker-arm created this revision. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. paulwalker-arm added a reviewer: sdesmalen. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81252 Files: clang/utils/TableGen/SveEmitter.cpp Index: clang/util

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-05 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 268746. dang marked 3 inline comments as done. dang added a comment. Address some code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/inclu

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-05 Thread Daniel Grumberg via Phabricator via cfe-commits
dang marked 4 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:248 + /// \returns - True if parsing was successful, false otherwise + bool parseSimpleArgs(const llvm::opt::ArgList &Args, + D

[clang] 1e44731 - [ARM] Add poly64_t on AArch32.

2020-06-05 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-05T13:04:21+01:00 New Revision: 1e447318339a6e740819ec1568002f4751527efe URL: https://github.com/llvm/llvm-project/commit/1e447318339a6e740819ec1568002f4751527efe DIFF: https://github.com/llvm/llvm-project/commit/1e447318339a6e740819ec1568002f4751527efe.diff LO

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

2020-06-05 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: dcoughlin, NoQ, alexfh. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Problem: Th

[PATCH] D81252: [SVE ACLE] Remove redundant bool_t typedef.

2020-06-05 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81252/new/ https://reviews.llvm.org/D81252 _

[PATCH] D81255: [clang-format] treat 'lock' as a keyword for C# code

2020-06-05 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir accepted this revision. This revision is now accepted and ready to land. This will put a space in `lock (process)` whe

[PATCH] D79711: [ARM] Add poly64_t on AArch32.

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1e447318339a: [ARM] Add poly64_t on AArch32. (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711

[clang] a6fcf5c - [clang][BFloat] add NEON emitter for bfloat

2020-06-05 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-05T14:11:51+01:00 New Revision: a6fcf5ca033a83b815f760664e0cff91c2c13dcd URL: https://github.com/llvm/llvm-project/commit/a6fcf5ca033a83b815f760664e0cff91c2c13dcd DIFF: https://github.com/llvm/llvm-project/commit/a6fcf5ca033a83b815f760664e0cff91c2c13dcd.diff LO

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

2020-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D80961#2073049 , @klimek wrote: > Without jumping into the discussion whether it should be the default, I think > we should be able to control template instantiation visitation separately > from other implicit nodes. >

[PATCH] D81173: [clangd] Change ParseInputs to store FSProvider rather than VFS

2020-06-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Hmm, having looked at this it is a bit of a mess, but I think partly because we're not converting *enough* code to use this abstraction (e.g. the preamble caching stuff, or prepareCompilerInstance). We should work how how to get the bugfix part of this landed, but I th

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait a bit in case @njames93 has any final thoughts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 ___

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa6fcf5ca033a: [clang][BFloat] add NEON emitter for bfloat (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

2020-06-05 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. I'm looking at this again and I am not sure how it is meant to work. For example in `Parser::parseClassSpecifier` in `ParseDeclCXX.cpp`. Here `attrs` is a local variable of type `ParsedAttributesWithRange`, already before my patch. `attrs` is then passed to 1. `MaybePar

[clang] 8b137a4 - [clang][BFloat] Add create/set/get/dup intrinsics

2020-06-05 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-05T14:35:10+01:00 New Revision: 8b137a430636c6626fcc6ef93b05eb69d6183e57 URL: https://github.com/llvm/llvm-project/commit/8b137a430636c6626fcc6ef93b05eb69d6183e57 DIFF: https://github.com/llvm/llvm-project/commit/8b137a430636c6626fcc6ef93b05eb69d6183e57.diff LO

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8b137a430636: [clang][BFloat] Add create/set/get/dup intrinsics (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://review

[clang] 23291b9 - Return "[InstCombine] Simplify compare of Phi with constant inputs against a constant"

2020-06-05 Thread Max Kazantsev via cfe-commits
Author: Max Kazantsev Date: 2020-06-05T20:48:29+07:00 New Revision: 23291b9863c8af7ad348c4a7d85d8d784df88eb1 URL: https://github.com/llvm/llvm-project/commit/23291b9863c8af7ad348c4a7d85d8d784df88eb1 DIFF: https://github.com/llvm/llvm-project/commit/23291b9863c8af7ad348c4a7d85d8d784df88eb1.diff

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a reviewer: NoQ. Szelethus added a subscriber: NoQ. Szelethus added a comment. @NoQ @baloghadamsoftware Escapes are more within your realm of expertise. Anything to add? From my end, this looks okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D59520: [WebAssembly] Address review comments on r352930

2020-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59520/new/ https://reviews.llvm.org/D59520 _

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-06-05 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 268780. adamcz marked 11 inline comments as done. adamcz added a comment. addressed review comments, some UI questions remain open for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81169/new/ https://review

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-06-05 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:525 + if (const auto *Var = dyn_cast(D)) { +// Check if we are inside CallExpr kadircet wrote: > umm, is this a fixme or a leftover? I suppose it is from a previous version > of

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

2020-06-05 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 268796. melver added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update IR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80805/new/ https://reviews.llvm.org/D80805 Fi

[PATCH] D81252: [SVE ACLE] Remove redundant bool_t typedef.

2020-06-05 Thread Paul Walker via Phabricator via cfe-commits
paulwalker-arm updated this revision to Diff 268795. paulwalker-arm added a comment. Stop SveEmitter adding a _t suffix to the scalar boolean type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81252/new/ https://reviews.llvm.org/D81252 Files: c

[clang] 28c2bdf - [AST] Record SourceLocation for TypoExpr.

2020-06-05 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-06-05T17:03:32+02:00 New Revision: 28c2bdf18f508460401ba1d6958de87b27d52618 URL: https://github.com/llvm/llvm-project/commit/28c2bdf18f508460401ba1d6958de87b27d52618 DIFF: https://github.com/llvm/llvm-project/commit/28c2bdf18f508460401ba1d6958de87b27d52618.diff LO

[clang] 99d6e05 - [lit] Improve naming of test result categories

2020-06-05 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2020-06-05T08:14:42-07:00 New Revision: 99d6e05e7144a2638c4e85ea75099e9dc6432cde URL: https://github.com/llvm/llvm-project/commit/99d6e05e7144a2638c4e85ea75099e9dc6432cde DIFF: https://github.com/llvm/llvm-project/commit/99d6e05e7144a2638c4e85ea75099e9dc6432cde.diff

[PATCH] D81176: [HIP] Add default header and include path

2020-06-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/ROCm.h:68 + + // CUDA architectures for which we have raised an error in + // CheckRocmVersionSupportsArch. tra wrote: > CUDA -> GPU? > Looks like the

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

2020-06-05 Thread Rodrigo Caetano Rocha via Phabricator via cfe-commits
rcorcs added a comment. LLVM already has the class PassBuilder::OptimizationLevel that encapsulates the logic of both speed and size optimization levels. This class already checks which values for SpeedLevel and SizeLevel are valid. However, other parts of the code define two separate variables

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

2020-06-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. So this is late in the game but... maybe we should just not report this case as a reference? `#undef foo` is valid if `foo` was never defined, and doesn't refer to anything. If we similarly don't resolve the reference in this case as we only import macros that were u

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

2020-06-05 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. dgoldman added reviewers: sammccall, yvvan. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Exempt ObjC from arrow/dot fixits since this has lim

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

2020-06-05 Thread Rodrigo Caetano Rocha via Phabricator via cfe-commits
rcorcs added a comment. If reviewers think that this patch is touching in too many files, I could try to focus it only on the LTO related files, converting OptimizationLevel back to two separate values when necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

2020-06-05 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/test/CodeCompletion/objc-member-access.m Index:

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-05 Thread Nathan James via Phabricator via cfe-commits
njames93 accepted this revision. njames93 added a comment. LGTM, nothing else to add. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

2020-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Generally looks good to me, but I had a question about test coverage. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/run-clang-tidy_config-file.cpp:1 -// RUN: %run_clang_tidy --help // RUN: rm -rf %t Is there a rea

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

2020-06-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I decided to do some more stringent benchmarking, just focusing on the matching, not the boilerplate of running clang-tidy. =BeforePatch=== Matcher Timings: 116.0756 user 29.1397 system 145.2154 pr

[PATCH] D81008: [AST] Record SourceLocation for TypoExpr.

2020-06-05 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG28c2bdf18f50: [AST] Record SourceLocation for TypoExpr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81008/new/ https://reviews.llvm.

[PATCH] D77708: [lit] Improve naming of test result categories

2020-06-05 Thread Julian Lettner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG99d6e05e7144: [lit] Improve naming of test result categories (authored by yln). Herald added subscribers: cfe-commits, msifontes, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufeng

[clang-tools-extra] c063b4a - Fix crash on misc-redundant-expression

2020-06-05 Thread Zinovy Nis via cfe-commits
Author: Zinovy Nis Date: 2020-06-05T18:43:57+03:00 New Revision: c063b4a72bb39d9ae4bd13851873ddcbc16f6804 URL: https://github.com/llvm/llvm-project/commit/c063b4a72bb39d9ae4bd13851873ddcbc16f6804 DIFF: https://github.com/llvm/llvm-project/commit/c063b4a72bb39d9ae4bd13851873ddcbc16f6804.diff LO

[PATCH] D81163: [AST][RecoveryExpr] Preserve the AST for invalid conditions.

2020-06-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81163/new/ https://reviews.llvm.org/D81163

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

2020-06-05 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 268818. dgoldman added a comment. - Fix broken diff base (due to lint fixes maybe?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeCom

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added a comment. In D80743#2074537 , @rsmith wrote: > In D80743#2074121 , @erichkeane > wrote: > > > @rsmith I think this implements what you've suggested? >

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 268822. erichkeane retitled this revision from "(PR46111) Desugar Elaborated types in Deduction Guides." to "(PR46111) Properly handle elaborated types in an implicit deduction guide". erichkeane edited the summary of this revision. CHANGES SINCE LAST AC

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-05 Thread Zinovy Nis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc063b4a72bb3: Fix crash on misc-redundant-expression (authored by zinovy.nis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-06-05 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 268840. Xiangling_L added a comment. Replace `int` with an more self-explanatory enum; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 Files: clang/include/clang/

[PATCH] D81272: [Clang-Tidy] New check `misc-redundant-condition`

2020-06-05 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: aaron.ballman, gribozavr2. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, steakhal, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun, whisperity, mgorny. Herald added a project

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

2020-06-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. This looks like a continuation of the work started in D61643 (which makes the loc of `#pragma` available to pragma handlers) and D61509 (which changes the start loc for OpenMP pragmas from `omp` to `#pra

[PATCH] D81272: [Clang-Tidy] New check `misc-redundant-condition`

2020-06-05 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. This check was made upon user request. I think it is a good base that can later be extended also for the negated cases (where the code inside the inner `if` never executes). That case is even more suspicious

[PATCH] D81273: [WIP] Enable new pass manager as default DO NOT SUBMIT

2020-06-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Just for bot testing Depends on D81175 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81273 Files: clang/CMake

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

2020-06-05 Thread Jeff Trull via Phabricator via cfe-commits
jaafar added a comment. Thank you. I'm trying to balance stability with getting the fixes I need and so have been avoiding the "bleeding edge". I find that unfortunately the newest code tends to be "unstable", as those releases are rightfully named, and I need clangd for my daily work. There a

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. How are you landing these changes, because the commit message isn't lining up with the PR name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 _

[PATCH] D81176: [HIP] Add default header and include path

2020-06-05 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. yaxunl marked 3 inline comments as done. Closed by commit rG11d06b9511bd: [HIP] Add default header and include path (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D8

[clang] e987c37 - Fix lit tests hip-include-path.hip and hip-host-cpu-macros.cu

2020-06-05 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-06-05T13:21:35-04:00 New Revision: e987c372185d805e3a30097366af2c6f94bc0b29 URL: https://github.com/llvm/llvm-project/commit/e987c372185d805e3a30097366af2c6f94bc0b29 DIFF: https://github.com/llvm/llvm-project/commit/e987c372185d805e3a30097366af2c6f94bc0b29.dif

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-05 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis added a comment. In D80896#2076735 , @njames93 wrote: > How are you landing these changes, because the commit message isn't lining up > with the PR name? It was my fault: I hadn't changed a title in my local branch and pushed it with git.

[PATCH] D81280: (Incomplete)Add support for id-expression

2020-06-05 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - TODO: Differ between NameQualifiers - TODO: Box all operators - Done: Treat NestedNameSpecifiers - Done: [Try] Unbox all operators Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

2020-06-05 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: howard.hinnant, samsonov. Herald added subscribers: Sanitizers, mgorny. Herald added a project: Sanitizers. There are two different _generic_ lists of source files in the compiler-rt/lib/builtins/CMakeLists.txt. Now there is no simpl

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

2020-06-05 Thread Alexander Potapenko via Phabricator via cfe-commits
glider accepted this revision. glider added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80805/new/ https://reviews.llvm.org/D80805 ___

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-05 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 268869. dang marked an inline comment as done. dang added a comment. Updating the patch with the correct merge base CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-05 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 268872. dang added a comment. This is the good diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Frontend/CompilerInvocation.h clang/

[clang] 5eedf07 - [apple clang] disable in-process CC1 to preserve crashlog compatibility

2020-06-05 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-06-05T10:55:42-07:00 New Revision: 5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11 URL: https://github.com/llvm/llvm-project/commit/5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11 DIFF: https://github.com/llvm/llvm-project/commit/5eedf07ab999d0a8ba43f41e0c1012d8f6e62c11.diff L

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-05 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. In D80833#2073458 , @hans wrote: > a. The compiler path is only absolute because it was absolute when put into > argv[0] right? I don't see anything in the code that makes it absolute? I > imagine most build systems will invoke th

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-05 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 268881. aganea marked 11 inline comments as done. aganea added a comment. Addressed comments (see inline). Ensured the generated .OBJ contains relative paths when passing `-fdebug-compilation-dir . -no-canonical-prefixes`. Repository: rG LLVM Github Monore

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

2020-06-05 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added a reviewer: howard.hinnant. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. This patch changes types of some integer function arguments or return values from `si_int` to the default `int` type (`typedef`ed to `native_

[PATCH] D80849: [apple clang] disable in-process CC1 to preserve crashlog compatibility

2020-06-05 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5eedf07ab999: [apple clang] disable in-process CC1 to preserve crashlog compatibility (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[clang] 866ee23 - [KernelAddressSanitizer] Make globals constructors compatible with kernel

2020-06-05 Thread Marco Elver via cfe-commits
Author: Marco Elver Date: 2020-06-05T20:20:46+02:00 New Revision: 866ee2353f7d0224644799d0d1faed53c7f3a06d URL: https://github.com/llvm/llvm-project/commit/866ee2353f7d0224644799d0d1faed53c7f3a06d DIFF: https://github.com/llvm/llvm-project/commit/866ee2353f7d0224644799d0d1faed53c7f3a06d.diff L

[clang] 931fcd3 - [WebAssembly] Improve clang diagnostics for wasm attributes

2020-06-05 Thread Dan Gohman via cfe-commits
Author: Dan Gohman Date: 2020-06-05T11:27:51-07:00 New Revision: 931fcd3ba011c27626a95e5e35b657763284882a URL: https://github.com/llvm/llvm-project/commit/931fcd3ba011c27626a95e5e35b657763284882a DIFF: https://github.com/llvm/llvm-project/commit/931fcd3ba011c27626a95e5e35b657763284882a.diff LO

[clang] ee60847 - Attempt to fix hip-include-path.hip

2020-06-05 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-06-05T14:36:36-04:00 New Revision: ee608478623a716da38cd09383f640f3a96f8d61 URL: https://github.com/llvm/llvm-project/commit/ee608478623a716da38cd09383f640f3a96f8d61 DIFF: https://github.com/llvm/llvm-project/commit/ee608478623a716da38cd09383f640f3a96f8d61.dif

[PATCH] D59520: [WebAssembly] Address review comments on r352930

2020-06-05 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks check-clang everywhere, e.g. here http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/39534/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Awarning-flags.c Please take a look and revert if it takes a while to fix. Going forward, ple

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

2020-06-05 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir updated this revision to Diff 268893. saghir added a comment. Updated the diff based on latest changes in master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80758/new/ https://reviews.llvm.org/D80758 Files: clang/include/clang/Driver/O

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

2020-06-05 Thread Marco Elver via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG866ee2353f7d: [KernelAddressSanitizer] Make globals constructors compatible with kernel (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D59520: [WebAssembly] Address review comments on r352930

2020-06-05 Thread sunfishcode via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG931fcd3ba011: [WebAssembly] Improve clang diagnostics for wasm attributes (authored by sunfishcode). Changed prior to commit: https://reviews.llvm.org/D59520?vs=268329&id=268900#toc Repository: rG LL

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

2020-06-05 Thread Rahul Joshi via Phabricator via cfe-commits
jurahul updated this revision to Diff 268903. jurahul added a comment. Fix Clang build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files: clang/include/clang/AST/DeclBase.h llvm/include/llvm

[clang] 3aec298 - Revert "[WebAssembly] Improve clang diagnostics for wasm attributes"

2020-06-05 Thread Dan Gohman via cfe-commits
Author: Dan Gohman Date: 2020-06-05T11:52:11-07:00 New Revision: 3aec298349fbc901a51b47004fb156090b3d6bce URL: https://github.com/llvm/llvm-project/commit/3aec298349fbc901a51b47004fb156090b3d6bce DIFF: https://github.com/llvm/llvm-project/commit/3aec298349fbc901a51b47004fb156090b3d6bce.diff LO

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

2020-06-05 Thread Rahul Joshi via Phabricator via cfe-commits
jurahul updated this revision to Diff 268905. jurahul added a comment. fix MLIR test failure due to change in error message. Reinstate the old message for a single parent case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://review

[PATCH] D81176: [HIP] Add default header and include path

2020-06-05 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This is still failing on Windows: http://45.33.8.238/win/16970/step_7.txt Please take a look and revert for now if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.ll

[PATCH] D81176: [HIP] Add default header and include path

2020-06-05 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Also still failing on mac: http://45.33.8.238/mac/14992/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.llvm.org/D81176 ___ cfe-commits maili

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-05 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 268906. aganea added a comment. Fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driv

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

2020-06-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I feel the refactoring of Aliasing should be in its own PR, with this being a child of it. Comment at: clang-tools-extra/clang-tidy/misc/RedundantConditionCheck.cpp:38 + ifStmt(hasCondition(anyOf( + declRefExpr(hasDeclaration(varD

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

2020-06-05 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:78 ^^ +- New :doc:`misc-redundant-condition + ` check. Please keep alphabetical order in new checks list. Comment at: clang-tools-extra/docs/Rel

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-05 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. I have a couple of drive-by suggestions, up to @dang and @Bigcheese whether to incorporate them. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:137-142 +.Case("static", llvm::Reloc::Static) +.Case("pic", llvm::

[clang] 3928436 - Attempt to fix hip-include-path.hip

2020-06-05 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-06-05T15:31:53-04:00 New Revision: 392843617acbce5baf6ca7c7fff8dbac58bf853f URL: https://github.com/llvm/llvm-project/commit/392843617acbce5baf6ca7c7fff8dbac58bf853f DIFF: https://github.com/llvm/llvm-project/commit/392843617acbce5baf6ca7c7fff8dbac58bf853f.dif

[clang] 672ed53 - [codeview] Put !heapallocsite on calls to operator new

2020-06-05 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-06-05T12:52:38-07:00 New Revision: 672ed5386024ba5cee53e19d637b7920a4889837 URL: https://github.com/llvm/llvm-project/commit/672ed5386024ba5cee53e19d637b7920a4889837 DIFF: https://github.com/llvm/llvm-project/commit/672ed5386024ba5cee53e19d637b7920a4889837.diff

[PATCH] D81176: [HIP] Add default header and include path

2020-06-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D81176#2077254 , @thakis wrote: > Also still failing on mac: http://45.33.8.238/mac/14992/step_7.txt I will try to fix it one more time. If it still fails I will revert it. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D81176: [HIP] Add default header and include path

2020-06-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D81176#2077319 , @thakis wrote: > Still broken: http://45.33.8.238/win/16976/summary.html reverted. The difficulty for fixing these failures is that they only show up on some systems I do not have access and cannot see the co

[PATCH] D81176: [HIP] Add default header and include path

2020-06-05 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Still broken: http://45.33.8.238/win/16976/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81176/new/ https://reviews.llvm.org/D81176 ___ cfe-commits mailing list cfe

  1   2   >